Skip to contentSkip to conversation

bcachefs: Fix potential sleeping during mount

PATCH Applied Daniel J Blueman 2 participants 2 messages Nov 12, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Fix potential sleeping during mount

During mount, bcachefs mount option processing may sleep while allocating a string buffer.

Fix this by reference counting in order to take the atomic path.

---
 fs/bcachefs/disk_groups.c | 2 ++
 1 file changed, 2 insertions(+)
fs/bcachefs/disk_groups.c +2 -0
index 1f334124055b..4d0cb0ccff32 100644
@@ -555,6 +555,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
 	case TARGET_DEV: {
 		struct bch_dev *ca;
 
+		out->atomic++;
 		rcu_read_lock();
 		ca = t.dev < c->sb.nr_devices
 			? rcu_dereference(c->devs[t.dev])
@@ -570,6 +571,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
 		}
 
 		rcu_read_unlock();
+		out->atomic--;
 		break;
 	}
 	case TARGET_GROUP:
Signature · 1 line
2.40.1
#1 lore raw
Quoted 5 lines · Daniel J Blueman

During mount, bcachefs mount option processing may sleep while allocating a string buffer.

Fix this by reference counting in order to take the atomic path.

Thanks, applied