Skip to contentSkip to conversation

ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c

PATCH RESEND Applied Richard Fitzgerald 2 participants 2 messages Nov 13, 2023 – Nov 14, 2023 Sound

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c

From: Simon Trimmer <[email protected]>

This can now be re-enabled as the sequence to reliably wake the device has been implemented in the shared ASoC code.

This has a functional dependency on commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued twice")

To protect against this, enabling hibernation is conditional on CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new hibernation sequences are available.

---
 sound/pci/hda/cs35l56_hda_i2c.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/pci/hda/cs35l56_hda_i2c.c +4 -0
index 757a4d193e0f..a9ef6d86de83 100644
@@ -21,6 +21,10 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt)
 		return -ENOMEM;
 
 	cs35l56->base.dev = &clt->dev;
+
+#ifdef CS35L56_WAKE_HOLD_TIME_US
+	cs35l56->base.can_hibernate = true;
+#endif
 	cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c);
 	if (IS_ERR(cs35l56->base.regmap)) {
 		ret = PTR_ERR(cs35l56->base.regmap);
Signature · 1 line
2.30.2
Applied
#1 lore raw
Quoted 9 lines · Richard Fitzgerald

From: Simon Trimmer <[email protected]>

This can now be re-enabled as the sequence to reliably wake the device has been implemented in the shared ASoC code.

This has a functional dependency on commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued twice")

Quoted 6 lines

To protect against this, enabling hibernation is conditional on CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new hibernation sequences are available.

Thanks, applied.

Takashi