perf test record.sh: Raise limit of open file descriptors
PATCH 1/1 perf test record.sh: Raise limit of open file descriptors
From: Veronika Molnarova <[email protected]>
Subtest for system-wide record with '--threads' option fails due to a limit of open file descriptors(usually set to 1024) on systems with 128 and more CPUs.
If the default limit is set lower than 2048 file descriptors, temporarily raise it to this value for the test.
--- tools/perf/tests/shell/record.sh | 8 ++++++++ 1 file changed, 8 insertions(+)
tools/perf/tests/shell/record.sh +8 -0
@@ -11,6 +11,8 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +min_fd_limit=2048 +default_fd_limit=$(ulimit -n) cleanup() { rm -rf "${perfdata}"
@@ -154,10 +156,16 @@ test_workload() { echo "Basic target workload test [Success]" } +if [[ $default_fd_limit -lt $min_fd_limit ]]; then + ulimit -n $min_fd_limit +fi + test_per_thread test_register_capture test_system_wide test_workload +ulimit -n $default_fd_limit + cleanup exit $err
Signature · 1 line
2.41.0
Arnaldo Carvalho de Melo
maintainerEm Wed, Nov 15, 2023 at 03:05:22PM +0100, [email protected] escreveu:
Quoted 8 lines
From: Veronika Molnarova <[email protected]>
Subtest for system-wide record with '--threads' option fails due to a limit of open file descriptors(usually set to 1024) on systems with 128 and more CPUs.
If the default limit is set lower than 2048 file descriptors, temporarily raise it to this value for the test.
Can we instead raise it to a multiple of the number of CPUs? Using:
[acme@five ~]$ getconf _NPROCESSORS_ONLN
32
[acme@five ~]$
If you tested 2048 is ok for a 128 CPU system, then maybe this is more future proof:
[acme@five ~]$ echo $(($(getconf _NPROCESSORS_ONLN) * 16)) 512
[acme@five ~]$ echo $((128 * 16))
2048
[acme@five ~]$
- Arnaldo
Quoted 37 lines
Signed-off-by Veronika Molnarova <[email protected]>--- tools/perf/tests/shell/record.sh | 8 ++++++++ 1 file changed, 8 insertions(+)tools/perf/tests/shell/record.sh +8
-0@@ -11,6 +11,8 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +min_fd_limit=2048 +default_fd_limit=$(ulimit -n) cleanup() { rm -rf "${perfdata}"@@ -154,10 +156,16 @@ test_workload() { echo "Basic target workload test [Success]" } +if [[ $default_fd_limit -lt $min_fd_limit ]]; then + ulimit -n $min_fd_limit +fi + test_per_thread test_register_capture test_system_wide test_workload +ulimit -n $default_fd_limit + cleanup exit $errSignature · 1 line
2.41.0
PATCH 1/1 perf test record.sh: Raise limit of open file descriptors
From: Veronika Molnarova <[email protected]>
Subtest for system-wide record with '--threads=cpu' option fails due to a limit of open file descriptors on systems with 128 or more CPUs as the default limit is set to 1024.
The number of open file descriptors should be slightly above nmb_events*nmb_cpus + nmb_cpus(for perf.data.n) + 4*nmb_cpus(for pipes), which equals 8*nmb_cpus. Therefore, temporarily raise the limit to 16*nmb_cpus for the test.
--- tools/perf/tests/shell/record.sh | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
tools/perf/tests/shell/record.sh +16 -0
@@ -11,6 +11,14 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +default_fd_limit=$(ulimit -n) +# With option --threads=cpu the number of open file descriptors should be +# equal to sum of: nmb_cpus * nmb_events (2+dummy), +# nmb_threads for perf.data.n (equal to nmb_cpus) and +# 2*nmb_cpus of pipes = 4*nmb_cpus (each pipe has 2 ends) +# All together it needs 8*nmb_cpus file descriptors plus some are also used +# outside of testing, thus raising the limit to 16*nmb_cpus +min_fd_limit=$(($(getconf _NPROCESSORS_ONLN) * 16)) cleanup() { rm -rf "${perfdata}"
@@ -154,10 +162,18 @@ test_workload() { echo "Basic target workload test [Success]" } +# raise the limit of file descriptors to minimum +if [[ $default_fd_limit -lt $min_fd_limit ]]; then + ulimit -n $min_fd_limit +fi + test_per_thread test_register_capture test_system_wide test_workload +# restore the default value +ulimit -n $default_fd_limit + cleanup exit $err
Signature · 1 line
2.41.0