powerpc/hv-gpci: Add return value check in affinity_domain_via_partition_show function
PATCH 1/2 powerpc/hv-gpci: Add return value check in affinity_domain_via_partition_show function
To access hv-gpci kernel interface files data, the "Enable Performance Information Collection" option has to be set in hmc. Incase that option is not set and user try to read the interface files, it should give error message as operation not permitted.
Result of accessing added interface files with disabled performance collection option:
[command]# cat processor_bus_topology
cat: processor_bus_topology: Operation not permitted
[command]# cat processor_config
cat: processor_config: Operation not permitted
[command]# cat affinity_domain_via_domain
cat: affinity_domain_via_domain: Operation not permitted
[command]# cat affinity_domain_via_virtual_processor
cat: affinity_domain_via_virtual_processor: Operation not permitted
[command]# cat affinity_domain_via_partition
Based on above result there is no error message when reading affinity_domain_via_partition file because of missing check for failed hcall. Fix this issue by adding
a check in the start of affinity_domain_via_partition_show function, to return error incase hcall fails, with error type other then H_PARAMETER.
--- arch/powerpc/perf/hv-gpci.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/perf/hv-gpci.c +3 -0
@@ -534,6 +534,9 @@ static ssize_t affinity_domain_via_partition_show(struct device *dev, struct devif (!ret) goto parse_result; +if (ret && (ret !=H_PARAMETER )) + goto out; +/* * ret value as 'H_PARAMETER' implies that the current buffer size * can't accommodate all the information, and a partial buffer
Signature · 1 line
2.39.3
PATCH 2/2 powerpc/hv-gpxi: Fix access permission of hv-gpci interface files
Fix access permission of the hv-gpci topology information interface files from 0444 to 0400 (admin read only).
--- arch/powerpc/perf/hv-gpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/perf/hv-gpci.c +1 -1
@@ -890,7 +890,7 @@ static struct device_attribute *sysinfo_device_attr_create(intreturn NULL ;sysfs_attr_init (&attr->attr); - attr->attr.mode =0444 ; + attr->attr.mode =0400 ;switch (sysinfo_interface_group_index) {case INTERFACE_PROCESSOR_BUS_TOPOLOGY_ATTR :
Signature · 1 line
2.39.3
Michael Ellerman
reviewerRe: [PATCH 2/2] powerpc/hv-gpxi: Fix access permission of hv-gpci interface files
Quoted 2 lines · Kajol Jain
Fix access permission of the hv-gpci topology information interface files from 0444 to 0400 (admin read only).
Please explain why they should be 0400.
Also typo in subject, "hv-gpxi".
cheers
Quoted 22 lines
Fixes 71f1c39647d8 ("powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show processor bus topology information")Reported-by Disha Goel <[email protected]>Signed-off-by Kajol Jain <[email protected]>--- arch/powerpc/perf/hv-gpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/perf/hv-gpci.c +1
-1@@ -890,7 +890,7 @@ static struct device_attribute *sysinfo_device_attr_create(intreturn NULL ;sysfs_attr_init (&attr->attr); - attr->attr.mode =0444 ; + attr->attr.mode =0400 ;switch (sysinfo_interface_group_index) {case INTERFACE_PROCESSOR_BUS_TOPOLOGY_ATTR :Signature · 1 line
2.39.3
Re: [PATCH 2/2] powerpc/hv-gpxi: Fix access permission of hv-gpci interface files
Quoted 7 lines · Michael Ellerman
Quoted 2 lines · Kajol Jain
Fix access permission of the hv-gpci topology information interface files from 0444 to 0400 (admin read only).
Please explain why they should be 0400.
Also typo in subject, "hv-gpxi".
Hi Michael,
Thanks for reviewing it. Will add the details in next version of the
patch.
Thanks,
Kajol Jain
Quoted 25 lines
cheers
Quoted 22 lines
Fixes 71f1c39647d8 ("powerpc/hv_gpci: Add sysfs file inside hv_gpci device to show processor bus topology information")Reported-by Disha Goel <[email protected]>Signed-off-by Kajol Jain <[email protected]>--- arch/powerpc/perf/hv-gpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/perf/hv-gpci.c +1
-1@@ -890,7 +890,7 @@ static struct device_attribute *sysinfo_device_attr_create(intreturn NULL ;sysfs_attr_init (&attr->attr); - attr->attr.mode =0444 ; + attr->attr.mode =0400 ;switch (sysinfo_interface_group_index) {case INTERFACE_PROCESSOR_BUS_TOPOLOGY_ATTR :Signature · 1 line
2.39.3
Michael Ellerman
AppliedRe: (subset) [PATCH 1/2] powerpc/hv-gpci: Add return value check in affinity_domain_via_partition_show function
In reply to Kajol JainQuoted 10 lines · Kajol Jain
To access hv-gpci kernel interface files data, the "Enable Performance Information Collection" option has to be set in hmc. Incase that option is not set and user try to read the interface files, it should give error message as operation not permitted.
Result of accessing added interface files with disabled performance collection option:
[...]
Applied to powerpc/next.
[1/2] powerpc/hv-gpci: Add return value check in affinity_domain_via_partition_show function
https://git.kernel.org/powerpc/c/070b71f428facd9130319707db854ed8bd24637a
cheers