Skip to contentSkip to conversation

spi: intel: make mem_ops comparison unique to opcode match

PATCH In review Raag Jadav 3 participants 3 messages Nov 17, 2023 – Nov 18, 2023 SPI

lore
Share & tools
lore

Raag Jadav

author
#0 lore raw

PATCH 1/1 spi: intel: make mem_ops comparison unique to opcode match

Instead of comparing parameters for every supported mem_ops, only compare on opcode match, which is relatively more efficient.

---
 drivers/spi/spi-intel.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/spi/spi-intel.c +5 -5
index 98ec4dc22b81..3654ae35d2db 100644
@@ -711,8 +711,7 @@ static bool intel_spi_cmp_mem_op(const struct intel_spi_mem_op *iop,
 {
 	if (iop->mem_op.cmd.nbytes != op->cmd.nbytes ||
 	    iop->mem_op.cmd.buswidth != op->cmd.buswidth ||
-	    iop->mem_op.cmd.dtr != op->cmd.dtr ||
-	    iop->mem_op.cmd.opcode != op->cmd.opcode)
+	    iop->mem_op.cmd.dtr != op->cmd.dtr)
 		return false;
 
 	if (iop->mem_op.addr.nbytes != op->addr.nbytes ||
@@ -737,11 +736,12 @@ intel_spi_match_mem_op(struct intel_spi *ispi, const struct spi_mem_op *op)
 	const struct intel_spi_mem_op *iop;
 
 	for (iop = ispi->mem_ops; iop->mem_op.cmd.opcode; iop++) {
-		if (intel_spi_cmp_mem_op(iop, op))
-			break;
+		if (iop->mem_op.cmd.opcode == op->cmd.opcode &&
+		    intel_spi_cmp_mem_op(iop, op))
+			return iop;
 	}
 
-	return iop->mem_op.cmd.opcode ? iop : NULL;
+	return NULL;
 }
 
 static bool intel_spi_supports_mem_op(struct spi_mem *mem,
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to Raag Jadav
Quoted 4 lines · Raag Jadav

Instead of comparing parameters for every supported mem_ops, only compare on opcode match, which is relatively more efficient.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: intel: make mem_ops comparison unique to opcode match

      commit: 18a813a1f94abbab14248071ca551e491bbc2abe

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark