Skip to contentSkip to conversation

dpp: fail early if multicast frame registration is unsupported

PATCH In review James Prestwood 2 participants 3 messages Nov 17, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dpp: fail early if multicast frame registration is unsupported

This is done already for DPP, do the same for PKEX. Few drivers (ath9k upstream, ath10k/11k in progress) support this which is unfortunate but since a configurator will not work without this capability its best to fail early.

---
 src/dpp.c | 6 ++++++
 1 file changed, 6 insertions(+)
src/dpp.c +6 -0
index 0064187b..c7cd4bb3 100644
@@ -4362,6 +4362,12 @@ static struct l_dbus_message *dpp_start_pkex_configurator(struct dpp_sm *dpp,
 				dpp->interface != DPP_INTERFACE_UNBOUND)
 		return dbus_error_busy(message);
 
+	if (!dpp->mcast_support) {
+		l_debug("Multicast frame registration not supported, cannot "
+			"start a configurator");
+		return dbus_error_not_supported(message);
+	}
+
 	if (!network || !bss)
 		return dbus_error_not_connected(message);
 
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 doc: document additional NotSupported shared code return

---
 doc/device-provisioning-api.txt | 2 ++
 1 file changed, 2 insertions(+)
doc/device-provisioning-api.txt +2 -0
index 9994aef5..6cf16fb8 100644
@@ -109,6 +109,7 @@ Object path	/net/connman/iwd/{phy0,phy1,...}/{1,2,...}
 			Possible errors:	net.connman.iwd.Busy
 						net.connman.iwd.NotConnected
 						net.connman.InvalidArguments
+						net.connman.NotSupported
 
 		void StartEnrollee(a{sv})
 
@@ -156,6 +157,7 @@ Object path	/net/connman/iwd/{phy0,phy1,...}/{1,2,...}
 			Possible errors:	net.connman.iwd.Busy
 						net.connman.iwd.NotConnected
 						net.connman.iwd.NoAgent
+						net.connman.iwd.NotSupported
 
 		Stop()
 
Signature · 1 line
2.34.1
#2 lore raw
In reply to James Prestwood

Hi James,

Quoted 8 lines · James Prestwood

This is done already for DPP, do the same for PKEX. Few drivers (ath9k upstream, ath10k/11k in progress) support this which is unfortunate but since a configurator will not work without this capability its best to fail early.

---
  src/dpp.c | 6 ++++++
  1 file changed, 6 insertions(+)

Both applied, thanks.

Regards,
-Denis