btrfs: ref-verify: fix memory leaks
PATCH v2 1/1 btrfs: ref-verify: fix memory leaks
In btrfs_ref_tree_mod(), when !parent 're' was allocated through kmalloc(). In the following code, if an error occurs, the execution will be redirected to 'out' or 'out_unlock' and the function will be exited. However, on some of the paths, 're' are not deallocated and may lead to memory leaks.
For example : lookup_block_entry() for 'be' returns null, the out label will be invoked. During that flow ref and ra was freed but not re, which can potentially lead to memleak
---
V1 -> V2: 're' shouldn't be freed after it added to rbtree
fs/btrfs/ref-verify.c | 2 ++ 1 file changed, 2 insertions(+)
fs/btrfs/ref-verify.c +2 -0
@@ -794,6 +794,7 @@ int btrfs_ref_tree_mod(struct btrfs_fs_info *fs_info,dump_ref_action (fs_info, ra);kfree (ref);kfree (ra); +kfree (re); goto out_unlock; }else if (be->num_refs ==0 ) { btrfs_err(fs_info,
@@ -803,6 +804,7 @@ int btrfs_ref_tree_mod(struct btrfs_fs_info *fs_info,dump_ref_action (fs_info, ra);kfree (ref);kfree (ra); +kfree (re); goto out_unlock; }
Signature · 1 line
2.34.1
Quoted 6 lines · Bragatheswaran Manickavel
In
btrfs_ref_tree_mod(), when !parent 're' was allocated throughkmalloc(). In the following code, if an error occurs, the execution will be redirected to 'out' or 'out_unlock' and the function will be exited. However, on some of the paths, 're' are not deallocated and may lead to memory leaks.
Quoted 7 lines
For example :
lookup_block_entry()for 'be' returns null, the out label will be invoked. During that flow ref and ra was freed but not re, which can potentially lead to memleakReported-and-tested-by [email protected]Signed-off-by Bragatheswaran Manickavel <[email protected]>
Added to misc-next, thanks.