selftests:proc-empty-vm: Remove unused debug write callIn the function test_proc_pid_statm
Subsystems (4)
PATCH 1/1 selftests:proc-empty-vm: Remove unused debug write callIn the function test_proc_pid_statm
From: angquan yu <[email protected]>
In tools/testing/selftests/proc/proc-empty->because the return value of a write call was being ignored. This call was partof a conditional debugging block (if (0) { ... }), which meant it would neveractually execute.
This patch removes the unused debug write call. This cleanup resolves the compi>warning about ignoring the result of write declared with the warn_unused_resultattribute.
Removing this code also improves the clarity and maintainability ofthe function, as it eliminates a non-functional block of code.
This is original warning: proc-empty-vm.c: In function ‘test_proc_pid_statm’:proc-empty-vm.c:385:17: warning: ignoring return value of ‘write’ declared with>385 | write(1, buf, rv);|
--- tools/testing/selftests/proc/proc-empty-vm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/proc/proc-empty-vm.c +4 -1
@@ -382,7 +382,10 @@ static int test_proc_pid_statm(pid_t pid)assert (rv >=0 );assert (rv <=sizeof (buf));if (0 ) { -write (1 , buf, rv); +ssize_t written =write (1 , buf, rv); +if (written ==-1 ) { +perror ("write failed /proc/${pid}" ); + } }const char *p = buf;
Signature · 1 line
2.39.2