Skip to contentSkip to conversation

pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP()

PATCH In review Andy Shevchenko 3 participants 5 messages Nov 20, 2023 – Nov 27, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP()

The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver.

---
 drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +4 -5
index 0cff44b07b29..4589900244c7 100644
@@ -474,9 +474,8 @@ enum {
 #undef WPCM450_GRP
 };
 
-static struct group_desc wpcm450_groups[] = {
-#define WPCM450_GRP(x) { .name = #x, .pins = x ## _pins, \
-			.num_pins = ARRAY_SIZE(x ## _pins) }
+static struct pingroup wpcm450_groups[] = {
+#define WPCM450_GRP(x) PINCTRL_PINGROUP(#x, x ## _pins, ARRAY_SIZE(x ## _pins))
 	WPCM450_GRPS
 #undef WPCM450_GRP
 };
@@ -852,7 +851,7 @@ static int wpcm450_get_group_pins(struct pinctrl_dev *pctldev,
 				  const unsigned int **pins,
 				  unsigned int *npins)
 {
-	*npins = wpcm450_groups[selector].num_pins;
+	*npins = wpcm450_groups[selector].npins;
 	*pins  = wpcm450_groups[selector].pins;
 
 	return 0;
@@ -901,7 +900,7 @@ static int wpcm450_pinmux_set_mux(struct pinctrl_dev *pctldev,
 	struct wpcm450_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
 
 	wpcm450_setfunc(pctrl->gcr_regmap, wpcm450_groups[group].pins,
-			wpcm450_groups[group].num_pins, function);
+			wpcm450_groups[group].npins, function);
 
 	return 0;
 }
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
#1 lore raw
Quoted 2 lines · Andy Shevchenko

The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver.

Linus, I dunno if you are going to apply this sooner (assuming Jonathan is okay with the change), but I have a bigger pending series where this will be a prerequisite. So, when I will be ready and if it's not being applied (yet), I'll include it into the bigger series as well.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver.

Linus, I dunno if you are going to apply this sooner (assuming Jonathan is okay with the change), but I have a bigger pending series where this will be a prerequisite. So, when I will be ready and if it's not being applied (yet), I'll include it into the bigger series as well.

No answer from Jonathan but I just applied another Nuvoton patch from Tomer, so maybe Tomer can look at/test this patch?

Yours,
Linus Walleij

#3 lore raw
Quoted 7 lines · Linus Walleij
Quoted 5 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver.

Quoted 7 lines
Quoted 4 lines

Linus, I dunno if you are going to apply this sooner (assuming Jonathan is okay with the change), but I have a bigger pending series where this will be a prerequisite. So, when I will be ready and if it's not being applied (yet), I'll include it into the bigger series as well.

No answer from Jonathan but I just applied another Nuvoton patch from Tomer, so maybe Tomer can look at/test this patch?

Jonathan acked it in the reincarnation in the series (see my big one).

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Hi Linus,

Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Linus Walleij
Quoted 5 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver.

Quoted 7 lines
Quoted 7 lines
Quoted 4 lines

Linus, I dunno if you are going to apply this sooner (assuming Jonathan is okay with the change), but I have a bigger pending series where this will be a prerequisite. So, when I will be ready and if it's not being applied (yet), I'll include it into the bigger series as well.

No answer from Jonathan but I just applied another Nuvoton patch from Tomer, so maybe Tomer can look at/test this patch?

Sorry, but I do not have wpcm450 board to test this patch. In general, the patch looks fine.

Quoted 8 lines

Jonathan acked it in the reincarnation in the series (see my big one).

--
With Best Regards,
Andy Shevchenko

Sorry I couldn't help.

Best regards,

Tomer