Skip to contentSkip to conversation

selftests/mm: prevent duplicate runs caused by TEST_GEN_PROGS

PATCH Applied Nico Pache 2 participants 2 messages Nov 20, 2023 – Nov 23, 2023

Subsystems (3)
lore
Share & tools
lore

Nico Pache

author
#0 lore raw

PATCH 1/1 selftests/mm: prevent duplicate runs caused by TEST_GEN_PROGS

commit 05f1edac8009 ("selftests/mm: run all tests from run_vmtests.sh") fixed the inconsistancy caused by tests being defined as TEST_GEN_PROGS. This issue was leading to tests not being executed via run_vmtests.sh and furthermore some tests running twice due to the kselftests wrapper also executing them.

Fix the definition of two tests (soft-dirty and pagemap_ioctl) that are still incorrectly defined.

---
 tools/testing/selftests/mm/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/Makefile +2 -2
index 78dfec8bc676..dede0bcf97a3 100644
@@ -60,7 +60,7 @@ TEST_GEN_FILES += mrelease_test
 TEST_GEN_FILES += mremap_dontunmap
 TEST_GEN_FILES += mremap_test
 TEST_GEN_FILES += on-fault-limit
-TEST_GEN_PROGS += pagemap_ioctl
+TEST_GEN_FILES += pagemap_ioctl
 TEST_GEN_FILES += thuge-gen
 TEST_GEN_FILES += transhuge-stress
 TEST_GEN_FILES += uffd-stress
@@ -72,7 +72,7 @@ TEST_GEN_FILES += mdwe_test
 TEST_GEN_FILES += hugetlb_fault_after_madv
 
 ifneq ($(ARCH),arm64)
-TEST_GEN_PROGS += soft-dirty
+TEST_GEN_FILES += soft-dirty
 endif
 
 ifeq ($(ARCH),x86_64)
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Nico Pache

commit 05f1edac8009 ("selftests/mm: run all tests from run_vmtests.sh") fixed the inconsistancy caused by tests being defined as TEST_GEN_PROGS. This issue was leading to tests not being executed via run_vmtests.sh and furthermore some tests running twice due to the kselftests wrapper also executing them.

Fix the definition of two tests (soft-dirty and pagemap_ioctl) that are still incorrectly defined.

---
  tools/testing/selftests/mm/Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/Makefile +1 -1
index 78dfec8bc676..dede0bcf97a3 100644
@@ -60,7 +60,7 @@ TEST_GEN_FILES += mrelease_test
  TEST_GEN_FILES += mremap_dontunmap
  TEST_GEN_FILES += mremap_test
  TEST_GEN_FILES += on-fault-limit
-TEST_GEN_PROGS += pagemap_ioctl
+TEST_GEN_FILES += pagemap_ioctl
  TEST_GEN_FILES += thuge-gen
  TEST_GEN_FILES += transhuge-stress
  TEST_GEN_FILES += uffd-stress

tools/testing/selftests/mm/Makefile TEST_GEN_FILES += mdwe_test · line 78

Quoted 8 lines
tools/testing/selftests/mm/Makefile +1 -1
@@ -72,7 +72,7 @@ TEST_GEN_FILES += mdwe_test
  TEST_GEN_FILES += hugetlb_fault_after_madv
 
  ifneq ($(ARCH),arm64)
-TEST_GEN_PROGS += soft-dirty
+TEST_GEN_FILES += soft-dirty
  endif
 
  ifeq ($(ARCH),x86_64)
Signature · 3 lines
Cheers,

David / dhildenb