Skip to contentSkip to conversation

lib: utils/irqchip: Avoid redundant writes to APLIC CLRIE register

PATCH New Anup Patel 3 participants 3 messages Nov 21, 2023 – Nov 24, 2023

lore
Share & tools
lore

Anup Patel

author
#0 lore raw

PATCH 1/1 lib: utils/irqchip: Avoid redundant writes to APLIC CLRIE register

Each APLIC CLRIE register allows disabling 32 interrupt sources at a time by writing -1 so no need to write CLRIE register separately for each interrupt source.

Fixes 99792653de29 ("lib: utils/irqchip: Add APLIC initialization

library")

---
 lib/utils/irqchip/aplic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/utils/irqchip/aplic.c +1 -1
index d7fd992..10236e7 100644
@@ -193,7 +193,7 @@ int aplic_cold_irqchip_init(struct aplic_data *aplic)
 	writel(0, (void *)(aplic->addr + APLIC_DOMAINCFG));
 
 	/* Disable all interrupts */
-	for (i = 0; i <= aplic->num_source; i++)
+	for (i = 0; i <= aplic->num_source; i += 32)
 		writel(-1U, (void *)(aplic->addr + APLIC_CLRIE_BASE +
 				     (i / 32) * sizeof(u32)));
 
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/1 lib: utils/irqchip: Avoid redundant writes to APLIC CLRIE register

Quoted 26 lines · On Tue, Nov 21, 2023 at 7:03?AM Anup Patel <[email protected]> wrote:

Each APLIC CLRIE register allows disabling 32 interrupt sources at a time by writing -1 so no need to write CLRIE register separately for each interrupt source.

Fixes 99792653de29 ("lib: utils/irqchip: Add APLIC initialization

library")

---
 lib/utils/irqchip/aplic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/utils/irqchip/aplic.c +1 -2
index d7fd992..10236e7 100644
@@ -193,7 +193,7 @@ int aplic_cold_irqchip_init(struct aplic_data *aplic)
        writel(0, (void *)(aplic->addr + APLIC_DOMAINCFG));
 
        /* Disable all interrupts */
-       for (i = 0; i <= aplic->num_source; i++)
+       for (i = 0; i <= aplic->num_source; i += 32)
                writel(-1U, (void *)(aplic->addr + APLIC_CLRIE_BASE +
                                     (i / 32) * sizeof(u32)));
 
--
Quoted 2 lines

2.34.1

Signature · 2 lines
Regards,
Atish
Applied
#2 lore raw

PATCH 1/1 lib: utils/irqchip: Avoid redundant writes to APLIC CLRIE register

In reply to Anup Patel
Quoted 8 lines · On Tue, Nov 21, 2023 at 8:33?PM Anup Patel <[email protected]> wrote:

Each APLIC CLRIE register allows disabling 32 interrupt sources at a time by writing -1 so no need to write CLRIE register separately for each interrupt source.

Fixes 99792653de29 ("lib: utils/irqchip: Add APLIC initialization

library")

Applied this patch to the riscv/opensbi repo.

Regards,
Anup

Quoted 20 lines
---
 lib/utils/irqchip/aplic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/utils/irqchip/aplic.c +1 -2
index d7fd992..10236e7 100644
@@ -193,7 +193,7 @@ int aplic_cold_irqchip_init(struct aplic_data *aplic)
        writel(0, (void *)(aplic->addr + APLIC_DOMAINCFG));
 
        /* Disable all interrupts */
-       for (i = 0; i <= aplic->num_source; i++)
+       for (i = 0; i <= aplic->num_source; i += 32)
                writel(-1U, (void *)(aplic->addr + APLIC_CLRIE_BASE +
                                     (i / 32) * sizeof(u32)));
 
--

2.34.1