Skip to contentSkip to conversation

pinctrl: intel: use the correct _PM_OPS() export macro

PATCH In review Raag Jadav 3 participants 3 messages Nov 22, 2023

Subsystems (3)
lore
Share & tools
lore

Raag Jadav

author
#0 lore raw

PATCH 1/1 pinctrl: intel: use the correct _PM_OPS() export macro

Since we don't have runtime PM handles here, we should be using EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can discard it in case CONFIG_PM_SLEEP=n.

Fixes b10a74b5c0c1 ("pinctrl: intel: Provide Intel pin control wide PM ops structure")
---
 drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/pinctrl-intel.c +1 -1
index 2367c2747a83..d6f29e6faab7 100644
@@ -1879,7 +1879,7 @@ static int intel_pinctrl_resume_noirq(struct device *dev)
 	return 0;
 }
 
-EXPORT_NS_GPL_DEV_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = {
+EXPORT_NS_GPL_DEV_SLEEP_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = {
 	NOIRQ_SYSTEM_SLEEP_PM_OPS(intel_pinctrl_suspend_noirq, intel_pinctrl_resume_noirq)
 };
 

base-commit: c5860e4a2737a8b29dc426c800d01c5be6aad811

Signature · 1 line
2.17.1
#2 lore raw
In reply to Raag Jadav
Quoted 3 lines · Raag Jadav

Since we don't have runtime PM handles here, we should be using EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can discard it in case CONFIG_PM_SLEEP=n.

Obviously correct fix, I've pushed to my review and testing queue, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko