Skip to contentSkip to conversation

init-manager-mdev-busybox: Keep sysvinit distro feature on

PATCH In review Khem Raj 2 participants 3 messages Nov 22, 2023 – Nov 23, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 init-manager-mdev-busybox: Keep sysvinit distro feature on

The rcS script that busybox-init provides is able to run scripts that are available as part of sysvinit, therefore its fine to keep sysvinit distro feature enabled so that we can build complex systems with busybox as init system.

---
 meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/conf/distro/include/init-manager-mdev-busybox.inc +2 -1
index 12091cba68c..a5a61bbe4d2 100644
@@ -1,5 +1,6 @@
 # enable mdev/busybox for init
-DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit"
+DISTRO_FEATURES:append = " sysvinit"
+DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd"
 VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev"
 VIRTUAL-RUNTIME_init_manager ??= "busybox"
 VIRTUAL-RUNTIME_initscripts ??= "initscripts"
Signature · 1 line
2.43.0
#1 lore raw

From: [email protected] <[email protected]> On Behalf Of Khem Raj via lists.openembedded.org

Quoted 15 lines

The rcS script that busybox-init provides is able to run scripts that are available as part of sysvinit, therefore its fine to keep sysvinit distro feature enabled so that we can build complex systems with busybox as init system.

---
 meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/conf/distro/include/init-manager-mdev-busybox.inc +0 -0
index 12091cba68c..a5a61bbe4d2 100644

meta/conf/distro/include/init-manager-mdev-busybox.inc line 2

Quoted 3 lines
meta/conf/distro/include/init-manager-mdev-busybox.inc +1 -1
@@ -1,5 +1,6 @@
 # enable mdev/busybox for init
-DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit"
+DISTRO_FEATURES:append = " sysvinit"

I don't think that this append is a good idea.
I want a small, lean, controllable init system, not a complex one. This probably belongs to distro or to a new INIT_MANAGER type.

Quoted 6 lines
meta/conf/distro/include/init-manager-mdev-busybox.inc +1 -0
+DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd"
 VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev"
 VIRTUAL-RUNTIME_init_manager ??= "busybox"
 VIRTUAL-RUNTIME_initscripts ??= "initscripts"
Signature · 1 line
2.43.0
author
#2 lore raw
Quoted 13 lines · Peter

From: [email protected] <[email protected]> On Behalf Of Khem Raj via lists.openembedded.org

Quoted 10 lines

The rcS script that busybox-init provides is able to run scripts that are available as part of sysvinit, therefore its fine to keep sysvinit distro feature enabled so that we can build complex systems with busybox as init system.

---
 meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines

meta/conf/distro/include/init-manager-mdev-busybox.inc line 2

Quoted 8 lines
meta/conf/distro/include/init-manager-mdev-busybox.inc +1 -1
index 12091cba68c..a5a61bbe4d2 100644
@@ -1,5 +1,6 @@
 # enable mdev/busybox for init
-DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit"
+DISTRO_FEATURES:append = " sysvinit"

I don't think that this append is a good idea.
I want a small, lean, controllable init system, not a complex one. This probably belongs to distro or to a new INIT_MANAGER type.

That's fair. Although one can easily build a full system just with busybox-init like this perhaps it should be a separate INIT_MANAGER perhaps eudev-busybox or some such.

Quoted 8 lines
Quoted 7 lines
meta/conf/distro/include/init-manager-mdev-busybox.inc +1 -1
+DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd"
 VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev"
 VIRTUAL-RUNTIME_init_manager ??= "busybox"
 VIRTUAL-RUNTIME_initscripts ??= "initscripts"
--

2.43.0