Skip to contentSkip to conversation

ACPI: thermal_lib: include "internal.h" for function prototypes

PATCH Applied Arnd Bergmann 2 participants 2 messages Nov 23, 2023 – Nov 24, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: thermal_lib: include "internal.h" for function prototypes

From: Arnd Bergmann <[email protected]>

The newly added functions are declared in a header that is not included before the definition:

drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)

      |     ^~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
   57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
   63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
   69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~~~~~~
Fixes 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
---
 drivers/acpi/thermal_lib.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/thermal_lib.c +1 -0
index 646ff6bda6dd..4e0519ca9739 100644
@@ -9,6 +9,7 @@
 #include <linux/acpi.h>
 #include <linux/units.h>
 #include <linux/thermal.h>
+#include "internal.h"
 
 /*
  * Minimum temperature for full military grade is 218°K (-55°C) and
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 30 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added functions are declared in a header that is not included before the definition:

drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)

      |     ^~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
   57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
   63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
   69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
      |     ^~~~~~~~~~~~~~~~~~~~~~~
Fixes 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
---
 drivers/acpi/thermal_lib.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/thermal_lib.c +0 -0
index 646ff6bda6dd..4e0519ca9739 100644

drivers/acpi/thermal_lib.c

Quoted 8 lines
drivers/acpi/thermal_lib.c +1 -1
@@ -9,6 +9,7 @@
 #include <linux/acpi.h>
 #include <linux/units.h>
 #include <linux/thermal.h>
+#include "internal.h"
 
 /*
  * Minimum temperature for full military grade is 218°K (-55°C) and
--

Applied, thanks!