riscv: declare overflow_stack as exported from traps.c
PATCH 1/1 riscv: declare overflow_stack as exported from traps.c
The percpu area overflow_stacks is exported from arch/riscv/kernel/traps.c for use in the entry code, but is not declared anywhere. Add the relevant declaration to arch/riscv/include/asm/stacktrace.h to silence the following sparse warning:
arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_stack' was not declared. Should it be static?
We don't add the stackinfo_get_overflow() call as for some of the other architectures as this doesn't seem to be used yet, so just silence the warning.
--- arch/riscv/include/asm/stacktrace.h | 5 +++++ 1 file changed, 5 insertions(+)
arch/riscv/include/asm/stacktrace.h +5 -0
@@ -21,4 +21,9 @@ static inline bool on_thread_stack(void)return !(((unsigned long )(current->stack) ^ current_stack_pointer) & ~(THREAD_SIZE -1 )); } + +#ifdef CONFIG_VMAP_STACK +DECLARE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)], overflow_stack); +#endif /* CONFIG_VMAP_STACK */ +#endif /* _ASM_RISCV_STACKTRACE_H */
Signature · 1 line
2.37.2.352.g3c44437643
Quoted 5 lines · Ben Dooks
The percpu area
overflow_stacksis exported fromarch/riscv/kernel/traps.cfor use in the entry code, but is not declared anywhere. Add the relevant declaration toarch/riscv/include/asm/stacktrace.hto silence the following sparse warning:
Quoted 7 lines
arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_stack' was not declared. Should it be static?We don't add the
stackinfo_get_overflow()call as for some of the other architectures as this doesn't seem to be used yet, so just silence the warning.Signed-off-by Ben Dooks <[email protected]>
I suppose this should also be
Cheers,
Conor.
Quoted 21 lines
--- arch/riscv/include/asm/stacktrace.h | 5 +++++ 1 file changed, 5 insertions(+)arch/riscv/include/asm/stacktrace.h +5
-0@@ -21,4 +21,9 @@ static inline bool on_thread_stack(void)return !(((unsigned long )(current->stack) ^ current_stack_pointer) & ~(THREAD_SIZE -1 )); } + +#ifdef CONFIG_VMAP_STACK +DECLARE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)], overflow_stack); +#endif /* CONFIG_VMAP_STACK */ +#endif /* _ASM_RISCV_STACKTRACE_H */ Signature · 1 line
2.37.2.352.g3c44437643
Quoted 12 lines · Conor Dooley
Quoted 11 lines · Ben Dooks
The percpu area
overflow_stacksis exported fromarch/riscv/kernel/traps.cfor use in the entry code, but is not declared anywhere. Add the relevant declaration toarch/riscv/include/asm/stacktrace.hto silence the following sparse warning:
arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_stack' was not declared. Should it be static?We don't add the
stackinfo_get_overflow()call as for some of the other architectures as this doesn't seem to be used yet, so just silence the warning.
Quoted 5 lines
Quoted 1 line
Signed-off-by Ben Dooks <[email protected]>Reviewed-by Conor Dooley <[email protected]>I suppose this should also be
Fixes be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
Thanks, never sure if the Fixes: should be applied when it is simply a warning fix and there's nothing actually being currently flagging an issue with anything else using it (currently just the assembly)
Signature · 10 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
This patch was applied to riscv/linux.git (fixes) by Palmer Dabbelt <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:
Quoted 8 lines · On Thu, 23 Nov 2023 13:42:14 +0000 you wrote:
The percpu area
overflow_stacksis exported fromarch/riscv/kernel/traps.cfor use in the entry code, but is not declared anywhere. Add the relevant declaration toarch/riscv/include/asm/stacktrace.hto silence the following sparse warning:
arch/riscv/kernel/traps.c:395:1: warning: symbol '__pcpu_scope_overflow_stack' was not declared. Should it be static?[...]
Here is the summary with links:
- riscv: declare overflow_stack as exported from traps.c
https://git.kernel.org/riscv/c/2cf963787529
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html