nvme-core: fix a memory leak in nvme_ns_info_from_identify()
PATCH 1/1 nvme-core: fix a memory leak in nvme_ns_info_from_identify()
In case of error, free the nvme_id_ns structure that was allocated by nvme_identify_ns().
Signed-off-by Maurizio Lombardi <[email protected]>
--- drivers/nvme/host/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/nvme/host/core.c +5 -2
@@ -1480,7 +1480,8 @@ static int nvme_ns_info_from_identify(struct nvme_ctrl *ctrl,if (id->ncap ==0 ) {/* namespace not allocated or attached */ info->is_removed = true; -return -ENODEV ; + ret = -ENODEV ; + goto error; } info->anagrpid = id->anagrpid;
@@ -1498,8 +1499,10 @@ static int nvme_ns_info_from_identify(struct nvme_ctrl *ctrl, !memchr_inv(ids->nguid, 0, sizeof(ids->nguid)))memcpy (ids->nguid, id->nguid,sizeof (ids->nguid)); } + +error:kfree (id); -return 0 ; +return ret; } static int nvme_ns_info_from_id_cs_indep(struct nvme_ctrl *ctrl,
Signature · 1 line
2.39.3
On 11/23/2023 7:37 PM, Maurizio Lombardi wrote:
Reviewed-by Kanchan Joshi <[email protected]>
Reviewed-by Sagi Grimberg <[email protected]>
Quoted 2 lines · Maurizio Lombardi
In case of error, free the
nvme_id_nsstructure that was allocated bynvme_identify_ns().
Thanks, applied to nvme-6.7.