Skip to contentSkip to conversation

ASoC: imx-rpmsg: SND_SOC_IMX_RPMSG should depend on OF and I2C

PATCH In review Chancel Liu 3 participants 3 messages Nov 25, 2023 – Nov 27, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: imx-rpmsg: SND_SOC_IMX_RPMSG should depend on OF and I2C

SND_SOC_IMX_RPMSG should depend on OF and I2C. It fixes the following error reported by kernel test robot:

ld: sound/soc/fsl/imx-rpmsg.o: in function `imx_rpmsg_late_probe':
imx-rpmsg.c:(.text+0x4f): undefined reference to `i2c_find_device_by_fwnode'

Fixes 5d9f746ca64c ("ASoC: imx-rpmsg: Force codec power on in low power audio mode")
---
 sound/soc/fsl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/fsl/Kconfig +1 -0
index bec2aa561930..acb518f7ae79 100644
@@ -347,6 +347,7 @@ config SND_SOC_IMX_HDMI
 config SND_SOC_IMX_RPMSG
 	tristate "SoC Audio support for i.MX boards with rpmsg"
 	depends on RPMSG
+	depends on OF && I2C
 	select SND_SOC_IMX_PCM_RPMSG
 	select SND_SOC_IMX_AUDIO_RPMSG
 	help
Signature · 1 line
2.42.0
#1 lore raw
kernel test robot noticed the following build warnings:

Hi Chancel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.7-rc2 next-20231124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chancel-Liu/ASoC-imx-rpmsg-SND_SOC_IMX_RPMSG-should-depend-on-OF-and-I2C/20231125-151826
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20231125065300.6385-1-chancel.liu%40nxp.com
patch subject: [PATCH] ASoC: imx-rpmsg: SND_SOC_IMX_RPMSG should depend on OF and I2C
config: alpha-kismet-CONFIG_SND_SOC_IMX_RPMSG-CONFIG_SND_SOC_FSL_RPMSG-0-0 (https://download.01.org/0day-ci/archive/20231126/[email protected]/config)
reproduce: (https://download.01.org/0day-ci/archive/20231126/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

kismet warnings: (new ones prefixed by >>)

>> kismet: WARNING: unmet direct dependencies detected for SND_SOC_IMX_RPMSG when selected by SND_SOC_FSL_RPMSG

WARNING: unmet direct dependencies detected for SND_SOC_IMX_RPMSG
Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_IMX_SOC [=y] && RPMSG [=y] && OF [=n] && I2C [=y]
Selected by [y]:
- SND_SOC_FSL_RPMSG [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && COMMON_CLK [=y] && RPMSG [=y] && (SND_IMX_SOC [=y] || SND_IMX_SOC [=y]=n) && SND_IMX_SOC [=y]!=n

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
maintainer
#2 lore raw
In reply to Chancel Liu
Quoted 8 lines · Chancel Liu

SND_SOC_IMX_RPMSG should depend on OF and I2C. It fixes the following error reported by kernel test robot:

ld: sound/soc/fsl/imx-rpmsg.o: in function `imx_rpmsg_late_probe':
imx-rpmsg.c:(.text+0x4f): undefined reference to `i2c_find_device_by_fwnode'

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: imx-rpmsg: SND_SOC_IMX_RPMSG should depend on OF and I2C

      commit: f83d38def6b1b00c9bb17173837045b41df7e7d7

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark