Skip to contentSkip to conversation

media: chips-media: wave5: Remove unneeded semicolon

PATCH In review Yang Li 2 participants 3 messages Nov 27, 2023 – Nov 30, 2023

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/2 media: chips-media: wave5: Remove unneeded semicolon

./drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c:95:2-3: Unneeded semicolon

---
 drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c +1 -1
index f29cfa3af94a..8bbf9d10b467 100644
@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
 		break;
 	case VPU_INST_STATE_STOP:
 		break;
-	};
+	}
 
 	dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
 		state_to_str(inst->state), state_to_str(state));
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 2/2 media: chips-media: wave5: Remove unneeded semicolon

./drivers/media/platform/chips-media/wave5/wave5-hw.c

---
 drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/chips-media/wave5/wave5-hw.c +1 -1
index 3fcb2d92add8..4606d3425339 100644
@@ -2318,7 +2318,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
 				param->intra_refresh_mode);
 			return false;
 		}
-	};
+	}
 	return true;
 
 invalid_refresh_argument:
Signature · 1 line
2.20.1.7.g153144c
#2 lore raw
In reply to Yang Li

Hey Yang,

Quoted 1 line · Yang Li

./drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c:95:2-3: Unneeded semicolon

Just pasting this line here makes the commit look a bit confusing. It would be enough to simply write:

A switch statement does not require a semicolon after the closing curly bracket, remove it.

The same applies for the second patch.

Greetings,
Sebastian

Quoted 25 lines

---
drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c +1 -1
index f29cfa3af94a..8bbf9d10b467 100644
@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
 		break;
 	case VPU_INST_STATE_STOP:
 		break;
-	};
+	}
 
 	dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
 		state_to_str(inst->state), state_to_str(state));
Signature · 1 line
2.20.1.7.g153144c