Resolve 'Unused Result' Warning from proc-empty-vm.c
Subsystems (2)
PATCH 1/1 Resolve 'Unused Result' Warning from proc-empty-vm.c
From: angquan yu <[email protected]>
In tools/testing/selftests/proc/proc-empty->because the return value of a write call was being ignored. This call was partof a conditional debugging block (if (0) { ... }), which meant it would neveractually execute.
This patch removes the unused debug write call. This cleanup resolves the compi>warning about ignoring the result of write declared with the warn_unused_resultattribute.
Removing this code also improves the clarity and maintainability of the function, as it eliminates a non-functional block of code.
This is original warning: proc-empty-vm.c: In function ‘test_proc_pid_statm’ :proc-empty-vm.c:385:17:
warning: ignoring return value of ‘write’
declared with>385 | write(1, buf, rv);|
--- tools/testing/selftests/proc/proc-empty-vm.c | 2 ++ 1 file changed, 2 insertions(+)
tools/testing/selftests/proc/proc-empty-vm.c +2 -0
@@ -383,8 +383,10 @@ static int test_proc_pid_statm(pid_t pid)assert (rv <=sizeof (buf));if (0 ) {ssize_t written =write (1 , buf, rv); +if (written ==-1 ) {perror ("write failed to /proc/${pid}" ); +return EXIT_FAILURE ; } }
Signature · 1 line
2.39.2