Skip to contentSkip to conversation

dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example

PATCH Applied Rob Herring 3 participants 3 messages Nov 28, 2023 – Nov 29, 2023

Subsystems (2)
Device tree bindings Reset controller framework
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example

Binding examples should generally only cover what the binding covers. A provider binding doesn't need to show consumers and vice-versa. The hisilicon,hi3660-reset binding example has both, so let's drop them.

This also fixes an undocumented (by schema) compatible warning for "hisilicon,hi3660-iomcu".

Signed-off-by Rob Herring <[email protected]>
---
 .../reset/hisilicon,hi3660-reset.yaml         | 25 +------------------
 1 file changed, 1 insertion(+), 24 deletions(-)
Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml +1 -24
index cdfcf32c53fa..e4de002d6903 100644
@@ -50,32 +50,9 @@ additionalProperties: false
 
 examples:
   - |
-    #include <dt-bindings/interrupt-controller/irq.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
-    #include <dt-bindings/clock/hi3660-clock.h>
-
-    iomcu: iomcu@ffd7e000 {
-        compatible = "hisilicon,hi3660-iomcu", "syscon";
-        reg = <0xffd7e000 0x1000>;
-    };
-
-    iomcu_rst: iomcu_rst_controller {
+    iomcu_rst_controller {
         compatible = "hisilicon,hi3660-reset";
         hisilicon,rst-syscon = <&iomcu>;
         #reset-cells = <2>;
     };
-
-    /* Specifying reset lines connected to IP modules */
-    i2c@ffd71000 {
-        compatible = "snps,designware-i2c";
-        reg = <0xffd71000 0x1000>;
-        interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
-        #address-cells = <1>;
-        #size-cells = <0>;
-        clock-frequency = <400000>;
-        clocks = <&crg_ctrl HI3660_CLK_GATE_I2C0>;
-        resets = <&iomcu_rst 0x20 3>;
-        pinctrl-names = "default";
-        pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
-    };
 ...
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Rob Herring

Binding examples should generally only cover what the binding covers. A provider binding doesn't need to show consumers and vice-versa. The hisilicon,hi3660-reset binding example has both, so let's drop them.

This also fixes an undocumented (by schema) compatible warning for "hisilicon,hi3660-iomcu".

Signed-off-by Rob Herring <[email protected]>

---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

Binding examples should generally only cover what the binding covers. A provider binding doesn't need to show consumers and vice-versa. The hisilicon,hi3660-reset binding example has both, so let's drop them.

This also fixes an undocumented (by schema) compatible warning for "hisilicon,hi3660-iomcu".

[...]

Applied to reset/next, thanks!

[1/1] dt-bindings: reset: hisilicon,hi3660-reset: Drop providers and consumers from example

      https://git.pengutronix.de/cgit/pza/linux/commit/?id=c3c46acd5be9

regards
Philipp