Skip to contentSkip to conversation

dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example

PATCH In review Rob Herring 3 participants 3 messages Nov 28, 2023 – Dec 4, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example

The example for the TI Palmas ADC is incomplete as the binding is the full PMIC, not just the sub-functions. It is preferred for MFD examples to be complete in the top-level MFD device binding rather than piecemeal in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for '"ti,twl6035-pmic", "ti,palmas-pmic"'.

---
 .../bindings/iio/adc/ti,palmas-gpadc.yaml         | 15 ---------------
 1 file changed, 15 deletions(-)
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml +0 -15
index 720c16a108d4..f94057d8f605 100644
@@ -67,19 +67,4 @@ required:
   - compatible
   - "#io-channel-cells"
 
-examples:
-  - |
-    #include <dt-bindings/clock/mt8183-clk.h>
-    pmic {
-        compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
-        adc {
-            compatible = "ti,palmas-gpadc";
-            interrupts = <18 0>,
-                         <16 0>,
-                         <17 0>;
-            #io-channel-cells = <1>;
-            ti,channel0-current-microamp = <5>;
-            ti,channel3-current-microamp = <10>;
-        };
-    };
 ...
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

The example for the TI Palmas ADC is incomplete as the binding is the full PMIC, not just the sub-functions. It is preferred for MFD examples to be complete in the top-level MFD device binding rather than piecemeal in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for '"ti,twl6035-pmic", "ti,palmas-pmic"'.

---

Best regards,
Krzysztof

maintainer
#2 lore raw
Quoted 9 lines · On Wed, 29 Nov 2023 09:30:23 +0100 Krzysztof Kozlowski…
Quoted 8 lines · Rob Herring

The example for the TI Palmas ADC is incomplete as the binding is the full PMIC, not just the sub-functions. It is preferred for MFD examples to be complete in the top-level MFD device binding rather than piecemeal in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for '"ti,twl6035-pmic", "ti,palmas-pmic"'.

Quoted 8 lines
Quoted 2 lines

---

Best regards,
Krzysztof

Applied to the togreg branch of iio.git and pushed out as testing for all the normal reasons.

Thanks,

Jonathan