Skip to contentSkip to conversation

selftests:x86: Fix Format String Warnings in lam.c

PATCH New angquan yu 1 participant 1 message Nov 29, 2023

Subsystems (2)
lore
Share & tools
lore

angquan yu

author
#0 lore raw

PATCH 1/1 selftests:x86: Fix Format String Warnings in lam.c

From: angquan yu <[email protected]>

This commit addresses compiler warnings in lam.c related to the usage of non-literal format strings without format arguments in the 'run_test' function.

Warnings fixed:
- Resolved warnings indicating that 'ksft_test_result_skip' and 'ksft_test_result' were called with 't->msg' as a format string without accompanying format arguments.

Changes made:
- Modified the calls to 'ksft_test_result_skip' and 'ksft_test_result' to explicitly include a format specifier ("%s") for 't->msg'.
- This ensures that the string is safely treated as a format argument, adhering to safer coding practices and resolving the compiler warnings.

---
 tools/testing/selftests/x86/lam.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/x86/lam.c +2 -2
index 8f9b06d9c..215b8150b 100644
@@ -817,7 +817,7 @@ static void run_test(struct testcases *test, int count)
 
 		/* return 3 is not support LA57, the case should be skipped */
 		if (ret == 3) {
-			ksft_test_result_skip(t->msg);
+			ksft_test_result_skip("%s", t->msg);
 			continue;
 		}
 
@@ -826,7 +826,7 @@ static void run_test(struct testcases *test, int count)
 		else
 			ret = !(t->expected);
 
-		ksft_test_result(ret, t->msg);
+		ksft_test_result(ret, "%s", t->msg);
 	}
 }
 
Signature · 1 line
2.39.2