dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples
Subsystems (3)
cover dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples
When reviewing the various SPMI PMIC bindings, I noticed that several examples were incorrect and misleading and could also use some cleanup.
This series addresses the thermal ones.
Johan
Johan Hovold (2):
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
.../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 8 +++++--- .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 16 ++++++++++------ 2 files changed, 15 insertions(+), 9 deletions(-)
Signature · 1 line
2.41.0
PATCH 1/2 dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
The ADC Thermal Monitor is part of an SPMI PMIC, which in turn sits on an SPMI bus.
--- .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 3 ++- .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml +2 -1
@@ -114,7 +114,8 @@ examples: - | #include <dt-bindings/iio/qcom,spmi-vadc.h> #include <dt-bindings/interrupt-controller/irq.h> - spmi_bus { + + pmic { #address-cells = <1>; #size-cells = <0>; pm8998_adc: adc@3100 {
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml +4 -2
@@ -167,7 +167,8 @@ examples: - | #include <dt-bindings/iio/qcom,spmi-vadc.h> #include <dt-bindings/interrupt-controller/irq.h> - spmi_bus { + + pmic { #address-cells = <1>; #size-cells = <0>; pm8150b_adc: adc@3100 {
@@ -207,7 +208,8 @@ examples: #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h> #include <dt-bindings/interrupt-controller/irq.h> - spmi_bus { + + pmic { #address-cells = <1>; #size-cells = <0>; pmk8350_vadc: adc@3100 {
Signature · 1 line
2.41.0
Re: [PATCH 1/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
Quoted 5 lines · Johan Hovold
The ADC Thermal Monitor is part of an SPMI PMIC, which in turn sits on an SPMI bus.
Fixes db03874b8543 ("dt-bindings: thermal: qcom: add HC variant of adc-thermal monitor bindings")Fixes e8ffd6c0756b ("dt-bindings: thermal: qcom: add adc-thermal monitor bindings")
This is just an example, not a binding. There is no real bug to be fixed.
Best regards,
Krzysztof
PATCH 2/2 dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
In reply to Johan HovoldClean up the examples by adding newline separators, moving 'reg' properties after 'compatible' and dropping unused labels.
--- .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml +3 -2
@@ -118,9 +118,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pm8998_adc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc-rev2"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>;
@@ -131,7 +132,7 @@ examples: }; }; - pm8998_adc_tm: adc-tm@3400 { + adc-tm@3400 { compatible = "qcom,spmi-adc-tm-hc"; reg = <0x3400>; interrupts = <0x2 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml +6 -4
@@ -171,9 +171,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pm8150b_adc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc5"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>;
@@ -187,7 +188,7 @@ examples: }; }; - pm8150b_adc_tm: adc-tm@3500 { + adc-tm@3500 { compatible = "qcom,spmi-adc-tm5"; reg = <0x3500>; interrupts = <0x2 0x35 0x0 IRQ_TYPE_EDGE_RISING>;
@@ -212,9 +213,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pmk8350_vadc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc7"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>;
@@ -235,7 +237,7 @@ examples: }; }; - pmk8350_adc_tm: adc-tm@3400 { + adc-tm@3400 { compatible = "qcom,spmi-adc-tm5-gen2"; reg = <0x3400>; interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
Signature · 1 line
2.41.0
Re: [PATCH 2/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
Quoted 8 lines · Johan Hovold
Clean up the examples by adding newline separators, moving 'reg' properties after 'compatible' and dropping unused labels.
Signed-off-by Johan Hovold <[email protected]>--- .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-)
This and previous patch are both trivial cleanups, so probably should be squashed together. Anyway:
Best regards,
Krzysztof
Re: [PATCH 2/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · Johan Hovold
Clean up the examples by adding newline separators, moving 'reg' properties after 'compatible' and dropping unused labels.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Johan Hovold <[email protected]>--- .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-)This and previous patch are both trivial cleanups, so probably should be squashed together. Anyway:
I didn't want to mix too many things in one patch, and as I just mentioned in another reply, I consider the "spmi" parent node name to be more than just a naming cleanup as calling the node "spmi" indicates that these "devices" are SPMI devices themselves, rather than part of an SPMI PMIC.
Quoted 1 line
Thanks again.
Johan
Hi Daniel and Rafael,
Quoted 8 lines · Johan Hovold
When reviewing the various SPMI PMIC bindings, I noticed that several examples were incorrect and misleading and could also use some cleanup.
This series addresses the thermal ones.
Johan Hovold (2):
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
Can we get these merged for 6.8?
Johan
Daniel Lezcano
AppliedQuoted 6 lines · Johan Hovold
Hi Daniel and Rafael,
Quoted 3 lines · Johan Hovold
When reviewing the various SPMI PMIC bindings, I noticed that several examples were incorrect and misleading and could also use some cleanup.
Quoted 7 lines
Quoted 5 lines
This series addresses the thermal ones.
Johan Hovold (2):
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examplesCan we get these merged for 6.8?
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog