Introducing P4TC
Subsystems (6)
Jamal Hadi Salim
maintainerv9 cover Introducing P4TC
We are seeking community feedback on P4TC patches.
Changes In RFC Version 2
-------------------------
Version 2 is the initial integration of the eBPF datapath.
We took into consideration suggestions provided to use eBPF and put effort into analyzing eBPF as datapath which involved extensive testing.
We implemented 6 approaches with eBPF and ran performance analysis and presented our results at the P4 2023 workshop in Santa Clara[see: 1, 3] on each of the 6 vs the scriptable P4TC and concluded that 2 of the approaches are sensible (4 if you account for XDP or TC separately).
Conclusions from the exercise: We lose the simple operational model we had prior to integrating eBPF. We do gain performance in most cases when the datapath is less compute-bound.
For more discussion on our requirements vs journeying the eBPF path please scroll down to "Restating Our Requirements" and "Challenges".
This patch set presented two modes.
mode1: the parser is entirely based on eBPF - whereas the rest of the SW datapath stays as _scriptable_ as in Version 1.
mode2: All of the kernel s/w datapath (including parser) is in eBPF.
The key ingredient for eBPF, that we did not have access to in the past, is kfunc (it made a big difference for us to reconsider eBPF).
In V2 the two modes are mutually exclusive (IOW, you get to choose one or the other via Kconfig).
Changes In RFC Version 3
-------------------------
These patches are still in a little bit of flux as we adjust to integrating eBPF. So there are small constructs that are used in V1 and 2 but no longer used in this version. We will make a V4 which will remove those. The changes from V2 are as follows:
1) Feedback we got in V2 is to try stick to one of the two modes. In this version we are taking one more step and going the path of mode2 vs v2 where we had 2 modes.
2) The P4 Register extern is no longer standalone. Instead, as part of integrating into eBPF we introduce another kfunc which encapsulates Register as part of the extern interface.
3) We have improved our CICD to include tools pointed to us by Simon. See "Testing" further below. Thanks to Simon for that and other issues he caught. Simon, we discussed on issue [7] but decided to keep that log since we think it is useful.
4) A lot of small cleanups. Thanks Marcelo. There are two things we need to re-discuss though; see: [5], [6].
5) We removed the need for a range of IDs for dynamic actions. Thanks Jakub.
6) Clarify ambiguity caused by smatch in an if(A) else if(B) condition. We are guaranteed that either A or B must exist; however, lets make smatch happy. Thanks to Simon and Dan Carpenter.
Changes In RFC Version 4
-------------------------
1) More integration from scriptable to eBPF. Small bug fixes.
2) More streamlining support of externs via kfunc (one additional kfunc).
3) Removed per-cpu scratchpad per Toke's suggestion and instead use XDP metadata.
There is more eBPF integration coming. One thing we looked at but is not in this patchset but should be in the next is use of eBPF link in our loading (see "challenge #1" further below).
Changes In RFC Version 5
-------------------------
1) More integration from scriptable view to eBPF. Small bug fixes from last integration.
2) More streamlining support of externs via kfunc (create-on-miss, etc)
3) eBPF linking for XDP.
There is more eBPF integration/streamlining coming (we are getting close to conversion from scriptable domain).
Changes In RFC Version 6
-------------------------
1) Completed integration from scriptable view to eBPF. Completed integration of externs integration.
2) Small bug fixes from v5 based on testing.
Changes In Version 7
-------------------------
0) First time removing the RFC tag!
1) Removed XDP cookie. It turns out as was pointed out by Toke(Thanks!) - that using bpf links was sufficient to protect us from someone replacing or deleting a eBPF program after it has been bound to a netdev.
2) Add some reviewed-bys from Vlad.
3) Small bug fixes from v6 based on testing for ebpf.
4) Added the counter extern as a sample extern. Illustrating this example because it is slightly complex since it is possible to invoke it directly from the P4TC domain (in case of direct counters) or from eBPF (indirect counters). It is not exactly the most efficient implementation (a reasonable counter impl should be per-cpu).
Changes In Version 8
---------------------
1) Fix all the patchwork warnings and improve our ci to catch them in the future
2) Reduce the number of patches to basic max(15) to ease review.
Changes In version 9
---------------------
1) Remove the largest patch (externs) to ease review.
2) Break up action patches into two to ease review bringing down the patches that need more scrutiny to 8 (the first 7 are almost trivial).
3) Fixup prefix naming convention to p4tc_xxx for uapi and p4a_xxx for actions to provide consistency(Jiri).
4) Silence sparse warning "was not declared. Should it be static?" for kfuncs by making them static. TBH, not sure if this is the right solution but it makes sparse happy and hopefully someone will comment.
What is P4?
-----------
The Programming Protocol-independent Packet Processors (P4) is an open source, domain-specific programming language for specifying data plane behavior.
The P4 ecosystem includes an extensive range of deployments, products, projects and services, etc[9][10][11][12].
__What is P4TC?__
P4TC is a net-namespace aware P4 implementation over TC; IOW, a P4 program and its associated objects and state are attachend to a netns.
The implementation builds on top of many years of Linux TC experiences of running a software datapath with an equivalent offloadable hardware datapath. On why P4 - see small treatise here:[4].
There have been many discussions and meetings since about 2015 in regards to P4 over TC[2] and we are finally proving the naysayers that we do get stuff done!
A lot more of the P4TC motivation is captured at:
https://github.com/p4tc-dev/docs/blob/main/why-p4tc.md
**In this patch series we focus on s/w datapath only**. The software datapath is useful regardless of presence of offloadable hardware. The s/w datapath is eBPF based and the initial code is derived from [13] with enhancements and fixes to meet our requirements (see "Restating Our Requirements" further below).
These patches enable kernel and user space code change _independence_ for any new P4 program that describes a new datapath.
__P4TC Workflow__
The workflow is as follows:
1) A developer writes a P4 program, "myprog"
2) Compiles it using the P4C compiler[8]. The compiler generates 3 outputs:
a) shell script(s) which form template definitions for the different P4 objects "myprog" utilizes (tables, externs, actions etc).
b) the parser and the rest of the datapath are generated
in eBPF and need to be compiled into binaries.
c) A json introspection file used for the control plane (by iproute2/tc).
3) The developer (or operator) executes the shell script(s) to manifest the functional "myprog" into the kernel.
4) The developer (or operator) instantiates "myprog" via the tc P4 filter
to ingress/egress (depending on P4 arch) of one or more netdevs/ports.
Example1: parser is an action:
"tc filter add block 22 ingress protocol all prio 10 p4 pname myprog \
action bpf obj $PARSER.o section parser/tc-ingress \
action bpf obj $PROGNAME.o section p4prog/tc"
Example2: parser explicitly bound and rest of dpath as an action:
"tc filter add block 22 ingress protocol all prio 10 p4 pname myprog \
prog tc obj $PARSER.o section parser/tc-ingress \
action bpf obj $PROGNAME.o section p4prog/tc"
Example3: parser is at XDP, rest of dpath as an action:
"tc filter add block 22 ingress protocol all prio 10 p4 pname myprog \
prog type xdp obj $PARSER.o section parser/xdp-ingress \
pinned_link /path/to/xdp-prog-link \
action bpf obj $PROGNAME.o section p4prog/tc"
Example4: parser+prog at XDP:
"tc filter add block 22 ingress protocol all prio 10 p4 pname myprog \
prog type xdp obj $PROGNAME.o section p4prog/xdp \
pinned_link /path/to/xdp-prog-link"See individual patches for more examples tc vs xdp etc. Also see section on "challenges" (further below on this cover letter).
Once "myprog" P4 program is instantiated one can start updating table entries and/or creating actions at runtime.
Example, creating an entry in myprog's table named "mytable" to redirect to eno1:
tc p4ctrl create myprog/table/mytable dstAddr 10.0.1.2/32 \
action send_to_port param port eno1A packet arriving on ingress of any of the ports on block 22 will first be exercised via the (generated eBPF) parser to extract the headers (the ip destination address in this case labelled "dstAddr").
The main eBPF datapath then uses the parsed dstAddr as a key to do a lookup in myprog's "mytable" which returns the action params which are then used to execute the action in the eBPF datapath (eventually sending out packets to eno1). On a table miss, mytable's default miss action is executed.
__Description of Patches__
P4TC is designed to have no impact on the core code for other users of the kernel IOW, you either can compile it out (or even compile it in and if you dont use it) then there should be no impact on your performance or functionality.
We do make small tc kernel changes. Patch #1 adds infrastructure for P4 actions that can be created on as need basis for the P4 program requirement. This patch makes a small incision into act_api which shouldn't affect the performance (or functionality) of the existing actions. Patches 2-4,6-7 are minimalist enablers for P4TC and have no effect the classical tc action. Patch 5 adds infrastructure support for preallocation of dynamic actions.
The core P4TC code implements several P4 objects.
1) Patch #8 introduces P4 data types which are consumed by the rest of the code
2) Patch #9 introduces the concept of templating Pipelines. i.e CRUD commands for P4 pipelines.
3) Patch #10 introduces the action templates and associated CRUD commands.
4) Patch #11 introduce the action runtime infrastructure.
5) Patch #12 introduces the concept of P4 table templates and associated CRUD commands for tables.
6) Patch #13 introduces runtime table entry infra and associated CRUD commands.
7) Patch #14 introduces interaction of eBPF to P4TC tables via kfunc.
8) Patch #15 introduces the TC classifier P4 used at runtime.
Note, to have the minimal viable implementation we need to have extern patch(es) on top of these. There are a few more patches (3-5) not in this patchset. So consider this patchset to be "part 1"; "part2" will come later.
__Testing__
Speaking of testing - we have ~300 tdc test cases. This number is growing as we are adjusting to accommodate for eBPF.
These tests are run on our CICD system on pull requests and after commits are approved. The CICD does a lot of other tests (more since v2, thanks to Simon's input)including:
checkpatch, sparse, smatch, coccinelle, 32 bit and 64 bit builds tested on both X86, ARM 64 and emulated BE via qemu s390. We trigger performance testing in the CICD to catch performance regressions (currently only on the control path, but in the future for the datapath).
Syzkaller runs 24/7 on dedicated hardware, originally we focussed only on memory sanitizer but recently added support for concurrency sanitizer. Before main releases we ensure each patch will compile on its own to help in git bisect and run the xmas tree tool. We eventually put the code via coverity.
In addition we are working on a tool that will take a P4 program, run it through the compiler, and generate permutations of traffic patterns via symbolic execution that will test both positive and negative datapath code paths. The test generator tool is still work in progress and will be generated by the P4 compiler.
Note: We have other code that test parallelization etc which we are trying to find a fit for in the kernel tree's testing infra.
__Restating Our Requirements__
The initial release made in January/2023 had a "scriptable" datapath (think u32 classifier and pedit action). In this section we review the scriptable version against the current implementation we are pushing upstream which uses eBPF.
Our intention is to target _the TC crowd_.
Essentially developers and ops people deploying TC based infra. More importantly the original intent for P4TC was to enable _ops folks_ more than devs (given code is being generated and doesn't need humans to write it).
With TC, we get whole "familiar" package of match-action pipeline abstraction++, meaning from the control plane all the way to the tooling infra, i.e iproute2/tc cli, netlink infra(request/resp, event subscribe/multicast-publish, congestion control etc), s/w and h/w symbiosis, the autonomous kernel control, etc.
The main advantage is that we have a singular vendor-neutral interface via the kernel using well understood mechanisms based on deployment experience (and at least this part doesnt need retraining).
1) Supporting expressibility of the universe set of P4 progs
It is a must to support 100% of all possible P4 programs. In the past the eBPF verifier, for example in [13], had to be worked around and even then there are cases where we couldnt avoid path explosion when branching is involved and failed to run. Kfunc-ing solves these issues for us. Note, there are still challenges running all potential P4 programs at the XDP level - the solution to that is to have the compiler generate XDP based code only if it possible to map it to that layer.
2) Support for P4 HW and SW equivalence.
This feature continues to work even in the presence of eBPF as the s/w datapath. There are cases of square-hole-round-peg scenarios but those are implementation issues we can live with.
3) Operational usability
By maintaining the TC control plane (even in presence of eBPF datapath) runtime aspects remain unchanged. So for our target audience of folks who have deployed tc, including offloads, the comfort zone is unchanged. There is also the comfort zone of continuing to use the true-and-tried netlink interfacing.
There is some loss in operational usability because we now have more knobs:
the extra compilation, loading and syncing of ebpf binaries, etc. IOW, I can no longer just ship someone a shell script in an email to say go run this and "myprog" will just work.
4) Operational and development Debuggability
If something goes wrong, the tc craftsperson is now required to have additional knowledge of eBPF code and process. This applies to both the operational person as well as someone who wrote a driver. We dont believe this is solvable.
5) Opportunity for rapid prototyping of new ideas
During the P4TC development phase something that came naturally was to often handcode the template scripts because the compiler backend (which is P4 arch specific) wasnt ready to generate certain things. Then you would read back the template and diff to ensure the kernel didn't get something wrong. So this started as a debug feature. During development, we wrote scripts that covered a range of P4 architectures(PSA, V1, etc) which required no kernel code changes.
Over time the debug feature morphed into: a) start by handcoding scripts then
b) read it back and then c) generate the P4 code.
It means one could start with the template scripts outside of the constraints of a P4 architecture spec(PNA/PSA) or even within a P4 architecture then test some ideas and eventually feed back the concepts to the compiler authors or modify or create a new P4 architecture and share with the P4 standards folks.
To summarize in presence of eBPF: The debugging idea is probably still alive. One could dump, with proper tooling(bpftool for example), the loaded eBPF code and be able to check for differences. But this is not the interesting part. The concept of going back from whats in the kernel to P4 is a lot more difficult to implement mostly due to scoping of DSL vs general purpose. It may be lost. We have been thinking of ways to use BTF and embedding annotations in the eBPF code and binary but more thought is required and we welcome suggestions.
6) Supporting per namespace program
In P4TC every program and its associated objects have unique IDs which are generated by the compiler. Multiple or the same P4 program(s) can run independently in different namespaces alongside their appropriate state and object instance parameterization (despite name or ID collission). This requirement is still met (by virtue of keeping P4 control objects within the TC domain and attaching to a netns).
__Challenges__
1) Concept of tc block in XDP is _very tedious_ to implement. It would be nice if we can use concept there as well, since we expect P4 to work with many ports. It will likely require some core patches to fix this.
2) Right now we are using "packed" construct to enforce alignment in kfunc data exchange; but we're wondering if there is potential to use BTF to understand parameters and their offsets and encode this information at the compiler level.
3) At the moment we are creating a static buffer of 128B to retrieve the action parameters. If you have a lot of table entries and individual(non-shared) action instances with actions that require very little (or no) param space a lot of memory is wasted. There may also be cases where 128B may not be enough; (likely this is something we can teach the P4C compiler). If we can have dynamic pointers instead for kfunc fixed length parameterization then this issue is resolvable.
4) See "Restating Our Requirements" #5.
We would really appreciate ideas/suggestions, etc.
__References__
[1]https://github.com/p4tc-dev/docs/blob/main/p4-conference-2023/2023P4WorkshopP4TC.pdf [2]https://github.com/p4tc-dev/docs/blob/main/why-p4tc.md#historical-perspective-for-p4tc [3]https://2023p4workshop.sched.com/event/1KsAe/p4tc-linux-kernel-p4-implementation-approaches-and-evaluation [4]https://github.com/p4tc-dev/docs/blob/main/why-p4tc.md#so-why-p4-and-how-does-p4-help-here [5]https://lore.kernel.org/netdev/[email protected]/T/#mf59be7abc5df3473cff3879c8cc3e2369c0640a6 [6]https://lore.kernel.org/netdev/[email protected]/T/#m783cfd79e9d755cf0e7afc1a7d5404635a5b1919 [7]https://lore.kernel.org/netdev/[email protected]/T/#ma8c84df0f7043d17b98f3d67aab0f4904c600469 [8]https://github.com/p4lang/p4c/tree/main/backends/tc
[9]https://p4.org/ [10]https://www.intel.com/content/www/us/en/products/details/network-io/ipu/e2000-asic.html [11]https://www.amd.com/en/accelerators/pensando
[12]https://github.com/sonic-net/DASH/tree/main [13]https://github.com/p4lang/p4c/tree/main/backends/ebpf
Jamal Hadi Salim (15):
net: sched: act_api: Introduce P4 actions list
net/sched: act_api: increase action kind string length
net/sched: act_api: Update tc_action_ops to account for P4 actions
net/sched: act_api: add struct p4tc_action_ops as a parameter to
lookup callback
net: sched: act_api: Add support for preallocated P4 action instances
net: introduce rcu_replace_pointer_rtnl
rtnl: add helper to check if group has listeners
p4tc: add P4 data types
p4tc: add template pipeline create, get, update, delete
p4tc: add action template create, update, delete, get, flush and dump
p4tc: add P4 action runtime support
p4tc: add template table create, update, delete, get, flush and dump
p4tc: add runtime table entry create, update, get, delete, flush and
dump
p4tc: add set of P4TC table kfuncs
p4tc: add P4 classifier
include/linux/bitops.h | 1 + include/linux/rtnetlink.h | 19 + include/net/act_api.h | 22 +- include/net/p4tc.h | 598 ++++++ include/net/p4tc_types.h | 88 + include/net/tc_act/p4tc.h | 52 + include/uapi/linux/p4tc.h | 343 ++++ include/uapi/linux/pkt_cls.h | 19 + include/uapi/linux/rtnetlink.h | 18 + include/uapi/linux/tc_act/tc_p4.h | 11 + net/sched/Kconfig | 23 + net/sched/Makefile | 3 + net/sched/act_api.c | 195 +- net/sched/cls_api.c | 2 +- net/sched/cls_p4.c | 447 +++++ net/sched/p4tc/Makefile | 8 + net/sched/p4tc/p4tc_action.c | 2292 +++++++++++++++++++++++ net/sched/p4tc/p4tc_bpf.c | 338 ++++ net/sched/p4tc/p4tc_pipeline.c | 675 +++++++ net/sched/p4tc/p4tc_runtime_api.c | 145 ++ net/sched/p4tc/p4tc_table.c | 1584 ++++++++++++++++ net/sched/p4tc/p4tc_tbl_entry.c | 2855 +++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_tmpl_api.c | 609 ++++++ net/sched/p4tc/p4tc_types.c | 1247 +++++++++++++ net/sched/p4tc/trace.c | 10 + net/sched/p4tc/trace.h | 44 + security/selinux/nlmsgtab.c | 10 +- 27 files changed, 11619 insertions(+), 39 deletions(-) create mode 100644 include/net/p4tc.h create mode 100644 include/net/p4tc_types.h create mode 100644 include/net/tc_act/p4tc.h create mode 100644 include/uapi/linux/p4tc.h create mode 100644 include/uapi/linux/tc_act/tc_p4.h create mode 100644 net/sched/cls_p4.c create mode 100644 net/sched/p4tc/Makefile create mode 100644 net/sched/p4tc/p4tc_action.c create mode 100644 net/sched/p4tc/p4tc_bpf.c create mode 100644 net/sched/p4tc/p4tc_pipeline.c create mode 100644 net/sched/p4tc/p4tc_runtime_api.c create mode 100644 net/sched/p4tc/p4tc_table.c create mode 100644 net/sched/p4tc/p4tc_tbl_entry.c create mode 100644 net/sched/p4tc/p4tc_tmpl_api.c create mode 100644 net/sched/p4tc/p4tc_types.c create mode 100644 net/sched/p4tc/trace.c create mode 100644 net/sched/p4tc/trace.h
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 1/15 net: sched: act_api: Introduce P4 actions list
In P4 we require to generate new actions "on the fly" based on the specified P4 action definition. P4 action kinds, like the pipeline they are attached to, must be per net namespace, as opposed to native action kinds which are global. For that reason, we chose to create a separate structure to store P4 actions.
--- include/net/act_api.h | 7 ++- net/sched/act_api.c | 123 +++++++++++++++++++++++++++++++++++++----- net/sched/cls_api.c | 2 +- 3 files changed, 115 insertions(+), 17 deletions(-)
include/net/act_api.h +5 -2
@@ -105,6 +105,7 @@ typedef void (*tc_action_priv_destructor)(void *priv);struct tc_action_ops {struct list_head head; +struct list_head p4_head;char kind[IFNAMSIZ ];enum tca_id id;/* identifier should match kind */ unsigned int net_id;
@@ -198,8 +199,10 @@ int tcf_idr_check_alloc(struct tc_action_net *tn, u32 *index,int tcf_idr_release (struct tc_action *a,bool bind);int tcf_register_action (struct tc_action_ops *a,struct pernet_operations *ops); +int tcf_register_p4_action (struct net *net,struct tc_action_ops *act);int tcf_unregister_action (struct tc_action_ops *a,struct pernet_operations *ops); +void tcf_unregister_p4_action (struct net *net,struct tc_action_ops *act);int tcf_action_destroy (struct tc_action *actions[],int bind);int tcf_action_exec (struct sk_buff *skb,struct tc_action **actions,int nr_actions,struct tcf_result *res);
@@ -207,8 +210,8 @@ int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla,struct nlattr *est, struct tc_action *actions[], int init_res[], size_t *attr_size, u32 flags, u32 fl_flags, struct netlink_ext_ack *extack); -struct tc_action_ops *tc_action_load_ops (struct nlattr *nla,bool police, -bool rtnl_held, +struct tc_action_ops *tc_action_load_ops (struct net *net,struct nlattr *nla, +bool police,bool rtnl_held,struct netlink_ext_ack *extack); struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp, struct nlattr *nla, struct nlattr *est,
net/sched/act_api.c +109 -14
215 lines not on this page · raw message
net/sched/cls_api.c +1 -1
@@ -3293,7 +3293,7 @@ int tcf_exts_validate_ex(struct net *net, struct tcf_proto *tp, struct nlattr **if (exts->police && tb[exts->police]) {struct tc_action_ops *a_o; - a_o =tc_action_load_ops (tb[exts->police], true, + a_o =tc_action_load_ops (net, tb[exts->police], true, !(flags &TCA_ACT_FLAGS_NO_RTNL ), extack);if (IS_ERR (a_o))
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 2/15 net/sched: act_api: increase action kind string length
In reply to Jamal Hadi SalimIncrease action kind string length from IFNAMSIZ to 64
The new P4 actions, created via templates, will have longer names of format: "pipeline_name/act_name". IFNAMSIZ is currently 16 and is most of the times undersized for the above format.
So, to conform to this new format, we increase the maximum name length to account for this extra string (pipeline name) and the '/' character.
--- include/net/act_api.h | 2 +- include/uapi/linux/pkt_cls.h | 1 + net/sched/act_api.c | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-)
include/net/act_api.h +1 -1
@@ -106,7 +106,7 @@ typedef void (*tc_action_priv_destructor)(void *priv);struct tc_action_ops {struct list_head head;struct list_head p4_head; -char kind[IFNAMSIZ ]; +char kind[ACTNAMSIZ ];enum tca_id id;/* identifier should match kind */ unsigned int net_id;size_t size;
include/uapi/linux/pkt_cls.h +1 -0
@@ -6,6 +6,7 @@#include <linux/pkt_sched.h> #define TC_COOKIE_MAX_SIZE 16 +#define ACTNAMSIZ 64/* Action attributes */ enum {
net/sched/act_api.c +3 -3
@@ -476,7 +476,7 @@ static size_t tcf_action_shared_attrs_size(const struct tc_action *act)rcu_read_unlock ();return nla_total_size (0 )/* action number nested */ - +nla_total_size (IFNAMSIZ )/* TCA_ACT_KIND */ + +nla_total_size (ACTNAMSIZ )/* TCA_ACT_KIND */ + cookie_len/* TCA_ACT_COOKIE */ +nla_total_size (sizeof (struct nla_bitfield32 ))/* TCA_ACT_HW_STATS */ +nla_total_size (0 )/* TCA_ACT_STATS nested */
@@ -1393,7 +1393,7 @@ struct tc_action_ops *tc_action_load_ops(struct net *net, struct nlattr *nla, {struct nlattr *tb[TCA_ACT_MAX +1 ];struct tc_action_ops *a_o; -char act_name[IFNAMSIZ ]; +char act_name[ACTNAMSIZ ];struct nlattr *kind;int err;
@@ -1408,7 +1408,7 @@ struct tc_action_ops *tc_action_load_ops(struct net *net, struct nlattr *nla,NL_SET_ERR_MSG (extack,"TC action kind must be specified" );return ERR_PTR (err); } -if (nla_strscpy (act_name, kind,IFNAMSIZ ) <0 ) { +if (nla_strscpy (act_name, kind,ACTNAMSIZ ) <0 ) {NL_SET_ERR_MSG (extack,"TC action name too long" );return ERR_PTR (err); }
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 3/15 net/sched: act_api: Update tc_action_ops to account for P4 actions
In reply to Jamal Hadi SalimThe initialisation of P4TC action instances require access to a struct p4tc_act (which appears in later patches) to help us to retrieve information like the P4 action parameters etc. In order to retrieve struct p4tc_act we need the pipeline name or id and the action name or id. Also recall that P4TC action IDs are P4 and are net namespace specific. The init callback from tc_action_ops parameters had no way of supplying us that information. To solve this issue, we decided to create a new tc_action_ops callback (init_ops), that provies us with the tc_action_ops struct which then provides us with the pipeline and action name. In addition we add a new refcount to struct tc_action_ops called dyn_ref, which accounts for how many action instances we have of a specific action.
--- include/net/act_api.h | 6 ++++++ net/sched/act_api.c | 14 +++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-)
include/net/act_api.h +6 -0
@@ -109,6 +109,7 @@ struct tc_action_ops {char kind[ACTNAMSIZ ];enum tca_id id;/* identifier should match kind */ unsigned int net_id; +refcount_t p4_ref;size_t size;struct module *owner; int (*act)(struct sk_buff *, const struct tc_action *,
@@ -120,6 +121,11 @@ struct tc_action_ops { struct nlattr *est, struct tc_action **act, struct tcf_proto *tp, u32 flags, struct netlink_ext_ack *extack); +/* This should be merged with the original init action */ +int (*init_ops)(struct net *net,struct nlattr *nla, +struct nlattr *est,struct tc_action **act, +struct tcf_proto *tp,struct tc_action_ops *ops, +u32 flags,struct netlink_ext_ack *extack); int (*walk)(struct net *, struct sk_buff *, struct netlink_callback *, int, const struct tc_action_ops *,
net/sched/act_api.c +11 -3
@@ -1023,7 +1023,7 @@ int tcf_register_action(struct tc_action_ops *act,struct tc_action_ops *a;int ret; -if (!act->act || !act->dump || !act->init) +if (!act->act || !act->dump || (!act->init && !act->init_ops))return -EINVAL ;/* We have to register pernet ops before making the action ops visible,
@@ -1484,8 +1484,16 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp, } } - err = a_o->init (net, tb[TCA_ACT_OPTIONS ], est, &a, tp, - userflags.value | flags, extack); +/* When we arrive here we guarantee that a_o->init or +* a_o->init_ops exist. +*/ +if (a_o->init) + err = a_o->init (net, tb[TCA_ACT_OPTIONS ], est, &a, tp, + userflags.value | flags, extack); +else + err = a_o->init_ops (net, tb[TCA_ACT_OPTIONS ], est, &a, + tp, a_o, userflags.value | flags, + extack); }else { err = a_o->init (net, nla, est, &a, tp, userflags.value | flags, extack);
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 4/15 net/sched: act_api: add struct p4tc_action_ops as a parameter to lookup callback
In reply to Jamal Hadi SalimFor P4 actions, we require information from struct tc_action_ops, specifically the action kind, to find and locate the P4 action information for the lookup operation.
--- include/net/act_api.h | 3 ++- net/sched/act_api.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
include/net/act_api.h +2 -1
@@ -116,7 +116,8 @@ struct tc_action_ops { struct tcf_result *); /* called under RCU BH lock*/int (*dump)(struct sk_buff *,struct tc_action *,int ,int );void (*cleanup)(struct tc_action *); -int (*lookup)(struct net *net,struct tc_action **a,u32 index); +int (*lookup)(struct net *net,const struct tc_action_ops *ops, +struct tc_action **a,u32 index); int (*init)(struct net *net, struct nlattr *nla, struct nlattr *est, struct tc_action **act, struct tcf_proto *tp,
net/sched/act_api.c +1 -1
@@ -726,7 +726,7 @@ static int __tcf_idr_search(struct net *net,struct tc_action_net *tn =net_generic (net, ops->net_id);if (unlikely (ops->lookup)) -return ops->lookup (net, a, index); +return ops->lookup (net, ops, a, index);return tcf_idr_search (tn, a, index); }
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 5/15 net: sched: act_api: Add support for preallocated P4 action instances
In reply to Jamal Hadi SalimIn P4, actions are assumed to pre exist and have an upper bound number of instances. Typically if you have 1M table entries you want to allocate enough action instances to cover the 1M entries. However, this is a big waste of memory if the action instances are not in use. So for our case, we allow the user to specify a minimal amount of actions in the template and then if more P4 action instances are needed then they will be added on demand as in the current approach with tc filter-action relationship.
Add the necessary code to preallocate actions instances for P4 actions.
We add 2 new actions flags:
- TCA_ACT_FLAGS_PREALLOC: Indicates the action instance is a P4 action and was preallocated for future use the templating phase of P4TC
- TCA_ACT_FLAGS_UNREFERENCED: Indicates the action instance was preallocated and is currently not being referenced by any other object. Which means it won't show up in an action instance dump.
Once an action instance is created we don't free it when the last table entry referring to it is deleted.
Instead we add it to the pool/cache of action instances for that specific action i.e it counts as if it is preallocated. Preallocated actions can't be deleted by the tc actions runtime commands and a dump or a get will only show preallocated actions instances which are being used (TCA_ACT_FLAGS_UNREFERENCED == false).
The preallocated actions will be deleted once the pipeline is deleted (which will purge the P4 action kind and its instances).
For example, if we were to create a P4 action that preallocates 128 elements and dumped:
$ tc -j p4template get action/myprog/send_nh | jq .
We'd see the following:
[
{
"obj": "action template",
"pname": "myprog",
"pipeid": 1
},
{
"templates": [
{
"aname": "myprog/send_nh",
"actid": 1,
"params": [
{
"name": "port",
"type": "dev",
"id": 1
}
],
"prealloc": 128
}
] }
]
If we try to dump the P4 action instances, we won't see any:
$ tc -j actions ls action myprog/send_nh | jq .
[]
However, if we create a table entry which references this action kind:
$ tc p4ctrl create myprog/table/cb/FDB \ dstAddr d2:96:91:5d:02:86 action myprog/send_nh \ param port type dev dummy0
Dumping the action instance will now show this one instance which is associated with the table entry:
$ tc -j actions ls action myprog/send_nh | jq .
[
{
"total acts": 1
},
{
"actions": [
{
"order": 0,
"kind": "myprog/send_nh",
"index": 1,
"ref": 1,
"bind": 1,
"params": [
{
"name": "port",
"type": "dev",
"value": "dummy0",
"id": 1
}
],
"not_in_hw": true
}
] }
]
--- include/net/act_api.h | 3 +++ net/sched/act_api.c | 50 ++++++++++++++++++++++++++++++++----------- 2 files changed, 41 insertions(+), 12 deletions(-)
include/net/act_api.h +3 -0
@@ -68,6 +68,8 @@ struct tc_action {#define TCA_ACT_FLAGS_REPLACE (1U << (TCA_ACT_FLAGS_USER_BITS + 2))#define TCA_ACT_FLAGS_NO_RTNL (1U << (TCA_ACT_FLAGS_USER_BITS + 3))#define TCA_ACT_FLAGS_AT_INGRESS (1U << (TCA_ACT_FLAGS_USER_BITS + 4)) +#define TCA_ACT_FLAGS_PREALLOC (1U << (TCA_ACT_FLAGS_USER_BITS + 5)) +#define TCA_ACT_FLAGS_UNREFERENCED (1U << (TCA_ACT_FLAGS_USER_BITS + 6))/* Update lastuse only if needed, to avoid dirtying a cache line. * We use a temp variable to avoid fetching jiffies twice.
@@ -200,6 +202,7 @@ int tcf_idr_create_from_flags(struct tc_action_net *tn, u32 index, const struct tc_action_ops *ops, int bind, u32 flags);void tcf_idr_insert_many (struct tc_action *actions[]); +void tcf_idr_insert_n (struct tc_action *actions[],const u32 n);void tcf_idr_cleanup (struct tc_action_net *tn,u32 index);int tcf_idr_check_alloc (struct tc_action_net *tn,u32 *index,struct tc_action **a,int bind);
net/sched/act_api.c +38 -12
84 lines not on this page · raw message
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 6/15 net: introduce rcu_replace_pointer_rtnl
In reply to Jamal Hadi SalimWe use rcu_replace_pointer(rcu_ptr, ptr, lockdep_rtnl_is_held()) throughout the P4TC infrastructure code.
It may be useful for other use cases, so we create a helper.
--- include/linux/rtnetlink.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
include/linux/rtnetlink.h +12 -0
@@ -62,6 +62,18 @@ static inline bool lockdep_rtnl_is_held(void)#define rcu_dereference_rtnl (p) \ rcu_dereference_check(p, lockdep_rtnl_is_held()) +/** +* rcu_replace_pointer_rtnl - replace an RCU pointer under rtnl_lock, returning +* its old value +* @rcu_ptr: RCU pointer, whose old value is returned +* @ptr: regular pointer +* +* Perform a replacement under rtnl_lock, where @rcu_ptr is an RCU-annotated +* pointer. The old value of @rcu_ptr is returned, and @rcu_ptr is set to @ptr +*/ +#define rcu_replace_pointer_rtnl (rcu_ptr, ptr) \ + rcu_replace_pointer(rcu_ptr, ptr, lockdep_rtnl_is_held()) +/** * rtnl_dereference - fetch RCU pointer when updates are prevented by RTNL * @p: The pointer to read, prior to dereferencing
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 7/15 rtnl: add helper to check if group has listeners
In reply to Jamal Hadi SalimAs of today, rtnl code creates a new skb and unconditionally fills and broadcasts it to the relevant group. For most operations this is okay and doesn't waste resources in general.
For P4TC, it's interesting to know if the TC group has any listeners when adding/updating/deleting table entries as we can optimize for the most likely case it contains none. This not only improves our processing speed, it also reduces pressure on the system memory as we completely avoid the broadcast skb allocation.
--- include/linux/rtnetlink.h | 7 +++++++ 1 file changed, 7 insertions(+)
include/linux/rtnetlink.h +7 -0
@@ -142,4 +142,11 @@ extern int ndo_dflt_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,extern void rtnl_offload_xstats_notify (struct net_device *dev); +static inline int rtnl_has_listeners (const struct net *net,u32 group) +{ +struct sock *rtnl = net->rtnl; + +return netlink_has_listeners (rtnl, group); +} +#endif /* __LINUX_RTNETLINK_H */
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 8/15 p4tc: add P4 data types
In reply to Jamal Hadi SalimIntroduce abstraction that represents P4 data types.
This also introduces the Kconfig and Makefile which later patches use. Types could be little, host or big endian definitions. The abstraction also supports defining:
a) bitstrings using P4 annotations that look like "bit<X>" where X is the number of bits defined in a type
b) bitslices such that one can define in P4 as bit<8>[0-3] and bit<16>[4-9]. A 4-bit slice from bits 0-3 and a 6-bit slice from bits 4-9 respectively.
Each type has a bitsize, a name (for debugging purposes), an ID and methods/ops. The P4 types will be used by externs, dynamic actions, packet headers and other parts of P4TC.
Each type has four ops:
- validate_p4t: Which validates if a given value of a specific type meets valid boundary conditions.
- create_bitops: Which, given a bitsize, bitstart and bitend allocates and returns a mask and a shift value. For example, if we have type bit<8>[3-3] meaning bitstart = 3 and bitend = 3, we'll create a mask which would only give us the fourth bit of a bit8 value, that is, 0x08. Since we are interested in the fourth bit, the bit shift value will be 3. This is also useful if an "irregular" bitsize is used, for example, bit24. In that case bitstart = 0 and bitend = 23. Shift will be 0 and the mask will be 0xFFFFFF00 if the machine is big endian.
- host_read : Which reads the value of a given type and transforms it to host order (if needed)
- host_write : Which writes a provided host order value and transforms it to the type's native order (if needed)
--- include/net/p4tc_types.h | 88 +++ include/uapi/linux/p4tc.h | 33 + net/sched/Kconfig | 11 + net/sched/Makefile | 2 + net/sched/p4tc/Makefile | 3 + net/sched/p4tc/p4tc_types.c | 1247 +++++++++++++++++++++++++++++++++++ 6 files changed, 1384 insertions(+) create mode 100644 include/net/p4tc_types.h create mode 100644 include/uapi/linux/p4tc.h create mode 100644 net/sched/p4tc/Makefile create mode 100644 net/sched/p4tc/p4tc_types.c
include/net/p4tc_types.h new file +88 -0
@@ -0,0 +1,88 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __NET_P4TYPES_H +#define __NET_P4TYPES_H + +#include <linux/netlink.h> +#include <linux/pkt_cls.h> +#include <linux/types.h> + +#include <uapi/linux/p4tc.h> + +#define P4TC_T_MAX_BITSZ 128 + +struct p4tc_type_mask_shift { +void *mask; +u8 shift; +}; + +struct p4tc_type ; +struct p4tc_type_ops { +int (*validate_p4t)(struct p4tc_type *container,void *value,u16 startbit, +u16 endbit,struct netlink_ext_ack *extack); +struct p4tc_type_mask_shift *(*create_bitops)(u16 bitsz, +u16 bitstart, +u16 bitend, +struct netlink_ext_ack *extack); +void (*host_read)(struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift,void *sval, +void *dval); +void (*host_write)(struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift,void *sval, +void *dval); +void (*print)(struct net *net,struct p4tc_type *container, +const char *prefix,void *val); +}; + +#define P4TC_T_MAX_STR_SZ 32 +struct p4tc_type { +char name[P4TC_T_MAX_STR_SZ ]; +const struct p4tc_type_ops *ops; +size_t container_bitsz; +size_t bitsz; +int typeid; +}; + +struct p4tc_type *p4type_find_byid (int id); +bool p4tc_is_type_unsigned (int typeid); + +void p4t_copy (struct p4tc_type_mask_shift *dst_mask_shift, +struct p4tc_type *dst_t,void *dstv, +struct p4tc_type_mask_shift *src_mask_shift, +struct p4tc_type *src_t,void *srcv); +int p4t_cmp (struct p4tc_type_mask_shift *dst_mask_shift, +struct p4tc_type *dst_t,void *dstv, +struct p4tc_type_mask_shift *src_mask_shift, +struct p4tc_type *src_t,void *srcv); +void p4t_release (struct p4tc_type_mask_shift *mask_shift); + +int p4tc_register_types (void ); +void p4tc_unregister_types (void ); + +#ifdef CONFIG_RETPOLINE +void __p4tc_type_host_read (const struct p4tc_type_ops *ops, +struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift,void *sval, +void *dval); +void __p4tc_type_host_write (const struct p4tc_type_ops *ops, +struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift,void *sval, +void *dval); +#else +static inline void __p4tc_type_host_read (const struct p4tc_type_ops *ops, +struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift, +void *sval,void *dval) +{ +return ops->host_read (container, mask_shift, sval, dval); +} + +static inline void __p4tc_type_host_write (const struct p4tc_type_ops *ops, +struct p4tc_type *container, +struct p4tc_type_mask_shift *mask_shift, +void *sval,void *dval) +{ +return ops->host_write (container, mask_shift, sval, dval); +} +#endif + +#endif
include/uapi/linux/p4tc.h new file +33 -0
@@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef __LINUX_P4TC_H +#define __LINUX_P4TC_H + +#define P4TC_MAX_KEYSZ 512 + +enum { +P4TC_T_UNSPEC , +P4TC_T_U8 , +P4TC_T_U16 , +P4TC_T_U32 , +P4TC_T_U64 , +P4TC_T_STRING , +P4TC_T_S8 , +P4TC_T_S16 , +P4TC_T_S32 , +P4TC_T_S64 , +P4TC_T_MACADDR , +P4TC_T_IPV4ADDR , +P4TC_T_BE16 , +P4TC_T_BE32 , +P4TC_T_BE64 , +P4TC_T_U128 , +P4TC_T_S128 , +P4TC_T_BOOL , +P4TC_T_DEV , +P4TC_T_KEY , + __P4TC_T_MAX, +}; + +#define P4TC_T_MAX (__P4TC_T_MAX - 1) + +#endif
net/sched/Kconfig +11 -0
@@ -675,6 +675,17 @@ config NET_EMATCH_IPT To compile this code as a module, choose M here: the module will be called em_ipt. +config NET_P4_TC + bool "P4 TC support" + select NET_CLS_ACT + help + Say Y here if you want to use P4 features on top of TC. + P4 is an open source, domain-specific programming language for + specifying data plane behavior. By enabling P4TC you will be able to + write a P4 program, use a P4 compiler that supports P4TC backend to + generate all needed artificats, which when loaded allow you to + introduce a new kernel datapath that can be controlled via TC. + config NET_CLS_ACT bool "Actions" select NET_CLS
net/sched/Makefile +2 -0
@@ -82,3 +82,5 @@ obj-$(CONFIG_NET_EMATCH_TEXT) += em_text.o obj-$(CONFIG_NET_EMATCH_CANID) += em_canid.o obj-$(CONFIG_NET_EMATCH_IPSET) += em_ipset.o obj-$(CONFIG_NET_EMATCH_IPT) += em_ipt.o + +obj-$(CONFIG_NET_P4_TC) += p4tc/
net/sched/p4tc/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-y := p4tc_types.o
net/sched/p4tc/p4tc_types.c new file +1247 -0
1,247 lines not on this page · raw message
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 9/15 p4tc: add template pipeline create, get, update, delete
In reply to Jamal Hadi Salim__Introducing P4 TC Pipeline__
This commit introduces P4 TC pipelines, which emulate the semantics of a P4 program/pipeline using the TC infrastructure.
One can refer to P4 programs/pipelines using their names or their specific pipeline ids (pipeid)
P4 template CRUD (Create, Read/get, Update and Delete) commands apply on a pipeline.
As an example, to create a P4 program/pipeline named aP4proggie with a single table in its pipeline, one would use the following command from user space tc (as generated by the compiler):
tc p4template create pipeline/aP4proggie numtables 1 pipeid 1
Note that, in the above command, the numtables is set as 1; the default is 0 because it is feasible to have a P4 program with no tables at all.
The P4 compiler will generate the pipeid, however if none is specified, the kernel will issue one. Like the following example:
tc p4template create pipeline/aP4proggie numtables 1
To Read pipeline aP4proggie attributes, one would retrieve those details as follows:
tc p4template get pipeline/[aP4proggie] [pipeid 1]
Note that in the above command one may specify pipeline ID, name or both.
To Update aP4proggie pipeline from 1 to 10 tables, one would use the following command:
tc p4template update pipeline/[aP4proggie] [pipeid 1] numtables 10
Note that, in the above command, one could use the P4 program/pipeline name, id or both to specify which P4 program/pipeline to update.
To Delete a P4 program/pipeline named aP4proggie with a pipeid of 1, one would use the following command:
tc p4template del pipeline/[aP4proggie] [pipeid 1]
Note that, in the above command, one could use the P4 program/pipeline name, id or both to specify which P4 program/pipeline to delete
If one wished to dump all the created P4 programs/pipelines, one would use the following command:
tc p4template get pipeline/
__Pipeline Lifetime__
After Create is issued, one can Read/get, Update and Delete; however the pipeline can only be put to use after it is "sealed". To seal a pipeline, one would issue the following command:
tc p4template update pipeline/aP4proggie state ready
After a pipeline is sealed it can be put to use via the TC P4 classifier. For example:
tc filter add dev $DEV ingress protocol any prio 6 p4 pname aP4proggie \
action bpf obj $PARSER.o section prog/tc-parser
action bpf obj $PROGNAME.o section prog/tc-ingress
Instantiates aP4proggie in the ingress of $DEV. One could also attach it to a block of ports (example tc block 22) as such:
tc filter add block 22 ingress protocol all prio 6 p4 pname aP4proggie \
action bpf obj $PARSER.o section prog/tc-parser
action bpf obj $PROGNAME.o section prog/tc-ingress
We can, after that, add a table entry.
Like, for example:
tc p4ctrl create aP4proggie/table/cb/aP4table \
dstAddr 10.10.10.0/24 srcAddr 192.168.0.0/16 prio 16 \
action dropOnce the pipeline is attached to a device or block it cannot be deleted. It becomes Read-only from the control plane/user space.
The pipeline can be deleted when there are no longer any users left.
--- include/net/p4tc.h | 126 +++++++ include/uapi/linux/p4tc.h | 66 ++++ include/uapi/linux/rtnetlink.h | 9 + net/sched/p4tc/Makefile | 2 +- net/sched/p4tc/p4tc_pipeline.c | 611 +++++++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_tmpl_api.c | 585 +++++++++++++++++++++++++++++++ security/selinux/nlmsgtab.c | 6 +- 7 files changed, 1403 insertions(+), 2 deletions(-) create mode 100644 include/net/p4tc.h create mode 100644 net/sched/p4tc/p4tc_pipeline.c create mode 100644 net/sched/p4tc/p4tc_tmpl_api.c
include/net/p4tc.h new file +126 -0
@@ -0,0 +1,126 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __NET_P4TC_H +#define __NET_P4TC_H + +#include <uapi/linux/p4tc.h> +#include <linux/workqueue.h> +#include <net/sch_generic.h> +#include <net/net_namespace.h> +#include <linux/refcount.h> +#include <linux/rhashtable.h> +#include <linux/rhashtable-types.h> + +#define P4TC_DEFAULT_NUM_TABLES P4TC_MINTABLES_COUNT +#define P4TC_DEFAULT_MAX_RULES 1 +#define P4TC_PATH_MAX 3 + +#define P4TC_KERNEL_PIPEID 0 + +#define P4TC_PID_IDX 0 + +struct p4tc_dump_ctx { +u32 ids[P4TC_PATH_MAX ]; +}; + +struct p4tc_template_common ; + +struct p4tc_path_nlattrs { +char *pname; +u32 *ids; +bool pname_passed; +}; + +struct p4tc_pipeline ; +struct p4tc_template_ops { +void (*init)(void ); +struct p4tc_template_common *(*cu)(struct net *net,struct nlmsghdr *n, +struct nlattr *nla, +struct p4tc_path_nlattrs *nl_pname, +struct netlink_ext_ack *extack); +int (*put)(struct p4tc_pipeline *pipeline, +struct p4tc_template_common *tmpl, +struct netlink_ext_ack *extack); +int (*gd)(struct net *net,struct sk_buff *skb,struct nlmsghdr *n, +struct nlattr *nla,struct p4tc_path_nlattrs *nl_pname, +struct netlink_ext_ack *extack); +int (*fill_nlmsg)(struct net *net,struct sk_buff *skb, +struct p4tc_template_common *tmpl, +struct netlink_ext_ack *extack); +int (*dump)(struct sk_buff *skb,struct p4tc_dump_ctx *ctx, +struct nlattr *nla,char **p_name,u32 *ids, +struct netlink_ext_ack *extack); +int (*dump_1)(struct sk_buff *skb,struct p4tc_template_common *common); +}; + +struct p4tc_template_common { +char name[P4TC_TMPL_NAMSZ ]; +struct p4tc_template_ops *ops; +u32 p_id; +u32 PAD0; +}; + +extern const struct p4tc_template_ops p4tc_pipeline_ops; + +struct p4tc_pipeline { +struct p4tc_template_common common; +struct rcu_head rcu; +struct net *net; +/* Accounts for how many entities are referencing this pipeline. +* As for now only P4 filters can refer to pipelines. +*/ +refcount_t p_ctrl_ref; +u16 num_tables; +u16 curr_tables; +u8 p_state; +}; + +struct p4tc_pipeline_net { +struct idr pipeline_idr; +}; + +static inline bool p4tc_tmpl_msg_is_update (struct nlmsghdr *n) +{ +return n->nlmsg_type ==RTM_UPDATEP4TEMPLATE ; +} + +int p4tc_tmpl_generic_dump (struct sk_buff *skb,struct p4tc_dump_ctx *ctx, +struct idr *idr,int idx, +struct netlink_ext_ack *extack); + +struct p4tc_pipeline *p4tc_pipeline_find_byany (struct net *net, +const char *p_name, +const u32 pipeid, +struct netlink_ext_ack *extack); +struct p4tc_pipeline *p4tc_pipeline_find_byid (struct net *net, +const u32 pipeid); +struct p4tc_pipeline *p4tc_pipeline_find_get (struct net *net, +const char *p_name, +const u32 pipeid, +struct netlink_ext_ack *extack); + +static inline bool p4tc_pipeline_get (struct p4tc_pipeline *pipeline) +{ +return refcount_inc_not_zero (&pipeline->p_ctrl_ref); +} + +void p4tc_pipeline_put (struct p4tc_pipeline *pipeline); +struct p4tc_pipeline * +p4tc_pipeline_find_byany_unsealed (struct net *net,const char *p_name, +const u32 pipeid, +struct netlink_ext_ack *extack); + +static inline int p4tc_action_destroy (struct tc_action **acts) +{ +int ret =0 ; + +if (acts) { + ret =tcf_action_destroy (acts,TCA_ACT_UNBIND ); +kfree (acts); + } + +return ret; +} + +#define to_pipeline (t) ((struct p4tc_pipeline *)t) + +#endif
include/uapi/linux/p4tc.h +66 -0
78 lines not on this page · raw message
include/uapi/linux/rtnetlink.h +9 -0
@@ -194,6 +194,15 @@ enum { RTM_GETTUNNEL,#define RTM_GETTUNNEL RTM_GETTUNNEL + RTM_CREATEP4TEMPLATE = 124, +#define RTM_CREATEP4TEMPLATE RTM_CREATEP4TEMPLATE + RTM_DELP4TEMPLATE, +#define RTM_DELP4TEMPLATE RTM_DELP4TEMPLATE + RTM_GETP4TEMPLATE, +#define RTM_GETP4TEMPLATE RTM_GETP4TEMPLATE + RTM_UPDATEP4TEMPLATE, +#define RTM_UPDATEP4TEMPLATE RTM_UPDATEP4TEMPLATE + __RTM_MAX,#define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1) };
net/sched/p4tc/Makefile +1 -1
@@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0 -obj-y := p4tc_types.o +obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o
net/sched/p4tc/p4tc_pipeline.c new file +611 -0
611 lines not on this page · raw message
net/sched/p4tc/p4tc_tmpl_api.c new file +585 -0
585 lines not on this page · raw message
security/selinux/nlmsgtab.c +5 -1
@@ -94,6 +94,10 @@ static const struct nlmsg_perm nlmsg_route_perms[] = { { RTM_NEWTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, { RTM_DELTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, { RTM_GETTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_READ }, + { RTM_CREATEP4TEMPLATE, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, + { RTM_DELP4TEMPLATE, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, + { RTM_GETP4TEMPLATE, NETLINK_ROUTE_SOCKET__NLMSG_READ }, + { RTM_UPDATEP4TEMPLATE, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, }; static const struct nlmsg_perm nlmsg_tcpdiag_perms[] = {
@@ -177,7 +181,7 @@ int selinux_nlmsg_lookup(u16 sclass, u16 nlmsg_type, u32 *perm)* structures at the top of this file with the new mappings * before updating the BUILD_BUG_ON() macro! */ -BUILD_BUG_ON (RTM_MAX != (RTM_NEWTUNNEL +3 )); +BUILD_BUG_ON (RTM_MAX != (RTM_CREATEP4TEMPLATE +3 )); err =nlmsg_perm (nlmsg_type, perm, nlmsg_route_perms,sizeof (nlmsg_route_perms));break ;
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 10/15 p4tc: add action template create, update, delete, get, flush and dump
In reply to Jamal Hadi SalimThis commit allows the control plane to create, update, delete, get, flush and dump action templates based on P4 action definitions.
Visualize the following action in a P4 program named aP4Proggie:
action send_nh(@tc_type("macaddr) bit<48> dstAddr, @tc_type("dev") bit<8> port)
{
hdr.ethernet.dstAddr = dstMac;
send_to_port(port);
}The above is an action called send_nh which receives as parameters a bit<48> dstAddr (a mac address) and a bit<8> port (something close to ifindex).
which is applied on a P4 table match as such:
table mytable {
key = {
hdr.ipv4.dstAddr @tc_type("ipv4"): lpm;
}
actions = {
send_nh;
drop;
NoAction;
}
size = 1024;
}The mechanics of actions follow the CRUD semantics.
___P4 ACTION KIND CREATION___
In this stage we create the p4 action kind by specifying the action name, its ID, its parameters and the parameter types.
So for the send_nh action, the creation would look something like this:
tc p4template create action/aP4proggie/send_nh \
param dstAddr type macaddr id 1 param port type dev id 2
All the template commands (tc p4template) are generated by the p4c compiler (but of course could be hand coded by humans).
Also note that an action name has to specify the program name since P4 actions are unique to a program. As an example, the above command creates an action template that is bounded to pipeline/program named "aP4proggie".
Note2: In P4, actions are assumed to pre-exist and have an upper bound number of instances. Typically, if you have a max of 1024 "mytable" table entries you want to allocate enough action instances to cover the 1024 entries. However, this is a big waste of memory when we have low table occupancy. We pick a middle ground by providing pre-allocation control via attribute "num_prealloc".
The compiler generated template does not specify it and by default we preallocate 16 entries. The user can override this value by editing the generated text, for example to change the number to 128 as such:
tc p4template create action/aP4proggie/send_nh num_prealloc 128 \
param dstAddr type macaddr id 1 param port type dev id 2
When all preallocated action instances are exhausted (used in table entries) then the behavior switches to the current tc action approach i.e for every table entry created a new action instance is dynamically allocated. Once an instance is created it is added to the pool and never freed.
Note, Current tc action behavior is maintained:
a) If the user wishes to preallocate more actions instance later at runtime to take advantage of a faster table entry creation (by avoiding dynamic allocation at table entry creation time), they will have to individually create actions via the control plane using the classical "tc actions" command.
For example:
tc actions add action aP4proggie/send_nh \
param dstAddr AA:BB:CC:DD:EE:DD param port eth1
The action is added to the pool of action aP4proggie/send_nh instances and any table entry creation will grab it. The parameters specified above will be replaced when the table entry is created.
b) Sharing of action instances works the same way (i.e you could autobind to any action instance in a table entry creation by specifying the action "index".
___ACTION KIND ACTIVATION___
Once we provided all the necessary information for the new p4 action, we can go to the final stage: action activation. In this stage, we activate the p4 action and make it available for instantiation. To activate the action template, we issue the following command:
tc p4template update action/aP4proggie/send_nh state active
After the above the command, the action is ready to be instantiated.
___OTHER CONTROL COMMANDS___
The lifetime of the p4 action is tied to its pipeline
(see earlier patches). As with all pipeline components, write operations to action templates, such as create, update and delete, can only be executed if the pipeline is not sealed. Read/get can be issued even after the pipeline is sealed.
If, after we are done with our action template we want to delete it, we could issue the following command:
tc p4template del action/aP4proggie/send_nh
Note: If any instance was created for this action (as illustrated earlier) than this action cannot be deleted, unless you delete all instances first.
If we had created more action templates and wanted to flush all of the action templates from pipeline aP4proggie, one would use the following command:
tc p4template del action/aP4proggie/
After creating or updating a p4 actions, if one wishes to verify that the p4 action was created correctly, one would use the following command:
tc p4template get action/aP4proggie/send_nh
The above command will display the relevant data for the action, such as parameter names, types, etc.
If one wanted to check which action templates were associated to a specific pipeline, one could use the following command:
tc p4template get action/aP4proggie/
Note that this command will only display the name of these action templates. To verify their specific details, one should use the get command, which was previously described.
--- include/net/act_api.h | 1 + include/net/p4tc.h | 79 ++- include/net/tc_act/p4tc.h | 28 + include/uapi/linux/p4tc.h | 54 ++ include/uapi/linux/tc_act/tc_p4.h | 11 + net/sched/p4tc/Makefile | 3 +- net/sched/p4tc/p4tc_action.c | 1081 +++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_pipeline.c | 16 +- net/sched/p4tc/p4tc_tmpl_api.c | 18 + 9 files changed, 1280 insertions(+), 11 deletions(-) create mode 100644 include/net/tc_act/p4tc.h create mode 100644 include/uapi/linux/tc_act/tc_p4.h create mode 100644 net/sched/p4tc/p4tc_action.c
include/net/act_api.h +1 -0
@@ -70,6 +70,7 @@ struct tc_action {#define TCA_ACT_FLAGS_AT_INGRESS (1U << (TCA_ACT_FLAGS_USER_BITS + 4))#define TCA_ACT_FLAGS_PREALLOC (1U << (TCA_ACT_FLAGS_USER_BITS + 5))#define TCA_ACT_FLAGS_UNREFERENCED (1U << (TCA_ACT_FLAGS_USER_BITS + 6)) +#define TCA_ACT_FLAGS_FROM_P4TC (1U << (TCA_ACT_FLAGS_USER_BITS + 7))/* Update lastuse only if needed, to avoid dirtying a cache line. * We use a temp variable to avoid fetching jiffies twice.
include/net/p4tc.h +71 -8
114 lines not on this page · raw message
include/net/tc_act/p4tc.h new file +28 -0
@@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __NET_TC_ACT_P4_H +#define __NET_TC_ACT_P4_H + +#include <net/pkt_cls.h> +#include <net/act_api.h> + +struct tcf_p4act_params { +struct tcf_exts exts; +struct idr params_idr; +struct p4tc_act_param **params_array; +struct rcu_head rcu; +u32 num_params; +u32 tot_params_sz; +}; + +struct tcf_p4act { +struct tc_action common; +/* Params IDR reference passed during runtime */ +struct tcf_p4act_params __rcu *params; +u32 p_id; +u32 act_id; +struct list_head node; +}; + +#define to_p4act (a) ((struct tcf_p4act *)a) + +#endif /* __NET_TC_ACT_P4_H */
include/uapi/linux/p4tc.h +54 -0
87 lines not on this page · raw message
include/uapi/linux/tc_act/tc_p4.h new file +11 -0
@@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef __LINUX_TC_P4_H +#define __LINUX_TC_P4_H + +#include <linux/pkt_cls.h> + +struct tc_act_p4 { +tc_gen ; +}; + +#endif
net/sched/p4tc/Makefile +2 -1
@@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o +obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o \ + p4tc_action.o
net/sched/p4tc/p4tc_action.c new file +1081 -0
1,081 lines not on this page · raw message
net/sched/p4tc/p4tc_pipeline.c +14 -2
@@ -74,6 +74,8 @@ static const struct nla_policy tc_pipeline_policy[P4TC_PIPELINE_MAX + 1] = {static void p4tc_pipeline_destroy (struct p4tc_pipeline *pipeline) { +idr_destroy (&pipeline->p_act_idr); +kfree (pipeline); }
@@ -95,8 +97,12 @@ static void p4tc_pipeline_teardown(struct p4tc_pipeline *pipeline,struct net *net = pipeline->net;struct p4tc_pipeline_net *pipe_net =net_generic (net, pipeline_net_id);struct net *pipeline_net =maybe_get_net (net); +unsigned long iter_act_id; +struct p4tc_act *act; +unsigned long tmp; -idr_remove (&pipe_net->pipeline_idr, pipeline->common.p_id); +idr_for_each_entry_ul (&pipeline->p_act_idr, act, tmp, iter_act_id) + act->common.ops->put (pipeline, &act->common, extack);/* If we are on netns cleanup we can't touch the pipeline_idr. * On pre_exit we will destroy the idr but never call into teardown
@@ -151,6 +157,7 @@ static inline int pipeline_try_set_state_ready(struct p4tc_pipeline *pipeline, } pipeline->p_state =P4TC_STATE_READY ; +return true; }
@@ -248,6 +255,10 @@ static struct p4tc_pipeline *p4tc_pipeline_create(struct net *net,else pipeline->num_tables =P4TC_DEFAULT_NUM_TABLES ; +idr_init (&pipeline->p_act_idr); + + pipeline->num_created_acts =0 ; + pipeline->p_state =P4TC_STATE_NOT_READY ; pipeline->net = net;
@@ -502,7 +513,8 @@ static int p4tc_pipeline_gd(struct net *net, struct sk_buff *skb,return PTR_ERR (pipeline); tmpl = (struct p4tc_template_common *)pipeline; -if (p4tc_pipeline_fill_nlmsg (net, skb, tmpl, extack) <0 ) + ret =p4tc_pipeline_fill_nlmsg (net, skb, tmpl, extack); +if (ret <0 )return -1 ;if (!ids[P4TC_PID_IDX ])
net/sched/p4tc/p4tc_tmpl_api.c +18 -0
@@ -42,6 +42,7 @@ static bool obj_is_valid(u32 obj) {switch (obj) {case P4TC_OBJ_PIPELINE : +case P4TC_OBJ_ACT :return true;default :return false;
@@ -50,6 +51,7 @@ static bool obj_is_valid(u32 obj)static const struct p4tc_template_ops *p4tc_ops[P4TC_OBJ_MAX +1 ] = { [P4TC_OBJ_PIPELINE ] = &p4tc_pipeline_ops, + [P4TC_OBJ_ACT ] = &p4tc_act_ops, }; int p4tc_tmpl_generic_dump(struct sk_buff *skb, struct p4tc_dump_ctx *ctx,
@@ -124,6 +126,11 @@ static int tc_ctl_p4_tmpl_gd_1(struct net *net, struct sk_buff *skb, ids[P4TC_PID_IDX ] = t->pipeid; +if (tb[P4TC_PATH ]) { +const u32 *arg_ids =nla_data (tb[P4TC_PATH ]); + +memcpy (&ids[P4TC_PID_IDX +1 ], arg_ids,nla_len (tb[P4TC_PATH ])); + } nl_path_attrs->ids = ids; op = (struct p4tc_template_ops *)p4tc_ops[t->obj];
@@ -311,6 +318,12 @@ p4tc_tmpl_cu_1(struct sk_buff *skb, struct net *net, struct nlmsghdr *n, } ids[P4TC_PID_IDX ] = t->pipeid; + +if (tb[P4TC_PATH ]) { +const u32 *arg_ids =nla_data (tb[P4TC_PATH ]); + +memcpy (&ids[P4TC_PID_IDX +1 ], arg_ids,nla_len (tb[P4TC_PATH ])); + } nl_path_attrs->ids = ids; op = (struct p4tc_template_ops *)p4tc_ops[t->obj];
@@ -504,6 +517,11 @@ static int tc_ctl_p4_tmpl_dump_1(struct sk_buff *skb, struct nlattr *arg, root =nla_nest_start (skb,P4TC_ROOT ); ids[P4TC_PID_IDX ] = t->pipeid; +if (tb[P4TC_PATH ]) { +const u32 *arg_ids =nla_data (tb[P4TC_PATH ]); + +memcpy (&ids[P4TC_PID_IDX +1 ], arg_ids,nla_len (tb[P4TC_PATH ])); + } op = (struct p4tc_template_ops *)p4tc_ops[t->obj]; ret = op->dump (skb, ctx, tb[P4TC_PARAMS ], &p_name, ids, extack);
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 11/15 p4tc: add P4 action runtime support
In reply to Jamal Hadi SalimThis commit deals with the runtime part of P4 actions i.e instantiation and binding of action kinds which are created via templates (see previous patch).
For illustration we repeat the P4 code snippet from the action template commit:
action send_nh(@tc_type("macaddr) bit<48> dstAddr, @tc_type("dev") bit<8> port)
{
hdr.ethernet.dstAddr = dstMac;
send_to_port(port);
}table mytable {
key = {
hdr.ipv4.dstAddr @tc_type("ipv4"): lpm;
}
actions = {
send_nh;
drop;
NoAction;
}
size = 1024;
}One could create a table entry alongside an action instance as follows:
tc p4ctrl create aP4proggie/table/mycontrol/mytable \
srcAddr 10.10.10.0/24 \
action send_nh param dstAddr AA:BB:CC:DD:EE:FF param port eth0
As previously stated, we refer to the action by it's "full name" (pipeline_name/action_name). Here we are creating an instance of the send_nh action specifying as parameter values AA:BB:CC:DD:EE:FF for dstAddr and eth0 for port.
Or they could create an instance that is then added to the pool of send_nh action instances as follows:
tc actions add action aP4proggie/send_nh \
param dstAddr AA:BB:CC:DD:EE:FF param port eth0
Observe these are _exactly the same semantics_ as what tc today already provides with a caveat that we have a keyword "param" to precede the appropriate parameters.
Note: We can create as many instances for action templates as we wish, as long as we do not exceed the maximum allowed actions - in this specific case 1024 for table "mytable".
Action sharing still works the same way (as in classical tc). For example if we know the action index of the previous instance is 100 then we can bind it to a table entry, for example
tc p4ctrl create aP4proggie/table/mycontrol/mytable \
srcAddr 11.11.0.0/16 action send_nh index 100
--- include/net/p4tc.h | 98 +++ net/sched/p4tc/p4tc_action.c | 1163 +++++++++++++++++++++++++++++++++- 2 files changed, 1251 insertions(+), 10 deletions(-)
include/net/p4tc.h +98 -0
@@ -117,6 +117,59 @@ p4tc_pipeline_find_byany_unsealed(struct net *net, const char *p_name,const u32 pipeid, struct netlink_ext_ack *extack); +struct p4tc_act *p4a_runt_find (struct net *net, +const struct tc_action_ops *a_o, +struct netlink_ext_ack *extack); +void +p4a_runt_prealloc_put (struct p4tc_act *act,struct tcf_p4act *p4_act); + +static inline int p4tc_action_destroy (struct tc_action **acts) +{ +struct tc_action *acts_non_prealloc[TCA_ACT_MAX_PRIO ] = {NULL }; +int ret =0 ; + +if (acts) { +int j =0 ; +int i; + +for (i =0 ; i <TCA_ACT_MAX_PRIO && acts[i]; i++) { +if (acts[i]->tcfa_flags &TCA_ACT_FLAGS_PREALLOC ) { +struct tcf_p4act *p4act; +struct p4tc_act *act; +struct net *net; + + p4act = (struct tcf_p4act *)acts[i]; + net =maybe_get_net (acts[i]->idrinfo->net); + +if (net) { +const struct tc_action_ops *ops; + + ops = acts[i]->ops; + act =p4a_runt_find (net, ops,NULL ); +p4a_runt_prealloc_put (act, p4act); +put_net (net); + }else { +/* If net is coming down, template +* action will be deleted, so no need to +* remove from prealloc list, just decr +* refcounts. +*/ + acts_non_prealloc[j] = acts[i]; + j++; + } + }else { + acts_non_prealloc[j] = acts[i]; + j++; + } + } + + ret =tcf_action_destroy (acts_non_prealloc,TCA_ACT_UNBIND ); +kfree (acts); + } + +return ret; +} +struct p4tc_act_param {struct list_head head;struct rcu_head rcu;
@@ -171,6 +224,47 @@ struct p4tc_act {extern const struct p4tc_template_ops p4tc_act_ops; +static inline int p4tc_action_init (struct net *net,struct nlattr *nla, +struct tc_action *acts[],u32 pipeid, +u32 flags,struct netlink_ext_ack *extack) +{ +int init_res[TCA_ACT_MAX_PRIO ]; +size_t attrs_size; +int ret; +int i; + +/* If action was already created, just bind to existing one */ + flags |=TCA_ACT_FLAGS_BIND ; + flags |=TCA_ACT_FLAGS_FROM_P4TC ; + ret =tcf_action_init (net,NULL , nla,NULL , acts, init_res, &attrs_size, + flags,0 , extack); + +/* Check if we are trying to bind to dynamic action from different +* pipeline. +*/ +for (i =0 ; i <TCA_ACT_MAX_PRIO && acts[i]; i++) { +struct tc_action *a = acts[i]; +struct tcf_p4act *p; + +if (a->ops->id <=TCA_ID_MAX ) +continue ; + + p =to_p4act (a); +if (p->p_id != pipeid) { +NL_SET_ERR_MSG (extack, +"Unable to bind to dynact from different pipeline" ); + ret = -EPERM ; + goto destroy_acts; + } + } + +return ret; + +destroy_acts: +p4tc_action_destroy (acts); +return ret; +} +struct p4tc_act *p4a_tmpl_get (struct p4tc_pipeline *pipeline,const char *act_name,const u32 a_id,struct netlink_ext_ack *extack);
@@ -182,6 +276,10 @@ static inline bool p4tc_action_put_ref(struct p4tc_act *act)return refcount_dec_not_one (&act->a_ref); } +struct tcf_p4act * +p4a_runt_prealloc_get_next (struct p4tc_act *act); +void p4a_runt_init_flags (struct tcf_p4act *p4act); +#define to_pipeline (t) ((struct p4tc_pipeline *)t)#define to_hdrfield (t) ((struct p4tc_hdrfield *)t)#define p4tc_to_act (t) ((struct p4tc_act *)t)
net/sched/p4tc/p4tc_action.c +1153 -10
1,282 lines not on this page · raw message
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 12/15 p4tc: add template table create, update, delete, get, flush and dump
In reply to Jamal Hadi SalimThis commit introduces code to creation and maintenance of P4 tables defined in a P4 program.
As with all other P4TC objects, tables' lifetimes conform to extended CRUD operations and are maintained via templates.
It's important to note that write operations, such as create, update and delete can only be made if the pipeline is not sealed.
Per the P4 specification, tables prefix their name with the control block (although this could be overridden by P4 annotations).
As an example, if one were to create a table named table1 in a pipeline named myprog1, on control block "mycontrol", one would use the following command:
tc p4template create table/myprog1/mycontrol/table1 tblid 1 \
keysz 32 nummasks 8 tentries 8192
Above says that we are creating a table (table1) attached to pipeline myprog1 on control block mycontrol. Table1's key size is 32 bits wide and it can have up to 8 associated masks and 8192 entries. The table id for table1 is 1. The table id is typically provided by the compiler.
Parameters such as nummasks (number of masks this table may have) and tentries (maximum number of entries this table may have) may also be omitted in which case 8 masks and 256 entries will be assumed.
P4 tables have many associated attributes that further refine how these tables operate. Some attributes per table and others per entry. Attributes include:
- Table aging: The aging for the table entries belonging to the table (could be per table or entry)
- Match key type: The match type of the table key (exact, LPM, ternary, etc).
Note in P4 a key may constitute multiple (sub)key types, eg matching on srcip using a prefix and an exact match for dstip. In such a case it is up to the compiler to generalize the key used (For example in this case the overall key may endup being LPM or ternary).
- Direct Counter: Table counter instances used directly by the table, when specified in the P4 program, there will be one counter per entry.
- Direct Meter: Table meter instances used directly by the table, when specified in the P4 program, there will be one meter per entry.
- CRUDXPS Permissions both for specific entries and tables. The permissions are applicable to both the control plane and the datapath (see "Table Permissions" further below).
- Allowed Actions List. This will be a list of all possible actions that can be added to table entries that are added to the specified table.
- Action profiles. When defined in a P4 program, action profiles provide a mechanism to share action instances.
- Actions Selectors. When defined in a P4 program can be used to select the execution of one or more action instance selected at table lookup time by using a hash computation.
- Default hit action. When a default hit action is defined it is used when a matched table entry did not define an action. Depending on the P4 program the default hit action can be updated at runtime (in addition to being specified in the template).
- Default miss action. When a default miss action is defined it is used when a lookup that table fails.
- Action scope. In addition to actions being annotated as default hit or miss they can also be annotated to be either specific to a table of globally available to multiple tables within the same P4 program.
- Max entries. This is an upper bound for number of entries a specific table allows.
- Num masks. In the case of LPM or ternary matches, this defines the maximum allowed masks for that table.
- Timers. When defined in a P4 program, each entry has an associated timer. The table entries share a per-table timeout. The timer is refreshed every time there's a hit. After an idle period (defined in the per-table timeout), the P4 program can define whether it wants to have an event generated to user space (and have user space delete the entry), or whether it wants the kernel to delete it and send the event to announce the deletion.
- per entry "static" vs "dynamic" entry. By default all entries made from the control plane are "static" unless otherwise specified. All entries added from datapath are "dynamic" unless otherwise specified. "Dynamic" entries are subject to deletion when idle (subject to the rules specified in "Timers" above).
If one were to retrieve the table named table1 (before or after the pipeline is sealed) one would use the following command:
tc -j p4template get table/myprog1/mycontrol/table1 | jq .
If one were to dump all the tables from a pipeline named myprog1, one would use the following command:
tc p4template get table/myprog1
If one were to update table1 (before the pipeline is sealed) one would use the following command:
tc p4template update table/myprog1/mycontrol/table1 ....
If one were to delete table1 (before the pipeline is sealed) one would use the following command:
tc p4template del table/myprog1/mycontrol/table1
If one were to flush all the tables from a pipeline named myprog1, control block "mycontrol" one would use the following command:
tc p4template del table/myprog1/mycontrol/
___Table Permissions___
Tables can have permissions which apply to all the entries in the specified table. Permissions are defined for both what the control plane (user space) as well as the data path are allowed to do.
The permissions field is a 16bit value which will hold CRUDXPS (create, read, update, delete, execute, publish and subscribe) permissions for control and data path. Bits 13-7 will have the CRUDXPS values for control and bits 6-0 will have CRUDXPS values for data path. By default each table has the following permissions:
CRUD-PS-R--X--
Which means the control plane can perform CRUDPS operations whereas the data path can only Read and execute on the entries.
The user can override these permissions when creating the table or when updating.
For example, the following command will create a table which will not allow the datapath to create, update or delete entries but give full CRUDP permissions for the control plane.
$TC p4template create table/aP4proggie/cb/tname tblid 1 keysz 64 type lpm \
permissions 0x3D24 ...
Recall that these permissions come in the form of CRUDXPSCRUDXPS, where the first CRUDXPS block is for control and the last is for data path.
So 0x3D24 is equivalent to CR-D-P--R--X--
If we were to issue a read command on a table (tname):
$TC -j p4template get table/aP4proggie/cb/tname | jq .
The output would be the following:
[
{
"obj": "table",
"pname": "aP4Proggie",
"pipeid": 22
},
{
"templates": [
{
"tblid": 1,
"tname": "cb/tname",
"keysz": 64,
"max_entries": 256,
"masks": 8,
"entries": 0,
"permissions": "CRUD-P--R--X--",
"table_type": "lpm",
"acts_list": []
}
] }
]
Note, the permissions concept is more powerful than classical const definition currently taken by P4 which makes everything in a table read-only.
___Initial Table Entries___
Templating can create initial table entries. For example:
tc p4template update table/myprog/cb/tname \
entry srcAddr 10.10.10.10/32 dstAddr 1.1.1.0/24 prio 17
In this command we are "updating" table cb/tname with a new entry. This entry has as its key srcAddr concatenated with dstAddr
(both IPv4 addresses) and prio 17.
If one was to read back the entry by issuing the following command:
tc p4template get table/myprog/cb/tname
They would get:
pipeline id 22
table id 1
table name cb/tname
key_sz 64
max entries 256
masks 8
table entries 1
permissions CRUD-P--R--X--
entry:
entry priority 17[permissions-RUD-P--R--X--]
entry key
srcAddr id:1 size:32b type:ipv4 exact fieldval 10.10.10.10/32
dstAddr id:2 size:32b type:ipv4 exact fieldval 1.1.1.0/24___Table Actions List___
P4 tables allow certain actions but not other to be part of match entry on a table. P4 also defines default actions to be executed when no entries match; we have extended this concept to have a default hit,which is executed upon matching an entry which has no action associated with it.
We also allow flags for each of the actions in this list that specify if the action can be added only as a table entry (tableonly), or only as a default action (defaultonly). If no flags are specified, it is assumed that the action can be used in both contexts.
Both default hit and default miss are optional.
An example of specifying a default miss action is as follows:
tc p4template update table/myprog/cb/mytable \
default_miss_action permissions 0x1124 action dropThe above will drop packets if the entry is not found in mytable. Note the above makes the default action a const. Meaning the control plane can neither replace it nor delete it.
tc p4template update table/myprog/mytable \
default_hit_action permissions 0x3004 action ok
Whereas the above allows a default hit action to accept the packet. The permission 0x3004 (binary 11000000000100) means we have only Create and Read permissions in the control plane and eXecute permissions in the data plane. This means, for example, that now we can only delete the default hit action from the control plane.
--- include/net/p4tc.h | 135 ++- include/net/p4tc_types.h | 2 +- include/uapi/linux/p4tc.h | 122 +++ net/sched/p4tc/Makefile | 2 +- net/sched/p4tc/p4tc_action.c | 4 +- net/sched/p4tc/p4tc_pipeline.c | 23 +- net/sched/p4tc/p4tc_table.c | 1542 ++++++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_tmpl_api.c | 2 + 8 files changed, 1820 insertions(+), 12 deletions(-) create mode 100644 net/sched/p4tc/p4tc_table.c
include/net/p4tc.h +134 -1
@@ -16,10 +16,18 @@#define P4TC_DEFAULT_MAX_RULES 1#define P4TC_PATH_MAX 3#define P4TC_MAX_TENTRIES 0x2000000 +#define P4TC_DEFAULT_TENTRIES 256 +#define P4TC_MAX_TMASKS 1024 +#define P4TC_DEFAULT_TMASKS 8 +#define P4TC_MAX_T_AGING_MS 864000000 +#define P4TC_DEFAULT_T_AGING_MS 30000 + +#define P4TC_MAX_PERMISSION (GENMASK(P4TC_PERM_MAX_BIT, 0))#define P4TC_KERNEL_PIPEID 0#define P4TC_PID_IDX 0 +#define P4TC_TBLID_IDX 1#define P4TC_AID_IDX 1#define P4TC_PARSEID_IDX 1
@@ -70,6 +78,7 @@ extern const struct p4tc_template_ops p4tc_pipeline_ops;struct p4tc_pipeline {struct p4tc_template_common common;struct idr p_act_idr; +struct idr p_tbl_idr;struct rcu_head rcu;struct net *net;u32 num_created_acts;
@@ -123,6 +132,11 @@ struct p4tc_act *p4a_runt_find(struct net *net,void p4a_runt_prealloc_put (struct p4tc_act *act,struct tcf_p4act *p4_act); +static inline bool p4tc_pipeline_sealed (struct p4tc_pipeline *pipeline) +{ +return pipeline->p_state ==P4TC_STATE_READY ; +} +static inline int p4tc_action_destroy (struct tc_action **acts) {struct tc_action *acts_non_prealloc[TCA_ACT_MAX_PRIO ] = {NULL };
@@ -170,6 +184,63 @@ static inline int p4tc_action_destroy(struct tc_action **acts)return ret; } +#define P4TC_CONTROL_PERMISSIONS (GENMASK(13, 7)) +#define P4TC_DATA_PERMISSIONS (GENMASK(6, 0)) + +#define P4TC_TABLE_PERMISSIONS \ + ((GENMASK(P4TC_CTRL_PERM_C_BIT, P4TC_CTRL_PERM_D_BIT)) | \ + P4TC_CTRL_PERM_P | P4TC_CTRL_PERM_S | P4TC_DATA_PERM_R | \ + P4TC_DATA_PERM_X) + +#define P4TC_PERMISSIONS_UNINIT (1 << P4TC_PERM_MAX_BIT) + +struct p4tc_table_defact { +struct tc_action **default_acts; +/* Will have two 7 bits blocks containing CRUDXPS (Create, read, update, +* delete, execute, publish and subscribe) permissions for control plane +* and data plane. The first 5 bits are for control and the next five +* are for data plane. |crudxpscrudxps| if we were to denote it as UNIX +* permission flags. +*/ +__u16 permissions; +struct rcu_head rcu; +}; + +struct p4tc_table_perm { +__u16 permissions; +struct rcu_head rcu; +}; + +struct p4tc_table { +struct p4tc_template_common common; +struct list_head tbl_acts_list; +struct idr tbl_masks_idr; +struct idr tbl_prio_idr; +struct rhltable tbl_entries; +struct p4tc_table_defact __rcu *tbl_default_hitact; +struct p4tc_table_defact __rcu *tbl_default_missact; +struct p4tc_table_perm __rcu *tbl_permissions; +struct p4tc_table_entry_mask __rcu **tbl_masks_array; +unsigned long __rcu *tbl_free_masks_bitmap; +u64 tbl_aging; +/* Locks the available masks IDR which will be used when adding and +* deleting table entries. +*/ +spinlock_t tbl_masks_idr_lock; +u32 tbl_keysz; +u32 tbl_id; +u32 tbl_max_entries; +u32 tbl_max_masks; +u32 tbl_curr_num_masks; +/* Accounts for how many entities refer to this table. Usually just the +* pipeline it belongs to. +*/ +refcount_t tbl_ctrl_ref; +u16 tbl_type; +}; + +extern const struct p4tc_template_ops p4tc_table_ops; +struct p4tc_act_param {struct list_head head;struct rcu_head rcu;
@@ -222,6 +293,12 @@ struct p4tc_act {char fullname[ACTNAMSIZ ]; }; +struct p4tc_table_act { +struct list_head node; +struct tc_action_ops *ops; +u8 flags; +}; +extern const struct p4tc_template_ops p4tc_act_ops; static inline int p4tc_action_init(struct net *net, struct nlattr *nla,
@@ -276,12 +353,68 @@ static inline bool p4tc_action_put_ref(struct p4tc_act *act)return refcount_dec_not_one (&act->a_ref); } +struct p4tc_act_param *p4a_parm_find_byid (struct idr *params_idr, +const u32 param_id); +struct p4tc_act_param * +p4a_parm_find_byany (struct p4tc_act *act,const char *param_name, +const u32 param_id,struct netlink_ext_ack *extack); + +struct p4tc_table *p4tc_table_find_byany (struct p4tc_pipeline *pipeline, +const char *tblname,const u32 tbl_id, +struct netlink_ext_ack *extack); +struct p4tc_table *p4tc_table_find_byid (struct p4tc_pipeline *pipeline, +const u32 tbl_id); +int p4tc_table_try_set_state_ready (struct p4tc_pipeline *pipeline, +struct netlink_ext_ack *extack); +void p4tc_table_put_mask_array (struct p4tc_pipeline *pipeline); +struct p4tc_table *p4tc_table_find_get (struct p4tc_pipeline *pipeline, +const char *tblname,const u32 tbl_id, +struct netlink_ext_ack *extack); + +static inline bool p4tc_table_put_ref (struct p4tc_table *table) +{ +return refcount_dec_not_one (&table->tbl_ctrl_ref); +} + +struct p4tc_table_default_act_params { +struct p4tc_table_defact *default_hitact; +struct p4tc_table_defact *default_missact; +struct nlattr *default_hit_attr; +struct nlattr *default_miss_attr; +}; + +int +p4tc_table_init_default_acts (struct net *net, +struct p4tc_table_default_act_params *def_params, +struct p4tc_table *table, +struct list_head *acts_list, +struct netlink_ext_ack *extack); + +static inline void +p4tc_table_defacts_acts_copy (struct p4tc_table_defact *defact_copy, +struct p4tc_table_defact *defact_orig) +{ + defact_copy->default_acts = defact_orig->default_acts; +} + +void +p4tc_table_replace_default_acts (struct p4tc_table *table, +struct p4tc_table_default_act_params *def_params, +bool lock_rtnl); + +struct p4tc_table_perm * +p4tc_table_init_permissions (struct p4tc_table *table,u16 permissions, +struct netlink_ext_ack *extack); +void p4tc_table_replace_permissions (struct p4tc_table *table, +struct p4tc_table_perm *tbl_perm, +bool lock_rtnl); +struct tcf_p4act *p4a_runt_prealloc_get_next (struct p4tc_act *act);void p4a_runt_init_flags (struct tcf_p4act *p4act);#define to_pipeline (t) ((struct p4tc_pipeline *)t) -#define to_hdrfield (t) ((struct p4tc_hdrfield *)t)#define p4tc_to_act (t) ((struct p4tc_act *)t) +#define p4tc_to_table (t) ((struct p4tc_table *)t)#endif
include/net/p4tc_types.h +1 -1
@@ -8,7 +8,7 @@#include <uapi/linux/p4tc.h> -#define P4TC_T_MAX_BITSZ 128 +#define P4TC_T_MAX_BITSZ P4TC_MAX_KEYSZstruct p4tc_type_mask_shift {void *mask;
include/uapi/linux/p4tc.h +122 -0
140 lines not on this page · raw message
net/sched/p4tc/Makefile +1 -1
@@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o \ - p4tc_action.o + p4tc_action.o p4tc_table.o
net/sched/p4tc/p4tc_action.c +2 -2
@@ -645,13 +645,13 @@ p4a_parm_find_byname(struct idr *params_idr, const char *param_name)return NULL ; } -static struct p4tc_act_param * +struct p4tc_act_param *p4a_parm_find_byid (struct idr *params_idr,const u32 param_id) {return idr_find (params_idr, param_id); } -static struct p4tc_act_param * +struct p4tc_act_param *p4a_parm_find_byany (struct p4tc_act *act,const char *param_name,const u32 param_id,struct netlink_ext_ack *extack) {
net/sched/p4tc/p4tc_pipeline.c +16 -7
@@ -75,6 +75,7 @@ static const struct nla_policy tc_pipeline_policy[P4TC_PIPELINE_MAX + 1] = {static void p4tc_pipeline_destroy (struct p4tc_pipeline *pipeline) {idr_destroy (&pipeline->p_act_idr); +idr_destroy (&pipeline->p_tbl_idr);kfree (pipeline); }
@@ -97,9 +98,13 @@ static void p4tc_pipeline_teardown(struct p4tc_pipeline *pipeline,struct net *net = pipeline->net;struct p4tc_pipeline_net *pipe_net =net_generic (net, pipeline_net_id);struct net *pipeline_net =maybe_get_net (net); -unsigned long iter_act_id; +unsigned long iter_act_id, tmp; +struct p4tc_table *table;struct p4tc_act *act; -unsigned long tmp; +unsigned long tbl_id; + +idr_for_each_entry_ul (&pipeline->p_tbl_idr, table, tmp, tbl_id) + table->common.ops->put (pipeline, &table->common, extack);idr_for_each_entry_ul (&pipeline->p_act_idr, act, tmp, iter_act_id) act->common.ops->put (pipeline, &act->common, extack);
@@ -150,22 +155,23 @@ static int __p4tc_pipeline_put(struct p4tc_pipeline *pipeline,static inline int pipeline_try_set_state_ready (struct p4tc_pipeline *pipeline,struct netlink_ext_ack *extack) { +int ret; +if (pipeline->curr_tables != pipeline->num_tables) {NL_SET_ERR_MSG (extack,"Must have all table defined to update state to ready" );return -EINVAL ; } + ret =p4tc_table_try_set_state_ready (pipeline, extack); +if (ret <0 ) +return ret; + pipeline->p_state =P4TC_STATE_READY ;return true; } -static inline bool p4tc_pipeline_sealed (struct p4tc_pipeline *pipeline) -{ -return pipeline->p_state ==P4TC_STATE_READY ; -} -struct p4tc_pipeline *p4tc_pipeline_find_byid (struct net *net,const u32 pipeid) {struct p4tc_pipeline_net *pipe_net;
@@ -257,6 +263,9 @@ static struct p4tc_pipeline *p4tc_pipeline_create(struct net *net,idr_init (&pipeline->p_act_idr); +idr_init (&pipeline->p_tbl_idr); + pipeline->curr_tables =0 ; + pipeline->num_created_acts =0 ; pipeline->p_state =P4TC_STATE_NOT_READY ;
net/sched/p4tc/p4tc_table.c new file +1542 -0
1,542 lines not on this page · raw message
net/sched/p4tc/p4tc_tmpl_api.c +2 -0
@@ -43,6 +43,7 @@ static bool obj_is_valid(u32 obj)switch (obj) {case P4TC_OBJ_PIPELINE :case P4TC_OBJ_ACT : +case P4TC_OBJ_TABLE :return true;default :return false;
@@ -52,6 +53,7 @@ static bool obj_is_valid(u32 obj)static const struct p4tc_template_ops *p4tc_ops[P4TC_OBJ_MAX +1 ] = { [P4TC_OBJ_PIPELINE ] = &p4tc_pipeline_ops, [P4TC_OBJ_ACT ] = &p4tc_act_ops, + [P4TC_OBJ_TABLE ] = &p4tc_table_ops, }; int p4tc_tmpl_generic_dump(struct sk_buff *skb, struct p4tc_dump_ctx *ctx,
Signature · 1 line
2.34.1
Jamal Hadi Salim
maintainerPATCH v9 13/15 p4tc: add runtime table entry create, update, get, delete, flush and dump
In reply to Jamal Hadi SalimTables are conceptually similar to TCAMs and this implementation could be labelled as an "algorithmic" TCAM. Tables have a key of a specific size, maximum number of entries and masks allowed. The basic P4 key types are supported (exact, LPM, ternary, and ranges) although the kernel side is oblivious of all that and sees only bit blobs which it masks before a lookup is performed.
This commit allows users to create, update, delete, get, flush and dump table _entries_ (templates were described in earlier patch).
Note that table entries can only be created once the pipeline template is sealed.
For example, a user issuing the following command:
tc p4ctrl create myprog/table/cb/tname \
dstAddr 10.10.10.0/24 srcAddr 192.168.0.0/16 prio 16 \
action send param port port1
indicates we are creating a table entry in table "cb/tname" (a table residing in control block "cb") on a pipeline named "myprog".
User space tc will create a key which has a value of 0x0a0a0a00c0a00000 (10.10.10.0 concatenated with 192.168.0.0) and a mask value of 0xffffff00ffff0000 (/24 concatenated with /16) that will be sent to the kernel. In addition a priority field of 16 is passed to the kernel as well as the action definition.
The priority field is needed to disambiguate in case two entries match. In that case, the kernel will choose the one with lowest priority number.
If the user wanted to, for example, update our just created entry with an action, they'd issue the following command:
tc p4ctrl update myprog/table/cb/tname srcAddr 10.10.10.0/24 \
dstAddr 192.168.0.0/16 prio 16 action send param port port5
In this case, the user needs to specify the pipeline name, the table name, the key and the priority, so that we can locate the table entry.
If the user wanted to, for example, get the table entry that we just updated, they'd issue the following command:
tc p4ctrl get myprog/table/cb/tname srcAddr 10.10.10.0/24 \
dstAddr 192.168.0.0/16 prio 16
Note that, again, we need to specify the pipeline name, the table name, the key and the priority, so that we can locate the table entry.
If the user wanted to delete the table entry we created, they'd issue the following command:
tc p4ctrl del myprog/table/cb/tname srcAddr 10.10.10.0/24 \
dstAddr 192.168.0.0/16 prio 16
Note that, again, we need to specify the pipeline name, the table name, the key and the priority, so that we can
locate the table entry.
We can also flush all the table entries from a specific table. To flush the table entries of table tname ane pipeline ptables, the user would issue the following command:
tc p4ctrl del myprog/table/cb/tname
We can also dump all the table entries from a specific table. To dump the table entries of table tname and pipeline myprog, the user would issue the following command:
tc p4ctrl get myprog/table/cb/tname
__Table Entry Permissions__
Table entries can have permissions specified when they are being added.
Caveat: we are doing a lot more than what P4 defines because we feel it is necessary.
It should be noted that there are two types of permissions:
- Table permissions which are a property of the table (think directory in file systems). These are set by the template (see earlier patch on table template).
- Table entry permissions which are specific to a table entry (think a file in a directory). This patch describes those permissions.
Furthermore in both cases the permissions are split into datapath vs control path. The template definition can set either one. For example, one could allow for adding table entries by the datapath in case of PNA add-on-miss is needed.
By default tables entries have control plane RUD, meaning the control plane can Read, Update or Delete entries. By default, as well, the control plane can create new entries unless specified otherwise by the template.
Lets see an example of which creates the table "cb/tname" at template time:
tc p4template create table/aP4proggie/cb/tname tblid 1 keysz 64 \
permissions 0x3C24 ...Above is setting the table tname's permission to be 0x3C24 is equivalent to CRUD----R--X-- meaning:
The control plane can Create, Read, Update, Delete The datapath can only Read and Execute table entries. If one was to dump this table with:
tc -j p4template get table/aP4proggie/cb/tname | jq .
The output would be the following:
[
{
"obj": "table",
"pname": "aP4proggie",
"pipeid": 22
},
{
"templates": [
{
"tblid": 1,
"tname": "cb/tname",
"keysz": 64,
"max_entries": 256,
"masks": 8,
"entries": 0,
"permissions": "CRUD----R--X--",
"table_type": "exact",
"acts_list": []
}
] }
]
The expressed permissions above are probably the most practical for most use cases.
__Constant Tables And P4-programmed Defined Entries__
If one wanted to restrict the table to be an equivalent to a "const" then the permissions would be set to be: -R------R--X--
In such a case, typically the P4 program will have some entries defined (see the famous P4 calculate example). The "initial entries" specified in the P4 program will have to be added by the template (as generated by the compiler), as such:
tc p4template update table/aP4proggie/cb/tname \
entry srcAddr 10.10.10.10/24 dstAddr 1.1.1.0/24 prio 17
This table cannot be updated at runtime. Any attempt to add an entry of a table which is read-only at runtime will get a permission denied response back from the kernel.
Note: If one was to create an equivalent for PNA add-on-miss feature for this table, then the template would issue table permissions as:
-R-----CR--X-- PNA doesn't specify whether the datapath can also delete or update entries, but if it did then more appropriate permissions will be:
-R-----CRUDX--
__Mix And Match of RW vs Constant Entries__
Lets look at other scenarios; lets say the table has CRUD----R--X-- permissions as defined by the template...
At runtime the user could add entries which are "const" - by specifying the entry's permission as -R------R--X-- example:
tc p4ctrl create aP4proggie/table/cb/tname srcAddr 10.10.10.10/24 \
dstAddr 1.1.1.0/24 prio 17 permissions 0x1024 action drop
or not specify permissions at all as such:
tc p4ctrl create aP4proggie/table/cb/tname srcAddr 10.10.10.10/24 \
dstAddr 1.1.1.0/24 prio 17 action drop
in which case the table's permissions defined at template time(CRUD----R--X--) are assumed; meaning the table entry can be deleted or updated by the control plane.
__Entries permissions Allowed On A Table Entry Creation At Runtime__
When an entry is added with expressed permissions it has at most to have what the template table definition expressed but could ask for less permission. For example, assuming a table with templated specified permissions of CR-D----R--X--:
An entry created at runtime with permission of -R------R--X-- is allowed but an entry with -RUD----R--X-- will be rejected.
--- include/net/p4tc.h | 124 +- include/uapi/linux/p4tc.h | 68 +- include/uapi/linux/rtnetlink.h | 9 + net/sched/p4tc/Makefile | 3 +- net/sched/p4tc/p4tc_runtime_api.c | 145 ++ net/sched/p4tc/p4tc_table.c | 54 +- net/sched/p4tc/p4tc_tbl_entry.c | 2572 +++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_tmpl_api.c | 4 +- security/selinux/nlmsgtab.c | 6 +- 9 files changed, 2968 insertions(+), 17 deletions(-) create mode 100644 net/sched/p4tc/p4tc_runtime_api.c create mode 100644 net/sched/p4tc/p4tc_tbl_entry.c
include/net/p4tc.h +122 -2
@@ -120,6 +120,11 @@ static inline bool p4tc_pipeline_get(struct p4tc_pipeline *pipeline)return refcount_inc_not_zero (&pipeline->p_ctrl_ref); } +static inline void p4tc_pipeline_put_ref (struct p4tc_pipeline *pipeline) +{ +refcount_dec (&pipeline->p_ctrl_ref); +} +void p4tc_pipeline_put (struct p4tc_pipeline *pipeline);struct p4tc_pipeline * p4tc_pipeline_find_byany_unsealed(struct net *net, const char *p_name,
@@ -194,6 +199,8 @@ static inline int p4tc_action_destroy(struct tc_action **acts)#define P4TC_PERMISSIONS_UNINIT (1 << P4TC_PERM_MAX_BIT) +#define P4TC_MAX_PARAM_DATA_SIZE 124 +struct p4tc_table_defact {struct tc_action **default_acts;/* Will have two 7 bits blocks containing CRUDXPS (Create, read, update,
@@ -215,8 +222,9 @@ struct p4tc_table {struct p4tc_template_common common;struct list_head tbl_acts_list;struct idr tbl_masks_idr; -struct idr tbl_prio_idr; +struct ida tbl_prio_idr;struct rhltable tbl_entries; +struct p4tc_table_entry *tbl_const_entry;struct p4tc_table_defact __rcu *tbl_default_hitact;struct p4tc_table_defact __rcu *tbl_default_missact;struct p4tc_table_perm __rcu *tbl_permissions;
@@ -232,11 +240,14 @@ struct p4tc_table {u32 tbl_max_entries;u32 tbl_max_masks;u32 tbl_curr_num_masks; +/* Accounts for how many entries this table has */ +atomic_t tbl_nelems;/* Accounts for how many entities refer to this table. Usually just the * pipeline it belongs to. */ refcount_t tbl_ctrl_ref;u16 tbl_type; +u16 PAD0 ; };extern const struct p4tc_template_ops p4tc_table_ops;
@@ -301,6 +312,86 @@ struct p4tc_table_act {extern const struct p4tc_template_ops p4tc_act_ops; +extern const struct rhashtable_params entry_hlt_params; + +struct p4tc_table_entry ; +struct p4tc_table_entry_work { +struct work_struct work; +struct p4tc_pipeline *pipeline; +struct p4tc_table_entry *entry; +struct p4tc_table *table; +u16 who_deleted; +bool send_event; +}; + +struct p4tc_table_entry_key { +u32 keysz; +/* Key start */ +u32 maskid; +unsigned char fa_key[]__aligned(8) ; +}; + +struct p4tc_table_entry_value { +u32 prio; +int num_acts; +struct tc_action **acts; +/* Accounts for how many entities are referencing, eg: Data path, +* one or more control path and timer. +*/ +refcount_t entries_ref; +u32 permissions; +struct p4tc_table_entry_tm __rcu *tm; +struct p4tc_table_entry_work *entry_work; +u64 aging_ms; +struct hrtimer entry_timer; +bool is_dyn; +}; + +struct p4tc_table_entry_mask { +struct rcu_head rcu; +u32 sz; +u32 mask_index; +/* Accounts for how many entries are using this mask */ +refcount_t mask_ref; +u32 mask_id; +unsigned char fa_value[]__aligned(8) ; +}; + +struct p4tc_table_entry { +struct rcu_head rcu; +struct rhlist_head ht_node; +struct p4tc_table_entry_key key; +/* fallthrough: key data + value */ +}; + +#define P4TC_KEYSZ_BYTES (bits) (round_up(BITS_TO_BYTES(bits), 8)) + +#define P4TC_ENTRY_KEY_OFFSET (offsetof(struct p4tc_table_entry_key, fa_key)) + +#define P4TC_ENTRY_VALUE_OFFSET (entry) \ + (offsetof(struct p4tc_table_entry, key) + P4TC_ENTRY_KEY_OFFSET \ + + P4TC_KEYSZ_BYTES((entry)->key.keysz)) + +static inline void *p4tc_table_entry_value (struct p4tc_table_entry *entry) +{ +return entry->key.fa_key +P4TC_KEYSZ_BYTES (entry->key.keysz); +} + +static inline struct p4tc_table_entry_work * +p4tc_table_entry_work (struct p4tc_table_entry *entry) +{ +struct p4tc_table_entry_value *value =p4tc_table_entry_value (entry); + +return value->entry_work; +} + +extern const struct nla_policy p4tc_root_policy[P4TC_ROOT_MAX +1 ]; +extern const struct nla_policy p4tc_policy[P4TC_MAX +1 ]; + +struct p4tc_table_entry * +p4tc_table_entry_lookup_direct (struct p4tc_table *table, +struct p4tc_table_entry_key *key); +static inline int p4tc_action_init (struct net *net,struct nlattr *nla,struct tc_action *acts[],u32 pipeid,u32 flags,struct netlink_ext_ack *extack)
@@ -390,6 +481,14 @@ p4tc_table_init_default_acts(struct net *net,struct list_head *acts_list, struct netlink_ext_ack *extack); +static inline void p4tc_table_defact_destroy (struct p4tc_table_defact *defact) +{ +if (defact) { +p4tc_action_destroy (defact->default_acts); +kfree (defact); + } +} +static inline void p4tc_table_defacts_acts_copy (struct p4tc_table_defact *defact_copy,struct p4tc_table_defact *defact_orig)
@@ -404,15 +503,36 @@ p4tc_table_replace_default_acts(struct p4tc_table *table,struct p4tc_table_perm *p4tc_table_init_permissions (struct p4tc_table *table,u16 permissions, -struct netlink_ext_ack *extack); +struct netlink_ext_ack *extack);void p4tc_table_replace_permissions (struct p4tc_table *table,struct p4tc_table_perm *tbl_perm,bool lock_rtnl); +void p4tc_table_entry_destroy_hash (void *ptr,void *arg); + +struct p4tc_table_entry * +p4tc_table_const_entry_cu (struct net *net,struct nlattr *arg, +struct p4tc_pipeline *pipeline, +struct p4tc_table *table, +struct netlink_ext_ack *extack); +int p4tc_tbl_entry_crud (struct net *net,struct sk_buff *skb, +struct nlmsghdr *n,int cmd, +struct netlink_ext_ack *extack); +int p4tc_tbl_entry_dumpit (struct net *net,struct sk_buff *skb, +struct netlink_callback *cb, +struct nlattr *arg,char *p_name); +int p4tc_tbl_entry_fill (struct sk_buff *skb,struct p4tc_table *table, +struct p4tc_table_entry *entry,u32 tbl_id, +u16 who_deleted);struct tcf_p4act *p4a_runt_prealloc_get_next (struct p4tc_act *act);void p4a_runt_init_flags (struct tcf_p4act *p4act); +static inline bool p4tc_runtime_msg_is_update (struct nlmsghdr *n) +{ +return n->nlmsg_type ==RTM_P4TC_UPDATE ; +} +#define to_pipeline (t) ((struct p4tc_pipeline *)t)#define p4tc_to_act (t) ((struct p4tc_act *)t)#define p4tc_to_table (t) ((struct p4tc_table *)t)
include/uapi/linux/p4tc.h +67 -1
98 lines not on this page · raw message
include/uapi/linux/rtnetlink.h +9 -0
@@ -203,6 +203,15 @@ enum { RTM_UPDATEP4TEMPLATE,#define RTM_UPDATEP4TEMPLATE RTM_UPDATEP4TEMPLATE + RTM_P4TC_CREATE = 128, +#define RTM_P4TC_CREATE RTM_P4TC_CREATE + RTM_P4TC_DEL, +#define RTM_P4TC_DEL RTM_P4TC_DEL + RTM_P4TC_GET, +#define RTM_P4TC_GET RTM_P4TC_GET + RTM_P4TC_UPDATE, +#define RTM_P4TC_UPDATE RTM_P4TC_UPDATE + __RTM_MAX,#define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1) };
net/sched/p4tc/Makefile +2 -1
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o \ - p4tc_action.o p4tc_table.o + p4tc_action.o p4tc_table.o p4tc_tbl_entry.o \ + p4tc_runtime_api.o
net/sched/p4tc/p4tc_runtime_api.c new file +145 -0
145 lines not on this page · raw message
net/sched/p4tc/p4tc_table.c +44 -10
102 lines not on this page · raw message
net/sched/p4tc/p4tc_tbl_entry.c new file +2572 -0
2,454 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.34.1
Part of the diff is not shown here. View the raw message.
Re: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump
Hi Jamal,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Jamal-Hadi-Salim/net-sched-act_api-increase-action-kind-string-length/20231202-032940 base: net-next/main patch link: https://lore.kernel.org/r/20231201182904.532825-14-jhs%40mojatatu.com patch subject: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump config: powerpc64-randconfig-r081-20231204 (https://download.01.org/0day-ci/archive/20231205/[email protected]/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231205/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:net/sched/p4tc/p4tc_tbl_entry.c:2555 p4tc_tbl_entry_dumpit() warn: can 'nl_path_attrs.pname' even be NULL?
vim +2555 net/sched/p4tc/p4tc_tbl_entry.c
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2529 pnatt = nla_reserve(skb, P4TC_ROOT_PNAME, P4TC_PIPELINE_NAMSIZ); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2530 if (!pnatt) 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2531 return -ENOMEM; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2532 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2533 ids[P4TC_PID_IDX] = t_new->pipeid; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2534 arg_ids = nla_data(tb[P4TC_PATH]); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2535 memcpy(&ids[P4TC_TBLID_IDX], arg_ids, nla_len(tb[P4TC_PATH])); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2536 nl_path_attrs.ids = ids; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2537 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2538 nl_path_attrs.pname = nla_data(pnatt);
nla_data() can't be NULL
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2539 if (!p_name) {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2540 /* Filled up by the operation or forced failure */
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2541 memset(nl_path_attrs.pname, 0, P4TC_PIPELINE_NAMSIZ);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2542 nl_path_attrs.pname_passed = false;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2543 } else {
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2544 strscpy(nl_path_attrs.pname, p_name, P4TC_PIPELINE_NAMSIZ);And we dereference it
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2545 nl_path_attrs.pname_passed = true;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2546 }
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2547
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2548 root = nla_nest_start(skb, P4TC_ROOT);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2549 ret = p4tc_table_entry_dump(net, skb, tb[P4TC_PARAMS], &nl_path_attrs,
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2550 cb, extack);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2551 if (ret <= 0)
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2552 goto out;
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2553 nla_nest_end(skb, root);
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2554
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 @2555 if (nl_path_attrs.pname) {
^^^^^^^^^^^^^^^^^^^This NULL check can be removed.
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Jamal Hadi Salim
maintainerRe: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump
Hi Dan,
Quoted 13 lines · Dan Carpenter
Hi Jamal,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Jamal-Hadi-Salim/net-sched-act_api-increase-action-kind-string-length/20231202-032940 base: net-next/main patch link: https://lore.kernel.org/r/20231201182904.532825-14-jhs%40mojatatu.com patch subject: [PATCH net-next v9 13/15] p4tc: add runtime table entry create, update, get, delete, flush and dump config: powerpc64-randconfig-r081-20231204 (https://download.01.org/0day-ci/archive/20231205/[email protected]/config) compiler: powerpc64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231205/[email protected]/reproduce)
Quoted 5 lines
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
Thanks - Will do (it will be a new version not separate fix commit).
Quoted 2 lines
smatch warnings:
net/sched/p4tc/p4tc_tbl_entry.c:2555p4tc_tbl_entry_dumpit()warn: can 'nl_path_attrs.pname' even be NULL?
We need to update our smatch i suppose because we didnt catch this one.
cheers,
jamal
Quoted 43 lines
vim +2555
net/sched/p4tc/p4tc_tbl_entry.c0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2529 pnatt = nla_reserve(skb, P4TC_ROOT_PNAME, P4TC_PIPELINE_NAMSIZ); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2530 if (!pnatt) 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2531 return -ENOMEM; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2532 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2533 ids[P4TC_PID_IDX] = t_new->pipeid; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2534 arg_ids = nla_data(tb[P4TC_PATH]); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2535 memcpy(&ids[P4TC_TBLID_IDX], arg_ids, nla_len(tb[P4TC_PATH])); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2536 nl_path_attrs.ids = ids; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2537 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2538 nl_path_attrs.pname = nla_data(pnatt);
nla_data()can't be NULL0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2539 if (!p_name) { 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2540 /* Filled up by the operation or forced failure */ 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2541 memset(nl_path_attrs.pname, 0, P4TC_PIPELINE_NAMSIZ); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2542 nl_path_attrs.pname_passed = false; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2543 } else { 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2544 strscpy(nl_path_attrs.pname, p_name, P4TC_PIPELINE_NAMSIZ);And we dereference it
0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2545 nl_path_attrs.pname_passed = true; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2546 } 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2547 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2548 root = nla_nest_start(skb, P4TC_ROOT); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2549 ret = p4tc_table_entry_dump(net, skb, tb[P4TC_PARAMS], &nl_path_attrs, 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2550 cb, extack); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2551 if (ret <= 0) 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2552 goto out; 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2553 nla_nest_end(skb, root); 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 2554 0d5bbed1381e54 Jamal Hadi Salim 2023-12-01 @2555 if (nl_path_attrs.pname) { ^^^^^^^^^^^^^^^^^^^This NULL check can be removed.
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Jamal Hadi Salim
maintainerPATCH v9 14/15 p4tc: add set of P4TC table kfuncs
In reply to Jamal Hadi SalimWe add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
- bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.
- xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in an xdp_md, the pipeline ID, the table ID, a key and a key size.
We use struct xdp_md to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.
- bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure
- xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take an xdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure
- bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure
- xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure
- bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure
- xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take an xdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure
- bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure
- xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take an xdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure
--- include/linux/bitops.h | 1 + include/net/p4tc.h | 60 +++++- include/net/tc_act/p4tc.h | 24 +++ include/uapi/linux/p4tc.h | 2 + net/sched/p4tc/Makefile | 1 + net/sched/p4tc/p4tc_action.c | 70 ++++++- net/sched/p4tc/p4tc_bpf.c | 338 ++++++++++++++++++++++++++++++++ net/sched/p4tc/p4tc_pipeline.c | 47 ++++- net/sched/p4tc/p4tc_table.c | 8 + net/sched/p4tc/p4tc_tbl_entry.c | 301 +++++++++++++++++++++++++++- net/sched/p4tc/p4tc_tmpl_api.c | 4 + 11 files changed, 843 insertions(+), 13 deletions(-) create mode 100644 net/sched/p4tc/p4tc_bpf.c
include/linux/bitops.h +1 -0
@@ -19,6 +19,7 @@#define BITS_TO_LONGS (nr) __KERNEL_DIV_ROUND_UP(nr, BITS_PER_TYPE(long))#define BITS_TO_U64 (nr) __KERNEL_DIV_ROUND_UP(nr, BITS_PER_TYPE(u64))#define BITS_TO_U32 (nr) __KERNEL_DIV_ROUND_UP(nr, BITS_PER_TYPE(u32)) +#define BITS_TO_U16 (nr) __KERNEL_DIV_ROUND_UP(nr, BITS_PER_TYPE(u16))#define BITS_TO_BYTES (nr) __KERNEL_DIV_ROUND_UP(nr, BITS_PER_TYPE(char))extern unsigned int __sw_hweight8 (unsigned int w);
include/net/p4tc.h +59 -1
91 lines not on this page · raw message
include/net/tc_act/p4tc.h +24 -0
@@ -14,10 +14,23 @@ struct tcf_p4act_params {u32 tot_params_sz; }; +#define P4TC_MAX_PARAM_DATA_SIZE 124 + +struct p4tc_table_entry_act_bpf { +u32 act_id; +u8 params[P4TC_MAX_PARAM_DATA_SIZE ]; +} __packed; + +struct p4tc_table_entry_act_bpf_kern { +struct rcu_head rcu; +struct p4tc_table_entry_act_bpf act_bpf; +}; +struct tcf_p4act {struct tc_action common;/* Params IDR reference passed during runtime */ struct tcf_p4act_params __rcu *params; +struct p4tc_table_entry_act_bpf_kern __rcu *act_bpf;u32 p_id;u32 act_id;struct list_head node;
@@ -25,4 +38,15 @@ struct tcf_p4act {#define to_p4act (a) ((struct tcf_p4act *)a) +static inline struct p4tc_table_entry_act_bpf * +p4tc_table_entry_act_bpf (struct tc_action *action) +{ +struct p4tc_table_entry_act_bpf_kern *act_bpf; +struct tcf_p4act *p4act =to_p4act (action); + + act_bpf =rcu_dereference (p4act->act_bpf); + +return &act_bpf->act_bpf; +} +#endif /* __NET_TC_ACT_P4_H */
include/uapi/linux/p4tc.h +2 -0
@@ -19,6 +19,8 @@ struct p4tcmsg {#define P4TC_MINTABLES_COUNT 0#define P4TC_MSGBATCH_SIZE 16 +#define P4TC_ACT_MAX_NUM_PARAMS P4TC_MSGBATCH_SIZE +#define P4TC_MAX_KEYSZ 512#define P4TC_DEFAULT_NUM_PREALLOC 16
net/sched/p4tc/Makefile +1 -0
@@ -3,3 +3,4 @@ obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o \ p4tc_action.o p4tc_table.o p4tc_tbl_entry.o \ p4tc_runtime_api.o +obj-$(CONFIG_DEBUG_INFO_BTF) += p4tc_bpf.o
net/sched/p4tc/p4tc_action.c +69 -1
132 lines not on this page · raw message
net/sched/p4tc/p4tc_bpf.c new file +338 -0
338 lines not on this page · raw message
net/sched/p4tc/p4tc_pipeline.c +45 -2
65 lines not on this page · raw message
net/sched/p4tc/p4tc_table.c +8 -0
@@ -380,6 +380,7 @@ static int _p4tc_table_put(struct net *net, struct nlattr **tb,rhltable_free_and_destroy (&table->tbl_entries, p4tc_table_entry_destroy_hash, table); +p4tc_tbl_cache_remove (net, table);idr_destroy (&table->tbl_masks_idr);ida_destroy (&table->tbl_prio_idr);
@@ -1143,6 +1144,10 @@ static struct p4tc_table *p4tc_table_create(struct net *net, struct nlattr **tb, goto defaultacts_destroy; } + ret =p4tc_tbl_cache_insert (net, pipeline->common.p_id, table); +if (ret <0 ) + goto entries_hashtable_destroy; + pipeline->curr_tables +=1 ; table->common.ops = (struct p4tc_template_ops *)&p4tc_table_ops;
@@ -1150,6 +1155,9 @@ static struct p4tc_table *p4tc_table_create(struct net *net, struct nlattr **tb,return table; +entries_hashtable_destroy: +rhltable_destroy (&table->tbl_entries); + defaultacts_destroy:p4tc_table_defact_destroy (def_params.default_hitact);p4tc_table_defact_destroy (def_params.default_missact);
net/sched/p4tc/p4tc_tbl_entry.c +292 -9
355 lines not on this page · raw message
net/sched/p4tc/p4tc_tmpl_api.c +4 -0
@@ -599,6 +599,10 @@ static int __init p4tc_template_init(void) op->init (); } +#if IS_ENABLED (CONFIG_DEBUG_INFO_BTF ) +register_p4tc_tbl_bpf (); +#endif +return 0 ; }
Signature · 1 line
2.34.1
Martin KaFai Lau
reviewerRe: [PATCH net-next v9 14/15] p4tc: add set of P4TC table kfuncs
Quoted 62 lines · Jamal Hadi Salim
We add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
-
bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in anxdp_md, the pipeline ID, the table ID, a key and a key size.
We use structxdp_mdto get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take anxdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure
[ ... ]
net/sched/p4tc/p4tc_bpf.c line 306
Quoted 7 lines
net/sched/p4tc/p4tc_bpf.c new file +7
-0+BTF_SET8_START (p4tc_kfunc_check_tbl_set_skb) +BTF_ID_FLAGS (func, bpf_p4tc_tbl_read, KF_RET_NULL); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create_on_miss); +BTF_ID_FLAGS (func, bpf_p4tc_entry_update); +BTF_ID_FLAGS (func, bpf_p4tc_entry_delete); +BTF_SET8_END (p4tc_kfunc_check_tbl_set_skb)
These create/read/update/delete kfuncs are like defining a new hidden bpf map type in the kernel. bpf prog can now create its own link-list and rbtree. sched_ext has already been using it. This is the way the bpf prog should use instead of creating a new map type.
Re: [PATCH net-next v9 14/15] p4tc: add set of P4TC table kfuncs
Quoted 66 lines · Martin KaFai Lau
Quoted 62 lines · Jamal Hadi Salim
We add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
-
bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in anxdp_md, the pipeline ID, the table ID, a key and a key size.
We use structxdp_mdto get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take anxdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure[ ... ]
Quoted 12 lines
net/sched/p4tc/p4tc_bpf.c line 306
Quoted 7 lines
net/sched/p4tc/p4tc_bpf.c new file +7
-0+BTF_SET8_START (p4tc_kfunc_check_tbl_set_skb) +BTF_ID_FLAGS (func, bpf_p4tc_tbl_read, KF_RET_NULL); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create_on_miss); +BTF_ID_FLAGS (func, bpf_p4tc_entry_update); +BTF_ID_FLAGS (func, bpf_p4tc_entry_delete); +BTF_SET8_END (p4tc_kfunc_check_tbl_set_skb)These create/read/update/delete kfuncs are like defining a new hidden bpf map type in the kernel. bpf prog can now create its own link-list and rbtree.
sched_exthas already been using it. This is the way the bpf prog should use instead of creating a new map type.
I don't really think this is an accurate assessment, given Jamal's use case. These kfuncs are more akin to the FIB lookup helper, or the netfilter kfuncs: they provide lookup into a kernel-internal data structure, so that BPF can access that data structure while staying in sync with the rest of the kernel.
If this was a BPF-only implementation you'd be right, but given the constraint of having the P4 objects represented in the kernel[0], I think this is a perfectly reasonable use of kfuncs, even though they happen to look like the map API.
-Toke
[0] Whether having those objects represented at all is reasonable is a separate discussion, which I believe John et al are having with Jamal in a separate subthread. I don't personally have any strong objections to doing that.
Martin KaFai Lau
reviewerRe: [PATCH net-next v9 14/15] p4tc: add set of P4TC table kfuncs
Quoted 92 lines · Toke Høiland-Jørgensen
Quoted 66 lines · Martin KaFai Lau
Quoted 62 lines · Jamal Hadi Salim
We add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
-
bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in anxdp_md, the pipeline ID, the table ID, a key and a key size.
We use structxdp_mdto get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take anxdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure[ ... ]
Quoted 12 lines
net/sched/p4tc/p4tc_bpf.c line 306
Quoted 7 lines
net/sched/p4tc/p4tc_bpf.c new file +7
-0+BTF_SET8_START (p4tc_kfunc_check_tbl_set_skb) +BTF_ID_FLAGS (func, bpf_p4tc_tbl_read, KF_RET_NULL); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create_on_miss); +BTF_ID_FLAGS (func, bpf_p4tc_entry_update); +BTF_ID_FLAGS (func, bpf_p4tc_entry_delete); +BTF_SET8_END (p4tc_kfunc_check_tbl_set_skb)These create/read/update/delete kfuncs are like defining a new hidden bpf map type in the kernel. bpf prog can now create its own link-list and rbtree.
sched_exthas already been using it. This is the way the bpf prog should use instead of creating a new map type.I don't really think this is an accurate assessment, given Jamal's use case. These kfuncs are more akin to the FIB lookup helper, or the netfilter kfuncs: they provide lookup into a kernel-internal data structure, so that BPF can access that data structure while staying in sync with the rest of the kernel.
If this was a BPF-only implementation you'd be right, but given the constraint of having the P4 objects represented in the kernel[0], I think this is a perfectly reasonable use of kfuncs, even though they happen to look like the map API.
Quoted 6 lines
-Toke
[0] Whether having those objects represented at all is reasonable is a separate discussion, which I believe John et al are having with Jamal in a separate subthread. I don't personally have any strong objections to doing that.
I might not be clear. It was my question on why it has to be in the kernel instead of in the bpf map, so the earlier bpf link-list and rbtree example just in case this recent bpf capability has not been considered.
If it is an existing kernel infra-structure, kfunc is a reasonable use.
The P4 objects are newly added to this set with bpf program as its user. It can be represented in the bpf map as well instead of in the kernel.
or is it fair to say that bpf prog is not the primary consumer of the P4 objects. Instead kernel is the primary user of the p4 objects such that p4tc can work independently without the bpf piece to begin with and bpf could be considered as an extension later?
Re: [PATCH net-next v9 14/15] p4tc: add set of P4TC table kfuncs
Quoted 95 lines · Martin KaFai Lau
Quoted 94 lines · Toke Høiland-Jørgensen
Quoted 66 lines · Martin KaFai Lau
Quoted 62 lines · Jamal Hadi Salim
We add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
-
bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in anxdp_md, the pipeline ID, the table ID, a key and a key size.
We use structxdp_mdto get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take anxdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure[ ... ]
Quoted 12 lines
net/sched/p4tc/p4tc_bpf.c line 306
Quoted 7 lines
net/sched/p4tc/p4tc_bpf.c new file +7
-0+BTF_SET8_START (p4tc_kfunc_check_tbl_set_skb) +BTF_ID_FLAGS (func, bpf_p4tc_tbl_read, KF_RET_NULL); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create_on_miss); +BTF_ID_FLAGS (func, bpf_p4tc_entry_update); +BTF_ID_FLAGS (func, bpf_p4tc_entry_delete); +BTF_SET8_END (p4tc_kfunc_check_tbl_set_skb)These create/read/update/delete kfuncs are like defining a new hidden bpf map type in the kernel. bpf prog can now create its own link-list and rbtree.
sched_exthas already been using it. This is the way the bpf prog should use instead of creating a new map type.I don't really think this is an accurate assessment, given Jamal's use case. These kfuncs are more akin to the FIB lookup helper, or the netfilter kfuncs: they provide lookup into a kernel-internal data structure, so that BPF can access that data structure while staying in sync with the rest of the kernel.
If this was a BPF-only implementation you'd be right, but given the constraint of having the P4 objects represented in the kernel[0], I think this is a perfectly reasonable use of kfuncs, even though they happen to look like the map API.
-Toke
Quoted 8 lines
Quoted 4 lines
[0] Whether having those objects represented at all is reasonable is a separate discussion, which I believe John et al are having with Jamal in a separate subthread. I don't personally have any strong objections to doing that.
I might not be clear. It was my question on why it has to be in the kernel instead of in the bpf map, so the earlier bpf link-list and rbtree example just in case this recent bpf capability has not been considered.
A bit tangential, but it came to mind while thinking about this: how would one go about updating a bpf rbtree-based data structure from userspace? Is there a way to get bpf_map_update()-semantics that inserts things into the rbtree somehow?
Quoted 9 lines
If it is an existing kernel infra-structure, kfunc is a reasonable use.
The P4 objects are newly added to this set with bpf program as its user. It can be represented in the bpf map as well instead of in the kernel.
or is it fair to say that bpf prog is not the primary consumer of the P4 objects. Instead kernel is the primary user of the p4 objects such that p4tc can work independently without the bpf piece to begin with and bpf could be considered as an extension later?
That's a good question, actually. I think that conceptually, if viewed purely as a control plane, it could be merged separately and the BPF support added later. But with this series, that would make it a control plane that doesn't really control anything; so there would need to be a second consumer (hardware offload?) added for that to make sense, I suppose.
Or to put it another way, the way this series is designed, there is an implicit "these are kernel objects that we want to use for other things" assumption in there; it's just that those "other things" are not part of this series (because hardware offload doesn't exist yet - I think? I'll let Jamal answer that). I can see the point of asking for that second user, though, as that would make it clear why the control plane needs to be in the kernel.
-Toke
Jamal Hadi Salim
maintainerRe: [PATCH net-next v9 14/15] p4tc: add set of P4TC table kfuncs
Quoted 129 lines · Toke Høiland-Jørgensen
Quoted 95 lines · Martin KaFai Lau
Quoted 94 lines · Toke Høiland-Jørgensen
Quoted 66 lines · Martin KaFai Lau
Quoted 62 lines · Jamal Hadi Salim
We add an initial set of kfuncs to allow interactions from eBPF programs to the P4TC domain.
-
bpf_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in TC. To find the table entry we take in an skb, the pipeline ID, the table ID, a key and a key size.
We use the skb to get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
xdp_p4tc_tbl_read: Used to lookup a table entry from a BPF program installed in XDP. To find the table entry we take in anxdp_md, the pipeline ID, the table ID, a key and a key size.
We use structxdp_mdto get the network namespace structure where all the pipelines are stored. After that we use the pipeline ID and the table ID, to find the table. We then use the key to search for the entry. We return an entry on success and NULL on failure.-
bpf_p4tc_entry_create: Used to create a table entry from a BPF program installed in TC. To create the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create: Used to create a table entry from a BPF program installed in XDP. To create the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_create_on_miss: conforms to PNA "add on miss". First does a lookup using the passed key and upon a miss will add the entry to the table.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_update: Used to update a table entry from a BPF program installed in TC. To update the table entry we take an skb, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_update: Used to update a table entry from a BPF program installed in XDP. To update the table entry we take anxdp_md, the pipeline ID, the table ID, a key and its size, and an action which will be associated with the new entry.
We return 0 on success and a negative errno on failure-
bpf_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in TC. To delete the table entry we take an skb, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure-
xdp_p4tc_entry_delete: Used to delete a table entry from a BPF program installed in XDP. To delete the table entry we take anxdp_md, the pipeline ID, the table ID, a key and a key size.
We return 0 on success and a negative errno on failure[ ... ]
Quoted 12 lines
net/sched/p4tc/p4tc_bpf.c line 306
Quoted 7 lines
net/sched/p4tc/p4tc_bpf.c new file +7
-0+BTF_SET8_START (p4tc_kfunc_check_tbl_set_skb) +BTF_ID_FLAGS (func, bpf_p4tc_tbl_read, KF_RET_NULL); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create); +BTF_ID_FLAGS (func, bpf_p4tc_entry_create_on_miss); +BTF_ID_FLAGS (func, bpf_p4tc_entry_update); +BTF_ID_FLAGS (func, bpf_p4tc_entry_delete); +BTF_SET8_END (p4tc_kfunc_check_tbl_set_skb)These create/read/update/delete kfuncs are like defining a new hidden bpf map type in the kernel. bpf prog can now create its own link-list and rbtree.
sched_exthas already been using it. This is the way the bpf prog should use instead of creating a new map type.I don't really think this is an accurate assessment, given Jamal's use case. These kfuncs are more akin to the FIB lookup helper, or the netfilter kfuncs: they provide lookup into a kernel-internal data structure, so that BPF can access that data structure while staying in sync with the rest of the kernel.
If this was a BPF-only implementation you'd be right, but given the constraint of having the P4 objects represented in the kernel[0], I think this is a perfectly reasonable use of kfuncs, even though they happen to look like the map API.
-Toke
Quoted 8 lines
Quoted 4 lines
[0] Whether having those objects represented at all is reasonable is a separate discussion, which I believe John et al are having with Jamal in a separate subthread. I don't personally have any strong objections to doing that.
I might not be clear. It was my question on why it has to be in the kernel instead of in the bpf map, so the earlier bpf link-list and rbtree example just in case this recent bpf capability has not been considered.
A bit tangential, but it came to mind while thinking about this: how would one go about updating a bpf rbtree-based data structure from userspace? Is there a way to get bpf_map_update()-semantics that inserts things into the rbtree somehow?
Quoted 9 lines
If it is an existing kernel infra-structure, kfunc is a reasonable use.
The P4 objects are newly added to this set with bpf program as its user. It can be represented in the bpf map as well instead of in the kernel.
or is it fair to say that bpf prog is not the primary consumer of the P4 objects. Instead kernel is the primary user of the p4 objects such that p4tc can work independently without the bpf piece to begin with and bpf could be considered as an extension later?
That's a good question, actually. I think that conceptually, if viewed purely as a control plane, it could be merged separately and the BPF support added later. But with this series, that would make it a control plane that doesn't really control anything; so there would need to be a second consumer (hardware offload?) added for that to make sense, I suppose.
Quoted 7 lines
Or to put it another way, the way this series is designed, there is an implicit "these are kernel objects that we want to use for other things" assumption in there; it's just that those "other things" are not part of this series (because hardware offload doesn't exist yet - I think? I'll let Jamal answer that). I can see the point of asking for that second user, though, as that would make it clear why the control plane needs to be in the kernel.
Yes, HW is also a consumer via TC but these patches are for the s/w only piece.
Martin, to get some understanding, see the last slide on
https://netdevconf.info/0x17/sessions/talk/integrating-ebpf-into-the-p4tc-datapath.html
If you want to see the history of what changed from V1 for the s/w side, see slide #14. And if you have the patience, look at the whole slide set, and read the abstract. If clarity is still lacking then the cover letter. And if you have even more patience then the relevant commit messages but more importantly we need help to review if we are making any amateur mistakes for the kfunc piece. TC (which is used for such offloads, see u32, flower, etc) has its own model for config/control driven via netlink. There are more objects than just tables (eg pipelines, actions, externs etc) that all are _attached to netns_ where they were instantiated - so we have a few more kfuncs for those objects which are not part of this patchset (since the rules say 15 patches is the max).
Hope that helps.
cheers,
jamal
Quoted 2 lines
-Toke
Jamal Hadi Salim
maintainerPATCH v9 15/15 p4tc: add P4 classifier
In reply to Jamal Hadi SalimIntroduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipeline simple_l3 we'd issue the following command:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname simple_l3 \
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingress
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname simple_l3 \
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingress
We support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname simple_l3 \
prog type xdp obj $PARSER.o section parser/xdp \
pinned_link /sys/fs/bpf/mylink \
action bpf obj $PROGNAME.o section prog/tc-ingressThe theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.
=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname simple_l3 \
prog type tc obj $PARSER.o section parser/tc-ingress \
action bpf obj $PROGNAME.o section prog/tc-ingress \
action mirred egress mirror index 1 dev $P1 \
action bpf obj $ANOTHERPROG.o section mysect/section-1It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
--- include/uapi/linux/pkt_cls.h | 18 ++ net/sched/Kconfig | 12 + net/sched/Makefile | 1 + net/sched/cls_p4.c | 447 +++++++++++++++++++++++++++++++++++ net/sched/p4tc/Makefile | 4 +- net/sched/p4tc/trace.c | 10 + net/sched/p4tc/trace.h | 44 ++++ 7 files changed, 535 insertions(+), 1 deletion(-) create mode 100644 net/sched/cls_p4.c create mode 100644 net/sched/p4tc/trace.c create mode 100644 net/sched/p4tc/trace.h
include/uapi/linux/pkt_cls.h +18 -0
@@ -739,6 +739,24 @@ enum {#define TCA_MATCHALL_MAX (__TCA_MATCHALL_MAX - 1) +/* P4 classifier */ + +enum { +TCA_P4_UNSPEC , +TCA_P4_CLASSID , +TCA_P4_ACT , +TCA_P4_PNAME , +TCA_P4_PIPEID , +TCA_P4_PROG_FD , +TCA_P4_PROG_NAME , +TCA_P4_PROG_TYPE , +TCA_P4_PROG_ID , +TCA_P4_PAD , + __TCA_P4_MAX, +}; + +#define TCA_P4_MAX (__TCA_P4_MAX - 1) +/* Extended Matches */ struct tcf_ematch_tree_hdr {
net/sched/Kconfig +12 -0
@@ -565,6 +565,18 @@ config NET_CLS_MATCHALL To compile this code as a module, choose M here: the module will be called cls_matchall. +config NET_CLS_P4 + tristate "P4 classifier" + select NET_CLS + select NET_P4_TC + help + If you say Y here, you will be able to bind a P4 pipeline + program. You will need to install a P4 template representing the + program successfully to use this feature. + + To compile this code as a module, choose M here: the module will + be called cls_p4. + config NET_EMATCH bool "Extended Matches" select NET_CLS
net/sched/Makefile +1 -0
@@ -73,6 +73,7 @@ obj-$(CONFIG_NET_CLS_CGROUP) += cls_cgroup.o obj-$(CONFIG_NET_CLS_BPF) += cls_bpf.o obj-$(CONFIG_NET_CLS_FLOWER) += cls_flower.o obj-$(CONFIG_NET_CLS_MATCHALL) += cls_matchall.o +obj-$(CONFIG_NET_CLS_P4) += cls_p4.o obj-$(CONFIG_NET_EMATCH) += ematch.o obj-$(CONFIG_NET_EMATCH_CMP) += em_cmp.o obj-$(CONFIG_NET_EMATCH_NBYTE) += em_nbyte.o
net/sched/cls_p4.c new file +447 -0
447 lines not on this page · raw message
net/sched/p4tc/Makefile +3 -1
@@ -1,6 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 +CFLAGS_trace.o := -I$(src) + obj-y := p4tc_types.o p4tc_tmpl_api.o p4tc_pipeline.o \ p4tc_action.o p4tc_table.o p4tc_tbl_entry.o \ - p4tc_runtime_api.o + p4tc_runtime_api.o trace.o obj-$(CONFIG_DEBUG_INFO_BTF) += p4tc_bpf.o
net/sched/p4tc/trace.c new file +10 -0
@@ -0,0 +1,10 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) + +#include <net/p4tc.h> + +#ifndef __CHECKER__ + +#define CREATE_TRACE_POINTS +#include "trace.h" +EXPORT_TRACEPOINT_SYMBOL_GPL (p4_classify); +#endif
net/sched/p4tc/trace.h new file +44 -0
44 lines not on this page · raw message
Signature · 1 line
2.34.1
RE: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:
In addition to my comments from last iteration.
Quoted 4 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingress
Having multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
Quoted 16 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
Quoted 8 lines
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingress
I don't think tc should be loading xdp programs. XDP is not 'tc'.
Quoted 20 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
Quoted 8 lines
prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 7 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>---
Re: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 12 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 8 lines
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingressHaving multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
+1, fully agree.
Quoted 17 lines
Quoted 17 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
Quoted 8 lines
Quoted 6 lines
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingressI don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have bpf_xdp_link_attach() via bpf(2) and regular progs we have the classic way via dev_change_xdp_fd() with IFLA_XDP_* attributes. Mid-term we'll also add bpf_mprog support for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.
Quoted 24 lines
Quoted 24 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1
Quoted 14 lines
Quoted 3 lines
It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 6 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>
The cls_p4 is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) through bpf_mprog (see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed. Therefore, from BPF side:
Cheers,
Daniel
Jamal Hadi Salim
maintainerRe: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 18 lines · Daniel Borkmann
Quoted 16 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingress
Quoted 6 lines
Quoted 4 lines
Having multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
+1, fully agree.
As I stated earlier: while performance is important it is not the highest priority for what we are doing, rather correctness is. We dont want to be wrestling with the verifier or some other limitation like tail call limits to gain some increase in a few kkps. We are taking a gamble with the parser which is not using any kfuncs at the moment. Putting them all in one program will increase the risk.
As i responded to you earlier, we just dont want to lose functionality, some sample space:
- we could have multiple pipelines with different priorities - and each pipeline may have its own logic with many tables etc (and the choice to iterate the next one is essentially encoded in the tc action codes)
- we want to be able to split the pipeline into parts that can run _in unison_ in h/w, xdp, and tc
- we use tc block to map groups of ports heavily
- we use netlink as our control API
Quoted 24 lines
Quoted 24 lines
Quoted 23 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingress
Quoted 7 lines
Quoted 1 line
I don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have
bpf_xdp_link_attach()via bpf(2) and regular progs we have the classic way viadev_change_xdp_fd()with IFLA_XDP_* attributes. Mid-term we'll also addbpf_mprogsupport for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.
I am probably missing something. We are not loading the XDP program - it is preloaded, the only thing the filter does above is grabbing a reference to it. The P4 pipeline in this case is split into a piece (the parser) that runs on XDP and some that runs on tc. And as i mentioned earlier we could go further another piece which is part of the pipeline may run in hw. And infact in the future a compiler will be able to generate code that is split across machines. For our s/w datapath on the same node the only split is between tc and XDP.
Quoted 39 lines
Quoted 24 lines
Quoted 24 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1Quoted 14 lines
Quoted 3 lines
It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 6 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>
Quoted 6 lines
The
cls_p4is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) throughbpf_mprog(see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed.
Sorry, that is your use case for kubernetes and not ours. We want to use the tc infra. We want to use netlink. I could be misreading what you are saying but it seems that you are suggesting that tc infra is now obsolete as far as ebpf is concerned? Overall: It is a bit selfish to say your use case dictates how other people use ebpf. ebpf is just a means to an end for us and _is not the end goal_ - just an infra toolset. We spent a long time compromising to meet you somewhere when you asked us to use ebpf but you are pushing it now .
If you feel we should unify the P4 classifier with the tc ebpf classifier etc then we are going to need some changes that are not going to be useful for other people. And i dont see the point in that.
cheers,
jamal
Quoted 6 lines
Therefore, from BPF side:
Nacked-by Daniel Borkmann <[email protected]>Cheers,
Daniel
Daniel Borkmann
maintainerRe: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 23 lines · Jamal Hadi Salim
Quoted 22 lines · Daniel Borkmann
Quoted 20 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingressHaving multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
Quoted 8 lines
Quoted 1 line
+1, fully agree.
As I stated earlier: while performance is important it is not the highest priority for what we are doing, rather correctness is. We dont want to be wrestling with the verifier or some other limitation like tail call limits to gain some increase in a few kkps. We are taking a gamble with the parser which is not using any kfuncs at the moment. Putting them all in one program will increase the risk.
I don't think this is a good reason, this corners you into UAPI which later on cannot be changed anymore. If you encounter such issues, then why not bringing up actual concrete examples / limitations you run into to the BPF community and help one way or another to get the verifier improved instead? (Again, see sched_ext as one example improving verifier, but also concrete example bug reports, etc could help.)
Quoted 8 lines
As i responded to you earlier, we just dont want to lose functionality, some sample space:
- we could have multiple pipelines with different priorities - and each pipeline may have its own logic with many tables etc (and the choice to iterate the next one is essentially encoded in the tc action codes)
- we want to be able to split the pipeline into parts that can run_inunison_in h/w, xdp, and tc
So parser at XDP, but then you push it up the stack (instead of staying only at XDP layer) just to reach into tc layer to perform a corresponding action.. and this just to work around verifier as you say?
Quoted 35 lines
- we use tc block to map groups of ports heavily
- we use netlink as our control APIQuoted 24 lines
Quoted 24 lines
Quoted 23 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingressQuoted 7 lines
Quoted 1 line
I don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have
bpf_xdp_link_attach()via bpf(2) and regular progs we have the classic way viadev_change_xdp_fd()with IFLA_XDP_* attributes. Mid-term we'll also addbpf_mprogsupport for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.
Quoted 8 lines
I am probably missing something. We are not loading the XDP program - it is preloaded, the only thing the filter does above is grabbing a reference to it. The P4 pipeline in this case is split into a piece (the parser) that runs on XDP and some that runs on tc. And as i mentioned earlier we could go further another piece which is part of the pipeline may run in hw. And infact in the future a compiler will be able to generate code that is split across machines. For our s/w datapath on the same node the only split is between tc and XDP.
So it is even worse from a design PoV. The kernel side allows XDP program to be passed to cls_p4, but then it's not doing anything but holding a reference to that BPF program. Iow, you need anyway to go the regular way of bpf_xdp_link_attach() or dev_change_xdp_fd() to install XDP. Why is the reference even needed here, why it cannot be done in user space from your control plane? This again, feels like a shim layer which should live in user space instead.
Quoted 38 lines
Quoted 38 lines
Quoted 37 lines
Quoted 19 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\Quoted 8 lines
prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 5 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>
Quoted 8 lines
Quoted 6 lines
The
cls_p4is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) throughbpf_mprog(see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed.Sorry, that is your use case for kubernetes and not ours. We want to
There is nothing specific to k8s, it's generic infrastructure for tc BPF and also used outside of k8s scope; please double-check the selftests to get a picture of the API and libbpf integration.
Quoted 6 lines
use the tc infra. We want to use netlink. I could be misreading what you are saying but it seems that you are suggesting that tc infra is now obsolete as far as ebpf is concerned? Overall: It is a bit selfish to say your use case dictates how other people use ebpf. ebpf is just a means to an end for us and
_isnot the endgoal_- just an infra toolset.
Not really, the infrastructure is already there and ready to be used and it supports basic building blocks such as BPF links, relative prog/link dependency resolution, etc, where none of it can be found here. The problem is "we want to use netlink" which is even why you need to push down things like XDP prog, but it's broken by design, really. You are trying to push down a control plane into netlink which should have been a framework in user space.
Quoted 13 lines
If you feel we should unify the P4 classifier with the tc ebpf classifier etc then we are going to need some changes that are not going to be useful for other people. And i dont see the point in that.
cheers,
jamalQuoted 6 lines
Therefore, from BPF side:
Nacked-by Daniel Borkmann <[email protected]>Cheers,
Daniel
Jamal Hadi Salim
maintainerRe: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 34 lines · Daniel Borkmann
Quoted 23 lines · Jamal Hadi Salim
Quoted 22 lines · Daniel Borkmann
Quoted 20 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingressHaving multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
Quoted 8 lines
Quoted 1 line
+1, fully agree.
As I stated earlier: while performance is important it is not the highest priority for what we are doing, rather correctness is. We dont want to be wrestling with the verifier or some other limitation like tail call limits to gain some increase in a few kkps. We are taking a gamble with the parser which is not using any kfuncs at the moment. Putting them all in one program will increase the risk.
Quoted 7 lines
I don't think this is a good reason, this corners you into UAPI which later on cannot be changed anymore. If you encounter such issues, then why not bringing up actual concrete examples / limitations you run into to the BPF community and help one way or another to get the verifier improved instead? (Again, see
sched_extas one example improving verifier, but also concrete example bug reports, etc could help.)
Which uapi are you talking about? The eBPF code gets generated by the compiler. Whether we generate one or 10 programs or where we place them is up to the compiler.
We choose today to generate the parser separately - but we can change it in a heartbeat with zero kernel changes.
Quoted 9 lines
Quoted 8 lines
As i responded to you earlier, we just dont want to lose functionality, some sample space:
- we could have multiple pipelines with different priorities - and each pipeline may have its own logic with many tables etc (and the choice to iterate the next one is essentially encoded in the tc action codes)
- we want to be able to split the pipeline into parts that can run_inunison_in h/w, xdp, and tc
Quoted 4 lines
So parser at XDP, but then you push it up the stack (instead of staying only at XDP layer) just to reach into tc layer to perform a corresponding action.. and this just to work around verifier as you say?
You are mixing things. The idea of being able to split a pipeline into hw:xdp:tc is a requirement. You can run the pipeline fully in XDP or fully in tc or split it when it makes sense.
The idea of splitting the parser from the main p4 control block is for two reasons 1) someone else can generate or handcode the parser if they need to - we feel this is an area that may need to take advantage of features like dynptr etc in the future 2) as a precaution to ensure all P4 programs load. We have no problem putting both in one ebpf prog when we gain confidence that it will _always_ work - it is a mere change to what the compiler generates.
Quoted 44 lines
Quoted 35 lines
- we use tc block to map groups of ports heavily
- we use netlink as our control APIQuoted 24 lines
Quoted 24 lines
Quoted 23 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingressQuoted 7 lines
Quoted 1 line
I don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have
bpf_xdp_link_attach()via bpf(2) and regular progs we have the classic way viadev_change_xdp_fd()with IFLA_XDP_* attributes. Mid-term we'll also addbpf_mprogsupport for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.Quoted 8 lines
I am probably missing something. We are not loading the XDP program - it is preloaded, the only thing the filter does above is grabbing a reference to it. The P4 pipeline in this case is split into a piece (the parser) that runs on XDP and some that runs on tc. And as i mentioned earlier we could go further another piece which is part of the pipeline may run in hw. And infact in the future a compiler will be able to generate code that is split across machines. For our s/w datapath on the same node the only split is between tc and XDP.
Quoted 1 line
So it is even worse from a design PoV.
So from a wild accusation that we are loading the program to now a condescending remark we have a bad design.
Quoted 8 lines
The kernel side allows XDP program
to be passed tocls_p4, but then it's not doing anything but holding a reference to that BPF program. Iow, you need anyway to go the regular way ofbpf_xdp_link_attach()ordev_change_xdp_fd()to install XDP. Why is the reference even needed here, why it cannot be done in user space from your control plane? This again, feels like a shim layer which should live in user space instead.
Our control path goes through tc - where we instantiate the pipeline on typically a tc block. Note: there could be many pipeline instances of the same set of ebpf programs. We need to know which ebpf programs are bound to which pipelines. When a pipeline is instantiated or destroyed it sends (netlink) events to user space. It is only natural to reference the programs which are part of the pipeline at that point i.e loading for tc progs and referencing for xdp. The control is already in user space to create bpf links etc.
Our concern was (if you looked at the RFC discussions earlier on) a) we dont want anyone removing or replacing the XDP program that is part of a P4 pipeline b) we wanted to ensure in the case of a split pipeline that the XDP code that ran before tc part of the pipeline was infact the one that we wanted to run. The original code (before Toke made a suggestion to use bpf links) was passing a cookie from XDP to tc which we would use to solve these concerns. By creating the link in user space we can pass the fd - which is what you are seeing here. That solves both #a and #b.
Granted we may be a little paranoid but operationally an important detail is: if one dumps the tc filter with this approach they know what progs compose the pipeline.
Quoted 45 lines
Quoted 45 lines
Quoted 44 lines
Quoted 24 lines
Quoted 24 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1Quoted 13 lines
Quoted 3 lines
It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 5 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>The
cls_p4is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) throughbpf_mprog(see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed.
Quoted 6 lines
Quoted 1 line
Sorry, that is your use case for kubernetes and not ours. We want to
There is nothing specific to k8s, it's generic infrastructure for tc BPF and also used outside of k8s scope; please double-check the selftests to get a picture of the API and libbpf integration.
I did and i couldnt see how we can do any of the tcx/mprog using tc to meet our requirements. I may be missing something very obvious but it was why i said it was for your use case not ours. I would be willing to look again if you say it works with tc but do note that I am fine with tc infra where i can add actions, all composed of different programs if i wanted to; and add addendums to use other tc existing (non-ebpf) actions if i needed to. We have what we need working fine, so there has to be a compelling reason to change.
I asked you a question earlier whether in your view tc use of ebpf is deprecated. I have seen you make a claim in the past that sched_act was useless and that everyone needs to use sched_cls and you went on to say nobody needs priorities. TBH, that is _your view for your use case_.
Quoted 7 lines
Quoted 6 lines
use the tc infra. We want to use netlink. I could be misreading what you are saying but it seems that you are suggesting that tc infra is now obsolete as far as ebpf is concerned? Overall: It is a bit selfish to say your use case dictates how other people use ebpf. ebpf is just a means to an end for us and
_isnot the endgoal_- just an infra toolset.
Quoted 8 lines
Not really, the infrastructure is already there and ready to be used and it supports basic building blocks such as BPF links, relative prog/link dependency resolution, etc, where none of it can be found here. The problem is "we want to use netlink" which is even why you need to push down things like XDP prog, but it's broken by design, really. You are trying to push down a control plane into netlink which should have been a framework in user space.
The netlink part is not negotiable - the cover letter says why and i have explained it 10K times in these threads. You are listing all these tcx features like relativeness for which i have no use for. OTOH, like i said if it works with tc then i would be willing to look at it but there need to be compelling reasons to move to that shiny new infra.
cheers,
jamal
Daniel Borkmann
maintainerRe: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 41 lines · Jamal Hadi Salim
Quoted 33 lines · Daniel Borkmann
Quoted 23 lines · Jamal Hadi Salim
Quoted 22 lines · Daniel Borkmann
Quoted 20 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingressHaving multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
Quoted 8 lines
Quoted 1 line
+1, fully agree.
As I stated earlier: while performance is important it is not the highest priority for what we are doing, rather correctness is. We dont want to be wrestling with the verifier or some other limitation like tail call limits to gain some increase in a few kkps. We are taking a gamble with the parser which is not using any kfuncs at the moment. Putting them all in one program will increase the risk.
Quoted 6 lines
I don't think this is a good reason, this corners you into UAPI which later on cannot be changed anymore. If you encounter such issues, then why not bringing up actual concrete examples / limitations you run into to the BPF community and help one way or another to get the verifier improved instead? (Again, see
sched_extas one example improving verifier, but also concrete example bug reports, etc could help.)
Quoted 5 lines
Which uapi are you talking about? The eBPF code gets generated by the compiler. Whether we generate one or 10 programs or where we place them is up to the compiler.
We choose today to generate the parser separately - but we can change it in a heartbeat with zero kernel changes.
With UAPI I mean to even have this parser separation. Ideally, this should just naturally be a single program as in XDP layer itself. You mentioned below you could run the pipeline just in XDP..
Quoted 13 lines
Quoted 9 lines
Quoted 8 lines
As i responded to you earlier, we just dont want to lose functionality, some sample space:
- we could have multiple pipelines with different priorities - and each pipeline may have its own logic with many tables etc (and the choice to iterate the next one is essentially encoded in the tc action codes)
- we want to be able to split the pipeline into parts that can run_inunison_in h/w, xdp, and tcQuoted 3 lines
So parser at XDP, but then you push it up the stack (instead of staying only at XDP layer) just to reach into tc layer to perform a corresponding action.. and this just to work around verifier as you say?
Quoted 10 lines
You are mixing things. The idea of being able to split a pipeline into hw:xdp:tc is a requirement. You can run the pipeline fully in XDP or fully in tc or split it when it makes sense.
The idea of splitting the parser from the main p4 control block is for two reasons 1) someone else can generate or handcode the parser if they need to - we feel this is an area that may need to take advantage of features like dynptr etc in the future 2) as a precaution to ensure all P4 programs load. We have no problem putting both in one ebpf prog when we gain confidence that it will _always_ work - it is a mere change to what the compiler generates.
The cooperation between BPF progs at different layers (e.g. nfp allowed that nicely from a BPF offload PoV) makes sense, just less to split the actions within a given layer into multiple units where state needs to be transferred, packets reparsed, etc. When you say that "we have no problem putting both in one ebpf prog when we gain confidence that it will _always_ work", then should this not be the goal to start with? How do you quantify "gain confidence"? Test/conformance suite? It would be better to start out with this in the first place and fix or collaborate with whatever limits get encountered along the way. This would be the case for XDP anyway given you mention you want to support this layer.
Quoted 44 lines
Quoted 44 lines
Quoted 43 lines
- we use tc block to map groups of ports heavily
- we use netlink as our control APIQuoted 24 lines
Quoted 24 lines
Quoted 23 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingressQuoted 7 lines
Quoted 1 line
I don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have
bpf_xdp_link_attach()via bpf(2) and regular progs we have the classic way viadev_change_xdp_fd()with IFLA_XDP_* attributes. Mid-term we'll also addbpf_mprogsupport for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.I am probably missing something. We are not loading the XDP program - it is preloaded, the only thing the filter does above is grabbing a reference to it. The P4 pipeline in this case is split into a piece (the parser) that runs on XDP and some that runs on tc. And as i mentioned earlier we could go further another piece which is part of the pipeline may run in hw. And infact in the future a compiler will be able to generate code that is split across machines. For our s/w datapath on the same node the only split is between tc and XDP.
Quoted 4 lines
Quoted 1 line
So it is even worse from a design PoV.
So from a wild accusation that we are loading the program to now a condescending remark we have a bad design.
It's my opinion, yes, because all the pieces don't really fit naturally together. It's all centered around the netlink layer which you call out as 'non-negotiable', whereas this would have a better fit for a s/w-based solution where you provide a framework for developers from user space. Why do you even need an XDP reference in tc layer? Even though the XDP loading happens through the regular path anyway.. just to knit the different pieces artificially together despite the different existing layers & APIs. What should actually sit in user space and orchestrate the different generic pieces of the kernel toolbox together, you now try to artificially move one one layer down in a /non-generic/ way. Given this is trying to target a s/w datapath, I just don't follow why the building blocks of this work cannot be done in a /generic/ way. Meaning, generic extensions to the kernel infra in a p4-agnostic way, so they are also useful and consumable outside of it for tc BPF or XDP users, and then in user space the control plane picks all the necessary pieces it needs. (Think of an analogy to containers today.. there is no such notion in the kernel and the user space infra picks all the necessary pieces such as netns, cgroups, etc to flexibly assemble this higher level concept.)
Quoted 17 lines
Quoted 7 lines
The kernel side allows XDP program
to be passed tocls_p4, but then it's not doing anything but holding a reference to that BPF program. Iow, you need anyway to go the regular way ofbpf_xdp_link_attach()ordev_change_xdp_fd()to install XDP. Why is the reference even needed here, why it cannot be done in user space from your control plane? This again, feels like a shim layer which should live in user space instead.Our control path goes through tc - where we instantiate the pipeline on typically a tc block. Note: there could be many pipeline instances of the same set of ebpf programs. We need to know which ebpf programs are bound to which pipelines. When a pipeline is instantiated or destroyed it sends (netlink) events to user space. It is only natural to reference the programs which are part of the pipeline at that point i.e loading for tc progs and referencing for xdp. The control is already in user space to create bpf links etc.
Quoted 12 lines
Our concern was (if you looked at the RFC discussions earlier on) a) we dont want anyone removing or replacing the XDP program that is part of a P4 pipeline b) we wanted to ensure in the case of a split pipeline that the XDP code that ran before tc part of the pipeline was infact the one that we wanted to run. The original code (before Toke made a suggestion to use bpf links) was passing a cookie from XDP to tc which we would use to solve these concerns. By creating the link in user space we can pass the fd - which is what you are seeing here. That solves both #a and #b.
Granted we may be a little paranoid but operationally an important detail is: if one dumps the tc filter with this approach they know what progs compose the pipeline.
But just holding the reference in the tc cls_p4 code on the XDP program doesn't automatically mean that this blocks anything else from happening. You still need a user space control plane which creates the link, maybe pins it somewhere, and when you need to update the program at the XDP layer, then that user space control plane updates the prog @ XDP link. At that point the dump in tc has a window of inconsistency given this is non-atomic, and given this two-step approach.. what happens when the control plane crashesin the middle in the worst case, then would you take the XDP link info as source of truth or the cls_p4 dump? Just operating on the XDP link without this two-step detour is a much more robust approach given you avoid this race altogether.
Quoted 51 lines
Quoted 45 lines
Quoted 45 lines
Quoted 44 lines
Quoted 24 lines
Quoted 24 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1Quoted 13 lines
Quoted 3 lines
It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 5 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>The
cls_p4is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) throughbpf_mprog(see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed.Quoted 5 lines
Quoted 1 line
Sorry, that is your use case for kubernetes and not ours. We want to
There is nothing specific to k8s, it's generic infrastructure for tc BPF and also used outside of k8s scope; please double-check the selftests to get a picture of the API and libbpf integration.
Quoted 13 lines
I did and i couldnt see how we can do any of the tcx/mprog using tc to meet our requirements. I may be missing something very obvious but it was why i said it was for your use case not ours. I would be willing to look again if you say it works with tc but do note that I am fine with tc infra where i can add actions, all composed of different programs if i wanted to; and add addendums to use other tc existing (non-ebpf) actions if i needed to. We have what we need working fine, so there has to be a compelling reason to change.
I asked you a question earlier whether in your view tc use of ebpf is deprecated. I have seen you make a claim in the past thatsched_actwas useless and that everyone needs to usesched_clsand you went on to say nobody needs priorities. TBH, that is_yourview for your usecase_.
I do see act_bpf as redundant given the cls_bpf with the direct action mode can do everything that is needed with BPF, and whenever something was needed, extensions to verifier/helpers/kfuncs/etc were sufficient. We've been using this for years this way in production with complex programs and never saw a need to utilize any of the remaining actions outside of BPF or to have a split of parser/action as mentioned above. The additional machinery would also add overhead in s/w fast path which can be avoided (if it were e.g. cls_matchall + act_bpf). That said, people use cls_bpf in multi-user mode where different progs get attached. The priorities was collective BPF community feedback that these are hard to use due to the seen collisions in practice which led to various hard to debug incidents. While this was not my view initially, I agree that the new design with before/after and relative prog/link reference is a better ux.
Quoted 15 lines
Quoted 7 lines
Quoted 6 lines
use the tc infra. We want to use netlink. I could be misreading what you are saying but it seems that you are suggesting that tc infra is now obsolete as far as ebpf is concerned? Overall: It is a bit selfish to say your use case dictates how other people use ebpf. ebpf is just a means to an end for us and
_isnot the endgoal_- just an infra toolset.Quoted 7 lines
Not really, the infrastructure is already there and ready to be used and it supports basic building blocks such as BPF links, relative prog/link dependency resolution, etc, where none of it can be found here. The problem is "we want to use netlink" which is even why you need to push down things like XDP prog, but it's broken by design, really. You are trying to push down a control plane into netlink which should have been a framework in user space.
Quoted 6 lines
The netlink part is not negotiable - the cover letter says why and i have explained it 10K times in these threads. You are listing all these tcx features like relativeness for which i have no use for. OTOH, like i said if it works with tc then i would be willing to look at it but there need to be compelling reasons to move to that shiny new infra.
If you don't have a particular case for multi-prog, that is totally fine. You mentioned earlier on "we dont want anyone removing or replacing the XDP program that is part of a P4 pipeline", and that you are using BPF links to solve it, so I presume it would be equally important case for the tc BPF program of your P4 pipeline. I presume you use libbpf, so here the controller would do exact similar steps on tcx that you do for XDP to set up BPF links. But again, my overall comment comes down to why it cannot be broken into generic extensions as mentioned above given XDP/tc infra is in place.
Thanks,
Daniel
Jamal Hadi Salim
maintainerRe: [PATCH net-next v9 15/15] p4tc: add P4 classifier
Quoted 49 lines · Daniel Borkmann
Quoted 41 lines · Jamal Hadi Salim
Quoted 33 lines · Daniel Borkmann
Quoted 23 lines · Jamal Hadi Salim
Quoted 22 lines · Daniel Borkmann
Quoted 20 lines · John Fastabend
Quoted 8 lines · Jamal Hadi Salim
Introduce P4 tc classifier. A tc filter instantiated on this classifier is used to bind a P4 pipeline to one or more netdev ports. To use P4 classifier you must specify a pipeline name that will be associated to this filter, a s/w parser and datapath ebpf program. The pipeline must have already been created via a template.
For example, if we were to add a filter to ingress of network interface device $P0 and associate it to P4 pipelinesimple_l3we'd issue the following command:In addition to my comments from last iteration.
Quoted 3 lines
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
action bpf obj $PARSER.o section prog/tc-parser \
action bpf obj $PROGNAME.o section prog/tc-ingressHaving multiple object files is a mistake IMO and will cost performance. Have a single object file avoid stitching together metadata and run to completion. And then run entirely from XDP this is how we have been getting good performance numbers.
Quoted 8 lines
Quoted 1 line
+1, fully agree.
As I stated earlier: while performance is important it is not the highest priority for what we are doing, rather correctness is. We dont want to be wrestling with the verifier or some other limitation like tail call limits to gain some increase in a few kkps. We are taking a gamble with the parser which is not using any kfuncs at the moment. Putting them all in one program will increase the risk.
Quoted 6 lines
I don't think this is a good reason, this corners you into UAPI which later on cannot be changed anymore. If you encounter such issues, then why not bringing up actual concrete examples / limitations you run into to the BPF community and help one way or another to get the verifier improved instead? (Again, see
sched_extas one example improving verifier, but also concrete example bug reports, etc could help.)Quoted 5 lines
Which uapi are you talking about? The eBPF code gets generated by the compiler. Whether we generate one or 10 programs or where we place them is up to the compiler.
We choose today to generate the parser separately - but we can change it in a heartbeat with zero kernel changes.
Quoted 4 lines
With UAPI I mean to even have this parser separation. Ideally, this should just naturally be a single program as in XDP layer itself. You mentioned below you could run the pipeline just in XDP..
Yes we can - but it doesnt break uapi. The simplest thing to do is to place the pipeline either at TC or XDP fully. Caveat being not everything can run on XDP.
Probably showing XDP running the parser was not a good example - and i think we should remove it from the commit messages to avoid confusion. The intent there was to show that XDP, given its speed advantages, can do the parsing faster and infact reject anything early if thats what the P4 programm deemed it do; if it likes something then the tc layer handles the rest of the pipeline processing. It is really p4 program dependent. Consider another example which is more sensible:
XDP has a fast path (pipeline branching based on runtime conditions works well in P4) and if there were exceptions to the fast path (maybe a cache miss) then processing in the tc layer, etc.
I think we'll just remove such examples in the commit.
For the multi-prog-per level: If for a given P4 program the compiler (v1) generates two separate ebpf programs(as we do in this case) and then the next version of the compiler(v2) puts all the logic in one ebpf program at XDP only - nothing breaks. i.e both V1 and V2 output continue to work; maybe the V2 output could end up being more efficient, etc.
Quoted 24 lines
Quoted 13 lines
Quoted 9 lines
Quoted 8 lines
As i responded to you earlier, we just dont want to lose functionality, some sample space:
- we could have multiple pipelines with different priorities - and each pipeline may have its own logic with many tables etc (and the choice to iterate the next one is essentially encoded in the tc action codes)
- we want to be able to split the pipeline into parts that can run_inunison_in h/w, xdp, and tcQuoted 3 lines
So parser at XDP, but then you push it up the stack (instead of staying only at XDP layer) just to reach into tc layer to perform a corresponding action.. and this just to work around verifier as you say?
Quoted 10 lines
You are mixing things. The idea of being able to split a pipeline into hw:xdp:tc is a requirement. You can run the pipeline fully in XDP or fully in tc or split it when it makes sense.
The idea of splitting the parser from the main p4 control block is for two reasons 1) someone else can generate or handcode the parser if they need to - we feel this is an area that may need to take advantage of features like dynptr etc in the future 2) as a precaution to ensure all P4 programs load. We have no problem putting both in one ebpf prog when we gain confidence that it will _always_ work - it is a mere change to what the compiler generates.
Quoted 4 lines
The cooperation between BPF progs at different layers (e.g. nfp allowed that nicely from a BPF offload PoV) makes sense, just less to split the actions within a given layer into multiple units where state needs to be transferred,
For the parser split, one motivation was: there are other tools that are very specialized on parsers (see Tom) and as long as that tool can read P4 and conform to our expectations, we should be able to use that parser as a replacement. Maybe that example is too specific and doesnt apply in the larger picture but like i said we can change it with a compiler mod. No rush - we'll see where this goes.
Quoted 7 lines
packets reparsed, etc. When you say that "we have no problem putting both in one ebpf prog when we gain confidence that it will _always_ work", then should this not be the goal to start with? How do you quantify "gain confidence"? Test/conformance suite? It would be better to start out with this in the first place and fix or collaborate with whatever limits get encountered along the way. This would be the case for XDP anyway given you mention you want to support this layer.
It's just bad experience with the eBPF tooling that drove us in this path (path explosions, pointer trickery, tail call limits, etc). Our goal is to not require eBPF expertise for tc people (who are the main consumers of this); things have to _just work_ after the compiler emits them. We dont want to maintain a bag of tricks which may work some of the time. For our audience a goal is to lower the barrier for them and reduce dependence on "you must now be a guru at eBPF". For now we are in a grace period with the compiler (even for the parser separation, which we could end up removing) and over time feedback for usability and optimization will keep improving generated code and hopefully using new eBPF features more effectively. So i am not very concerned about this.
Quoted 49 lines
Quoted 44 lines
Quoted 44 lines
Quoted 43 lines
- we use tc block to map groups of ports heavily
- we use netlink as our control APIQuoted 24 lines
Quoted 24 lines
Quoted 23 lines
$PROGNAME.o and $PARSER.o is a compilation of the eBPF programs generated by the P4 compiler and will be the representation of the P4 program. Note that filter understands that $PARSER.o is a parser to be loaded at the tc level. The datapath program is merely an eBPF action.
Note we do support a distinct way of loading the parser as opposed to making it be an action, the above example would be:
tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\
prog type tc obj $PARSER.o ... \
action bpf obj $PROGNAME.o section prog/tc-ingressWe support two types of loadings of these initial programs in the pipeline and differentiate between what gets loaded at tc vs xdp by using syntax of
either "prog type tc obj" or "prog type xdp obj"
For XDP:
tc filter add dev $P0 ingress protocol all prio 1 p4 pname
simple_l3\prog type xdp obj $PARSER.o section parser/xdp \ pinned_link /sys/fs/bpf/mylink \ action bpf obj $PROGNAME.o section prog/tc-ingressQuoted 7 lines
Quoted 1 line
I don't think tc should be loading xdp programs. XDP is not 'tc'.
For XDP, we do have a separate attach API, for BPF links we have
bpf_xdp_link_attach()via bpf(2) and regular progs we have the classic way viadev_change_xdp_fd()with IFLA_XDP_* attributes. Mid-term we'll also addbpf_mprogsupport for XDP to allow multi-user attachment. tc kernel code should not add yet another way of attaching XDP, this should just reuse existing uapi infra instead from userspace control plane side.I am probably missing something. We are not loading the XDP program - it is preloaded, the only thing the filter does above is grabbing a reference to it. The P4 pipeline in this case is split into a piece (the parser) that runs on XDP and some that runs on tc. And as i mentioned earlier we could go further another piece which is part of the pipeline may run in hw. And infact in the future a compiler will be able to generate code that is split across machines. For our s/w datapath on the same node the only split is between tc and XDP.
Quoted 4 lines
Quoted 1 line
So it is even worse from a design PoV.
So from a wild accusation that we are loading the program to now a condescending remark we have a bad design.
Quoted 8 lines
It's my opinion, yes, because all the pieces don't really fit naturally together. It's all centered around the netlink layer which you call out as 'non-negotiable', whereas this would have a better fit for a s/w-based solution where you provide a framework for developers from user space. Why do you even need an XDP reference in tc layer? Even though the XDP loading happens through the regular path anyway.. just to knit the different pieces artificially together despite the different existing layers & APIs.
The P4 abstraction is a pipeline - to give analogy with current tc offloads (such as flower): the pipeline placement could be split between h/w and s/w (or be entirely in one or other),
So the placement idea is already cooked in the TC psyche. And the control to all that happens at the tc layer. I can send a netlink message and it will tell me which part is in h/w and s/w. We are just following a similar thought process here: The pipeline is owned by TC and therefore its management and control (and source of truth) sits at TC. True, XDP is a different layer - but from an engineering perspective, I dont see this as this layer violation rather it is something pragmatic to do.
Quoted 12 lines
What should actually sit in user space and orchestrate
the different generic pieces of the kernel toolbox together, you now try to artificially move one one layer down in a /non-generic/ way. Given this is trying to target a s/w datapath, I just don't follow why the building blocks of this work cannot be done in a /generic/ way. Meaning, generic extensions to the kernel infra in a p4-agnostic way, so they are also useful and consumable outside of it for tc BPF or XDP users, and then in user space the control plane picks all the necessary pieces it needs. (Think of an analogy to containers today.. there is no such notion in the kernel and the user space infra picks all the necessary pieces such as netns, cgroups, etc to flexibly assemble this higher level concept.)
If there are alternative ways to load the programs and define their dependency that would work with tc, then it should be sufficient to just feed the fds to the p4 classifier when we instantiate a p4 pipeline (or may not even be needed depending on what that stiching infra is). I did look at tcx hard after my last response and i am afraid, Daniel, that you divorced us and our status right now is we are your "ex" ;-> (is that what x means in tcx?). But if such a scheme exists, the eBPF progs can still call the exposed kfuncs meaning it will continue to work in the TC realm...
Quoted 30 lines
Quoted 17 lines
Quoted 7 lines
The kernel side allows XDP program
to be passed tocls_p4, but then it's not doing anything but holding a reference to that BPF program. Iow, you need anyway to go the regular way ofbpf_xdp_link_attach()ordev_change_xdp_fd()to install XDP. Why is the reference even needed here, why it cannot be done in user space from your control plane? This again, feels like a shim layer which should live in user space instead.Our control path goes through tc - where we instantiate the pipeline on typically a tc block. Note: there could be many pipeline instances of the same set of ebpf programs. We need to know which ebpf programs are bound to which pipelines. When a pipeline is instantiated or destroyed it sends (netlink) events to user space. It is only natural to reference the programs which are part of the pipeline at that point i.e loading for tc progs and referencing for xdp. The control is already in user space to create bpf links etc.
Quoted 12 lines
Our concern was (if you looked at the RFC discussions earlier on) a) we dont want anyone removing or replacing the XDP program that is part of a P4 pipeline b) we wanted to ensure in the case of a split pipeline that the XDP code that ran before tc part of the pipeline was infact the one that we wanted to run. The original code (before Toke made a suggestion to use bpf links) was passing a cookie from XDP to tc which we would use to solve these concerns. By creating the link in user space we can pass the fd - which is what you are seeing here. That solves both #a and #b.
Granted we may be a little paranoid but operationally an important detail is: if one dumps the tc filter with this approach they know what progs compose the pipeline.
Quoted 11 lines
But just holding the reference in the tc
cls_p4code on the XDP program doesn't automatically mean that this blocks anything else from happening. You still need a user space control plane which creates the link, maybe pins it somewhere, and when you need to update the program at the XDP layer, then that user space control plane updates the prog @ XDP link. At that point the dump in tc has a window of inconsistency given this is non-atomic, and given this two-step approach.. what happens when the control plane crashesin the middle in the worst case, then would you take the XDP link info as source of truth or thecls_p4dump? Just operating on the XDP link without this two-step detour is a much more robust approach given you avoid this race altogether.
See my comment above on tcx on splitting the loading from tc runtime. My experience in SDN is that you want the kernel to be the source of truth. i.e. if i want to know which progs are running for a given p4 pipeline, at what level, putting this info on some user space daemon which - as you point out may crush - is not the most robust. I should be able to just use a cli to find out the truth.
I didnt quiet follow your comment above on the XDP prog being replaced which a dump is going on... Am i mistaken in thinking that as long as i hold the refcount, you cant just swap things out from underneath me?
Quoted 65 lines
Quoted 51 lines
Quoted 45 lines
Quoted 45 lines
Quoted 44 lines
Quoted 24 lines
Quoted 24 lines
The theory of operations is as follows:
================================1. PARSING================================
The packet first encounters the parser.
The parser is implemented in ebpf residing either at the TC or XDP level. The parsed header values are stored in a shared eBPF map. When the parser runs at XDP level, we load it into XDP using tc filter command and pin it to a file.=============================2. ACTIONS=============================
In the above example, the P4 program (minus the parser) is encoded in an action($PROGNAME.o). It should be noted that classical tc actions continue to work:
IOW, someone could decide to add a mirred action to mirror all packets after or before the ebpf action.tc filter add dev $P0 parent ffff: protocol all prio 6 p4 pname
simple_l3\prog type tc obj $PARSER.o section parser/tc-ingress \ action bpf obj $PROGNAME.o section prog/tc-ingress \ action mirred egress mirror index 1 dev $P1 \ action bpf obj $ANOTHERPROG.o section mysect/section-1Quoted 13 lines
Quoted 3 lines
It should also be noted that it is feasible to split some of the ingress datapath into XDP first and more into TC later (as was shown above for example where the parser runs at XDP level). YMMV.
Is there any performance value in partial XDP and partial TC? The main wins we see in XDP are when we can drop, redirect, etc the packet entirely in XDP and avoid skb altogether.
Quoted 5 lines
Co-developed-by Victor Nogueira <[email protected]>Signed-off-by Victor Nogueira <[email protected]>Co-developed-by Pedro Tammela <[email protected]>Signed-off-by Pedro Tammela <[email protected]>Signed-off-by Jamal Hadi Salim <[email protected]>The
cls_p4is roughly a copy of {cls,act}_bpf, and from a BPF community side we moved away from this some time ago for the benefit of a better management API for tc BPF programs via bpf(2) throughbpf_mprog(see libbpf and BPF selftests around this), as mentioned earlier. Please use this instead for your userspace control plane, otherwise we are repeating the same mistakes from the past again that were already fixed.Quoted 5 lines
Quoted 1 line
Sorry, that is your use case for kubernetes and not ours. We want to
There is nothing specific to k8s, it's generic infrastructure for tc BPF and also used outside of k8s scope; please double-check the selftests to get a picture of the API and libbpf integration.
Quoted 13 lines
I did and i couldnt see how we can do any of the tcx/mprog using tc to meet our requirements. I may be missing something very obvious but it was why i said it was for your use case not ours. I would be willing to look again if you say it works with tc but do note that I am fine with tc infra where i can add actions, all composed of different programs if i wanted to; and add addendums to use other tc existing (non-ebpf) actions if i needed to. We have what we need working fine, so there has to be a compelling reason to change.
I asked you a question earlier whether in your view tc use of ebpf is deprecated. I have seen you make a claim in the past thatsched_actwas useless and that everyone needs to usesched_clsand you went on to say nobody needs priorities. TBH, that is_yourview for your usecase_.
Quoted 7 lines
I do see
act_bpfas redundant given thecls_bpfwith the direct action mode can do everything that is needed with BPF, and whenever something was needed, extensions to verifier/helpers/kfuncs/etc were sufficient. We've been using this for years this way in production with complex programs and never saw a need to utilize any of the remaining actions outside of BPF or to have a split of parser/action as mentioned above.
When you have a very specific use case you can fix things as needed as you described a lot easier; we have a large permutation of potential progs and pipeline flows to be dictated by P4 progs. We want to make sure things work all the time without someone calling us to say "how come this doesnt load?". For that we are willing to sacrifice some performance and i am sure we'll get better over time. So if it is multi-action so be it, at least for now. Definitely, we would not have wanted to go the eBPF path without kfuncs (and XDP plays a nice role)
- so i feel we are in a good place.
My thinking process has been converted from prioritizing "let me squeeze those cycles by skipping a memset" to "lets make this thing usable by other people" and if i loose a few kpps because i have two actions instead of one, no big deal - we'll get better over time.
Quoted 9 lines
The additional machinery would also add overhead
in s/w fast path which can be avoided (if it were e.g.cls_matchall+act_bpf). That said, people usecls_bpfin multi-user mode where different progs get attached. The priorities was collective BPF community feedback that these are hard to use due to the seen collisions in practice which led to various hard to debug incidents. While this was not my view initially, I agree that the new design with before/after and relative prog/link reference is a better ux.
I empathize with the situation you faced (i note that motivation was a multi user food fight). We dont have that "collision" problem in our use cases. TBH, TC priorities and chains (which i can jump to) are sufficient for what we do. Note: I am also not objecting to getting better performance (which i am sure we'll get better over time) or finding a common ground for how to specify the collection of programs (as long as it serves our needs as well i.e tc, netlink).
cheers,
jamal
Quoted 35 lines
Quoted 15 lines
Quoted 7 lines
Quoted 6 lines
use the tc infra. We want to use netlink. I could be misreading what you are saying but it seems that you are suggesting that tc infra is now obsolete as far as ebpf is concerned? Overall: It is a bit selfish to say your use case dictates how other people use ebpf. ebpf is just a means to an end for us and
_isnot the endgoal_- just an infra toolset.Quoted 7 lines
Not really, the infrastructure is already there and ready to be used and it supports basic building blocks such as BPF links, relative prog/link dependency resolution, etc, where none of it can be found here. The problem is "we want to use netlink" which is even why you need to push down things like XDP prog, but it's broken by design, really. You are trying to push down a control plane into netlink which should have been a framework in user space.
Quoted 6 lines
The netlink part is not negotiable - the cover letter says why and i have explained it 10K times in these threads. You are listing all these tcx features like relativeness for which i have no use for. OTOH, like i said if it works with tc then i would be willing to look at it but there need to be compelling reasons to move to that shiny new infra.
If you don't have a particular case for multi-prog, that is totally fine. You mentioned earlier on "we dont want anyone removing or replacing the XDP program that is part of a P4 pipeline", and that you are using BPF links to solve it, so I presume it would be equally important case for the tc BPF program of your P4 pipeline. I presume you use libbpf, so here the controller would do exact similar steps on tcx that you do for XDP to set up BPF links. But again, my overall comment comes down to why it cannot be broken into generic extensions as mentioned above given XDP/tc infra is in place.
Thanks,
Daniel