Skip to contentSkip to conversation

iommu: Don't reserve 0-length IOVA region

PATCH Applied Ashish Mhetre 3 participants 4 messages Dec 5, 2023 – Dec 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iommu: Don't reserve 0-length IOVA region

When the bootloader/firmware doesn't setup the framebuffers, their address and size are 0 in "iommu-addresses" property. If IOVA region is reserved with 0 length, then it ends up corrupting the IOVA rbtree with an entry which has pfn_hi < pfn_lo.
If we intend to use display driver in kernel without framebuffer then it's causing the display IOMMU mappings to fail as entire valid IOVA space is reserved when address and length are passed as 0. An ideal solution would be firmware removing the "iommu-addresses" property and corresponding "memory-region" if display is not present. But the kernel should be able to handle this by checking for size of IOVA region and skipping the IOVA reservation if size is 0. Also, add a warning if firmware is requesting 0-length IOVA region reservation.

Fixes a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
---
 drivers/iommu/of_iommu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/iommu/of_iommu.c +4 -0
index 47302b637cc0..42cffb0ee5e2 100644
@@ -264,6 +264,10 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list)
 					prot |= IOMMU_CACHE;
 
 				maps = of_translate_dma_region(np, maps, &iova, &length);
+				if (length == 0) {
+					dev_warn(dev, "Cannot reserve IOVA region of 0 size\n");
+					continue;
+				}
 				type = iommu_resv_region_get_type(dev, &phys, iova, length);
 
 				region = iommu_alloc_resv_region(iova, length, prot, type,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 24 lines · Ashish Mhetre

When the bootloader/firmware doesn't setup the framebuffers, their address and size are 0 in "iommu-addresses" property. If IOVA region is reserved with 0 length, then it ends up corrupting the IOVA rbtree with an entry which has pfn_hi < pfn_lo.
If we intend to use display driver in kernel without framebuffer then it's causing the display IOMMU mappings to fail as entire valid IOVA space is reserved when address and length are passed as 0. An ideal solution would be firmware removing the "iommu-addresses" property and corresponding "memory-region" if display is not present. But the kernel should be able to handle this by checking for size of IOVA region and skipping the IOVA reservation if size is 0. Also, add a warning if firmware is requesting 0-length IOVA region reservation.

Fixes a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
---
  drivers/iommu/of_iommu.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/iommu/of_iommu.c +0 -0
index 47302b637cc0..42cffb0ee5e2 100644

drivers/iommu/of_iommu.c void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) · line 273

Quoted 10 lines
drivers/iommu/of_iommu.c +4 -0
@@ -264,6 +264,10 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list)
  					prot |= IOMMU_CACHE;
 
  				maps = of_translate_dma_region(np, maps, &iova, &length);
+				if (length == 0) {
+					dev_warn(dev, "Cannot reserve IOVA region of 0 size\n");
+					continue;
+				}
  				type = iommu_resv_region_get_type(dev, &phys, iova, length);
 
  				region = iommu_alloc_resv_region(iova, length, prot, type,

Hi all,

Can you please review this patch and provide feedback?

Thank you,
Ashish Mhetre

reviewer Acked-by on v2 1/1
#2 lore raw
In reply to Ashish Mhetre
Quoted 4 lines · Ashish Mhetre

When the bootloader/firmware doesn't setup the framebuffers, their address and size are 0 in "iommu-addresses" property. If IOVA region is reserved with 0 length, then it ends up corrupting the IOVA rbtree with an entry which has pfn_hi < pfn_lo.

Quoted 8 lines

If we intend to use display driver in kernel without framebuffer then it's causing the display IOMMU mappings to fail as entire valid IOVA space is reserved when address and length are passed as 0. An ideal solution would be firmware removing the "iommu-addresses" property and corresponding "memory-region" if display is not present. But the kernel should be able to handle this by checking for size of IOVA region and skipping the IOVA reservation if size is 0. Also, add a warning if firmware is requesting 0-length IOVA region reservation.

Quoted 21 lines
Fixes a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
---
  drivers/iommu/of_iommu.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/iommu/of_iommu.c +4 -0
index 47302b637cc0..42cffb0ee5e2 100644
@@ -264,6 +264,10 @@ void of_iommu_get_resv_regions(struct device *dev, struct list_head *list)
  					prot |= IOMMU_CACHE;
 
  				maps = of_translate_dma_region(np, maps, &iova, &length);
+				if (length == 0) {
+					dev_warn(dev, "Cannot reserve IOVA region of 0 size\n");
+					continue;
+				}
  				type = iommu_resv_region_get_type(dev, &phys, iova, length);
 
  				region = iommu_alloc_resv_region(iova, length, prot, type,