arm64: dts: qcom: qrb5165-rb5: add an alias for uart6
PATCH 1/3 arm64: dts: qcom: qrb5165-rb5: add an alias for uart6
From: Bartosz Golaszewski <[email protected]>
Alias uart6 to serial1 for qrb5165-rb5. This is the high-speed port used by Bluetooth.
--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +1 -0
@@ -23,6 +23,7 @@ / { aliases { serial0 = &uart12; + serial1 = &uart6; sdhc2 = &sdhc_2; };
Signature · 1 line
2.40.1
PATCH 2/3 arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO
From: Bartosz Golaszewski <[email protected]>
Set up the pin function for the Bluetooth enable GPIO.
--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +11 -0
@@ -1264,6 +1264,17 @@ &tlmm { "HST_WLAN_UART_TX", "HST_WLAN_UART_RX"; + bt_en_state: bt-default-state { + bt-en { + pins = "gpio21"; + function = "gpio"; + + drive-strength = <16>; + output-low; + bias-pull-up; + }; + }; + lt9611_irq_pin: lt9611-irq-state { pins = "gpio63"; function = "gpio";
Signature · 1 line
2.40.1
Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO
Quoted 21 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Set up the pin function for the Bluetooth enable GPIO.
Signed-off-by Bartosz Golaszewski <[email protected]>--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +4
-0@@ -1264,6 +1264,17 @@ &tlmm { "HST_WLAN_UART_TX", "HST_WLAN_UART_RX"; + bt_en_state: bt-default-state { + bt-en { + pins = "gpio21"; + function = "gpio";
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts &tlmm { · line 1280
Quoted 10 lines
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +7
-0+ + drive-strength = <16>; + output-low; + bias-pull-up; + }; + }; + lt9611_irq_pin: lt9611-irq-state { pins = "gpio63"; function = "gpio";
This makes no sense as a separate patch and should be squashed with the final patch enabling bluetooth. Same for the first patch.
Johan
Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO
In reply to Bartosz GolaszewskiQuoted 14 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Set up the pin function for the Bluetooth enable GPIO.
Signed-off-by Bartosz Golaszewski <[email protected]>--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +0
-0
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts &tlmm { · line 1268
Quoted 5 lines
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +2
-0@@ -1264,6 +1264,17 @@ &tlmm { "HST_WLAN_UART_TX", "HST_WLAN_UART_RX"; + bt_en_state: bt-default-state { + bt-en {
This looks like tlmm, so you miss here suffix.
It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
Re: [PATCH 2/3] arm64: dts: qcom: qrb5165-rb5: add a pin function for BT enable GPIO
In reply to Bartosz GolaszewskiQuoted 14 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Set up the pin function for the Bluetooth enable GPIO.
Signed-off-by Bartosz Golaszewski <[email protected]>--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +0
-0
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts &tlmm { · line 1269
Quoted 6 lines
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +3
-0@@ -1264,6 +1264,17 @@ &tlmm { "HST_WLAN_UART_TX", "HST_WLAN_UART_RX"; + bt_en_state: bt-default-state { + bt-en { + pins = "gpio21";
If it's the only GPIO expected to be here, you may drop the extra bt-en level, like the entry below
Konrad
PATCH 3/3 arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
Add the Bluetooth node for RB5.
--- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +20 -0
@@ -1308,6 +1308,26 @@ sdc2_card_det_n: sd-card-det-n-state { }; }; +&uart6 { + status = "okay"; + + bluetooth { + compatible = "qcom,qca6390-bt"; + + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_state>; + + enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>; + + vddio-supply = <&vreg_s4a_1p8>; + vddpmu-supply = <&vreg_s2f_0p95>; + vddaon-supply = <&vreg_s6a_0p95>; + vddrfa1-supply = <&vreg_s2f_0p95>; + vddrfa2-supply = <&vreg_s8c_1p3>; + vddrfa3-supply = <&vreg_s5a_1p9>; + }; +}; + &uart12 { status = "okay"; };
Signature · 1 line
2.40.1