Bluetooth: power-on QCA6390 correctly
Subsystems (4)
v2 cover Bluetooth: power-on QCA6390 correctly
From: Bartosz Golaszewski <[email protected]>
Patch 1 is just a typo fix as we're already touching this bindings. The second patch adds more regulator defintions and enforces them for the QCA6390 model. The final patch enables the power sequence for the BT module of QCA6390 in the hci_qca driver.
v1 -> v2:
- squashed the two bluetooth patches into one
- changed the naming convention for the RFA regulators to follow the existing ones
- added dt-bindings patches
Bartosz Golaszewski (3):
dt-bindings: net: bluetooth: qualcomm: fix a typo
dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390
Bluetooth: qca: run the power-on/off sequence for QCA6390 too
.../net/bluetooth/qualcomm-bluetooth.yaml | 26 ++++++++++++++++++- drivers/bluetooth/hci_qca.c | 14 +++++++++- 2 files changed, 38 insertions(+), 2 deletions(-)
Signature · 1 line
2.40.1
PATCH v2 1/3 dt-bindings: net: bluetooth: qualcomm: fix a typo
From: Bartosz Golaszewski <[email protected]>
Spell supply correctly.
--- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +1 -1
@@ -69,7 +69,7 @@ properties: description: VDD_RFA_CMN supply regulator handle vddrfa0p8-supply: - description: VDD_RFA_0P8 suppply regulator handle + description: VDD_RFA_0P8 supply regulator handle vddrfa1p7-supply: description: VDD_RFA_1P7 supply regulator handle
Signature · 1 line
2.40.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=807781
---Test result---
Test Summary:
CheckPatch PASS 1.39 seconds GitLint PASS 0.70 seconds SubjectPrefix FAIL 0.53 seconds BuildKernel PASS 27.14 seconds CheckAllWarning PASS 30.14 seconds CheckSparse PASS 38.64 seconds CheckSmatch PASS 97.95 seconds BuildKernel32 PASS 26.25 seconds TestRunnerSetup PASS 414.38 seconds TestRunner_l2cap-tester PASS 23.75 seconds TestRunner_iso-tester PASS 52.14 seconds TestRunner_bnep-tester PASS 7.04 seconds TestRunner_mgmt-tester PASS 159.16 seconds TestRunner_rfcomm-tester PASS 11.00 seconds TestRunner_sco-tester PASS 14.60 seconds TestRunner_ioctl-tester PASS 12.05 seconds TestRunner_mesh-tester PASS 8.82 seconds TestRunner_smp-tester PASS 9.85 seconds TestRunner_userchan-tester PASS 7.60 seconds IncrementalBuild PASS 34.10 seconds
Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix Output:
"Bluetooth: " prefix is not specified in the subject "Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
PATCH v2 2/3 dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
Add regulator properties for QCA6390 that are missing from the bindings and enforce required properties for this model as well.
--- .../net/bluetooth/qualcomm-bluetooth.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)
Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +24 -0
@@ -65,12 +65,21 @@ properties: vddbtcxmx-supply: description: VDD_BT_CXMX supply regulator handle + vddpmu-supply: + description: VDD_PMU supply regulator handle + vddrfacmn-supply: description: VDD_RFA_CMN supply regulator handle vddrfa0p8-supply: description: VDD_RFA_0P8 supply regulator handle + vddrfa0p9-supply: + description: VDD_RFA_0P9 supply regulator handle + + vddrfa1p3-supply: + description: VDD_RFA1P3 supply regulator handle + vddrfa1p7-supply: description: VDD_RFA_1P7 supply regulator handle
@@ -180,6 +189,21 @@ allOf: - vddrfa0p8-supply - vddrfa1p2-supply - vddrfa1p9-supply + - if: + properties: + compatible: + contains: + enum: + - qcom,qca6390-bt + then: + required: + - enable-gpios + - vddio-supply + - vddpmu-supply + - vddaon-supply + - vddrfa0p9-supply + - vddrfa1p3-supply + - vddrfa1p9-supply examples: - |
Signature · 1 line
2.40.1
Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Add regulator properties for QCA6390 that are missing from the bindings and enforce required properties for this model as well.
Signed-off-by Bartosz Golaszewski <[email protected]>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390
Quoted 19 lines · Krzysztof Kozlowski
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Add regulator properties for QCA6390 that are missing from the bindings and enforce required properties for this model as well.
Signed-off-by Bartosz Golaszewski <[email protected]>Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Quoted 5 lines
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
Sorry, I just used the command I used last but this time there were additional dt-bindings patches. Will resend it tomorrow.
Bart
PATCH v2 3/3 Bluetooth: qca: run the power-on/off sequence for QCA6390 too
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
The Bluetooth module on QCA6390 needs to be powered-on by enabling the relevant regulators and driving the enable GPIO high. We can reuse the power sequence for the WNC models if we add the list of required regulators to the OF match data.
--- drivers/bluetooth/hci_qca.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/bluetooth/hci_qca.c +13 -1
@@ -1788,6 +1788,7 @@ static int qca_power_on(struct hci_dev *hdev)case QCA_WCN6750 :case QCA_WCN6855 :case QCA_WCN7850 : +case QCA_QCA6390 : ret =qca_regulator_init (hu);break ;
@@ -2044,7 +2045,15 @@ static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = {static const struct qca_device_data qca_soc_data_qca6390__maybe_unused = { .soc_type =QCA_QCA6390 , - .num_vregs =0 , + .vregs = (struct qca_vreg []) { + {"vddio" ,20000 }, + {"vddaon" ,100000 }, + {"vddpmu" ,1250000 }, + {"vddrfa0p9" ,200000 }, + {"vddrfa1p3" ,400000 }, + {"vddrfa1p9" ,400000 }, + }, + .num_vregs =6 , };static const struct qca_device_data qca_soc_data_wcn6750__maybe_unused = {
@@ -2129,6 +2138,7 @@ static void qca_power_shutdown(struct hci_uart *hu)case QCA_WCN6750 :case QCA_WCN6855 : +case QCA_QCA6390 :gpiod_set_value_cansleep (qcadev->bt_en,0 );msleep (100 );qca_regulator_disable (qcadev);
@@ -2276,6 +2286,7 @@ static int qca_serdev_probe(struct serdev_device *serdev)case QCA_WCN6750 :case QCA_WCN6855 :case QCA_WCN7850 : +case QCA_QCA6390 : qcadev->bt_power =devm_kzalloc (&serdev->dev,sizeof (struct qca_power ),GFP_KERNEL );
@@ -2386,6 +2397,7 @@ static void qca_serdev_remove(struct serdev_device *serdev)case QCA_WCN6750 :case QCA_WCN6855 :case QCA_WCN7850 : +case QCA_QCA6390 :if (power->vregs_on) {qca_power_shutdown (&qcadev->serdev_hu);break ;
Signature · 1 line
2.40.1