Skip to contentSkip to conversation

mm: do not protect VMA lock object in vma_end_read()

PATCH In review Alexander Gordeev 2 participants 2 messages Dec 7, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: do not protect VMA lock object in vma_end_read()

In early discussion to the implementation of vma_end_read() Jann Horn pointed out that up_read() could access the VMA lock object after it has already been acquired by someone else. As result, up_read() is protected with RCU read lock:

	rcu_read_lock(); /* keeps vma alive */
	up_read(&vma->lock);
	rcu_read_unlock();

Since commit 3f5245538a19 ("locking/rwsem: Disable preemption in all down_read*() and up_read() code paths") __up_read() disables preemption internally and thus the need to protect the VMA lock object does not exist anymore.

---
 include/linux/mm.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/mm.h +0 -2
index 418d26608ece..7b32bc75a4ab 100644
@@ -683,9 +683,7 @@ static inline bool vma_start_read(struct vm_area_struct *vma)
 
 static inline void vma_end_read(struct vm_area_struct *vma)
 {
-	rcu_read_lock(); /* keeps vma alive till the end of up_read */
 	up_read(&vma->vm_lock->lock);
-	rcu_read_unlock();
 }
 
 /* WARNING! Can only be used if mmap_lock is expected to be write-locked */
Signature · 1 line
2.40.1
#1 lore raw
Quoted 5 lines · Alexander Gordeev

In early discussion to the implementation of vma_end_read() Jann Horn pointed out that up_read() could access the VMA lock object after it has already been acquired by someone else. As result, up_read() is protected with RCU read lock:

Quoted 8 lines
        rcu_read_lock(); /* keeps vma alive */
        up_read(&vma->lock);
        rcu_read_unlock();

Since commit 3f5245538a19 ("locking/rwsem: Disable preemption in all down_read*() and up_read() code paths") __up_read() disables preemption internally and thus the need to protect the VMA lock object does not exist anymore.

I think this is a bad idea. Please don't.

Yes, it looks like the (non-RT) implementation of __up_read *currently* disables preemption. But that's an implementation detail, not a documented API contract of up_read(), so there would be nothing stopping someone from reimplementing __up_read() in the future such that the preemption stuff disappears again.

And from what I can tell from a quick look, the RT implementation of __up_read() does not currently give you this kind of guarantee.

In my opinion, if you want to make this change, then as a prerequisite you have to get buy-in from the locking maintainers.

Quoted 25 lines
---
 include/linux/mm.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/mm.h +0 -3
index 418d26608ece..7b32bc75a4ab 100644
@@ -683,9 +683,7 @@ static inline bool vma_start_read(struct vm_area_struct *vma)
 
 static inline void vma_end_read(struct vm_area_struct *vma)
 {
-       rcu_read_lock(); /* keeps vma alive till the end of up_read */
        up_read(&vma->vm_lock->lock);
-       rcu_read_unlock();
 }
 
 /* WARNING! Can only be used if mmap_lock is expected to be write-locked */
--

2.40.1