Skip to contentSkip to conversation

ida-make-ida_dump-static.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Dec 11, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: ida: make 'ida_dump' static
has been removed from the -mm tree. Its filename was
ida-make-ida_dump-static.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Arnd Bergmann <[email protected]>
Subject: ida: make 'ida_dump' static
Date: Thu, 23 Nov 2023 12:05:01 +0100

Patch series "Treewide: enable -Wmissing-prototypes", v3.

At this point, there are five architectures with a number of known
regressions: alpha, nios2, mips, sh and sparc. In the previous version of this patch, I had turned off the missing prototype warnings for the 15 architectures that still had issues, but since there are only five left, I think we can leave the rest to the maintainers (Cc'd here) as well.

The series is also likely to cause occasional build regressions on linux-next as developers add new code that misses prototypes. Hopefully this should be resolved by the time the patches make it into a release and everyone gets the warnings right away.

This patch (of 6):

There is no global declaration for ida_dump() and no other callers, so make it static to avoid this warning:

lib/test_ida.c:16:6: error: no previous prototype for 'ida_dump'

Fixes 8ab8ba38d488 ("ida: Start new test_ida module")
Cc "David S. Miller" <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Ivan Kokshaysky <[email protected]>
Cc John Paul Adrian Glaubitz <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Matt Turner <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nicolas Schier <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Richard Henderson <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc Rich Felker <[email protected]>
Cc Stephen Rothwell <[email protected]>
Cc Thomas Bogendoerfer <[email protected]>
Cc Tudor Ambarus <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Kees Cook <[email protected]>
Cc Palmer Dabbelt <[email protected]>
Cc Zhihao Cheng <[email protected]>

---

 lib/test_ida.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_ida.c renamed from lib/test_ida.c~ida-make-ida_dump-static +1 -1
@@ -13,7 +13,7 @@ static unsigned int tests_run;
 static unsigned int tests_passed;
 
 #ifdef __KERNEL__
-void ida_dump(struct ida *ida) { }
+static void ida_dump(struct ida *ida) { }
 #endif
 #define IDA_BUG_ON(ida, x) do {						\
 	tests_run++;							\

_

Patches currently in -mm which might be from [email protected] are

kexec-fix-kexec_file-dependencies.patch kexec-fix-kexec_file-dependencies-fix.patch kexec-select-crypto-from-kexec_file-instead-of-depending-on-it.patch makefileextrawarn-turn-on-missing-prototypes-globally.patch