Skip to contentSkip to conversation

ACPI: LPSS: Fix the fractional clock divider flags

PATCH Applied Andy Shevchenko 2 participants 2 messages Dec 11, 2023 – Dec 12, 2023 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: LPSS: Fix the fractional clock divider flags

The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags in the parameters and hence miscalculates the values in the clock divider. Fix this by applying the flag to the proper parameter.

Fixes 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag")
---
 drivers/acpi/acpi_lpss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +2 -1
index 79f4fc7d6871..6f454f61a432 100644
@@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev,
 		if (!clk_name)
 			return -ENOMEM;
 		clk = clk_register_fractional_divider(NULL, clk_name, parent,
+						      0, prv_base, 1, 15, 16, 15,
 						      CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
-						      prv_base, 1, 15, 16, 15, 0, NULL);
+						      NULL);
 		parent = clk_name;
 
 		clk_name = kasprintf(GFP_KERNEL, "%s-update", devname);
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
maintainer Applied
#1 lore raw
Quoted 18 lines · Andy Shevchenko

The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags in the parameters and hence miscalculates the values in the clock divider. Fix this by applying the flag to the proper parameter.

Fixes 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag")
---
 drivers/acpi/acpi_lpss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +0 -0
index 79f4fc7d6871..6f454f61a432 100644
@@ -453,8 +453,9 @@ static int register_device_clock(struct acpi_device *adev,
                if (!clk_name)

drivers/acpi/acpi_lpss.c static int register_device_clock(struct acpi_device *adev,

Quoted 10 lines
drivers/acpi/acpi_lpss.c +2 -2
                        return -ENOMEM;
                clk = clk_register_fractional_divider(NULL, clk_name, parent,
+                                                     0, prv_base, 1, 15, 16, 15,
                                                      CLK_FRAC_DIVIDER_POWER_OF_TWO_PS,
-                                                     prv_base, 1, 15, 16, 15, 0, NULL);
+                                                     NULL);
                parent = clk_name;
 
                clk_name = kasprintf(GFP_KERNEL, "%s-update", devname);
--

Applied as 6.8 material, thanks!