Skip to contentSkip to conversation

doc: remove cmdline_poll deprecation notice

PATCH Applied Stephen Hemminger 3 participants 3 messages Dec 11, 2023 – Feb 13, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: remove cmdline_poll deprecation notice

cmdline_poll has been removed by:
commit f44f2edd198a ("cmdline: remove poll function") but deprecation notice was left behind.

---
 doc/guides/rel_notes/deprecation.rst | 4 ----
 1 file changed, 4 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -4
index 81b93515cbd9..10630ba25564 100644
@@ -27,10 +27,6 @@ Deprecation Notices
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
-* cmdline: The function ``cmdline_poll`` does not work correctly on either
-  Linux or Windows and is unused by any part of DPDK.
-  This function is now deprecated and will be removed in DPDK 23.11.
-
 * telemetry: The functions ``rte_tel_data_add_array_u64`` and ``rte_tel_data_add_dict_u64``,
   used by telemetry callbacks for adding unsigned integer values to be returned to the user,
   are renamed to ``rte_tel_data_add_array_uint`` and ``rte_tel_data_add_dict_uint`` respectively.
Signature · 1 line
2.42.0
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Stephen Hemminger

cmdline_poll has been removed by:
commit f44f2edd198a ("cmdline: remove poll function") but deprecation notice was left behind.

Suggest adding that commit in a fixes line and adding stable on Cc so this can be picked up for backport.

Quoted 1 line
Quoted 22 lines
---
 doc/guides/rel_notes/deprecation.rst | 4 ----
 1 file changed, 4 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -4
index 81b93515cbd9..10630ba25564 100644
@@ -27,10 +27,6 @@ Deprecation Notices
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
-* cmdline: The function ``cmdline_poll`` does not work correctly on either
-  Linux or Windows and is unused by any part of DPDK.
-  This function is now deprecated and will be removed in DPDK 23.11.
-
 * telemetry: The functions ``rte_tel_data_add_array_u64`` and ``rte_tel_data_add_dict_u64``,
   used by telemetry callbacks for adding unsigned integer values to be returned to the user,
   are renamed to ``rte_tel_data_add_array_uint`` and ``rte_tel_data_add_dict_uint`` respectively.
Signature · 1 line
2.42.0
Acked-by Bruce Richardson on v1 1/1 Applied
#2 lore raw
In reply to Stephen Hemminger
Quoted 5 lines · Stephen Hemminger

cmdline_poll has been removed by:
commit f44f2edd198a ("cmdline: remove poll function") but deprecation notice was left behind.

Fixes f44f2edd198a ("cmdline: remove poll function")
Quoted 1 line

Applied, thanks.

Signature · 1 line
David Marchand