gpiolib: allocate memory atomically with a spinlock held
PATCH 1/1 gpiolib: allocate memory atomically with a spinlock held
From: Bartosz Golaszewski <[email protected]>
We will eventually switch to protecting the GPIO descriptors with a mutex but until then, we need to allocate memory for the label copy atomically while we're holding the global spinlock.
--- drivers/gpio/gpiolib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpio/gpiolib.c +9 -1
@@ -2399,7 +2399,15 @@ char *gpiochip_dup_line_label(struct gpio_chip *gc, unsigned int offset)if (!test_bit (FLAG_REQUESTED , &desc->flags))return NULL ; - label =kstrdup (desc->label,GFP_KERNEL ); +/* +* FIXME: Once we mark gpiod_direction_input/output() and +* gpiod_get_direction() with might_sleep(), we'll be able to protect +* the GPIO descriptors with mutex (while value setting operations will +* become lockless). +* +* Until this happens, this allocation needs to be atomic. +*/ + label =kstrdup (desc->label,GFP_ATOMIC );if (!label)return ERR_PTR (-ENOMEM );
Signature · 1 line
2.40.1
Quoted 10 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
We will eventually switch to protecting the GPIO descriptors with a mutex but until then, we need to allocate memory for the label copy atomically while we're holding the global spinlock.
Reported-by Dan Carpenter <[email protected]>Fixes f8d05e276b45 ("gpiolib: remove gpiochip_is_requested()")Signed-off-by Bartosz Golaszewski <[email protected]>
Makes sense.
Yours,
Linus Walleij
Quoted 37 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
We will eventually switch to protecting the GPIO descriptors with a mutex but until then, we need to allocate memory for the label copy atomically while we're holding the global spinlock.
Reported-by Dan Carpenter <[email protected]>Fixes f8d05e276b45 ("gpiolib: remove gpiochip_is_requested()")Signed-off-by Bartosz Golaszewski <[email protected]>--- drivers/gpio/gpiolib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/gpio/gpiolib.c +9
-2@@ -2399,7 +2399,15 @@ char *gpiochip_dup_line_label(struct gpio_chip *gc, unsigned int offset)if (!test_bit (FLAG_REQUESTED , &desc->flags))return NULL ; - label =kstrdup (desc->label,GFP_KERNEL ); +/* +* FIXME: Once we mark gpiod_direction_input/output() and +* gpiod_get_direction() with might_sleep(), we'll be able to protect +* the GPIO descriptors with mutex (while value setting operations will +* become lockless). +* +* Until this happens, this allocation needs to be atomic. +*/ + label =kstrdup (desc->label,GFP_ATOMIC );if (!label)return ERR_PTR (-ENOMEM ); --
Quoted 2 lines
2.40.1
Patch applied.
Bart