Skip to contentSkip to conversation

dt-bindings: extcon: ptn5150: Describe the USB connector

PATCH Applied Fabio Estevam 3 participants 6 messages Dec 12, 2023 – Jan 13, 2024

Subsystems (5)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/3 dt-bindings: extcon: ptn5150: Describe the USB connector

From: Fabio Estevam <[email protected]>

PTN5150 supports USB Type-C connector, so improve the bindings by allowing to describe the connector like it is done on nxp,ptn5110.yaml.

---
Changes since v1:
- Removed type and unevaluatedProperties: false (Conor).

 Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml +3 -0
index d5cfa32ea52d..b3e5c0df0cd7 100644
@@ -37,6 +37,9 @@ properties:
       GPIO pin (output) used to control VBUS. If skipped, no such control
       takes place.
 
+  connector:
+    $ref: /schemas/connector/usb-connector.yaml#
+
 required:
   - compatible
   - interrupts
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH v2 2/3 arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector

From: Fabio Estevam <[email protected]>

Describe the PTN5150 USB-C connector to improve the devicetree description and fix the following dt-schema warning:

imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#

---
Changes since v1:
- None

 .../boot/dts/freescale/imx8mn-var-som-symphony.dts    | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts +8 -3
index a6b94d1957c9..f38ee2266b25 100644
@@ -128,9 +128,14 @@ extcon_usbotg1: typec@3d {
 		pinctrl-0 = <&pinctrl_ptn5150>;
 		status = "okay";
 
-		port {
-			typec1_dr_sw: endpoint {
-				remote-endpoint = <&usb1_drd_sw>;
+		connector {
+			compatible = "usb-c-connector";
+			label = "USB-C";
+
+			port {
+				typec1_dr_sw: endpoint {
+					remote-endpoint = <&usb1_drd_sw>;
+				};
 			};
 		};
 	};
Signature · 1 line
2.34.1
Applied
#2 lore raw

Re: [PATCH v2 2/3] arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Describe the PTN5150 USB-C connector to improve the devicetree description and fix the following dt-schema warning:

imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#

Applied, thanks!

author reviewer
#3 lore raw

PATCH v2 3/3 arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Describe the PTN5150 USB-C connector to improve the devicetree description and fix the following dt-schema warning:

imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#

---
Changes since v1:
- None

 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts +8 -4
index b749e28e5ede..fea67a9282f0 100644
@@ -175,10 +175,14 @@ typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				port {
-
-					ptn5150_out_ep: endpoint {
-						remote-endpoint = <&dwc3_0_ep>;
+				connector {
+					compatible = "usb-c-connector";
+					label = "USB-C";
+
+					port {
+						ptn5150_out_ep: endpoint {
+							remote-endpoint = <&dwc3_0_ep>;
+						};
 					};
 				};
 			};
Signature · 1 line
2.34.1
Applied
#4 lore raw

Re: [PATCH v2 3/3] arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Describe the PTN5150 USB-C connector to improve the devicetree description and fix the following dt-schema warning:

imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#

Applied, thanks!

#5 lore raw

Re: [PATCH v2 3/3] arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector

Quoted 6 lines · Shawn Guo
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Describe the PTN5150 USB-C connector to improve the devicetree description and fix the following dt-schema warning:

Quoted 6 lines
Quoted 4 lines

imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#

Applied, thanks!

This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this patch, it is detected.

Please drop this patch for now.