Skip to contentSkip to conversation

linux-next: build failure after merge of the thermal tree

DISCUSSION Stephen Rothwell 3 participants 5 messages Dec 18, 2023 – Dec 21, 2023 Linux-next tree

lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

After merging the thermal tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: "__hw_protection_shutdown" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

726edaad90f6 ("thermal/core: Prepare for introduction of thermal reboot")

I have used the thermal tree from next-20231218 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hi Stephen,

Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the thermal tree, today's linux-next build (x86_64 allmodconfig) failed like this:

Quoted 7 lines

ERROR: modpost: "__hw_protection_shutdown" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

726edaad90f6 ("thermal/core: Prepare for introduction of thermal
reboot")

Thanks for reporting.

Daniel,

Could you please squash the following fix to the commit above?

kernel/reboot.c +1 -0
index 07eb6537ed8b..f814568525f1 100644
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, int ms_until_forced, bool shut
        if (shutdown)
                orderly_poweroff(true);
 }
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);
 
 static int __init reboot_setup(char *str)
 {

x86_64 allmodconfig builds successfully with this change.

Thanks,

Fabio Estevam

#2 lore raw
Quoted 26 lines · Fabio Estevam

Hi Stephen,

Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the thermal tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: "__hw_protection_shutdown" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

  726edaad90f6 ("thermal/core: Prepare for introduction of thermal reboot")

Thanks for reporting.

Daniel,

Could you please squash the following fix to the commit above?

kernel/reboot.c +0 -0
index 07eb6537ed8b..f814568525f1 100644
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason,
Quoted 5 lines

int ms_until_forced, bool shut
        if (shutdown)
                orderly_poweroff(true);
 }
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);

Yeah, I've done it

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#3 lore raw

Hi Daniel,

Quoted 22 lines · On Tue, 19 Dec 2023 18:59:14 +0100 Daniel Lezcano <[email protected]>…
Quoted 20 lines · Fabio Estevam
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the thermal tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: "__hw_protection_shutdown" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

  726edaad90f6 ("thermal/core: Prepare for introduction of thermal >> reboot")

Thanks for reporting.

Daniel,

Could you please squash the following fix to the commit above?

Quoted 11 lines

kernel/reboot.c void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut · line 1005

Quoted 9 lines
kernel/reboot.c +1 -0
index 07eb6537ed8b..f814568525f1 100644
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut
         if (shutdown)
                 orderly_poweroff(true);
  }
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);

Yeah, I've done it

Forgot to push out?

Signature · 2 lines
Cheers,
Stephen Rothwell
#4 lore raw

Hi Stephen,

Quoted 12 lines · Stephen Rothwell
Quoted 11 lines

kernel/reboot.c void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut · line 1005

Quoted 9 lines
kernel/reboot.c +1 -0
index 07eb6537ed8b..f814568525f1 100644
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, > int ms_until_forced, bool shut
         if (shutdown)
                 orderly_poweroff(true);
  }
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);

Yeah, I've done it

Quoted 1 line

Forgot to push out?

The 'bleeding-edge' branch contains the fix now:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=f21b0d185f75e15561047312dd4b8306eac8ad71