riscv: mm: Fixup compat mode boot failure
PATCH 1/1 riscv: mm: Fixup compat mode boot failure
From: Guo Ren <[email protected]>
In COMPAT mode, the STACK_TOP is 0x80000000, but the TASK_SIZE is 0x7fff000. When the user stack is upon 0x7fff000, it will cause a user segment fault. Sometimes, it would cause boot failure when the whole rootfs is rv32.
Freeing unused kernel image (initmem) memory: 2236K
Run /sbin/init as init process
Starting init: /sbin/init exists but couldn't execute it (error -14) Run /etc/init as init process
...
--- arch/riscv/include/asm/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/include/asm/pgtable.h +1 -1
@@ -881,7 +881,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)#define TASK_SIZE_MIN (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)#ifdef CONFIG_COMPAT -#define TASK_SIZE_32 (_AC(0x80000000, UL) - PAGE_SIZE) +#define TASK_SIZE_32 (UL(1) << (MMAP_VA_BITS - 1))#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ TASK_SIZE_32 : TASK_SIZE_64)#else
Signature · 1 line
2.40.1
Quoted 13 lines · On Tue, Dec 19, 2023 at 06:17:01AM -0500, [email protected] wrote:
From: Guo Ren <[email protected]>
In COMPAT mode, the
STACK_TOPis0x80000000, but theTASK_SIZEis0x7fff000. When the user stack is upon0x7fff000, it will cause a user segment fault. Sometimes, it would cause boot failure when the whole rootfs is rv32.Freeing unused kernel image (initmem) memory: 2236K
Run/sbin/initas init process
Starting init:/sbin/initexists but couldn't execute it (error -14) Run/etc/initas init process
...
Quoted 3 lines
Fixes add2cc6b6515 ("RISC-V: mm: Restrict address space for sv39,sv48,sv57")Signed-off-by Guo Ren <[email protected]>Signed-off-by Guo Ren <[email protected]>
Abandon this patch, and here is the v2:
https://lore.kernel.org/linux-riscv/[email protected]/
Quoted 26 lines
--- arch/riscv/include/asm/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/include/asm/pgtable.h +1
-1@@ -881,7 +881,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte)#define TASK_SIZE_MIN (PGDIR_SIZE_L3 * PTRS_PER_PGD / 2)#ifdef CONFIG_COMPAT -#define TASK_SIZE_32 (_AC(0x80000000, UL) - PAGE_SIZE) +#define TASK_SIZE_32 (UL(1) << (MMAP_VA_BITS - 1))#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ TASK_SIZE_32 : TASK_SIZE_64)#else Signature · 7 lines
2.40.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv