Skip to contentSkip to conversation

sbp1: Add support for IBM SBP1 board

PATCH In review Naresh Solanki 3 participants 6 messages Dec 20, 2023 – Jan 3, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sbp1: Add support for IBM SBP1 board

From: Patrick Rudolph <[email protected]>

Add defconfig & devicetree for IBM SBP1 board BMC based on AST2600 SoC.

---

Changes:
- Update MAINTAINERS

---
 arch/arm/dts/Makefile                |   4 +-
 arch/arm/dts/ast2600-sbp1.dts        |  96 ++++++++++++++++++++
 board/aspeed/evb_ast2600/MAINTAINERS |   1 +
 configs/ibm-sbp1_defconfig           | 126 +++++++++++++++++++++++++++
 4 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-sbp1.dts
 create mode 100644 configs/ibm-sbp1_defconfig
arch/arm/dts/Makefile +3 -1
index 1be08c5fdc..85514fb8ba 100644
@@ -1353,7 +1353,9 @@ dtb-$(CONFIG_BCM6878) += \
 	bcm96878.dtb
 
 dtb-$(CONFIG_ASPEED_AST2500) += ast2500-evb.dtb
-dtb-$(CONFIG_ASPEED_AST2600) += ast2600-evb.dtb
+dtb-$(CONFIG_ASPEED_AST2600) += \
+	ast2600-evb.dtb \
+	ast2600-sbp1.dtb
 
 dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
 
arch/arm/dts/ast2600-sbp1.dts new file +96 -0

96 lines not on this page · raw message

board/aspeed/evb_ast2600/MAINTAINERS +1 -0
index e83aae5d6a..5368e8ee5f 100644
@@ -4,3 +4,4 @@ S:	Maintained
 F:	board/aspeed/evb_ast2600/
 F:	include/configs/evb_ast2600.h
 F:	configs/evb-ast2600_defconfig
+F:	configs/ibm-sbp1_defconfig
configs/ibm-sbp1_defconfig new file +126 -0

126 lines not on this page · raw message

Signature · 1 line
2.41.0
#1 lore raw
Quoted 10 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Add defconfig & devicetree for IBM SBP1 board BMC based on AST2600 SoC.

---

Changes:
- Update MAINTAINERS

Quoted 8 lines
---
 arch/arm/dts/Makefile                |   4 +-
 arch/arm/dts/ast2600-sbp1.dts        |  96 ++++++++++++++++++++
 board/aspeed/evb_ast2600/MAINTAINERS |   1 +
 configs/ibm-sbp1_defconfig           | 126 +++++++++++++++++++++++++++
 4 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-sbp1.dts
 create mode 100644 configs/ibm-sbp1_defconfig

Is this device tree submitted upstream?

Signature · 1 line
Tom
#2 lore raw

Hi Tom

Quoted 21 lines · Tom Rini
Quoted 10 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Add defconfig & devicetree for IBM SBP1 board BMC based on AST2600 SoC.

---

Changes:
- Update MAINTAINERS

Quoted 8 lines
---
 arch/arm/dts/Makefile                |   4 +-
 arch/arm/dts/ast2600-sbp1.dts        |  96 ++++++++++++++++++++
 board/aspeed/evb_ast2600/MAINTAINERS |   1 +
 configs/ibm-sbp1_defconfig           | 126 +++++++++++++++++++++++++++
 4 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-sbp1.dts
 create mode 100644 configs/ibm-sbp1_defconfig
Quoted 1 line

Is this device tree submitted upstream?

This devicetree is meant for uboot.
devicetree for linux kernel is wip.

Regards,
Naresh

Quoted 3 lines

--
Tom

#3 lore raw
Quoted 24 lines · Naresh Solanki

Hi Tom

Quoted 21 lines · Tom Rini
Quoted 18 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Add defconfig & devicetree for IBM SBP1 board BMC based on AST2600 SoC.

---

Changes:
- Update MAINTAINERS

---
 arch/arm/dts/Makefile                |   4 +-
 arch/arm/dts/ast2600-sbp1.dts        |  96 ++++++++++++++++++++
 board/aspeed/evb_ast2600/MAINTAINERS |   1 +
 configs/ibm-sbp1_defconfig           | 126 +++++++++++++++++++++++++++
 4 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-sbp1.dts
 create mode 100644 configs/ibm-sbp1_defconfig
Quoted 3 lines
Quoted 1 line

Is this device tree submitted upstream?

This devicetree is meant for uboot.
devicetree for linux kernel is wip.

Right, but the DTs in U-Boot are intended to be re-synced with the kernel and medium to long term the goal should be that the run-time DT U-Boot has is passed to the OS.

Signature · 1 line
Tom
#4 lore raw

Hi Tom,
can you please clarify or point us to some documentation that explains the new DT setup?
I thought the u-boot DT is only used for u-boot internal drivers.

Do we need to upstream the kernel DT first?
Do we need to provide a complete "kernel DT" to u-boot as well?

Regards,
Patrick Rudolph

Quoted 36 lines · Tom Rini
Quoted 24 lines · Naresh Solanki

Hi Tom

Quoted 21 lines · Tom Rini
Quoted 18 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Add defconfig & devicetree for IBM SBP1 board BMC based on AST2600 SoC.

---

Changes:
- Update MAINTAINERS

---
 arch/arm/dts/Makefile                |   4 +-
 arch/arm/dts/ast2600-sbp1.dts        |  96 ++++++++++++++++++++
 board/aspeed/evb_ast2600/MAINTAINERS |   1 +
 configs/ibm-sbp1_defconfig           | 126 +++++++++++++++++++++++++++
 4 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-sbp1.dts
 create mode 100644 configs/ibm-sbp1_defconfig
Quoted 3 lines
Quoted 1 line

Is this device tree submitted upstream?

This devicetree is meant for uboot.
devicetree for linux kernel is wip.

Right, but the DTs in U-Boot are intended to be re-synced with the kernel and medium to long term the goal should be that the run-time DT U-Boot has is passed to the OS.

--
Tom

#5 lore raw
Quoted 4 lines · Patrick Rudolph

Hi Tom,
can you please clarify or point us to some documentation that explains the new DT setup?
I thought the u-boot DT is only used for u-boot internal drivers.

The DT has always supposed to have been the same one as the Linux Kernel, to make things easier for developers as they would only need one DT, not two. For systems that use the EFI loader we pass the same DT to the OS which can simplify life.

Quoted 1 line

Do we need to upstream the kernel DT first?

If the DT is not upstream it really should be being submitted upstream and not just never upstreamed. I know this is more challenging in some cases than others.

Quoted 1 line

Do we need to provide a complete "kernel DT" to u-boot as well?

That is usually easiest, yes.

Signature · 1 line
Tom