Skip to contentSkip to conversation

iio: pressure: bmp280: Add missing bmp085 to SPI id table

PATCH Applied Sam Protsenko 4 participants 4 messages Dec 20, 2023 – Dec 21, 2023 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: pressure: bmp280: Add missing bmp085 to SPI id table

"bmp085" is missing in bmp280_spi_id[] table, which leads to the next warning in dmesg:

SPI driver bmp280 has no spi_device_id for bosch,bmp085

Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in bmp280_of_spi_match[] table to fix the above warning.

Fixes b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
---
 drivers/iio/pressure/bmp280-spi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/pressure/bmp280-spi.c +1 -0
index 433d6fac83c4..e8a5fed07e88 100644
@@ -87,6 +87,7 @@ static const struct of_device_id bmp280_of_spi_match[] = {
 MODULE_DEVICE_TABLE(of, bmp280_of_spi_match);
 
 static const struct spi_device_id bmp280_spi_id[] = {
+	{ "bmp085", (kernel_ulong_t)&bmp180_chip_info },
 	{ "bmp180", (kernel_ulong_t)&bmp180_chip_info },
 	{ "bmp181", (kernel_ulong_t)&bmp180_chip_info },
 	{ "bmp280", (kernel_ulong_t)&bmp280_chip_info },
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Sam Protsenko

"bmp085" is missing in bmp280_spi_id[] table, which leads to the next warning in dmesg:

SPI driver bmp280 has no spi_device_id for bosch,bmp085

Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in bmp280_of_spi_match[] table to fix the above warning.

Good catch!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#2 lore raw
In reply to Sam Protsenko
Quoted 10 lines · Sam Protsenko

"bmp085" is missing in bmp280_spi_id[] table, which leads to the next warning in dmesg:

SPI driver bmp280 has no spi_device_id for bosch,bmp085

Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in bmp280_of_spi_match[] table to fix the above warning.

Fixes b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")

Right! Thanks for fixing this Sam!

Yours,
Linus Walleij

maintainer Applied
#3 lore raw
Quoted 8 lines · On Wed, 20 Dec 2023 20:07:57 +0100 Linus Walleij <[email protected]>…
Quoted 5 lines · Sam Protsenko

"bmp085" is missing in bmp280_spi_id[] table, which leads to the next warning in dmesg:

SPI driver bmp280 has no spi_device_id for bosch,bmp085

Quoted 9 lines
Quoted 5 lines

Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in bmp280_of_spi_match[] table to fix the above warning.

Fixes b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")

Right! Thanks for fixing this Sam!

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

J

Quoted 2 lines

Yours,
Linus Walleij