gpio: tps65219: don't use CONFIG_DEBUG_GPIO
Subsystems (2)
PATCH 1/1 gpio: tps65219: don't use CONFIG_DEBUG_GPIO
From: Bartosz Golaszewski <[email protected]>
CONFIG_DEBUG_GPIO should only be used to enable debug log messages and for core GPIOLIB debugging. Don't use it to control the execution of potentially buggy code. Just put it under an always-false #if.
--- drivers/gpio/gpio-tps65219.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpio/gpio-tps65219.c +9 -9
@@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off* Below can be used for test purpose only. */ -if (IS_ENABLED (CONFIG_DEBUG_GPIO )) { -int ret =regmap_update_bits (gpio->tps->regmap,TPS65219_REG_MFP_1_CONFIG , -TPS65219_GPIO0_DIR_MASK , direction); -if (ret) { -dev_err (dev, -"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n" , - direction, offset); -return ret; - } +#if 0 +int ret =regmap_update_bits (gpio->tps->regmap,TPS65219_REG_MFP_1_CONFIG , +TPS65219_GPIO0_DIR_MASK , direction); +if (ret) { +dev_err (dev, +"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n" , + direction, offset); +return ret; } +#endif dev_err(dev, "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",
Signature · 1 line
2.40.1
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
CONFIG_DEBUG_GPIOshould only be used to enable debug log messages and for core GPIOLIB debugging. Don't use it to control the execution of potentially buggy code. Just put it under an always-false #if.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
CONFIG_DEBUG_GPIOshould only be used to enable debug log messages and for core GPIOLIB debugging. Don't use it to control the execution of potentially buggy code. Just put it under an always-false #if.Signed-off-by Bartosz Golaszewski <[email protected]>
Maybe I would have simply deleted the code, but OK. I bet some static analyzers will promptly return complaints about "no #if 0 in the kernel" :/ In this case it's an OK compromise.
Yours,
Linus Walleij
Quoted 43 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
CONFIG_DEBUG_GPIOshould only be used to enable debug log messages and for core GPIOLIB debugging. Don't use it to control the execution of potentially buggy code. Just put it under an always-false #if.Signed-off-by Bartosz Golaszewski <[email protected]>--- drivers/gpio/gpio-tps65219.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)drivers/gpio/gpio-tps65219.c +9
-10@@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off* Below can be used for test purpose only. */ -if (IS_ENABLED (CONFIG_DEBUG_GPIO )) { -int ret =regmap_update_bits (gpio->tps->regmap,TPS65219_REG_MFP_1_CONFIG , -TPS65219_GPIO0_DIR_MASK , direction); -if (ret) { -dev_err (dev, -"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n" , - direction, offset); -return ret; - } +#if 0 +int ret =regmap_update_bits (gpio->tps->regmap,TPS65219_REG_MFP_1_CONFIG , +TPS65219_GPIO0_DIR_MASK , direction); +if (ret) { +dev_err (dev, +"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n" , + direction, offset); +return ret; } +#endif dev_err(dev, "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n", --
Quoted 2 lines
2.40.1
Patch applied.
Bart