staging: rtl8712: fix open parentheses alignment
PATCH v2 1/1 staging: rtl8712: fix open parentheses alignment
Made corrections given we have 100 lines. Thanks for the update.
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by Ryan England <[email protected]>
--- drivers/staging/rtl8712/os_intfs.c | 3 +- drivers/staging/rtl8712/rtl8712_efuse.c | 9 +- drivers/staging/rtl8712/rtl8712_recv.c | 3 +- drivers/staging/rtl8712/rtl8712_xmit.c | 60 +++--- drivers/staging/rtl8712/rtl871x_cmd.c | 159 +++++--------- drivers/staging/rtl8712/rtl871x_cmd.h | 37 ++-- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 203 +++++++----------- 7 files changed, 173 insertions(+), 301 deletions(-)
drivers/staging/rtl8712/os_intfs.c +1 -2
@@ -221,8 +221,7 @@ struct net_device *r8712_init_netdev(void)static u32 start_drv_threads (struct _adapter *padapter) { - padapter->cmd_thread =kthread_run (r8712_cmd_thread, padapter,"%s" , - padapter->pnetdev->name); + padapter->cmd_thread =kthread_run (r8712_cmd_thread, padapter,"%s" , padapter->pnetdev->name);if (IS_ERR (padapter->cmd_thread))return _FAIL;return _SUCCESS;
drivers/staging/rtl8712/rtl8712_efuse.c +4 -5
@@ -213,8 +213,8 @@ u16 r8712_efuse_get_current_size(struct _adapter *adapter)u8 hworden =0 ;u8 efuse_data, word_cnts =0 ; -while (bContinual &&efuse_one_byte_read (adapter, efuse_addr, - &efuse_data) && (efuse_addr < efuse_available_max_size)) { +while (bContinual &&efuse_one_byte_read (adapter, efuse_addr, &efuse_data) && + (efuse_addr < efuse_available_max_size)) {if (efuse_data !=0xFF ) { hworden = efuse_data &0x0F ; word_cnts =calculate_word_cnts (hworden);
@@ -252,9 +252,8 @@ u8 r8712_efuse_pg_packet_read(struct _adapter *adapter, u8 offset, u8 *data)memset (tmpdata,0xFF ,PGPKT_DATA_SIZE );for (tmpidx =0 ; tmpidx < word_cnts *2 ; tmpidx++) { -if (efuse_one_byte_read (adapter, - efuse_addr +1 + tmpidx, - &efuse_data)) { +if (efuse_one_byte_read (adapter, efuse_addr +1 + tmpidx, + &efuse_data)) { tmpdata[tmpidx] = efuse_data; }else { ret = false;
drivers/staging/rtl8712/rtl8712_recv.c +1 -2
@@ -267,8 +267,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,/*the first fragment*/ if (!list_empty (&pdefrag_q->queue)) {/*free current defrag_q */ -r8712_free_recvframe_queue (pdefrag_q, - pfree_recv_queue); +r8712_free_recvframe_queue (pdefrag_q, pfree_recv_queue); } }/* Then enqueue the 0~(n-1) fragment to the defrag_q */
drivers/staging/rtl8712/rtl8712_xmit.c +24 -36
146 lines not on this page · raw message
drivers/staging/rtl8712/rtl871x_cmd.c +56 -103
304 lines not on this page · raw message
drivers/staging/rtl8712/rtl871x_cmd.h +13 -24
@@ -716,39 +716,28 @@ struct DisconnectCtrlEx_param {#define H2C_RESERVED 0x07void r8712_setMacAddr_cmd (struct _adapter *padapter,const u8 *mac_addr); -u8 r8712_sitesurvey_cmd (struct _adapter *padapter, -struct ndis_802_11_ssid *pssid); +u8 r8712_sitesurvey_cmd (struct _adapter *padapter,struct ndis_802_11_ssid *pssid);int r8712_createbss_cmd (struct _adapter *padapter);void r8712_setstakey_cmd (struct _adapter *padapter,u8 *psta,u8 unicast_key); -int r8712_joinbss_cmd (struct _adapter *padapter, -struct wlan_network *pnetwork); +int r8712_joinbss_cmd (struct _adapter *padapter,struct wlan_network *pnetwork);void r8712_disassoc_cmd (struct _adapter *padapter); -void r8712_setopmode_cmd (struct _adapter *padapter, -enum NDIS_802_11_NETWORK_INFRASTRUCTURE networktype); +void r8712_setopmode_cmd (struct _adapter *padapter,enum NDIS_802_11_NETWORK_INFRASTRUCTURE networktype);int r8712_setdatarate_cmd (struct _adapter *padapter,u8 *rateset);void r8712_set_chplan_cmd (struct _adapter *padapter,int chplan);int r8712_getrfreg_cmd (struct _adapter *padapter,u8 offset,u8 *pval);int r8712_setrfreg_cmd (struct _adapter *padapter,u8 offset,u32 val);void r8712_addbareq_cmd (struct _adapter *padapter,u8 tid);void r8712_wdg_wk_cmd (struct _adapter *padapter); -void r8712_survey_cmd_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_disassoc_cmd_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_joinbss_cmd_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_createbss_cmd_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_getbbrfreg_cmdrsp_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_readtssi_cmdrsp_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_setstaKey_cmdrsp_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_setassocsta_cmdrsp_callback (struct _adapter *padapter, -struct cmd_obj *pcmd); -void r8712_disconnectCtrlEx_cmd (struct _adapter *adapter,u32 enableDrvCtrl, -u32 tryPktCnt,u32 tryPktInterval,u32 firstStageTO); +void r8712_survey_cmd_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_disassoc_cmd_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_joinbss_cmd_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_createbss_cmd_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_getbbrfreg_cmdrsp_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_readtssi_cmdrsp_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_setstaKey_cmdrsp_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_setassocsta_cmdrsp_callback (struct _adapter *padapter,struct cmd_obj *pcmd); +void r8712_disconnectCtrlEx_cmd (struct _adapter *adapter,u32 enableDrvCtrl,u32 tryPktCnt, +u32 tryPktInterval,u32 firstStageTO);struct _cmd_callback {u32 cmd_code;
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +74 -129
482 lines not on this page · raw message
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerQuoted 1 line · Ryan England
Made corrections given we have 100 lines. Thanks for the update.
Why is this in the changelog text now? As per the documentation, something like this should go below the --- line, as my bot says:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
thanks,
greg k-h