Skip to contentSkip to conversation

Revert "md: fix a crash in mempool_free"

PATCH New [email protected] 1 participant 1 message Dec 22, 2023 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "md: fix a crash in mempool_free"

From: Ulrich Hecht <[email protected]>

This reverts commit a8e2077ebc799a5fc55c369d4a4e41ba05534fb6, which is commit cf06b162f5b6337b688072a1a47941280b8f7110 upstream.

The patch has been applied twice:

779785788a82f md: fix a crash in mempool_free
a8e2077ebc799 md: fix a crash in mempool_free

This reverts the second variant which has been mangled and causes a crash when using raid1.

Fixes a8e2077ebc79 ("md: fix a crash in mempool_free")

---

Alexander, could you do us the favor of testing this again to make sure that the removal of the rdev_dec_pending() call doesn't cause any issues? Thanks.

CU
Uli

 drivers/md/md.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/md/md.c +0 -4
index 09e1b21460470..67bfdd95e9d4a 100644
@@ -736,10 +736,6 @@ static void super_written(struct bio *bio)
 
 	bio_put(bio);
 
-	bio_put(bio);
-
-	rdev_dec_pending(rdev, mddev);
-
 	if (atomic_dec_and_test(&mddev->pending_writes))
 		wake_up(&mddev->sb_wait);
 }
Signature · 1 line
2.39.2