Skip to contentSkip to conversation

dts: rockpro64: Disable usb regulators-always-on

PATCH In review Shantur Rathore 2 participants 2 messages Dec 22, 2023 – Jan 18, 2024 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dts: rockpro64: Disable usb regulators-always-on

USB port regulators should be controlled by PHYs so we remove always-on property and let phy manage the regulator.

phy-supply isn't configured for TypeC port in upstream and now that we are removing always-on, we need to add the phy-supply until its fixed upstream.

---

Changes in v4:
- otg port must be configured with phy-supply instead of host port node

Changes in v3:
- Split up patches as seperate series

Changes in v2:
- As requested, added fix for regulator-always-on in RockPro64

 arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +12 -0
index 732727d9b0..0ac9fa9a03 100644
@@ -22,6 +22,18 @@
 	};
 };
 
+&u2phy0_otg {
+	phy-supply = <&vcc5v0_typec>;
+};
+
+&vcc5v0_host {
+	/delete-property/ regulator-always-on;
+};
+
+&vcc5v0_typec {
+	/delete-property/ regulator-always-on;
+};
+
 &vdd_center {
 	regulator-min-microvolt = <950000>;
 	regulator-max-microvolt = <950000>;
Signature · 1 line
2.40.1
#1 lore raw

Hi Shantur,

    Since you are working on the dts change in mainline kernel, you can sync the dts after kernel apply.

This patch will be dropped.

Thanks,

- Kever

Quoted 47 lines · Shantur Rathore

USB port regulators should be controlled by PHYs so we remove always-on property and let phy manage the regulator.

phy-supply isn't configured for TypeC port in upstream and now that we are removing always-on, we need to add the phy-supply until its fixed upstream.

---

Changes in v4:
- otg port must be configured with phy-supply instead of host port node

Changes in v3:
- Split up patches as seperate series

Changes in v2:
- As requested, added fix for regulator-always-on in RockPro64

  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 12 ++++++++++++
  1 file changed, 12 insertions(+)
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi +12 -0
index 732727d9b0..0ac9fa9a03 100644
@@ -22,6 +22,18 @@
  	};
  };
 
+&u2phy0_otg {
+	phy-supply = <&vcc5v0_typec>;
+};
+
+&vcc5v0_host {
+	/delete-property/ regulator-always-on;
+};
+
+&vcc5v0_typec {
+	/delete-property/ regulator-always-on;
+};
+
  &vdd_center {
  	regulator-min-microvolt = <950000>;
  	regulator-max-microvolt = <950000>;