Skip to contentSkip to conversation

staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h

PATCH Superseded Dipendra Khadka 3 participants 6 messages Dec 23, 2023

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +2 -2
index d6e52b4971d6..1dc2085ecd61 100644
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
 		memory_offsets;  /** offset wrt hdr in bytes */
 	u32 prog_name_offset;  /** offset wrt hdr in bytes */
 	u32 size;			/** Size of blob */
-	u32 padding_size;	/** total cummulative of bytes added due to section alignment */
+	u32 padding_size;	/** total cumulative of bytes added due to section alignment */
 	u32 icache_source;	/** Position of icache in blob */
 	u32 icache_size;	/** Size of icache section */
 	u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {
Signature · 1 line
2.39.2 (Apple Git-143)
Acked-by on v2 1/1
#1 lore raw

Hi Dipendra,

Quoted 11 lines · Dipendra Khadka

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

This patch is an improvement so it could be merged as is IMO. But...

Quoted 14 lines

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +0 -0
index d6e52b4971d6..1dc2085ecd61 100644

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_blob_info { · line 87

Quoted 5 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
 		memory_offsets;  /** offset wrt hdr in bytes */
 	u32 prog_name_offset;  /** offset wrt hdr in bytes */
 	u32 size;			/** Size of blob */
-	u32 padding_size;	/** total cummulative of bytes added due to section alignment */
+	u32 padding_size;	/** total cumulative of bytes added due to section alignment */

I apologize for not looking at your v1 patch carefully. The comment above would be much better as

				/** total accumulation of bytes added due to section alignment */

And if the maintainer(s) want to take it as is:

Thanks.

Quoted 12 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
 	u32 icache_source;	/** Position of icache in blob */
 	u32 icache_size;	/** Size of icache section */
 	u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {
Signature · 3 lines
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
#2 lore raw

Hi Randy,

Quoted 42 lines · Randy Dunlap

Hi Dipendra,

Quoted 11 lines · Dipendra Khadka

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

This patch is an improvement so it could be merged as is IMO. But...

Quoted 14 lines

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +0 -0
index d6e52b4971d6..1dc2085ecd61 100644

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_blob_info { · line 87

Quoted 5 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
              memory_offsets;  /** offset wrt hdr in bytes */
      u32 prog_name_offset;  /** offset wrt hdr in bytes */
      u32 size;                       /** Size of blob */
-     u32 padding_size;       /** total cummulative of bytes added due to section alignment */
+     u32 padding_size;       /** total cumulative of bytes added due to section alignment */

I apologize for not looking at your v1 patch carefully. The comment above would be much better as

Quoted 2 lines
                                /** total accumulation of bytes added due to section alignment */

So, would you like me to change "cummulative" to accumulation or should I wait what other maintainer(s) would say?

Thanks.

Quoted 23 lines

And if the maintainer(s) want to take it as is:

Thanks.

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_acc_sp { · line 414

Quoted 12 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
      u32 icache_source;      /** Position of icache in blob */
      u32 icache_size;        /** Size of icache section */
      u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

#3 lore raw
Quoted 45 lines · Dipendra Khadka

Hi Randy,

Quoted 42 lines · Randy Dunlap

Hi Dipendra,

Quoted 11 lines · Dipendra Khadka

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

This patch is an improvement so it could be merged as is IMO. But...

Quoted 14 lines

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +0 -0
index d6e52b4971d6..1dc2085ecd61 100644

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_blob_info { · line 87

Quoted 5 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
              memory_offsets;  /** offset wrt hdr in bytes */
      u32 prog_name_offset;  /** offset wrt hdr in bytes */
      u32 size;                       /** Size of blob */
-     u32 padding_size;       /** total cummulative of bytes added due to section alignment */
+     u32 padding_size;       /** total cumulative of bytes added due to section alignment */

I apologize for not looking at your v1 patch carefully. The comment above would be much better as

Quoted 6 lines
Quoted 2 lines
                                /** total accumulation of bytes added due to section alignment */

So, would you like me to change "cummulative" to accumulation or should I wait what other maintainer(s) would say?

I think just wait for a few days to see what other review comments there are.

Quoted 24 lines
Quoted 24 lines

And if the maintainer(s) want to take it as is:

Thanks.

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_acc_sp { · line 414

Quoted 12 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
      u32 icache_source;      /** Position of icache in blob */
      u32 icache_size;        /** Size of icache section */
      u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

Signature · 3 lines
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
#4 lore raw
In reply to Randy Dunlap

Hi,

Quoted 41 lines · Randy Dunlap

Hi Dipendra,

Quoted 11 lines · Dipendra Khadka

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

This patch is an improvement so it could be merged as is IMO. But...

Quoted 14 lines

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +0 -0
index d6e52b4971d6..1dc2085ecd61 100644

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_blob_info { · line 87

Quoted 5 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
 		memory_offsets;  /** offset wrt hdr in bytes */
 	u32 prog_name_offset;  /** offset wrt hdr in bytes */
 	u32 size;			/** Size of blob */
-	u32 padding_size;	/** total cummulative of bytes added due to section alignment */
+	u32 padding_size;	/** total cumulative of bytes added due to section alignment */

I apologize for not looking at your v1 patch carefully. The comment above would be much better as

Quoted 1 line
				/** total accumulation of bytes added due to section alignment */

I agree that that is better. Dipendra can you please send a v3 using the new text suggested by Randy ?

Regards,

Hans

Quoted 13 lines
Quoted 12 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
 	u32 icache_source;	/** Position of icache in blob */
 	u32 icache_size;	/** Size of icache section */
 	u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {
#5 lore raw

Hi,

Quoted 45 lines · Hans de Goede

Hi,

Quoted 41 lines · Randy Dunlap

Hi Dipendra,

Quoted 11 lines · Dipendra Khadka

codespell reported spelling mistakes in
ia_css_acc_types.h as below:

'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''

This patch fixes these spelling mistakes.

This patch is an improvement so it could be merged as is IMO. But...

Quoted 14 lines

---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/[email protected]/

 drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +0 -0
index d6e52b4971d6..1dc2085ecd61 100644

drivers/staging/media/atomisp/pci/ia_css_acc_types.h struct ia_css_blob_info { · line 87

Quoted 5 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
             memory_offsets;  /** offset wrt hdr in bytes */
     u32 prog_name_offset;  /** offset wrt hdr in bytes */
     u32 size;                       /** Size of blob */
-    u32 padding_size;       /** total cummulative of bytes added due to section alignment */
+    u32 padding_size;       /** total cumulative of bytes added due to section alignment */

I apologize for not looking at your v1 patch carefully. The comment above would be much better as

Quoted 4 lines
Quoted 1 line
                              /** total accumulation of bytes added due to section alignment */

I agree that that is better. Dipendra can you please send a v3 using the new text suggested by Randy ?

Sure,let me send a v3 with the new text suggested by Randy.

Regards,

Dipendra

Quoted 21 lines

Regards,

Hans

Quoted 13 lines
Quoted 12 lines
drivers/staging/media/atomisp/pci/ia_css_acc_types.h +1 -1
     u32 icache_source;      /** Position of icache in blob */
     u32 icache_size;        /** Size of icache section */
     u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
 };
 
 /* Acceleration firmware descriptor.
-  * This descriptor descibes either SP code (stand-alone), or
+  * This descriptor describes either SP code (stand-alone), or
   * ISP code (a separate pipeline stage).
   */
 struct ia_css_acc_fw_hdr {