Skip to contentSkip to conversation

arm64: dts: rockchip: support poweroff on rock-5b

PATCH Superseded John Clark 2 participants 11 messages Dec 25, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

John Clark

author
#0 lore raw

PATCH 1/2 arm64: dts: rockchip: support poweroff on rock-5b

Allow the rock-5b to poweroff its pmic.

related: c699fbfdfd54630fc51b96da577f02e7b772eb37

---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +2 -0
index 74719aaf697c..dc7b88f29172 100644
@@ -426,6 +426,8 @@ pmic@0 {
 		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
 			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
 
+		system-power-controller;
+
 		vcc1-supply = <&vcc5v0_sys>;
 		vcc2-supply = <&vcc5v0_sys>;
 		vcc3-supply = <&vcc5v0_sys>;
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author
#1 lore raw

PATCH 1/2 arm64: dts: rockchip: support poweroff on the rock-5b

Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead.

Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this issue for the nanopc-t6.

---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +2 -0
index 74719aaf697c..dc7b88f29172 100644
@@ -426,6 +426,8 @@ pmic@0 {
 		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
 			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
 
+		system-power-controller;
+
 		vcc1-supply = <&vcc5v0_sys>;
 		vcc2-supply = <&vcc5v0_sys>;
 		vcc3-supply = <&vcc5v0_sys>;
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author
#2 lore raw

PATCH 2/2 arm64: dts: rockchip: correct gpio_pwrctrl1 typo

gpio_pwrctrl2 is duplicated twice and gpio_pwrctrl1 is not set. Set gpio_pwrctrl1.

---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +1 -1
index dc7b88f29172..a0e303c3a1dc 100644
@@ -448,7 +448,7 @@ pmic@0 {
 		#gpio-cells = <2>;
 
 		rk806_dvs1_null: dvs1-null-pins {
-			pins = "gpio_pwrctrl2";
+			pins = "gpio_pwrctrl1";
 			function = "pin_fun0";
 		};
 
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#3 lore raw

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

In reply to John Clark
Quoted 6 lines · John Clark

Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead.

Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this issue for the nanopc-t6.

That's not the syntax I asked for. Where is its subject? Syntax is:
commit foo ("subject"), respecting the length of SHA, as checked by checkpatch.

You still miss v2 and changelog. I also wrote about this. b4 does it for you, but if you decide to use git manually, then you have to add it.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author
#4 lore raw

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · John Clark

Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead.

Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this issue for the nanopc-t6.

That's not the syntax I asked for. Where is its subject? Syntax is:
commit foo ("subject"), respecting the length of SHA, as checked by checkpatch.

Quoted 6 lines

You still miss v2 and changelog. I also wrote about this. b4 does it for you, but if you decide to use git manually, then you have to add it.

Best regards,
Krzysztof

The documentation for  --in-reply-to=<identifier> clearly states that it will generate the v2 semantics for the subject, yet it did not.  I used the message-id from the first message since it was a two email patch to begin with.  It is not clear to me why this did not happen.  I will see if I can find a sandbox to practice my get-send-email skills in.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#5 lore raw

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

Quoted 12 lines · John Clark
Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · John Clark

Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead.

Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this issue for the nanopc-t6.

That's not the syntax I asked for. Where is its subject? Syntax is:
commit foo ("subject"), respecting the length of SHA, as checked by checkpatch.

Quoted 7 lines
Quoted 6 lines

You still miss v2 and changelog. I also wrote about this. b4 does it for you, but if you decide to use git manually, then you have to add it.

Best regards,
Krzysztof

The documentation for  --in-reply-to=<identifier> clearly states that it

No, it does not state that.

Quoted 1 line

will generate the v2 semantics for the subject, yet it did not.  I used

Because it doesn't...

Quoted 1 line

the message-id from the first message since it was a two email patch to

Which you should not. Each submission is its own thread, which is already expressed:

https://elixir.bootlin.com/linux/v6.7-rc7/source/Documentation/process/submitting-patches.rst#L782

Quoted 2 lines

begin with.  It is not clear to me why this did not happen.  I will see if I can find a sandbox to practice my get-send-email skills in.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author
#7 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 3 lines · John Clark

Allow the rock-5b to poweroff its pmic.

related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Reference commits how checkpatch and submitting-patches ask - commit foo ("bar") and explain what is "related".

Best regards,
Krzysztof

When issuing a "shutdown -h now" on the rock-5b it reboots instead.  Using the 'system-power-controller' allows the rk806 to power down instead.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#8 lore raw
Quoted 5 lines · John Clark
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · John Clark

Allow the rock-5b to poweroff its pmic.

related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Quoted 8 lines
Quoted 6 lines

Reference commits how checkpatch and submitting-patches ask - commit foo ("bar") and explain what is "related".

Best regards,
Krzysztof

When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead.

I meant, explain in the commit msg.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author
#9 lore raw

PATCH 2/2 arm64: dts: rockchip: correct gpio_pwrctrl1 typo

In reply to John Clark
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +1 -1
index dc7b88f29172..a0e303c3a1dc 100644
@@ -448,7 +448,7 @@ pmic@0 {
 		#gpio-cells = <2>;
 
 		rk806_dvs1_null: dvs1-null-pins {
-			pins = "gpio_pwrctrl2";
+			pins = "gpio_pwrctrl1";
 			function = "pin_fun0";
 		};
 
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip