arm64: dts: rockchip: support poweroff on the rock-5b
Subsystems (2)
PATCH v2 1/2 arm64: dts: rockchip: support poweroff on the rock-5b
Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Defining 'system-power-controller' allows the rk806 to power down.
Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on NanoPC-T6") similarly resolves this issue for the nanopc-t6.
---
Changes since v1:
- added commit message with additional patch detail
- expressed the related commit using checkpatch
--- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +2 -0
@@ -426,6 +426,8 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; + system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;
Signature · 1 line
2.43.0
PATCH v2 2/2 arm64: dts: rockchip: correct gpio_pwrctrl1 typo
Both rk806_dvs1_null and rk806_dvs2_null duplicate gpio_pwrctrl2 and gpio_pwrctrl1 is not set. This patch sets gpio_pwrctrl1.
---
Changes since v1:
- added commit message with additional patch detail
--- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +1 -1
@@ -448,7 +448,7 @@ pmic@0 { #gpio-cells = <2>; rk806_dvs1_null: dvs1-null-pins { - pins = "gpio_pwrctrl2"; + pins = "gpio_pwrctrl1"; function = "pin_fun0"; };
Signature · 1 line
2.43.0
Re: [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo
Hi,
Quoted 9 lines · John Clark
Both
rk806_dvs1_nullandrk806_dvs2_nullduplicategpio_pwrctrl2andgpio_pwrctrl1is not set. This patch setsgpio_pwrctrl1.Signed-off-by John Clark <[email protected]>---
Changes since v1:
- added commit message with additional patch detail---
-- Sebastian
Quoted 20 lines
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +1
-1@@ -448,7 +448,7 @@ pmic@0 { #gpio-cells = <2>; rk806_dvs1_null: dvs1-null-pins { - pins = "gpio_pwrctrl2"; + pins = "gpio_pwrctrl1"; function = "pin_fun0"; };Signature · 1 line
2.43.0
Hi,
Quoted 9 lines · John Clark
Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Defining 'system-power-controller' allows the rk806 to power down.
Commit
c699fbfdfd54("arm64: dts: rockchip: Support poweroff on NanoPC-T6") similarly resolves this issue for the nanopc-t6.Signed-off-by John Clark <[email protected]>---
-- Sebastian
Quoted 25 lines
Changes since v1:
- added commit message with additional patch detail
- expressed the related commit using checkpatch--- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +2
-0@@ -426,6 +426,8 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; + system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;Signature · 1 line
2.43.0
Quoted 8 lines · John Clark
Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Defining 'system-power-controller' allows the rk806 to power down.
Commit
c699fbfdfd54("arm64: dts: rockchip: Support poweroff on NanoPC-T6") similarly resolves this issue for the nanopc-t6.[...]
Applied, thanks!
[1/2] arm64: dts: rockchip: support poweroff on the rock-5b
commit: 7738f551173540b3daa63a91b384b167eacd24fd
[2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo
commit: aed6514c4e3aee843385ded4c5ee0921b51c30faBest regards,
Signature · 1 line
Heiko Stuebner <[email protected]>