Skip to contentSkip to conversation

tests/kms_lease: Cache xe_device info for lease fd

PATCH Superseded Mohammed Thasleem 3 participants 8 messages Dec 12, 2023 – Dec 26, 2023

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_lease: Cache xe_device info for lease fd

Cache xe_device struct info for lease fd before perpare crtc with lessee's fd.

---
 tests/kms_lease.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
tests/kms_lease.c +10 -0
index 8ac58af38..e57aea2a2 100644
@@ -48,6 +48,8 @@
 
 #include <drm.h>
 #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
 
 /**
  * SUBTEST: atomic-implicit-crtc
@@ -305,6 +307,10 @@ static void simple_lease(data_t *data)
 	/* Create a valid lease */
 	igt_assert_eq(make_lease(data), 0);
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
 	igt_display_require(&data->lease.display, data->lease.fd);
 
 	/* Set a mode on the leased output */
@@ -772,6 +778,10 @@ static void lease_revoke(data_t *data)
 	/* Create a valid lease */
 	igt_assert_eq(make_lease(data), 0);
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
 	igt_display_require(&data->lease.display, data->lease.fd);
 
 	/* try to revoke an invalid lease */
Signature · 1 line
2.25.1
#1 lore raw

✗ Fi.CI.BAT: failure for tests/kms_lease: Cache xe_device info for lease fd

== Series Details ==

== Series Details ==

Series: tests/kms_lease: Cache xe_device info for lease fd
URL : https://patchwork.freedesktop.org/series/127676/
State : failure

== Summary ==

CI Bug Log - changes from IGT_7636 -> IGTPW_10402
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_10402 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10402, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/index.html

Participating hosts (36 -> 34)
------------------------------

Additional (1): bat-kbl-2
Missing (3): fi-bsw-n3050 fi-snb-2520m fi-pnv-d510

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_10402:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- bat-adlp-9: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-9/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-9/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-adlp-11: [PASS][3] -> [SKIP][4] +5 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-11: NOTRUN -> [SKIP][5] +8 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

#### Warnings ####

* igt@kms_dsc@dsc-basic:
- bat-adlp-11: [SKIP][6] ([i915#3555] / [i915#3840]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_10402 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@fbdev@info:
- bat-adlp-11: [PASS][8] -> [SKIP][9] ([i915#1849] / [i915#2582])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]
- bat-kbl-2: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1849])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-kbl-2/igt@[email protected]

* igt@fbdev@nullptr:
- bat-adlp-11: [PASS][11] -> [SKIP][12] ([i915#2582]) +3 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-dg2-8: NOTRUN -> [INCOMPLETE][13] ([i915#9275])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-dg2-8/igt@gem_exec_suspend@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-kbl-2: NOTRUN -> [SKIP][14] ([fdo#109271]) +36 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-kbl-2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-adlp-11: NOTRUN -> [SKIP][15] ([i915#4613]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-adlp-11: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- bat-adlp-11: NOTRUN -> [SKIP][17] ([i915#3637]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-11: [PASS][18] -> [SKIP][19] ([i915#4342] / [i915#5354])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][20] ([i915#8668])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-rplp-1/igt@kms_pm_backlight@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-11: NOTRUN -> [SKIP][21] ([i915#3555])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- bat-adlp-11: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#3708])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-11: NOTRUN -> [SKIP][23] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg2-9: [INCOMPLETE][24] ([i915#9275]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-dg2-9/igt@gem_exec_suspend@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-dg2-9/igt@gem_exec_suspend@[email protected]

* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg2-8: [INCOMPLETE][26] ([i915#9275]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-dg2-8/igt@gem_exec_suspend@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-dg2-8/igt@gem_exec_suspend@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][28] ([i915#8668]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pm_rpm@basic-pci-d3-state:
- bat-adlp-11: [ABORT][30] ([i915#8668]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

#### Warnings ####

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-11: [SKIP][32] ([i915#4103] / [i915#5608]) -> [SKIP][33] ([i915#5608]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7636/bat-adlp-11/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/bat-adlp-11/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7636 -> IGTPW_10402

CI-20190529: 20190529
CI_DRM_14010: b4182ec1538e8cebf630083ec4296bed0061d594 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10402: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/index.html
IGT_7636: 7636

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/index.html

#2 lore raw

✓ CI.xeBAT: success for tests/kms_lease: Cache xe_device info for lease fd

In reply to Mohammed Thasleem
== Series Details ==

== Series Details ==

Series: tests/kms_lease: Cache xe_device info for lease fd
URL : https://patchwork.freedesktop.org/series/127676/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7636_BAT -> XEIGTPW_10402_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (1 -> 4)
------------------------------

Additional (3): bat-pvc-2 bat-dg2-oem2 bat-atsm-2

Known issues
------------

Here are the changes found in XEIGTPW_10402_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-pvc-2: NOTRUN -> [SKIP][1] ([i915#6077]) +30 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-oem2: NOTRUN -> [SKIP][2] ([Intel XE#623])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@kms_addfb_basic@invalid-set-prop-any:
- bat-atsm-2: NOTRUN -> [SKIP][3] ([i915#6077]) +30 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-pvc-2: NOTRUN -> [SKIP][4] ([Intel XE#1024] / [Intel XE#782]) +5 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- bat-atsm-2: NOTRUN -> [SKIP][5] ([Intel XE#1024] / [Intel XE#782]) +5 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-atsm-2: NOTRUN -> [SKIP][6] ([Intel XE#1024] / [Intel XE#784])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]
- bat-pvc-2: NOTRUN -> [SKIP][7] ([Intel XE#1024] / [Intel XE#784])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]
- bat-dg2-oem2: NOTRUN -> [SKIP][8] ([Intel XE#423])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- bat-pvc-2: NOTRUN -> [SKIP][9] ([Intel XE#1024] / [Intel XE#947]) +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-modeset:
- bat-atsm-2: NOTRUN -> [SKIP][10] ([Intel XE#1024] / [Intel XE#947]) +3 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
- bat-adlp-7: [PASS][11] -> [FAIL][12] ([Intel XE#480])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7636/bat-adlp-7/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-adlp-7/igt@kms_flip@[email protected]

* igt@kms_force_connector_basic@force-connector-state:
- bat-pvc-2: NOTRUN -> [SKIP][13] ([Intel XE#540]) +3 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]
- bat-atsm-2: NOTRUN -> [SKIP][14] ([Intel XE#540]) +3 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-oem2: NOTRUN -> [SKIP][15] ([i915#5274])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-pvc-2: NOTRUN -> [SKIP][16] ([Intel XE#1024] / [Intel XE#783])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]
- bat-dg2-oem2: NOTRUN -> [FAIL][17] ([Intel XE#608])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]
- bat-atsm-2: NOTRUN -> [SKIP][18] ([Intel XE#1024] / [Intel XE#783])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- bat-dg2-oem2: NOTRUN -> [FAIL][19] ([Intel XE#400] / [Intel XE#616]) +2 other tests fail
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- bat-atsm-2: NOTRUN -> [SKIP][20] ([i915#1836]) +6 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-pvc-2: NOTRUN -> [SKIP][21] ([Intel XE#829]) +6 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@kms_prop_blob@basic:
- bat-pvc-2: NOTRUN -> [SKIP][22] ([Intel XE#780])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]
- bat-atsm-2: NOTRUN -> [SKIP][23] ([Intel XE#780])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@xe_compute@compute-square:
- bat-atsm-2: NOTRUN -> [SKIP][24] ([Intel XE#672])
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]
- bat-dg2-oem2: NOTRUN -> [SKIP][25] ([Intel XE#672])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@xe_create@create-execqueues-leak:
- bat-atsm-2: NOTRUN -> [FAIL][26] ([Intel XE#524]) +1 other test fail
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@xe_create@create-execqueues-noleak:
- bat-adlp-7: [PASS][27] -> [FAIL][28] ([Intel XE#524])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7636/bat-adlp-7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-adlp-7/igt@[email protected]

* igt@xe_evict@evict-beng-small-external:
- bat-pvc-2: NOTRUN -> [FAIL][29] ([Intel XE#1000]) +3 other tests fail
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_evict@evict-small-cm:
- bat-pvc-2: NOTRUN -> [DMESG-FAIL][30] ([Intel XE#482]) +3 other tests dmesg-fail
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_evict_ccs@evict-overcommit-parallel-nofree-samefd:
- bat-pvc-2: NOTRUN -> [INCOMPLETE][31] ([Intel XE#392])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_exec_fault_mode@many-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][32] ([Intel XE#288]) +32 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@xe_exec_fault_mode@twice-userptr-invalidate-imm:
- bat-atsm-2: NOTRUN -> [SKIP][33] ([Intel XE#288]) +32 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]

* igt@xe_huc_copy@huc_copy:
- bat-pvc-2: NOTRUN -> [SKIP][34] ([Intel XE#255])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@xe_huc_copy@huc_copy.html
- bat-dg2-oem2: NOTRUN -> [SKIP][35] ([Intel XE#255])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html
- bat-atsm-2: NOTRUN -> [SKIP][36] ([Intel XE#255])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@xe_huc_copy@huc_copy.html

* igt@xe_intel_bb@render:
- bat-pvc-2: NOTRUN -> [SKIP][37] ([Intel XE#532])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_module_load@load:
- bat-pvc-2: NOTRUN -> [SKIP][38] ([Intel XE#378])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_pat@pat-index-xe2:
- bat-pvc-2: NOTRUN -> [SKIP][39] ([Intel XE#977]) +1 other test skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]
- bat-atsm-2: NOTRUN -> [SKIP][40] ([Intel XE#977])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]
- bat-dg2-oem2: NOTRUN -> [SKIP][41] ([Intel XE#977])
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@xe_pat@pat-index-xehpc:
- bat-dg2-oem2: NOTRUN -> [SKIP][42] ([Intel XE#979]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-dg2-oem2/igt@[email protected]

* igt@xe_pat@pat-index-xelpg:
- bat-atsm-2: NOTRUN -> [SKIP][43] ([Intel XE#979]) +1 other test skip
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@[email protected]
- bat-pvc-2: NOTRUN -> [SKIP][44] ([Intel XE#979])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_pm_residency@gt-c6-on-idle:
- bat-pvc-2: NOTRUN -> [SKIP][45] ([Intel XE#531])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@[email protected]

* igt@xe_prime_self_import@basic-with_one_bo:
- bat-atsm-2: NOTRUN -> [FAIL][46] ([Intel XE#999])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-atsm-2/igt@xe_prime_self_import@basic-with_one_bo.html
- bat-pvc-2: NOTRUN -> [FAIL][47] ([Intel XE#999]) +1 other test fail
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- bat-adlp-7: [FAIL][48] ([Intel XE#480]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7636/bat-adlp-7/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-adlp-7/igt@kms_flip@[email protected]

#### Warnings ####

* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-7: [DMESG-WARN][50] ([Intel XE#282] / [i915#2017]) -> [DMESG-FAIL][51] ([Intel XE#1033] / [i915#2017])
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7636/bat-adlp-7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/bat-adlp-7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#1000]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1000
[Intel XE#1021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1021
[Intel XE#1024]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1024
[Intel XE#1033]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1033
[Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
[Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/392
[Intel XE#400]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/400
[Intel XE#423]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/423
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/482
[Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524
[Intel XE#531]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/531
[Intel XE#532]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/532
[Intel XE#540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/540
[Intel XE#608]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/608
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
[Intel XE#672]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/672
[Intel XE#780]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/780
[Intel XE#782]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/782
[Intel XE#783]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/783
[Intel XE#784]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/784
[Intel XE#829]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/829
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#947]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/947
[Intel XE#976]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/976
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
[Intel XE#999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/999
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077

Build changes
-------------

* IGT: IGT_7636 -> IGTPW_10402

IGTPW_10402: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10402/index.html
IGT_7636: 7636
xe-570-0c30a1b58ce6096e5d6a6c9ba32961c345fab7c8: 0c30a1b58ce6096e5d6a6c9ba32961c345fab7c8

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10402/index.html

#3 lore raw
In reply to Mohammed Thasleem
Quoted 2 lines · Mohammed Thasleem

Cache xe_device struct info for lease fd before perpare crtc with lessee's fd.

I think we should add why this is required for this test.

Quoted 20 lines
---
  tests/kms_lease.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
tests/kms_lease.c +2 -0
index 8ac58af38..e57aea2a2 100644
@@ -48,6 +48,8 @@
 
  #include <drm.h>
  #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
 
  /**
   * SUBTEST: atomic-implicit-crtc

tests/kms_lease.c static void simple_lease(data_t *data) · line 312

Quoted 6 lines
tests/kms_lease.c +3 -0
@@ -305,6 +307,10 @@ static void simple_lease(data_t *data)
  	/* Create a valid lease */
  	igt_assert_eq(make_lease(data), 0);
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);

I wonder this will be required for other subtests too.

I think we should call this in make_lease(), after create_lease() is successful and we get file descriptor for the lease.

Regards,

Ankit

Quoted 15 lines
tests/kms_lease.c +5 -0
+
  	igt_display_require(&data->lease.display, data->lease.fd);
 
  	/* Set a mode on the leased output */
@@ -772,6 +778,10 @@ static void lease_revoke(data_t *data)
  	/* Create a valid lease */
  	igt_assert_eq(make_lease(data), 0);
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
  	igt_display_require(&data->lease.display, data->lease.fd);
 
  	/* try to revoke an invalid lease */
#4 lore raw
Quoted 35 lines · Ankit K
Quoted 2 lines · Mohammed Thasleem

Cache xe_device struct info for lease fd before perpare crtc with lessee's fd.

I think we should add why this is required for this test.

Quoted 20 lines

---
  tests/kms_lease.c | 10 ++++++++++

  1 file changed, 10 insertions(+)
tests/kms_lease.c +2 -0
index 8ac58af38..e57aea2a2 100644
@@ -48,6 +48,8 @@
     #include <drm.h>
   #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
     /**
    * SUBTEST: atomic-implicit-crtc
@@ -305,6 +307,10 @@ static void simple_lease(data_t *data)
       /* Create a valid lease */
       igt_assert_eq(make_lease(data), 0);
Quoted 3 lines

  +    /* Cache xe_device struct */
+    if (is_xe_device(data->lease.fd))
+        xe_device_get(data->lease.fd);

I wonder this will be required for other subtests too.

Quoted 1 line

I think we should call this in make_lease(), after create_lease() is successful and we get file descriptor for the lease.

Missed to mention, we also need to remove it with xe_device_put, while terminating the lease.

Regards,

Ankit

Quoted 20 lines

Regards,

Ankit

Quoted 12 lines

+
      igt_display_require(&data->lease.display, data->lease.fd); /* Set a mode on the leased output */

tests/kms_lease.c +0 -0
@@ -772,6 +778,10 @@ static void lease_revoke(data_t *data)
       /* Create a valid lease */
       igt_assert_eq(make_lease(data), 0);

  +    /* Cache xe_device struct */
+    if (is_xe_device(data->lease.fd))
+        xe_device_get(data->lease.fd);
+
      igt_display_require(&data->lease.display, data->lease.fd); /* try to revoke an invalid lease */

#5 lore raw

PATCH v2 1/1 tests/kms_lease: Cache xe_device info for lease fd

In reply to Mohammed Thasleem

In case of xe device for lessor fd, the xe_device struct gets created and cached during drm_open. But for the lessee fd, the xe_device info struct is not created and cached.

This causes problem in prepare_crtc() for lessee with xe, which needs the xe_device info struct. So, create and cache the xe_device struct info for lease fd, when we make lease and remove it from cache while terminating the lease.

v2: -Update description and move logic to make_lease call. (Ankit)
-Add xe_device_put, while terminating the lease. (Ankit)

---
 tests/kms_lease.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
tests/kms_lease.c +10 -0
index 8ac58af38..f7531c803 100644
@@ -48,6 +48,8 @@
 
 #include <drm.h>
 #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
 
 /**
  * SUBTEST: atomic-implicit-crtc
@@ -267,12 +269,20 @@ static int make_lease(data_t *data)
 	if (ret)
 		return ret;
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
 	data->lease.lessee_id = mcl.lessee_id;
 	return 0;
 }
 
 static void terminate_lease(int lease_fd)
 {
+	/* Remove xe_device from cache. */
+	if (is_xe_device(lease_fd))
+		xe_device_put(lease_fd);
+
 	close(lease_fd);
 }
 
Signature · 1 line
2.25.1
#6 lore raw

PATCH v2 1/1 tests/kms_lease: Cache xe_device info for lease fd

In reply to Mohammed Thasleem

In case of xe device for lessor fd, the xe_device struct gets created and cached during drm_open. But for the lessee fd, the xe_device info struct is not created and cached.

This causes problem in prepare_crtc() for lessee with xe, which needs the xe_device info struct. So, create and cache the xe_device struct info for lease fd, when we make lease and remove it from cache while terminating the lease.

v2: -Update description and move logic to make_lease call. (Ankit)
-Add xe_device_put, while terminating the lease. (Ankit)

---
 tests/kms_lease.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
tests/kms_lease.c +10 -0
index 8ac58af38..f7531c803 100644
@@ -48,6 +48,8 @@
 
 #include <drm.h>
 #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
 
 /**
  * SUBTEST: atomic-implicit-crtc
@@ -267,12 +269,20 @@ static int make_lease(data_t *data)
 	if (ret)
 		return ret;
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
 	data->lease.lessee_id = mcl.lessee_id;
 	return 0;
 }
 
 static void terminate_lease(int lease_fd)
 {
+	/* Remove xe_device from cache. */
+	if (is_xe_device(lease_fd))
+		xe_device_put(lease_fd);
+
 	close(lease_fd);
 }
 
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#7 lore raw
Quoted 9 lines · Mohammed Thasleem

In case of xe device for lessor fd, the xe_device struct gets created and cached during drm_open. But for the lessee fd, the xe_device info struct is not created and cached.

This causes problem in prepare_crtc() for lessee with xe, which needs the xe_device info struct. So, create and cache the xe_device struct info for lease fd, when we make lease and remove it from cache while terminating the lease.

Quoted 4 lines

v2: -Update description and move logic to make_lease call. (Ankit)
-Add xe_device_put, while terminating the lease. (Ankit)

LGTM.

Regards,

Ankit

Quoted 38 lines
---
  tests/kms_lease.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
tests/kms_lease.c +10 -0
index 8ac58af38..f7531c803 100644
@@ -48,6 +48,8 @@
 
  #include <drm.h>
  #include "igt_device.h"
+#include "xe_drm.h"
+#include "xe/xe_query.h"
 
  /**
   * SUBTEST: atomic-implicit-crtc
@@ -267,12 +269,20 @@ static int make_lease(data_t *data)
  	if (ret)
  		return ret;
 
+	/* Cache xe_device struct */
+	if (is_xe_device(data->lease.fd))
+		xe_device_get(data->lease.fd);
+
  	data->lease.lessee_id = mcl.lessee_id;
  	return 0;
  }
 
  static void terminate_lease(int lease_fd)
  {
+	/* Remove xe_device from cache. */
+	if (is_xe_device(lease_fd))
+		xe_device_put(lease_fd);
+
  	close(lease_fd);
  }