GenieZone hypervisor drivers
Subsystems (7)
v8 cover GenieZone hypervisor drivers
This series is based on linux-next, tag: next-20231222.
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports various virtual machine types and provides security features such as TEE-like scenarios and secure boot. It can create guest VMs for security use cases and has virtualization capabilities for both platform and interrupt. Although the hypervisor can be booted independently, it requires the assistance of GenieZone hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux kernel for vCPU scheduling, memory management, inter-VM communication and virtio backend support.
Changes in v8:
- Add reasons for using dt solution in dt-bindings.
- Add locks for memory pin/unpin and relinquish operations.
- Add VM memory stats in debugfs.
- Add tracing support for hypercall and vcpu exit reasons.
- Enable PTP for timing synchronization between host and guests.
- Optimize memory performance for protected VMs.
- Refactor wording and titles in documentation.
Changes in v7:
https://lore.kernel.org/all/[email protected]/
- Rebase these patches to the Linux 6.7-rc1 release.
- Refactor patches 1 to 15 to improve coding style while ensuring they do not violate the majority of the changes made in v6
- Provide individual VM memory statistics within debugfs in patch 16.
- Add tracing support for hyper call and vcpu exit_reason.
Changes in v6:
https://lore.kernel.org/all/[email protected]/
- Rebase based on kernel 6.6-rc1
- Keep dt solution and leave the reasons in the commit message
- Remove arch/arm64/include/uapi/asm/gzvm_arch.h due to simplicity
- Remove resampler in drivers/virt/geniezone/gzvm_irqfd.c due to defeature for now
- Remove PPI in arch/arm64/geniezone/vgic.c
- Refactor vm related components into 3 smaller patches, namely adding vm support, setting user memory region and checking vm capability
- Refactor vcpu and vm component to remove unnecessary ARM prefix
- Add demand paging to fix crash on destroying memory page, acclerate on booting and support ballooning deflate
- Add memory pin/unpin memory mechanism to support protected VM
- Add block-based demand paging for performance concern
- Response to reviewers and fix coding style accordingly
Changes in v5:
https://lore.kernel.org/all/[email protected]/
- Add dt solution back for device initialization
- Add GZVM_EXIT_GZ reason for gzvm_vcpu_run()
- Add patch for guest page fault handler
- Add patch for supporitng pin/unpin memory
- Remove unused enum members, namely GZVM_FUNC_GET_REGS and GZVM_FUNC_SET_REGS
- Use dev_debug() for debugging when platform device is available, and use pr_debug() otherwise
- Response to reviewers and fix bugs accordingly
Changes in v4:
https://lore.kernel.org/all/[email protected]/
- Add macro to set VM as protected without triggering pvmfw in AVF.
- Add support to pass dtb config to hypervisor.
- Add support for virtual timer.
- Add UAPI to pass memory region metadata to hypervisor.
- Define our own macros for ARM's interrupt number
- Elaborate more on GenieZone hyperivsor in documentation
- Fix coding style.
- Implement our own module for coverting ipa to pa
- Modify the way of initializing device from dt to a more discoverable way
- Move refactoring changes into indepedent patches.
Changes in v3:
https://lore.kernel.org/all/[email protected]/
- Refactor: separate arch/arm64/geniezone/gzvm_arch.c into vm.c/vcpu.c/vgic.c
- Remove redundant functions
- Fix reviewer's comments
Changes in v2:
https://lore.kernel.org/all/[email protected]/
- Refactor: move to drivers/virt/geniezone
- Refactor: decouple arch-dependent and arch-independent
- Check pending signal before entering guest context
- Fix reviewer's comments
Initial Commit in v1:
https://lore.kernel.org/all/[email protected]/
Yi-De Wu (20):
docs: geniezone: Introduce GenieZone hypervisor
dt-bindings: hypervisor: Add MediaTek GenieZone hypervisor
virt: geniezone: Add GenieZone hypervisor driver
virt: geniezone: Add vm support
virt: geniezone: Add set_user_memory_region for vm
virt: geniezone: Add vm capability check
virt: geniezone: Optimize performance of protected VM memory
virt: geniezone: Add vcpu support
virt: geniezone: Add irqchip support for virtual interrupt injection
virt: geniezone: Add irqfd support
virt: geniezone: Add ioeventfd support
virt: geniezone: Add memory region support
virt: geniezone: Add dtb config support
virt: geniezone: Add demand paging support
virt: geniezone: Add block-based demand paging support
virt: geniezone: Add memory pin/unpin support
virt: geniezone: Add memory relinquish support
virt: geniezone: Provide individual VM memory statistics within
debugfs
virt: geniezone: Add tracing support for hyp call and vcpu exit_reason
virt: geniezone: Enable PTP for synchronizing time between host and
guest VMs
.../hypervisor/mediatek,geniezone-hyp.yaml | 31 + Documentation/virt/geniezone/introduction.rst | 87 +++ Documentation/virt/index.rst | 1 + MAINTAINERS | 11 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/gzvm_arch_common.h | 122 ++++ arch/arm64/geniezone/hvc.c | 73 +++ arch/arm64/geniezone/vcpu.c | 80 +++ arch/arm64/geniezone/vgic.c | 50 ++ arch/arm64/geniezone/vm.c | 424 ++++++++++++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 12 + drivers/virt/geniezone/gzvm_common.h | 12 + drivers/virt/geniezone/gzvm_exception.c | 61 ++ drivers/virt/geniezone/gzvm_ioeventfd.c | 276 ++++++++ drivers/virt/geniezone/gzvm_irqfd.c | 382 +++++++++++ drivers/virt/geniezone/gzvm_main.c | 153 +++++ drivers/virt/geniezone/gzvm_mmu.c | 300 +++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 284 ++++++++ drivers/virt/geniezone/gzvm_vm.c | 608 ++++++++++++++++++ include/linux/gzvm_drv.h | 221 +++++++ include/trace/events/geniezone.h | 54 ++ include/uapi/linux/gzvm.h | 396 ++++++++++++ 25 files changed, 3666 insertions(+) create mode 100644 Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml create mode 100644 Documentation/virt/geniezone/introduction.rst create mode 100644 arch/arm64/geniezone/Makefile create mode 100644 arch/arm64/geniezone/gzvm_arch_common.h create mode 100644 arch/arm64/geniezone/hvc.c create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 arch/arm64/geniezone/vgic.c create mode 100644 arch/arm64/geniezone/vm.c create mode 100644 drivers/virt/geniezone/Kconfig create mode 100644 drivers/virt/geniezone/Makefile create mode 100644 drivers/virt/geniezone/gzvm_common.h create mode 100644 drivers/virt/geniezone/gzvm_exception.c create mode 100644 drivers/virt/geniezone/gzvm_ioeventfd.c create mode 100644 drivers/virt/geniezone/gzvm_irqfd.c create mode 100644 drivers/virt/geniezone/gzvm_main.c create mode 100644 drivers/virt/geniezone/gzvm_mmu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vm.c create mode 100644 include/linux/gzvm_drv.h create mode 100644 include/trace/events/geniezone.h create mode 100644 include/uapi/linux/gzvm.h
Signature · 1 line
2.18.0
PATCH v8 1/20 docs: geniezone: Introduce GenieZone hypervisor
From: "Yingshiuan Pan" <[email protected]>
GenieZone is MediaTek proprietary hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. It is a pure EL2 implementation which implies it does not rely any specific host VM, and this behavior improves GenieZone's security as it limits its interface.
--- Documentation/virt/geniezone/introduction.rst | 87 +++++++++++++++++++ Documentation/virt/index.rst | 1 + MAINTAINERS | 6 ++ 3 files changed, 94 insertions(+) create mode 100644 Documentation/virt/geniezone/introduction.rst
Documentation/virt/geniezone/introduction.rst new file +87 -0
@@ -0,0 +1,87 @@ +.. SPDX-License-Identifier: GPL-2.0 + +====================== +GenieZone Introduction +====================== + +Overview +======== +GenieZone hypervisor (gzvm) is a type-1 hypervisor that supports various virtual +machine types and provides security features such as TEE-like scenarios and +secure boot. It can create guest VMs for security use cases and has +virtualization capabilities for both platform and interrupt. Although the +hypervisor can be booted independently, it requires the assistance of GenieZone +hypervisor kernel driver(also named gzvm) to leverage the ability of Linux +kernel for vCPU scheduling, memory management, inter-VM communication and virtio +backend support. + +Supported Architecture +====================== +GenieZone now only supports MediaTek ARM64 SoC. + +Features +======== + +- vCPU Management + + VM manager aims to provide vCPUs on the basis of time sharing on physical + CPUs. It requires Linux kernel in host VM for vCPU scheduling and VM power + management. + +- Memory Management + + Direct use of physical memory from VMs is forbidden and designed to be + dictated to the privilege models managed by GenieZone hypervisor for security + reason. With the help of gzvm module, the hypervisor would be able to manipulate + memory as objects. + +- Virtual Platform + + We manage to emulate a virtual mobile platform for guest OS running on guest + VM. The platform supports various architecture-defined devices, such as + virtual arch timer, GIC, MMIO, PSCI, and exception watching...etc. + +- Inter-VM Communication + + Communication among guest VMs was provided mainly on RPC. More communication + mechanisms were to be provided in the future based on VirtIO-vsock. + +- Device Virtualization + + The solution is provided using the well-known VirtIO. The gzvm module would + redirect MMIO traps back to VMM where the virtual devices are mostly emulated. + Ioeventfd is implemented using eventfd for signaling host VM that some IO + events in guest VMs need to be processed. + +- Interrupt virtualization + + All Interrupts during some guest VMs running would be handled by GenieZone + hypervisor with the help of gzvm module, both virtual and physical ones. + In case there's no guest VM running out there, physical interrupts would be + handled by host VM directly for performance reason. Irqfd is also implemented + using eventfd for accepting vIRQ requests in gzvm module. + +Platform architecture component +=============================== + +- vm + + The vm component is responsible for setting up the capability and memory + management for the protected VMs. The capability is mainly about the lifecycle + control and boot context initialization. And the memory management is highly + integrated with ARM 2-stage translation tables to convert VA to IPA to PA + under proper security measures required by protected VMs. + +- vcpu + + The vcpu component is the core of virtualizing aarch64 physical CPU runnable, + and it controls the vCPU lifecycle including creating, running and destroying. + With self-defined exit handler, the vm component would be able to act + accordingly before terminated. + +- vgic + + The vgic component exposes control interfaces to Linux kernel via irqchip, and + we intend to support all SPI, PPI, and SGI. When it comes to virtual + interrupts, the GenieZone hypervisor would write to list registers and trigger + vIRQ injection in guest VMs via GIC.
Documentation/virt/index.rst +1 -0
@@ -16,6 +16,7 @@ Virtualization Support coco/sev-guest coco/tdx-guest hyperv/index + geniezone/introduction .. only:: html and subproject
MAINTAINERS +6 -0
@@ -8979,6 +8979,12 @@ F: include/vdso/ F: kernel/time/vsyscall.c F: lib/vdso/ +GENIEZONE HYPERVISOR DRIVER +M: Yingshiuan Pan <[email protected]> +M: Ze-Yu Wang <[email protected]> +M: Yi-De Wu <[email protected]> +F: Documentation/virt/geniezone/ + GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]> S: Supported
Signature · 1 line
2.18.0
PATCH v8 2/20 dt-bindings: hypervisor: Add MediaTek GenieZone hypervisor
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Add documentation for GenieZone(gzvm) node. This node informs gzvm driver to start probing if geniezone hypervisor is available and able to do virtual machine operations.
[Reason to use dt solution]
- The GenieZone hypervisor serves as a vendor model for facilitating platform virtualization, with an implementation that is independent from Linuxism.
- In contrast to the dt solution, our previous approach involved probing via hypercall to determine the existence of our hypervisor. However, this method raised concerns about potentially impacting all systems, including those without the GenieZone hypervisor embedded[ref].
ref: https://lore.kernel.org/all/[email protected]/
--- .../hypervisor/mediatek,geniezone-hyp.yaml | 31 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml
Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml new file +31 -0
@@ -0,0 +1,31 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hypervisor/mediatek,geniezone-hyp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek GenieZone hypervisor + +maintainers: + - Yingshiuan Pan <[email protected]> + +description: + This interface is designed for integrating GenieZone hypervisor into Android + Virtualization Framework(AVF) along with Crosvm as a VMM. + It acts like a wrapper for every hypercall to GenieZone hypervisor in + order to control guest VM lifecycles and virtual interrupt injections. + +properties: + compatible: + const: mediatek,geniezone-hyp + +required: + - compatible + +additionalProperties: false + +examples: + - | + hypervisor { + compatible = "mediatek,geniezone-hyp"; + };
MAINTAINERS +1 -0
@@ -8983,6 +8983,7 @@ GENIEZONE HYPERVISOR DRIVER M: Yingshiuan Pan <[email protected]> M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> +F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ GENWQE (IBM Generic Workqueue Card)
Signature · 1 line
2.18.0
PATCH v8 3/20 virt: geniezone: Add GenieZone hypervisor driver
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports various virtual machine types and provides security features such as TEE-like scenarios and secure boot. It can create guest VMs for security use cases and has virtualization capabilities for both platform and interrupt. Although the hypervisor can be booted independently, it requires the assistance of GenieZone hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux kernel for vCPU scheduling, memory management, inter-VM communication and virtio backend support.
Add the basic hypervisor driver. Subsequent patches will add more supported features to this driver.
--- MAINTAINERS | 3 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 +++ arch/arm64/geniezone/gzvm_arch_common.h | 44 ++++++++++++ arch/arm64/geniezone/vm.c | 47 +++++++++++++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 +++++ drivers/virt/geniezone/Makefile | 10 +++ drivers/virt/geniezone/gzvm_main.c | 89 +++++++++++++++++++++++++ include/linux/gzvm_drv.h | 25 +++++++ 10 files changed, 246 insertions(+) create mode 100644 arch/arm64/geniezone/Makefile create mode 100644 arch/arm64/geniezone/gzvm_arch_common.h create mode 100644 arch/arm64/geniezone/vm.c create mode 100644 drivers/virt/geniezone/Kconfig create mode 100644 drivers/virt/geniezone/Makefile create mode 100644 drivers/virt/geniezone/gzvm_main.c create mode 100644 include/linux/gzvm_drv.h
MAINTAINERS +3 -0
@@ -8985,6 +8985,9 @@ M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ +F: arch/arm64/geniezone/ +F: drivers/virt/geniezone/ +F: include/linux/gzvm_drv.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>
arch/arm64/Kbuild +1 -0
@@ -4,6 +4,7 @@ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(subst m,y,$(CONFIG_HYPERV)) += hyperv/ obj-$(CONFIG_CRYPTO) += crypto/ +obj-$(CONFIG_MTK_GZVM) += geniezone/ # for cleaning subdir- += boot
arch/arm64/geniezone/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Main Makefile for gzvm, this one includes drivers/virt/geniezone/Makefile +# +include $(srctree)/drivers/virt/geniezone/Makefile + +gzvm-y += vm.o + +obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h new file +44 -0
44 lines not on this page · raw message
arch/arm64/geniezone/vm.c new file +47 -0
47 lines not on this page · raw message
drivers/virt/Kconfig +2 -0
@@ -50,4 +50,6 @@ source "drivers/virt/acrn/Kconfig" source "drivers/virt/coco/Kconfig" +source "drivers/virt/geniezone/Kconfig" + endif
drivers/virt/geniezone/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config MTK_GZVM + tristate "GenieZone Hypervisor driver for guest VM operation" + depends on ARM64 && EVENTFD + help + This driver, gzvm, enables to run guest VMs on MTK GenieZone + hypervisor. It exports kvm-like interfaces for VMM (e.g., crosvm) in + order to operate guest VMs on GenieZone hypervisor. + + GenieZone hypervisor now only supports MediaTek SoC and arm64 + architecture. + + Select M if you want it be built as a module (gzvm.ko). + + If unsure, say N.
drivers/virt/geniezone/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Makefile for GenieZone driver, this file should be include in arch's +# to avoid two ko being generated. +# + +GZVM_DIR ?= ../../../drivers/virt/geniezone + +gzvm-y := $(GZVM_DIR)/gzvm_main.o +
drivers/virt/geniezone/gzvm_main.c new file +89 -0
89 lines not on this page · raw message
include/linux/gzvm_drv.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_DRV_H__ +#define __GZVM_DRV_H__ + +/* +* These are the definitions of APIs between GenieZone hypervisor and driver, +* there's no need to be visible to uapi. Furthermore, we need GenieZone +* specific error code in order to map to Linux errno +*/ +#define NO_ERROR (0) +#define ERR_NO_MEMORY (-5) +#define ERR_NOT_SUPPORTED (-24) +#define ERR_NOT_IMPLEMENTED (-27) +#define ERR_FAULT (-40) + +int gzvm_err_to_errno (unsigned long err); + +/* arch-dependant functions */ +int gzvm_arch_probe (void ); + +#endif /* __GZVM_DRV_H__ */
Signature · 1 line
2.18.0
PATCH v8 4/20 virt: geniezone: Add vm support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
The VM component is responsible for setting up the capability and memory management for the protected VMs. The capability is mainly about the lifecycle control and boot context initialization.
--- MAINTAINERS | 1 + arch/arm64/geniezone/gzvm_arch_common.h | 9 ++ arch/arm64/geniezone/vm.c | 29 +++++++ drivers/virt/geniezone/Makefile | 2 +- drivers/virt/geniezone/gzvm_main.c | 19 +++++ drivers/virt/geniezone/gzvm_vm.c | 107 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 26 ++++++ include/uapi/linux/gzvm.h | 25 ++++++ 8 files changed, 217 insertions(+), 1 deletion(-) create mode 100644 drivers/virt/geniezone/gzvm_vm.c create mode 100644 include/uapi/linux/gzvm.h
MAINTAINERS +1 -0
@@ -8988,6 +8988,7 @@ F: Documentation/virt/geniezone/ F: arch/arm64/geniezone/ F: drivers/virt/geniezone/ F: include/linux/gzvm_drv.h +F: include/uapi/linux/gzvm.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>
arch/arm64/geniezone/gzvm_arch_common.h +9 -0
@@ -9,6 +9,8 @@#include <linux/arm-smccc.h> enum { +GZVM_FUNC_CREATE_VM =0 , +GZVM_FUNC_DESTROY_VM =1 ,GZVM_FUNC_PROBE =12 ,NR_GZVM_FUNC , };
@@ -19,6 +21,8 @@ enum {ARM_SMCCC_CALL_VAL (ARM_SMCCC_FAST_CALL ,ARM_SMCCC_SMC_64 , \ SMC_ENTITY_MTK, (GZVM_FUNCID_START + (func))) +#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC_CREATE_VM) +#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)/**
@@ -41,4 +45,9 @@ int gzvm_hypcall_wrapper(unsigned long a0, unsigned long a1, unsigned long a6, unsigned long a7, struct arm_smccc_res *res); +static inline u16 get_vmid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple >>16 ); +} +#endif /* __GZVM_ARCH_COMMON_H__ */
arch/arm64/geniezone/vm.c +29 -0
@@ -7,9 +7,12 @@#include <linux/err.h> #include <linux/uaccess.h> +#include <linux/gzvm.h> #include <linux/gzvm_drv.h> #include "gzvm_arch_common.h" +#define PAR_PA47_MASK ((((1UL << 48) - 1) >> 12) << 12) +/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls * @a0: arguments passed in registers 0
@@ -45,3 +48,29 @@ int gzvm_arch_probe(void)return 0 ; } + +/** +* gzvm_arch_create_vm() - create vm +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: +* * positive value - VM ID +* * -ENOMEM - Memory not enough for storing VM data +*/ +int gzvm_arch_create_vm (unsigned long vm_type) +{ +struct arm_smccc_res res; +int ret; + + ret =gzvm_hypcall_wrapper (MT_HVC_GZVM_CREATE_VM , vm_type,0 ,0 ,0 ,0 , +0 ,0 , &res); +return ret ? ret : res.a1; +} + +int gzvm_arch_destroy_vm (u16 vm_id) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_DESTROY_VM , vm_id,0 ,0 ,0 ,0 , +0 ,0 , &res); +}
drivers/virt/geniezone/Makefile +1 -1
@@ -6,5 +6,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone -gzvm-y := $(GZVM_DIR)/gzvm_main.o +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o
drivers/virt/geniezone/gzvm_main.c +19 -0
@@ -4,6 +4,7 @@*/ #include <linux/device.h> +#include <linux/file.h> #include <linux/kdev_t.h> #include <linux/miscdevice.h> #include <linux/module.h>
@@ -40,7 +41,24 @@ int gzvm_err_to_errno(unsigned long err)return -EINVAL ; } +static long gzvm_dev_ioctl (struct file *filp,unsigned int cmd, +unsigned long user_args) +{ +long ret; + +switch (cmd) { +case GZVM_CREATE_VM : + ret =gzvm_dev_ioctl_create_vm (user_args); +return ret; +default : +break ; + } + +return -ENOTTY ; +} +static const struct file_operations gzvm_chardev_ops = { + .unlocked_ioctl = gzvm_dev_ioctl, .llseek = noop_llseek, };
@@ -62,6 +80,7 @@ static int gzvm_drv_probe(struct platform_device *pdev)static int gzvm_drv_remove (struct platform_device *pdev) { +gzvm_destroy_all_vms ();misc_deregister (&gzvm_dev);return 0 ; }
drivers/virt/geniezone/gzvm_vm.c new file +107 -0
107 lines not on this page · raw message
include/linux/gzvm_drv.h +26 -0
@@ -6,6 +6,12 @@#ifndef __GZVM_DRV_H__#define __GZVM_DRV_H__ +#include <linux/list.h> +#include <linux/mutex.h> +#include <linux/gzvm.h> + +#define INVALID_VM_ID 0xffff +/* * These are the definitions of APIs between GenieZone hypervisor and driver, * there's no need to be visible to uapi. Furthermore, we need GenieZone
@@ -17,9 +23,29 @@#define ERR_NOT_IMPLEMENTED (-27)#define ERR_FAULT (-40) +/* +* The following data structures are for data transferring between driver and +* hypervisor, and they're aligned with hypervisor definitions +*/ + +struct gzvm { +/* userspace tied to this vm */ +struct mm_struct *mm; +/* lock for list_add*/ +struct mutex lock; +struct list_head vm_list; +u16 vm_id; +}; + +int gzvm_dev_ioctl_create_vm (unsigned long vm_type); +int gzvm_err_to_errno (unsigned long err); +void gzvm_destroy_all_vms (void ); +/* arch-dependant functions */ int gzvm_arch_probe (void ); +int gzvm_arch_create_vm (unsigned long vm_type); +int gzvm_arch_destroy_vm (u16 vm_id);#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +/** +* DOC: UAPI of GenieZone Hypervisor +* +* This file declares common data structure shared among user space, +* kernel space, and GenieZone hypervisor. +*/ +#ifndef __GZVM_H__ +#define __GZVM_H__ + +#include <linux/const.h> +#include <linux/types.h> +#include <linux/ioctl.h> + +/* GZVM ioctls */ +#define GZVM_IOC_MAGIC 0x92/* gz */ + +/* ioctls for /dev/gzvm fds */ +#define GZVM_CREATE_VM _IO(GZVM_IOC_MAGIC, 0x01)/* Returns a Geniezone VM fd */ + +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 5/20 virt: geniezone: Add set_user_memory_region for vm
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Direct use of physical memory from VMs is forbidden and designed to be dictated to the privilege models managed by GenieZone hypervisor for security reason. With the help of gzvm-ko, the hypervisor would be able to manipulate memory as objects. And the memory management is highly integrated with ARM 2-stage translation tables to convert VA to IPA to PA under proper security measures required by protected VMs.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 + arch/arm64/geniezone/vm.c | 9 ++ drivers/virt/geniezone/Makefile | 1 - drivers/virt/geniezone/gzvm_vm.c | 110 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 44 ++++++++++ include/uapi/linux/gzvm.h | 26 ++++++ 6 files changed, 191 insertions(+), 1 deletion(-)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -11,6 +11,7 @@enum {GZVM_FUNC_CREATE_VM =0 ,GZVM_FUNC_DESTROY_VM =1 , +GZVM_FUNC_SET_MEMREGION =4 ,GZVM_FUNC_PROBE =12 ,NR_GZVM_FUNC , };
@@ -23,6 +24,7 @@ enum {#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC_CREATE_VM)#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM) +#define MT_HVC_GZVM_SET_MEMREGION GZVM_HCALL_ID(GZVM_FUNC_SET_MEMREGION)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)/**
arch/arm64/geniezone/vm.c +9 -0
@@ -49,6 +49,15 @@ int gzvm_arch_probe(void)return 0 ; } +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_SET_MEMREGION , vm_id, + buf_size, region,0 ,0 ,0 ,0 , &res); +} +/** * gzvm_arch_create_vm() - create vm * @vm_type: VM type. Only supports Linux VM now.
drivers/virt/geniezone/Makefile +0 -1
@@ -7,4 +7,3 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o -
drivers/virt/geniezone/gzvm_vm.c +110 -0
122 lines not on this page · raw message
include/linux/gzvm_drv.h +44 -0
70 lines not on this page · raw message
include/uapi/linux/gzvm.h +26 -0
@@ -22,4 +22,30 @@/* ioctls for /dev/gzvm fds */ #define GZVM_CREATE_VM _IO(GZVM_IOC_MAGIC, 0x01)/* Returns a Geniezone VM fd */ +/* ioctls for VM fds */ +/* for GZVM_SET_MEMORY_REGION */ +struct gzvm_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +__u64 memory_size;/* bytes */ +}; + +#define GZVM_SET_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x40, \ + struct gzvm_memory_region) + +/* for GZVM_SET_USER_MEMORY_REGION */ +struct gzvm_userspace_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +/* bytes */ +__u64 memory_size; +/* start of the userspace allocated memory */ +__u64 userspace_addr; +}; + +#define GZVM_SET_USER_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x46, \ + struct gzvm_userspace_memory_region) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 6/20 virt: geniezone: Add vm capability check
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Inquire the capability support on GenieZone hypervisor. Example:GZVM_CAP_PROTECTED_VM or GZVM_CAP_VM_GPA_SIZE.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 + arch/arm64/geniezone/vm.c | 122 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 27 ++++++ drivers/virt/geniezone/gzvm_vm.c | 21 ++++ include/linux/gzvm_drv.h | 6 +- include/uapi/linux/gzvm.h | 31 ++++++ 6 files changed, 208 insertions(+), 1 deletion(-)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -13,6 +13,7 @@ enum {GZVM_FUNC_DESTROY_VM =1 ,GZVM_FUNC_SET_MEMREGION =4 ,GZVM_FUNC_PROBE =12 , +GZVM_FUNC_ENABLE_CAP =13 , NR_GZVM_FUNC, };
@@ -26,6 +27,7 @@ enum {#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM)#define MT_HVC_GZVM_SET_MEMREGION GZVM_HCALL_ID(GZVM_FUNC_SET_MEMREGION)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE) +#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls
arch/arm64/geniezone/vm.c +122 -0
131 lines not on this page · raw message
drivers/virt/geniezone/gzvm_main.c +27 -0
@@ -41,6 +41,28 @@ int gzvm_err_to_errno(unsigned long err)return -EINVAL ; } +/** +* gzvm_dev_ioctl_check_extension() - Check if given capability is support +* or not +* +* @gzvm: Pointer to struct gzvm +* @args: Pointer in u64 from userspace +* +* Return: +* * 0 - Supported, no error +* * -EOPNOTSUPP - Unsupported +* * -EFAULT - Failed to get data from userspace +*/ +long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args) +{ +__u64 cap; +void __user *argp = (void __user *)args; + +if (copy_from_user (&cap, argp,sizeof (uint64_t ))) +return -EFAULT ; +return gzvm_arch_check_extension (gzvm, cap, argp); +} +static long gzvm_dev_ioctl (struct file *filp,unsigned int cmd,unsigned long user_args) {
@@ -50,6 +72,11 @@ static long gzvm_dev_ioctl(struct file *filp, unsigned int cmd,case GZVM_CREATE_VM : ret =gzvm_dev_ioctl_create_vm (user_args);return ret; +case GZVM_CHECK_EXTENSION : +if (!user_args) +return -EINVAL ; + ret =gzvm_dev_ioctl_check_extension (NULL , user_args); +return ret;default :break ; }
drivers/virt/geniezone/gzvm_vm.c +21 -0
@@ -98,6 +98,13 @@ gzvm_vm_ioctl_set_memory_region(struct gzvm *gzvm,return register_memslot_addr_range (gzvm, memslot); } +static int gzvm_vm_ioctl_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +return gzvm_vm_ioctl_arch_enable_cap (gzvm, cap, argp); +} +/* gzvm_vm_ioctl() - Ioctl handler of VM FD */ static long gzvm_vm_ioctl (struct file *filp,unsigned int ioctl,unsigned long arg)
@@ -107,6 +114,10 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl,struct gzvm *gzvm = filp->private_data;switch (ioctl) { +case GZVM_CHECK_EXTENSION : { + ret =gzvm_dev_ioctl_check_extension (gzvm, arg); +break ; + }case GZVM_SET_USER_MEMORY_REGION : {struct gzvm_userspace_memory_region userspace_mem;
@@ -117,6 +128,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_vm_ioctl_set_memory_region (gzvm, &userspace_mem);break ; } +case GZVM_ENABLE_CAP : { +struct gzvm_enable_cap cap; + +if (copy_from_user (&cap, argp,sizeof (cap))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_vm_ioctl_enable_cap (gzvm, &cap, argp); +break ; + }default : ret = -ENOTTY ; }
include/linux/gzvm_drv.h +5 -1
@@ -73,6 +73,7 @@ struct gzvm {u16 vm_id; }; +long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);int gzvm_dev_ioctl_create_vm (unsigned long vm_type);int gzvm_err_to_errno (unsigned long err);
@@ -83,9 +84,12 @@ void gzvm_destroy_all_vms(void);int gzvm_arch_probe (void );int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size,phys_addr_t region); +int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp);int gzvm_arch_create_vm (unsigned long vm_type);int gzvm_arch_destroy_vm (u16 vm_id); - +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp);u64 gzvm_hva_to_pa_arch (u64 hva);u64 hva_to_pa_fast (u64 hva);u64 hva_to_pa_slow (u64 hva);
include/uapi/linux/gzvm.h +31 -0
@@ -16,12 +16,30 @@#include <linux/types.h> #include <linux/ioctl.h> +#define GZVM_CAP_VM_GPA_SIZE 0xa5 +#define GZVM_CAP_PROTECTED_VM 0xffbadab1 + +/* sub-commands put in args[0] for GZVM_CAP_PROTECTED_VM */ +#define GZVM_CAP_PVM_SET_PVMFW_GPA 0 +#define GZVM_CAP_PVM_GET_PVMFW_SIZE 1 +/* GZVM_CAP_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */ +#define GZVM_CAP_PVM_SET_PROTECTED_VM 2 +/* GZVM ioctls */ #define GZVM_IOC_MAGIC 0x92/* gz */ /* ioctls for /dev/gzvm fds */ #define GZVM_CREATE_VM _IO(GZVM_IOC_MAGIC, 0x01)/* Returns a Geniezone VM fd */ +/* +* Check if the given capability is supported or not. +* The argument is capability. Ex. GZVM_CAP_PROTECTED_VM or GZVM_CAP_VM_GPA_SIZE +* return is 0 (supported, no error) +* return is -EOPNOTSUPP (unsupported) +* return is -EFAULT (failed to get the argument from userspace) +*/ +#define GZVM_CHECK_EXTENSION _IO(GZVM_IOC_MAGIC, 0x03) +/* ioctls for VM fds */ /* for GZVM_SET_MEMORY_REGION */ struct gzvm_memory_region {
@@ -48,4 +66,17 @@ struct gzvm_userspace_memory_region {#define GZVM_SET_USER_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x46, \ struct gzvm_userspace_memory_region) +/** +* struct gzvm_enable_cap: The `capability support` on GenieZone hypervisor +* @cap: `GZVM_CAP_ARM_PROTECTED_VM` or `GZVM_CAP_ARM_VM_IPA_SIZE` +* @args: x3-x7 registers can be used for additional args +*/ +struct gzvm_enable_cap { +__u64 cap; +__u64 args[5 ]; +}; + +#define GZVM_ENABLE_CAP _IOW(GZVM_IOC_MAGIC, 0xa3, \ + struct gzvm_enable_cap) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 7/20 virt: geniezone: Optimize performance of protected VM memory
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
The memory protection mechanism performs better with batch operations on memory pages. To leverage this, we pre-allocate memory for VMs that are set to protected mode. As a result, the memory protection mechanism can proactively protect the pre-allocated memory in advance through batch operations, leading to improved performance during VM booting.
--- arch/arm64/geniezone/vm.c | 146 ++++++++++++++++++++++++++++++ drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_mmu.c | 108 ++++++++++++++++++++++ 3 files changed, 256 insertions(+), 1 deletion(-) create mode 100644 drivers/virt/geniezone/gzvm_mmu.c
arch/arm64/geniezone/vm.c +146 -0
@@ -156,6 +156,122 @@ static int gzvm_vm_ioctl_get_pvmfw_size(struct gzvm *gzvm,return 0 ; } +/** +* fill_constituents() - Populate pa to buffer until full +* @consti: Pointer to struct mem_region_addr_range. +* @consti_cnt: Constituent count. +* @max_nr_consti: Maximum number of constituent count. +* @gfn: Guest frame number. +* @total_pages: Total page numbers. +* @slot: Pointer to struct gzvm_memslot. +* +* Return: how many pages we've fill in, negative if error +*/ +static int fill_constituents (struct mem_region_addr_range *consti, +int *consti_cnt,int max_nr_consti,u64 gfn, +u32 total_pages,struct gzvm_memslot *slot) +{ +u64 pfn, prev_pfn, gfn_end; +int nr_pages =1 ; +int i =0 ; + +if (unlikely (total_pages ==0 )) +return -EINVAL ; + gfn_end = gfn + total_pages; + +/* entry 0 */ +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; + consti[0 ].address =PFN_PHYS (pfn); + consti[0 ].pg_cnt =1 ; + gfn++; + prev_pfn = pfn; + +while (i < max_nr_consti && gfn < gfn_end) { +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; +if (pfn == (prev_pfn +1 )) { + consti[i].pg_cnt++; + }else { + i++; +if (i >= max_nr_consti) +break ; + consti[i].address =PFN_PHYS (pfn); + consti[i].pg_cnt =1 ; + } + prev_pfn = pfn; + gfn++; + nr_pages++; + } +if (i != max_nr_consti) + i++; + *consti_cnt = i; + +return nr_pages; +} + +/** +* populate_mem_region() - Iterate all mem slot and populate pa to buffer until it's full +* @gzvm: Pointer to struct gzvm. +* +* Return: 0 if it is successful, negative if error +*/ +static int populate_mem_region (struct gzvm *gzvm) +{ +int slot_cnt =0 ; + +while (slot_cnt <GZVM_MAX_MEM_REGION && gzvm->memslot[slot_cnt].npages !=0 ) { +struct gzvm_memslot *memslot = &gzvm->memslot[slot_cnt]; +struct gzvm_memory_region_ranges *region; +int max_nr_consti, remain_pages; +u64 gfn, gfn_end; +u32 buf_size; + + buf_size =PAGE_SIZE *2 ; + region =alloc_pages_exact (buf_size,GFP_KERNEL ); +if (!region) +return -ENOMEM ; + + max_nr_consti = (buf_size -sizeof (*region)) / +sizeof (struct mem_region_addr_range ); + + region->slot = memslot->slot_id; + remain_pages = memslot->npages; + gfn = memslot->base_gfn; + gfn_end = gfn + remain_pages; + +while (gfn < gfn_end) { +int nr_pages; + + nr_pages =fill_constituents (region->constituents, + ®ion->constituent_cnt, + max_nr_consti, gfn, + remain_pages, memslot); + +if (nr_pages <0 ) { +pr_err ("Failed to fill constituents\n" ); +free_pages_exact (region, buf_size); +return -EFAULT ; + } + + region->gpa =PFN_PHYS (gfn); + region->total_pages = nr_pages; + remain_pages -= nr_pages; + gfn += nr_pages; + +if (gzvm_arch_set_memregion (gzvm->vm_id, buf_size, +virt_to_phys (region))) { +pr_err ("Failed to register memregion to hypervisor\n" ); +free_pages_exact (region, buf_size); +return -EFAULT ; + } + } +free_pages_exact (region, buf_size); + ++slot_cnt; + } +return 0 ; +} +/** * gzvm_vm_ioctl_cap_pvm() - Proceed GZVM_CAP_PROTECTED_VM's subcommands * @gzvm: Pointer to struct gzvm.
@@ -177,6 +293,11 @@ static int gzvm_vm_ioctl_cap_pvm(struct gzvm *gzvm,case GZVM_CAP_PVM_SET_PVMFW_GPA : fallthrough;case GZVM_CAP_PVM_SET_PROTECTED_VM : +/* +* To improve performance for protected VM, we have to populate VM's memory +* before VM booting +*/ +populate_mem_region (gzvm); ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res);return ret;case GZVM_CAP_PVM_GET_PVMFW_SIZE :
@@ -205,3 +326,28 @@ int gzvm_vm_ioctl_arch_enable_cap(struct gzvm *gzvm,return -EINVAL ; } + +/** +* gzvm_hva_to_pa_arch() - converts hva to pa with arch-specific way +* @hva: Host virtual address. +* +* Return: GZVM_PA_ERR_BAD for translation error +*/ +u64 gzvm_hva_to_pa_arch (u64 hva) +{ +unsigned long flags; +u64 par; + +local_irq_save (flags); + asmvolatile ("at s1e1r, %0" ::"r" (hva)); +isb (); + par =read_sysreg_par (); +local_irq_restore (flags); + +if (par &SYS_PAR_EL1_F ) +return GZVM_PA_ERR_BAD ; + par = par &PAR_PA47_MASK ; +if (!par) +return GZVM_PA_ERR_BAD ; +return par; +}
drivers/virt/geniezone/Makefile +2 -1
@@ -6,4 +6,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone -gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ + $(GZVM_DIR)/gzvm_mmu.o
drivers/virt/geniezone/gzvm_mmu.c new file +108 -0
108 lines not on this page · raw message
Signature · 1 line
2.18.0
PATCH v8 8/20 virt: geniezone: Add vcpu support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and this fd will be for any vcpu operations, such as setting vcpu registers and accepts the most important ioctl GZVM_VCPU_RUN which requests GenieZone hypervisor to do context switch to execute VM's vcpu context.
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 30 +++ arch/arm64/geniezone/vcpu.c | 80 ++++++++ arch/arm64/geniezone/vm.c | 12 ++ drivers/virt/geniezone/Makefile | 2 +- drivers/virt/geniezone/gzvm_vcpu.c | 251 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vm.c | 5 + include/linux/gzvm_drv.h | 24 +++ include/uapi/linux/gzvm.h | 164 ++++++++++++++++ 9 files changed, 568 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o +gzvm-y += vm.o vcpu.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h +30 -0
@@ -11,9 +11,15 @@enum {GZVM_FUNC_CREATE_VM =0 ,GZVM_FUNC_DESTROY_VM =1 , +GZVM_FUNC_CREATE_VCPU =2 , +GZVM_FUNC_DESTROY_VCPU =3 ,GZVM_FUNC_SET_MEMREGION =4 , +GZVM_FUNC_RUN =5 , +GZVM_FUNC_GET_ONE_REG =8 , +GZVM_FUNC_SET_ONE_REG =9 ,GZVM_FUNC_PROBE =12 ,GZVM_FUNC_ENABLE_CAP =13 , +GZVM_FUNC_INFORM_EXIT =14 ,NR_GZVM_FUNC , };
@@ -25,9 +31,15 @@ enum {#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC_CREATE_VM)#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM) +#define MT_HVC_GZVM_CREATE_VCPU GZVM_HCALL_ID(GZVM_FUNC_CREATE_VCPU) +#define MT_HVC_GZVM_DESTROY_VCPU GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VCPU)#define MT_HVC_GZVM_SET_MEMREGION GZVM_HCALL_ID(GZVM_FUNC_SET_MEMREGION) +#define MT_HVC_GZVM_RUN GZVM_HCALL_ID(GZVM_FUNC_RUN) +#define MT_HVC_GZVM_GET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_GET_ONE_REG) +#define MT_HVC_GZVM_SET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_SET_ONE_REG)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP) +#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls
@@ -54,4 +66,22 @@ static inline u16 get_vmid_from_tuple(unsigned int tuple) return (u16)(tuple >> 16); } +static inline u16 get_vcpuid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple &0xffff ); +} + +static inline unsigned int +assemble_vm_vcpu_tuple (u16 vmid,u16 vcpuid) +{ +return ((unsigned int )vmid <<16 | vcpuid); +} + +static inline void +disassemble_vm_vcpu_tuple (unsigned int tuple,u16 *vmid,u16 *vcpuid) +{ + *vmid =get_vmid_from_tuple (tuple); + *vcpuid =get_vcpuid_from_tuple (tuple); +} +#endif /* __GZVM_ARCH_COMMON_H__ */
arch/arm64/geniezone/vcpu.c new file +80 -0
80 lines not on this page · raw message
arch/arm64/geniezone/vm.c +12 -0
@@ -37,6 +37,18 @@ int gzvm_hypcall_wrapper(unsigned long a0, unsigned long a1,return gzvm_err_to_errno (res->a0); } +int gzvm_arch_inform_exit (u16 vm_id) +{ +struct arm_smccc_res res; +int ret; + + ret =gzvm_hypcall_wrapper (MT_HVC_GZVM_INFORM_EXIT , vm_id,0 ,0 ,0 ,0 ,0 ,0 , &res); +if (ret) +return -ENXIO ; + +return 0 ; +} +int gzvm_arch_probe (void ) {struct arm_smccc_res res;
drivers/virt/geniezone/Makefile +1 -1
@@ -7,4 +7,4 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ - $(GZVM_DIR)/gzvm_mmu.o + $(GZVM_DIR)/gzvm_mmu.o $(GZVM_DIR)/gzvm_vcpu.o
drivers/virt/geniezone/gzvm_vcpu.c new file +251 -0
251 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vm.c +5 -0
@@ -118,6 +118,10 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_dev_ioctl_check_extension (gzvm, arg);break ; } +case GZVM_CREATE_VCPU : { + ret =gzvm_vm_ioctl_create_vcpu (gzvm, arg); +break ; + }case GZVM_SET_USER_MEMORY_REGION : {struct gzvm_userspace_memory_region userspace_mem;
@@ -151,6 +155,7 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_lock (&gzvm->lock); +gzvm_destroy_vcpus (gzvm);gzvm_arch_destroy_vm (gzvm->vm_id);mutex_lock (&gzvm_list_lock);
include/linux/gzvm_drv.h +24 -0
@@ -17,6 +17,7 @@*/ #define GZVM_PA_ERR_BAD (0x7ffULL << 52) +#define GZVM_VCPU_MMAP_SIZE PAGE_SIZE#define INVALID_VM_ID 0xffff/*
@@ -34,8 +35,11 @@* The following data structures are for data transferring between driver and * hypervisor, and they're aligned with hypervisor definitions */ +#define GZVM_MAX_VCPUS 8#define GZVM_MAX_MEM_REGION 10 +#define GZVM_VCPU_RUN_MAP_SIZE (PAGE_SIZE * 2) +/* struct mem_region_addr_range - Identical to ffa memory constituent */ struct mem_region_addr_range {/* the base IPA of the constituent memory region, aligned to 4 kiB */
@@ -63,7 +67,16 @@ struct gzvm_memslot {u32 slot_id; }; +struct gzvm_vcpu { +struct gzvm *gzvm; +int vcpuid; +/* lock of vcpu*/ +struct mutex lock; +struct gzvm_vcpu_run *run; +}; +struct gzvm { +struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */ struct mm_struct *mm;struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ];
@@ -80,6 +93,8 @@ int gzvm_err_to_errno(unsigned long err);void gzvm_destroy_all_vms (void ); +void gzvm_destroy_vcpus (struct gzvm *gzvm); +/* arch-dependant functions */ int gzvm_arch_probe (void ); int gzvm_arch_set_memregion(u16 vm_id, size_t buf_size,
@@ -90,10 +105,19 @@ int gzvm_arch_destroy_vm(u16 vm_id);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp); +u64 gzvm_hva_to_pa_arch (u64 hva);u64 hva_to_pa_fast (u64 hva);u64 hva_to_pa_slow (u64 hva);int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn);u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn); +int gzvm_vm_ioctl_create_vcpu (struct gzvm *gzvm,u32 cpuid); +int gzvm_arch_vcpu_update_one_reg (struct gzvm_vcpu *vcpu,__u64 reg_id, +bool is_write,__u64 *data); +int gzvm_arch_create_vcpu (u16 vm_id,int vcpuid,void *run); +int gzvm_arch_vcpu_run (struct gzvm_vcpu *vcpu,__u64 *exit_reason); +int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid); +int gzvm_arch_inform_exit (u16 vm_id); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +164 -0
186 lines not on this page · raw message
Signature · 1 line
2.18.0
Simon Horman
reviewerRe: [PATCH v8 08/20] virt: geniezone: Add vcpu support
Quoted 7 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and this fd will be for any vcpu operations, such as setting vcpu registers and accepts the most important ioctl
GZVM_VCPU_RUNwhich requests GenieZone hypervisor to do context switch to execute VM's vcpu context.
Quoted 5 lines
Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by kevenny hsieh <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>
Hi Yi-De Wu,
some minor feedback from my side.
...
Quoted 5 lines
include/uapi/linux/gzvm.h +0
-0
include/uapi/linux/gzvm.h line 33
Quoted 9 lines
include/uapi/linux/gzvm.h +6
-0@@ -25,6 +25,34 @@/* GZVM_CAP_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */ #define GZVM_CAP_PVM_SET_PROTECTED_VM 2 +/* +* Architecture specific registers are to be defined and ORed with +* the arch identifier. +*/ +#define GZVM_REG_ARCH_ARM64 0x6000000000000000ULL +#define GZVM_REG_ARCH_MASK 0xff00000000000000ULL
nit: using GENMASK_ULL and FIELD_PREP seems appropriate here.
Quoted 6 lines
include/uapi/linux/gzvm.h +6
-0+ +/* +* Reg size = BIT((reg.id & GZVM_REG_SIZE_MASK) >> GZVM_REG_SIZE_SHIFT) bytes +*/ +#define GZVM_REG_SIZE_SHIFT 52 +#define GZVM_REG_SIZE_MASK 0x00f0000000000000ULL
include/uapi/linux/gzvm.h line 49
Quoted 10 lines
include/uapi/linux/gzvm.h +10
-0+ +#define GZVM_REG_SIZE_U8 0x0000000000000000ULL +#define GZVM_REG_SIZE_U16 0x0010000000000000ULL +#define GZVM_REG_SIZE_U32 0x0020000000000000ULL +#define GZVM_REG_SIZE_U64 0x0030000000000000ULL +#define GZVM_REG_SIZE_U128 0x0040000000000000ULL +#define GZVM_REG_SIZE_U256 0x0050000000000000ULL +#define GZVM_REG_SIZE_U512 0x0060000000000000ULL +#define GZVM_REG_SIZE_U1024 0x0070000000000000ULL +#define GZVM_REG_SIZE_U2048 0x0080000000000000ULL
And here.
include/uapi/linux/gzvm.h line 54
Quoted 5 lines
include/uapi/linux/gzvm.h +5
-0+ +/* Register type definitions */ +#define GZVM_REG_TYPE_SHIFT 16 +/* Register type: general purpose */ +#define GZVM_REG_TYPE_GENERAL (0x10 << GZVM_REG_TYPE_SHIFT)
And using FIELD_PREP seems appropriate here too.
...
Quoted 68 lines
include/uapi/linux/gzvm.h +57
-0@@ -51,6 +79,11 @@ struct gzvm_memory_region {#define GZVM_SET_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x40, \ struct gzvm_memory_region) +/* +* GZVM_CREATE_VCPU receives as a parameter the vcpu slot, +* and returns a vcpu fd. +*/ +#define GZVM_CREATE_VCPU _IO(GZVM_IOC_MAGIC, 0x41)/* for GZVM_SET_USER_MEMORY_REGION */ struct gzvm_userspace_memory_region {@@ -66,6 +99,124 @@ struct gzvm_userspace_memory_region {#define GZVM_SET_USER_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x46, \ struct gzvm_userspace_memory_region) +/* +* ioctls for vcpu fds +*/ +#define GZVM_RUN _IO(GZVM_IOC_MAGIC, 0x80) + +/* VM exit reason */ +enum { +GZVM_EXIT_UNKNOWN =0x92920000 , +GZVM_EXIT_MMIO =0x92920001 , +GZVM_EXIT_HYPERCALL =0x92920002 , +GZVM_EXIT_IRQ =0x92920003 , +GZVM_EXIT_EXCEPTION =0x92920004 , +GZVM_EXIT_DEBUG =0x92920005 , +GZVM_EXIT_FAIL_ENTRY =0x92920006 , +GZVM_EXIT_INTERNAL_ERROR =0x92920007 , +GZVM_EXIT_SYSTEM_EVENT =0x92920008 , +GZVM_EXIT_SHUTDOWN =0x92920009 , +GZVM_EXIT_GZ =0x9292000a , +}; + +/** +* struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is +* shared between userspace, kernel and +* GenieZone hypervisor +* @exit_reason: The reason why gzvm_vcpu_run has stopped running the vCPU +* @immediate_exit: Polled when the vcpu is scheduled. +* If set, immediately returns -EINTR +* @padding1: Reserved for future-proof and must be zero filled +* @mmio: The nested struct in anonymous union. Handle mmio in host side +* @phys_addr: The address guest tries to access +* @data: The value to be written (is_write is 1) or +* be filled by user for reads (is_write is 0) +* @size: The size of written data. +* Only the first `size` bytes of `data` are handled +* @reg_nr: The register number where the data is stored +* @is_write: 1 for VM to perform a write or 0 for VM to perform a read +* @fail_entry: The nested struct in anonymous union. +* Handle invalid entry address at the first run +* @hardware_entry_failure_reason: The reason codes about hardware entry failure +* @cpu: The current processor number via smp_processor_id() +* @exception: The nested struct in anonymous union. +* Handle exception occurred in VM +* @exception: Which exception vector +* @error_code: Exception error codes +* @hypercall: The nested struct in anonymous union. +* Some hypercalls issued from VM must be handled +* @args: The hypercall's arguments +* @internal: The nested struct in anonymous union. The errors from hypervisor +* @suberror: The errors codes about GZVM_EXIT_INTERNAL_ERROR +* @ndata: The number of elements used in data[] +* @data: Keep the detailed information about GZVM_EXIT_INTERNAL_ERROR +* @system_event: The nested struct in anonymous union.
include/uapi/linux/gzvm.h struct gzvm_userspace_memory_region { · line 163
Quoted 10 lines
include/uapi/linux/gzvm.h +10
-0+* VM's PSCI must be handled by host +* @type: System event type. +* Ex. GZVM_SYSTEM_EVENT_SHUTDOWN or GZVM_SYSTEM_EVENT_RESET...etc. +* @ndata: The number of elements used in data[] +* @data: Keep the detailed information about GZVM_EXIT_SYSTEM_EVENT +* @padding: Fix it to a reasonable size future-proof for keeping the same +* struct size when adding new variables in the union is needed +* +* Keep identical layout between the 3 modules +*/
I am unsure how to address this, but ./scripts/kernel-doc seems confused about the correlation between the fields documented above and the nested structure below.
"./scripts/kernel-doc -none" says:
.../gzvm.h:219: warning: Excess struct member 'phys_addr' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'data' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'size' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'reg_nr' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'is_write' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'hardware_entry_failure_reason' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'cpu' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'error_code' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'args' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'suberror' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'ndata' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'data' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'type' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'ndata' description in 'gzvm_vcpu_run' .../gzvm.h:219: warning: Excess struct member 'data' description in 'gzvm_vcpu_run'
Quoted 55 lines
include/uapi/linux/gzvm.h +55
-0+struct gzvm_vcpu_run { +/* to userspace */ +__u32 exit_reason; +__u8 immediate_exit; +__u8 padding1[3 ]; +/* union structure of collection of guest exit reason */ +union { +/* GZVM_EXIT_MMIO */ +struct { +/* from FAR_EL2 */ +__u64 phys_addr; +__u8 data[8 ]; +/* from ESR_EL2 as */ +__u64 size; +/* from ESR_EL2 */ +__u32 reg_nr; +/* from ESR_EL2 */ +__u8 is_write; + } mmio; +/* GZVM_EXIT_FAIL_ENTRY */ +struct { +__u64 hardware_entry_failure_reason; +__u32 cpu; + } fail_entry; +/* GZVM_EXIT_EXCEPTION */ +struct { +__u32 exception; +__u32 error_code; + } exception; +/* GZVM_EXIT_HYPERCALL */ +struct { +__u64 args[8 ];/* in-out */ + } hypercall; +/* GZVM_EXIT_INTERNAL_ERROR */ +struct { +__u32 suberror; +__u32 ndata; +__u64 data[16 ]; + } internal; +/* GZVM_EXIT_SYSTEM_EVENT */ +struct { +#define GZVM_SYSTEM_EVENT_SHUTDOWN 1 +#define GZVM_SYSTEM_EVENT_RESET 2 +#define GZVM_SYSTEM_EVENT_CRASH 3 +#define GZVM_SYSTEM_EVENT_WAKEUP 4 +#define GZVM_SYSTEM_EVENT_SUSPEND 5 +#define GZVM_SYSTEM_EVENT_SEV_TERM 6 +#define GZVM_SYSTEM_EVENT_S2IDLE 7 +__u32 type; +__u32 ndata; +__u64 data[16 ]; + } system_event; +char padding[256 ]; + }; +};
...
PATCH v8 9/20 virt: geniezone: Add irqchip support for virtual interrupt injection
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Enable GenieZone to handle virtual interrupt injection request.
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 4 ++ arch/arm64/geniezone/vgic.c | 50 +++++++++++++++ drivers/virt/geniezone/gzvm_common.h | 12 ++++ drivers/virt/geniezone/gzvm_vm.c | 81 +++++++++++++++++++++++++ include/linux/gzvm_drv.h | 4 ++ include/uapi/linux/gzvm.h | 66 ++++++++++++++++++++ 7 files changed, 218 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/geniezone/vgic.c create mode 100644 drivers/virt/geniezone/gzvm_common.h
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o vcpu.o +gzvm-y += vm.o vcpu.o vgic.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h +4 -0
@@ -17,6 +17,8 @@ enum {GZVM_FUNC_RUN =5 ,GZVM_FUNC_GET_ONE_REG =8 ,GZVM_FUNC_SET_ONE_REG =9 , +GZVM_FUNC_IRQ_LINE =10 , +GZVM_FUNC_CREATE_DEVICE =11 ,GZVM_FUNC_PROBE =12 ,GZVM_FUNC_ENABLE_CAP =13 , GZVM_FUNC_INFORM_EXIT = 14,
@@ -37,6 +39,8 @@ enum {#define MT_HVC_GZVM_RUN GZVM_HCALL_ID(GZVM_FUNC_RUN)#define MT_HVC_GZVM_GET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_GET_ONE_REG)#define MT_HVC_GZVM_SET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_SET_ONE_REG) +#define MT_HVC_GZVM_IRQ_LINE GZVM_HCALL_ID(GZVM_FUNC_IRQ_LINE) +#define MT_HVC_GZVM_CREATE_DEVICE GZVM_HCALL_ID(GZVM_FUNC_CREATE_DEVICE)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)
arch/arm64/geniezone/vgic.c new file +50 -0
50 lines not on this page · raw message
drivers/virt/geniezone/gzvm_common.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZ_COMMON_H__ +#define __GZ_COMMON_H__ + +int gzvm_irqchip_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq,bool level); + +#endif /* __GZVM_COMMON_H__ */
drivers/virt/geniezone/gzvm_vm.c +81 -0
99 lines not on this page · raw message
include/linux/gzvm_drv.h +4 -0
@@ -120,4 +120,8 @@ int gzvm_arch_vcpu_run(struct gzvm_vcpu *vcpu, __u64 *exit_reason);int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid);int gzvm_arch_inform_exit (u16 vm_id); +int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); +int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq,bool level); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +66 -0
72 lines not on this page · raw message
Signature · 1 line
2.18.0
PATCH v8 10/20 virt: geniezone: Add irqfd support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
irqfd enables other threads than vcpu threads to inject virtual interrupt through irqfd asynchronously rather through ioctl interface. This interface is necessary for VMM which creates separated thread for IO handling or uses vhost devices.
--- arch/arm64/geniezone/gzvm_arch_common.h | 18 ++ drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_irqfd.c | 382 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 12 +- drivers/virt/geniezone/gzvm_vcpu.c | 1 + drivers/virt/geniezone/gzvm_vm.c | 18 ++ include/linux/gzvm_drv.h | 25 ++ include/uapi/linux/gzvm.h | 26 ++ 8 files changed, 483 insertions(+), 2 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_irqfd.c
arch/arm64/geniezone/gzvm_arch_common.h +18 -0
@@ -45,6 +45,8 @@ enum {#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT) +#define GIC_V3_NR_LRS 16 +/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls * @a0: arguments passed in registers 0
@@ -75,6 +77,22 @@ static inline u16 get_vcpuid_from_tuple(unsigned int tuple)return (u16)(tuple &0xffff ); } +/** +* struct gzvm_vcpu_hwstate: Sync architecture state back to host for handling +* @nr_lrs: The available LRs(list registers) in Soc. +* @__pad: add an explicit '__u32 __pad;' in the middle to make it clear +* what the actual layout is. +* @lr: The array of LRs(list registers). +* +* - Keep the same layout of hypervisor data struct. +* - Sync list registers back for acking virtual device interrupt status. +*/ +struct gzvm_vcpu_hwstate { +__le32 nr_lrs; +__le32 __pad; +__le64 lr[GIC_V3_NR_LRS ]; +}; +static inline unsigned int assemble_vm_vcpu_tuple (u16 vmid,u16 vcpuid) {
drivers/virt/geniezone/Makefile +2 -1
@@ -7,4 +7,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ - $(GZVM_DIR)/gzvm_mmu.o $(GZVM_DIR)/gzvm_vcpu.o + $(GZVM_DIR)/gzvm_mmu.o $(GZVM_DIR)/gzvm_vcpu.o \ + $(GZVM_DIR)/gzvm_irqfd.o
drivers/virt/geniezone/gzvm_irqfd.c new file +382 -0
382 lines not on this page · raw message
drivers/virt/geniezone/gzvm_main.c +11 -1
@@ -97,16 +97,26 @@ static struct miscdevice gzvm_dev = {static int gzvm_drv_probe (struct platform_device *pdev) { +int ret; +if (gzvm_arch_probe () !=0 ) {dev_err (&pdev->dev,"Not found available conduit\n" );return -ENODEV ; } -return misc_register (&gzvm_dev); + ret =misc_register (&gzvm_dev); +if (ret) +return ret; + + ret =gzvm_drv_irqfd_init (); +if (ret) +return ret; +return 0 ; }static int gzvm_drv_remove (struct platform_device *pdev) { +gzvm_drv_irqfd_exit ();gzvm_destroy_all_vms ();misc_deregister (&gzvm_dev);return 0 ;
drivers/virt/geniezone/gzvm_vcpu.c +1 -0
@@ -228,6 +228,7 @@ int gzvm_vm_ioctl_create_vcpu(struct gzvm *gzvm, u32 cpuid) ret = -ENOMEM ; goto free_vcpu; } + vcpu->hwstate = (void *)vcpu->run +PAGE_SIZE ; vcpu->vcpuid = cpuid; vcpu->gzvm = gzvm;mutex_init (&vcpu->lock);
drivers/virt/geniezone/gzvm_vm.c +18 -0
@@ -213,6 +213,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_vm_ioctl_create_device (gzvm, argp);break ; } +case GZVM_IRQFD : { +struct gzvm_irqfd data; + +if (copy_from_user (&data, argp,sizeof (data))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_irqfd (gzvm, &data); +break ; + }case GZVM_ENABLE_CAP : {struct gzvm_enable_cap cap;
@@ -236,6 +246,7 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_lock (&gzvm->lock); +gzvm_vm_irqfd_release (gzvm);gzvm_destroy_vcpus (gzvm);gzvm_arch_destroy_vm (gzvm->vm_id);
@@ -281,6 +292,13 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type) gzvm->mm = current->mm;mutex_init (&gzvm->lock); + ret =gzvm_vm_irqfd_init (gzvm); +if (ret) { +pr_err ("Failed to initialize irqfd\n" ); +kfree (gzvm); +return ERR_PTR (ret); + } +mutex_lock (&gzvm_list_lock);list_add (&gzvm->vm_list, &gzvm_list);mutex_unlock (&gzvm_list_lock);
include/linux/gzvm_drv.h +25 -0
@@ -10,6 +10,7 @@#include <linux/mm.h> #include <linux/mutex.h> #include <linux/gzvm.h> +#include <linux/srcu.h> /* * For the normal physical address, the highest 12 bits should be zero, so we
@@ -30,6 +31,7 @@#define ERR_NOT_SUPPORTED (-24)#define ERR_NOT_IMPLEMENTED (-27)#define ERR_FAULT (-40) +#define GZVM_IRQFD_RESAMPLE_IRQ_SOURCE_ID 1/* * The following data structures are for data transferring between driver and
@@ -73,6 +75,7 @@ struct gzvm_vcpu {/* lock of vcpu*/ struct mutex lock;struct gzvm_vcpu_run *run; +struct gzvm_vcpu_hwstate *hwstate; };struct gzvm {
@@ -82,8 +85,23 @@ struct gzvm {struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ];/* lock for list_add*/ struct mutex lock; + +struct { +/* lock for irqfds list operation */ +spinlock_t lock; +struct list_head items; +struct list_head resampler_list; +/* lock for irqfds resampler */ +struct mutex resampler_lock; + } irqfds; +struct list_head vm_list;u16 vm_id; + +struct hlist_head irq_ack_notifier_list; +struct srcu_struct irq_srcu; +/* lock for irq injection */ +struct mutex irq_lock; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
@@ -124,4 +142,11 @@ int gzvm_arch_create_device(u16 vm_id, struct gzvm_create_device *gzvm_dev);int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx,u32 irq,bool level); +void gzvm_notify_acked_irq (struct gzvm *gzvm,unsigned int gsi); +int gzvm_irqfd (struct gzvm *gzvm,struct gzvm_irqfd *args); +int gzvm_drv_irqfd_init (void ); +void gzvm_drv_irqfd_exit (void ); +int gzvm_vm_irqfd_init (struct gzvm *gzvm); +void gzvm_vm_irqfd_release (struct gzvm *gzvm); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +26 -0
@@ -309,4 +309,30 @@ struct gzvm_one_reg {#define GZVM_REG_GENERIC 0x0000000000000000ULL +#define GZVM_IRQFD_FLAG_DEASSIGN BIT(0) +/* +* GZVM_IRQFD_FLAG_RESAMPLE indicates resamplefd is valid and specifies +* the irqfd to operate in resampling mode for level triggered interrupt +* emulation. +*/ +#define GZVM_IRQFD_FLAG_RESAMPLE BIT(1) + +/** +* struct gzvm_irqfd: gzvm irqfd descriptor +* @fd: File descriptor. +* @gsi: Used for level IRQ fast-path. +* @flags: FLAG_DEASSIGN or FLAG_RESAMPLE. +* @resamplefd: The file descriptor of the resampler. +* @pad: Reserved for future-proof. +*/ +struct gzvm_irqfd { +__u32 fd; +__u32 gsi; +__u32 flags; +__u32 resamplefd; +__u8 pad[16 ]; +}; + +#define GZVM_IRQFD _IOW(GZVM_IOC_MAGIC, 0x76, struct gzvm_irqfd) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 11/20 virt: geniezone: Add ioeventfd support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Ioeventfd leverages eventfd to provide asynchronous notification mechanism for VMM. VMM can register a mmio address and bind with an eventfd. Once a mmio trap occurs on this registered region, its corresponding eventfd will be notified.
--- drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_ioeventfd.c | 276 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 27 ++- drivers/virt/geniezone/gzvm_vm.c | 17 ++ include/linux/gzvm_drv.h | 12 ++ include/uapi/linux/gzvm.h | 25 +++ 6 files changed, 358 insertions(+), 2 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_ioeventfd.c
drivers/virt/geniezone/Makefile +2 -1
@@ -8,4 +8,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ $(GZVM_DIR)/gzvm_mmu.o $(GZVM_DIR)/gzvm_vcpu.o \ - $(GZVM_DIR)/gzvm_irqfd.o + $(GZVM_DIR)/gzvm_irqfd.o $(GZVM_DIR)/gzvm_ioeventfd.o +
drivers/virt/geniezone/gzvm_ioeventfd.c new file +276 -0
276 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vcpu.c +26 -1
@@ -51,6 +51,30 @@ static long gzvm_vcpu_update_one_reg(struct gzvm_vcpu *vcpu,return 0 ; } +/** +* gzvm_vcpu_handle_mmio() - Handle mmio in kernel space. +* @vcpu: Pointer to vcpu. +* +* Return: +* * true - This mmio exit has been processed. +* * false - This mmio exit has not been processed, require userspace. +*/ +static bool gzvm_vcpu_handle_mmio (struct gzvm_vcpu *vcpu) +{ +__u64 addr; +__u32 len; +const void *val_ptr; + +/* So far, we don't have in-kernel mmio read handler */ +if (!vcpu->run->mmio.is_write) +return false; + addr = vcpu->run->mmio.phys_addr; + len = vcpu->run->mmio.size; + val_ptr = &vcpu->run->mmio.data; + +return gzvm_ioevent_write (vcpu, addr, len, val_ptr); +} +/** * gzvm_vcpu_run() - Handle vcpu run ioctl, entry point to guest and exit * point from guest
@@ -82,7 +106,8 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void __user *argp)switch (exit_reason) {case GZVM_EXIT_MMIO : - need_userspace = true; +if (!gzvm_vcpu_handle_mmio (vcpu)) + need_userspace = true;break ;/** * it's geniezone's responsibility to fill corresponding data
drivers/virt/geniezone/gzvm_vm.c +17 -0
@@ -223,6 +223,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_irqfd (gzvm, &data);break ; } +case GZVM_IOEVENTFD : { +struct gzvm_ioeventfd data; + +if (copy_from_user (&data, argp,sizeof (data))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_ioeventfd (gzvm, &data); +break ; + }case GZVM_ENABLE_CAP : {struct gzvm_enable_cap cap;
@@ -299,6 +309,13 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type)return ERR_PTR (ret); } + ret =gzvm_init_ioeventfd (gzvm); +if (ret) { +pr_err ("Failed to initialize ioeventfd\n" ); +kfree (gzvm); +return ERR_PTR (ret); + } +mutex_lock (&gzvm_list_lock);list_add (&gzvm->vm_list, &gzvm_list);mutex_unlock (&gzvm_list_lock);
include/linux/gzvm_drv.h +12 -0
@@ -6,6 +6,7 @@#ifndef __GZVM_DRV_H__#define __GZVM_DRV_H__ +#include <linux/eventfd.h> #include <linux/list.h> #include <linux/mm.h> #include <linux/mutex.h>
@@ -95,6 +96,8 @@ struct gzvm {struct mutex resampler_lock; } irqfds; +struct list_head ioevents; +struct list_head vm_list;u16 vm_id;
@@ -149,4 +152,13 @@ void gzvm_drv_irqfd_exit(void);int gzvm_vm_irqfd_init (struct gzvm *gzvm);void gzvm_vm_irqfd_release (struct gzvm *gzvm); +int gzvm_init_ioeventfd (struct gzvm *gzvm); +int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args); +bool gzvm_ioevent_write (struct gzvm_vcpu *vcpu,__u64 addr,int len, +const void *val); +void eventfd_ctx_do_read (struct eventfd_ctx *ctx,__u64 *cnt); +struct vm_area_struct *vma_lookup (struct mm_struct *mm,unsigned long addr); +void add_wait_queue_priority (struct wait_queue_head *wq_head, +struct wait_queue_entry *wq_entry); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +25 -0
@@ -335,4 +335,29 @@ struct gzvm_irqfd {#define GZVM_IRQFD _IOW(GZVM_IOC_MAGIC, 0x76, struct gzvm_irqfd) +enum { + gzvm_ioeventfd_flag_nr_datamatch =0 , + gzvm_ioeventfd_flag_nr_pio =1 , + gzvm_ioeventfd_flag_nr_deassign =2 , + gzvm_ioeventfd_flag_nr_max, +}; + +#define GZVM_IOEVENTFD_FLAG_DATAMATCH (1 << gzvm_ioeventfd_flag_nr_datamatch) +#define GZVM_IOEVENTFD_FLAG_PIO (1 << gzvm_ioeventfd_flag_nr_pio) +#define GZVM_IOEVENTFD_FLAG_DEASSIGN (1 << gzvm_ioeventfd_flag_nr_deassign) +#define GZVM_IOEVENTFD_VALID_FLAG_MASK ((1 << gzvm_ioeventfd_flag_nr_max) - 1) + +struct gzvm_ioeventfd { +__u64 datamatch; +/* private: legal pio/mmio address */ +__u64 addr; +/* private: 1, 2, 4, or 8 bytes; or 0 to ignore length */ +__u32 len; +__s32 fd; +__u32 flags; +__u8 pad[36 ]; +}; + +#define GZVM_IOEVENTFD _IOW(GZVM_IOC_MAGIC, 0x79, struct gzvm_ioeventfd) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 12/20 virt: geniezone: Add memory region support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Hypervisor might need to know the precise purpose of each memory region, so that it can provide specific memory protection. We add a new uapi to pass address and size of a memory region and its purpose.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 ++ arch/arm64/geniezone/vm.c | 10 ++++++++++ drivers/virt/geniezone/gzvm_vm.c | 7 +++++++ include/linux/gzvm_drv.h | 3 +++ 4 files changed, 22 insertions(+)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -22,6 +22,7 @@ enum {GZVM_FUNC_PROBE =12 ,GZVM_FUNC_ENABLE_CAP =13 ,GZVM_FUNC_INFORM_EXIT =14 , +GZVM_FUNC_MEMREGION_PURPOSE =15 , NR_GZVM_FUNC, };
@@ -44,6 +45,7 @@ enum {#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT) +#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +10 -0
@@ -130,6 +130,16 @@ int gzvm_arch_destroy_vm(u16 vm_id) 0, 0, &res); } +int gzvm_arch_memregion_purpose (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_MEMREGION_PURPOSE , gzvm->vm_id, + mem->guest_phys_addr, mem->memory_size, + mem->flags,0 ,0 ,0 , &res); +} +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,struct arm_smccc_res *res)
drivers/virt/geniezone/gzvm_vm.c +7 -0
@@ -72,6 +72,7 @@ static int gzvm_vm_ioctl_set_memory_region(struct gzvm *gzvm, struct gzvm_userspace_memory_region *mem) { + int ret;struct vm_area_struct *vma;struct gzvm_memslot *memslot;unsigned long size;
@@ -96,6 +97,12 @@ gzvm_vm_ioctl_set_memory_region(struct gzvm *gzvm, memslot->vma = vma; memslot->flags = mem->flags; memslot->slot_id = mem->slot; + + ret =gzvm_arch_memregion_purpose (gzvm, mem); +if (ret) { +pr_err ("Failed to config memory region for the specified purpose\n" ); +return -EFAULT ; + }return register_memslot_addr_range (gzvm, memslot); }
include/linux/gzvm_drv.h +3 -0
@@ -152,6 +152,9 @@ void gzvm_drv_irqfd_exit(void);int gzvm_vm_irqfd_init (struct gzvm *gzvm);void gzvm_vm_irqfd_release (struct gzvm *gzvm); +int gzvm_arch_memregion_purpose (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem); +int gzvm_init_ioeventfd (struct gzvm *gzvm);int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args); bool gzvm_ioevent_write(struct gzvm_vcpu *vcpu, __u64 addr, int len,
Signature · 1 line
2.18.0
PATCH v8 13/20 virt: geniezone: Add dtb config support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Hypervisor might need to know the accurate address and size of dtb passed from userspace. And then hypervisor would parse the dtb and get vm information.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 ++ arch/arm64/geniezone/vm.c | 9 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 10 ++++++++++ include/linux/gzvm_drv.h | 1 + include/uapi/linux/gzvm.h | 14 ++++++++++++++ 5 files changed, 36 insertions(+)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -23,6 +23,7 @@ enum {GZVM_FUNC_ENABLE_CAP =13 ,GZVM_FUNC_INFORM_EXIT =14 ,GZVM_FUNC_MEMREGION_PURPOSE =15 , +GZVM_FUNC_SET_DTB_CONFIG =16 , NR_GZVM_FUNC, };
@@ -46,6 +47,7 @@ enum {#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE) +#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +9 -0
@@ -140,6 +140,15 @@ int gzvm_arch_memregion_purpose(struct gzvm *gzvm, mem->flags, 0, 0, 0, &res); } +int gzvm_arch_set_dtb_config (struct gzvm *gzvm,struct gzvm_dtb_config *cfg) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_SET_DTB_CONFIG , gzvm->vm_id, + cfg->dtb_addr, cfg->dtb_size,0 ,0 ,0 ,0 , + &res); +} +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,struct arm_smccc_res *res)
drivers/virt/geniezone/gzvm_vm.c +10 -0
@@ -250,6 +250,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_vm_ioctl_enable_cap (gzvm, &cap, argp);break ; } +case GZVM_SET_DTB_CONFIG : { +struct gzvm_dtb_config cfg; + +if (copy_from_user (&cfg, argp,sizeof (cfg))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_arch_set_dtb_config (gzvm, &cfg); +break ; + }default : ret = -ENOTTY ; }
include/linux/gzvm_drv.h +1 -0
@@ -154,6 +154,7 @@ void gzvm_vm_irqfd_release(struct gzvm *gzvm);int gzvm_arch_memregion_purpose (struct gzvm *gzvm,struct gzvm_userspace_memory_region *mem); +int gzvm_arch_set_dtb_config (struct gzvm *gzvm,struct gzvm_dtb_config *args);int gzvm_init_ioeventfd (struct gzvm *gzvm);int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args);
include/uapi/linux/gzvm.h +14 -0
@@ -360,4 +360,18 @@ struct gzvm_ioeventfd {#define GZVM_IOEVENTFD _IOW(GZVM_IOC_MAGIC, 0x79, struct gzvm_ioeventfd) +/** +* struct gzvm_dtb_config: store address and size of dtb passed from userspace +* +* @dtb_addr: dtb address set by VMM (guset memory) +* @dtb_size: dtb size +*/ +struct gzvm_dtb_config { +__u64 dtb_addr; +__u64 dtb_size; +}; + +#define GZVM_SET_DTB_CONFIG _IOW(GZVM_IOC_MAGIC, 0xff, \ + struct gzvm_dtb_config) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v8 14/20 virt: geniezone: Add demand paging support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
This page fault handler helps GenieZone hypervisor to do demand paging. On a lower level translation fault, GenieZone hypervisor will first check the fault GPA (guest physical address or IPA in ARM) is valid e.g. within the registered memory region, then it will setup the vcpu_run->exit_reason with necessary information for returning to gzvm driver.
With the fault information, the gzvm driver looks up the physical address and call the MT_HVC_GZVM_MAP_GUEST to request the hypervisor maps the found PA to the fault GPA (IPA).
There is one exception, for protected vm, we will populate full VM's memory region in advance in order to improve performance.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 ++ arch/arm64/geniezone/vm.c | 9 ++++++ drivers/virt/geniezone/Makefile | 4 +-- drivers/virt/geniezone/gzvm_exception.c | 39 +++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 2 ++ drivers/virt/geniezone/gzvm_mmu.c | 39 +++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 6 ++-- drivers/virt/geniezone/gzvm_vm.c | 25 ++++++++++++++++ include/linux/gzvm_drv.h | 7 +++++ include/uapi/linux/gzvm.h | 11 +++++++ 10 files changed, 140 insertions(+), 4 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_exception.c
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -24,6 +24,7 @@ enum {GZVM_FUNC_INFORM_EXIT =14 ,GZVM_FUNC_MEMREGION_PURPOSE =15 ,GZVM_FUNC_SET_DTB_CONFIG =16 , +GZVM_FUNC_MAP_GUEST =17 , NR_GZVM_FUNC, };
@@ -48,6 +49,7 @@ enum {#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE)#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG) +#define MT_HVC_GZVM_MAP_GUEST GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +9 -0
@@ -382,3 +382,12 @@ u64 gzvm_hva_to_pa_arch(u64 hva)return GZVM_PA_ERR_BAD ;return par; } + +int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn, +u64 nr_pages) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_MAP_GUEST , vm_id, memslot_id, + pfn, gfn, nr_pages,0 ,0 , &res); +}
drivers/virt/geniezone/Makefile +2 -2
@@ -8,5 +8,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ $(GZVM_DIR)/gzvm_mmu.o $(GZVM_DIR)/gzvm_vcpu.o \ - $(GZVM_DIR)/gzvm_irqfd.o $(GZVM_DIR)/gzvm_ioeventfd.o - + $(GZVM_DIR)/gzvm_irqfd.o $(GZVM_DIR)/gzvm_ioeventfd.o \ + $(GZVM_DIR)/gzvm_exception.o
drivers/virt/geniezone/gzvm_exception.c new file +39 -0
@@ -0,0 +1,39 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/device.h> +#include <linux/gzvm_drv.h> + +/** +* gzvm_handle_guest_exception() - Handle guest exception +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +* Return: +* * true - This exception has been processed, no need to back to VMM. +* * false - This exception has not been processed, require userspace. +*/ +bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu) +{ +int ret; + +for (int i =0 ; i <ARRAY_SIZE (vcpu->run->exception.reserved); i++) { +if (vcpu->run->exception.reserved[i]) +return -EINVAL ; + } + +switch (vcpu->run->exception.exception) { +case GZVM_EXCEPTION_PAGE_FAULT : + ret =gzvm_handle_page_fault (vcpu); +break ; +case GZVM_EXCEPTION_UNKNOWN : + fallthrough; +default : + ret = -EFAULT ; + } + +if (!ret) +return true; +else +return false; +}
drivers/virt/geniezone/gzvm_main.c +2 -0
@@ -28,6 +28,8 @@ int gzvm_err_to_errno(unsigned long err)return 0 ;case ERR_NO_MEMORY :return -ENOMEM ; +case ERR_INVALID_ARGS : +return -EINVAL ;case ERR_NOT_SUPPORTED :return -EOPNOTSUPP ;case ERR_NOT_IMPLEMENTED :
drivers/virt/geniezone/gzvm_mmu.c +39 -0
@@ -106,3 +106,42 @@ int gzvm_gfn_to_pfn_memslot(struct gzvm_memslot *memslot, u64 gfn,return 0 ; } + +static int handle_single_demand_page (struct gzvm *vm,int memslot_id,u64 gfn) +{ +int ret; +u64 pfn; + + ret =gzvm_gfn_to_pfn_memslot (&vm->memslot[memslot_id], gfn, &pfn); +if (unlikely (ret)) +return -EFAULT ; + + ret =gzvm_arch_map_guest (vm->vm_id, memslot_id, pfn, gfn,1 ); +if (unlikely (ret)) +return -EFAULT ; + +return 0 ; +} + +/** +* gzvm_handle_page_fault() - Handle guest page fault, find corresponding page +* for the faulting gpa +* @vcpu: Pointer to struct gzvm_vcpu_run of the faulting vcpu +* +* Return: +* * 0 - Success to handle guest page fault +* * -EFAULT - Failed to map phys addr to guest's GPA +*/ +int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu) +{ +struct gzvm *vm = vcpu->gzvm; +int memslot_id; +u64 gfn; + + gfn =PHYS_PFN (vcpu->run->exception.fault_gpa); + memslot_id =gzvm_find_memslot (vm, gfn); +if (unlikely (memslot_id <0 )) +return -EFAULT ; + +return handle_single_demand_page (vm, memslot_id, gfn); +}
drivers/virt/geniezone/gzvm_vcpu.c +4 -2
@@ -113,9 +113,11 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void __user *argp)* it's geniezone's responsibility to fill corresponding data * structure */ -case GZVM_EXIT_HYPERCALL : - fallthrough;case GZVM_EXIT_EXCEPTION : +if (!gzvm_handle_guest_exception (vcpu)) + need_userspace = true; +break ; +case GZVM_EXIT_HYPERCALL : fallthrough;case GZVM_EXIT_DEBUG : fallthrough;
drivers/virt/geniezone/gzvm_vm.c +25 -0
@@ -23,6 +23,31 @@ u64 gzvm_gfn_to_hva_memslot(struct gzvm_memslot *memslot, u64 gfn)return memslot->userspace_addr + offset *PAGE_SIZE ; } +/** +* gzvm_find_memslot() - Find memslot containing this @gpa +* @vm: Pointer to struct gzvm +* @gfn: Guest frame number +* +* Return: +* * >=0 - Index of memslot +* * -EFAULT - Not found +*/ +int gzvm_find_memslot (struct gzvm *vm,u64 gfn) +{ +int i; + +for (i =0 ; i <GZVM_MAX_MEM_REGION ; i++) { +if (vm->memslot[i].npages ==0 ) +continue ; + +if (gfn >= vm->memslot[i].base_gfn && + gfn < vm->memslot[i].base_gfn + vm->memslot[i].npages) +return i; + } + +return -EFAULT ; +} +/** * register_memslot_addr_range() - Register memory region to GenieZone * @gzvm: Pointer to struct gzvm
include/linux/gzvm_drv.h +7 -0
@@ -29,6 +29,7 @@*/ #define NO_ERROR (0)#define ERR_NO_MEMORY (-5) +#define ERR_INVALID_ARGS (-8)#define ERR_NOT_SUPPORTED (-24)#define ERR_NOT_IMPLEMENTED (-27)#define ERR_FAULT (-40)
@@ -123,6 +124,8 @@ int gzvm_arch_set_memregion(u16 vm_id, size_t buf_size,int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp);int gzvm_arch_create_vm (unsigned long vm_type);int gzvm_arch_destroy_vm (u16 vm_id); +int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn, +u64 nr_pages);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp);
@@ -141,6 +144,10 @@ int gzvm_arch_vcpu_run(struct gzvm_vcpu *vcpu, __u64 *exit_reason);int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid);int gzvm_arch_inform_exit (u16 vm_id); +int gzvm_find_memslot (struct gzvm *vm,u64 gpa); +int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu); +bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu); +int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev);int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx,u32 irq,bool level);
include/uapi/linux/gzvm.h +11 -0
@@ -185,6 +185,12 @@ enum { GZVM_EXIT_GZ = 0x9292000a, }; +/* exception definitions of GZVM_EXIT_EXCEPTION */ +enum { +GZVM_EXCEPTION_UNKNOWN =0x0 , +GZVM_EXCEPTION_PAGE_FAULT =0x1 , +}; +/** * struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is * shared between userspace, kernel and
@@ -209,6 +215,9 @@ enum {* Handle exception occurred in VM * @exception: Which exception vector * @error_code: Exception error codes +* @fault_gpa: Fault GPA (guest physical address or IPA in ARM) +* @reserved: Future-proof reservation and reset to zero in hypervisor. +* Fill up to the union size, 256 bytes. * @hypercall: The nested struct in anonymous union. * Some hypercalls issued from VM must be handled * @args: The hypercall's arguments
@@ -255,6 +264,8 @@ struct gzvm_vcpu_run {struct {__u32 exception;__u32 error_code; +__u64 fault_gpa; +__u64 reserved[30 ]; } exception;/* GZVM_EXIT_HYPERCALL */ struct {
Signature · 1 line
2.18.0
PATCH v8 15/20 virt: geniezone: Add block-based demand paging support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
To balance memory usage and performance, GenieZone supports larger granularity demand paging, called block-based demand paging. Gzvm driver uses enable_cap to query the hypervisor if it supports block-based demand paging and the given granularity or not. Meanwhile, the gzvm driver allocates a shared buffer for storing the physical pages later.
If the hypervisor supports, every time the gzvm driver handles guest page faults, it allocates more memory in advance (default: 2MB) for demand paging. And fills those physical pages into the allocated shared memory, then calls the hypervisor to map to guest's memory.
The physical pages allocated for block-based demand paging is not necessary to be contiguous because in many cases, 2MB block is not followed. 1st, the memory is allocated because of VMM's page fault (VMM loads kernel image to guest memory before running). In this case, the page is allocated by the host kernel and using PAGE_SIZE. 2nd is that guest may return memory to host via ballooning and that is still 4KB (or PAGE_SIZE) granularity. Therefore, we do not have to allocate physically contiguous 2MB pages.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 + arch/arm64/geniezone/vm.c | 19 ++++++++-- drivers/virt/geniezone/gzvm_mmu.c | 44 +++++++++++++++++++++- drivers/virt/geniezone/gzvm_vm.c | 49 +++++++++++++++++++++++++ include/linux/gzvm_drv.h | 16 ++++++++ include/uapi/linux/gzvm.h | 2 + 6 files changed, 128 insertions(+), 4 deletions(-)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -25,6 +25,7 @@ enum {GZVM_FUNC_MEMREGION_PURPOSE =15 ,GZVM_FUNC_SET_DTB_CONFIG =16 ,GZVM_FUNC_MAP_GUEST =17 , +GZVM_FUNC_MAP_GUEST_BLOCK =18 , NR_GZVM_FUNC, };
@@ -50,6 +51,7 @@ enum {#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE)#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG)#define MT_HVC_GZVM_MAP_GUEST GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST) +#define MT_HVC_GZVM_MAP_GUEST_BLOCK GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST_BLOCK)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +16 -3
@@ -325,10 +325,11 @@ static int gzvm_vm_ioctl_cap_pvm(struct gzvm *gzvm, fallthrough;case GZVM_CAP_PVM_SET_PROTECTED_VM :/* -* To improve performance for protected VM, we have to populate VM's memory -* before VM booting +* If the hypervisor doesn't support block-based demand paging, we +* populate memory in advance to improve performance for protected VM. */ -populate_mem_region (gzvm); +if (gzvm->demand_page_gran ==PAGE_SIZE ) +populate_mem_region (gzvm); ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res);return ret;case GZVM_CAP_PVM_GET_PVMFW_SIZE :
@@ -345,12 +346,16 @@ int gzvm_vm_ioctl_arch_enable_cap(struct gzvm *gzvm,struct gzvm_enable_cap *cap, void __user *argp) { + struct arm_smccc_res res = {0};int ret;switch (cap->cap) {case GZVM_CAP_PROTECTED_VM : ret =gzvm_vm_ioctl_cap_pvm (gzvm, cap, argp);return ret; +case GZVM_CAP_BLOCK_BASED_DEMAND_PAGING : + ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res); +return ret;default :break ; }
@@ -391,3 +396,11 @@ int gzvm_arch_map_guest(u16 vm_id, int memslot_id, u64 pfn, u64 gfn,return gzvm_hypcall_wrapper (MT_HVC_GZVM_MAP_GUEST , vm_id, memslot_id, pfn, gfn, nr_pages,0 ,0 , &res); } + +int gzvm_arch_map_guest_block (u16 vm_id,int memslot_id,u64 gfn,u64 nr_pages) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_MAP_GUEST_BLOCK , vm_id, + memslot_id, gfn, nr_pages,0 ,0 ,0 , &res); +}
drivers/virt/geniezone/gzvm_mmu.c +43 -1
54 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vm.c +49 -0
73 lines not on this page · raw message
include/linux/gzvm_drv.h +16 -0
@@ -44,6 +44,8 @@#define GZVM_VCPU_RUN_MAP_SIZE (PAGE_SIZE * 2) +#define GZVM_BLOCK_BASED_DEMAND_PAGE_SIZE (2 * 1024 * 1024)/* 2MB */ +/* struct mem_region_addr_range - Identical to ffa memory constituent */ struct mem_region_addr_range {/* the base IPA of the constituent memory region, aligned to 4 kiB */
@@ -106,6 +108,19 @@ struct gzvm {struct srcu_struct irq_srcu;/* lock for irq injection */ struct mutex irq_lock; + +/* +* demand page granularity: how much memory we allocate for VM in a +* single page fault +*/ +u32 demand_page_gran; +/* the mailbox for transferring large portion pages */ +u64 *demand_page_buffer; +/* +* lock for preventing multiple cpu using the same demand page mailbox +* at the same time +*/ +struct mutex demand_paging_lock; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
@@ -126,6 +141,7 @@ int gzvm_arch_create_vm(unsigned long vm_type);int gzvm_arch_destroy_vm (u16 vm_id);int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn,u64 nr_pages); +int gzvm_arch_map_guest_block (u16 vm_id,int memslot_id,u64 gfn,u64 nr_pages);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp);
include/uapi/linux/gzvm.h +2 -0
@@ -18,6 +18,8 @@#define GZVM_CAP_VM_GPA_SIZE 0xa5#define GZVM_CAP_PROTECTED_VM 0xffbadab1 +/* query hypervisor supported block-based demand page */ +#define GZVM_CAP_BLOCK_BASED_DEMAND_PAGING 0x9201/* sub-commands put in args[0] for GZVM_CAP_PROTECTED_VM */ #define GZVM_CAP_PVM_SET_PVMFW_GPA 0
Signature · 1 line
2.18.0
PATCH v8 16/20 virt: geniezone: Add memory pin/unpin support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Protected VM's memory cannot be swapped out because the memory pages are protected from host access.
Once host accesses to those protected pages, the hardware exception is triggered and may crash the host. So, we have to make those protected pages be ineligible for swapping or merging by the host kernel to avoid host access. To do so, we pin the page when it is assigned (donated) to VM and unpin when VM relinquish the pages or is destroyed. Besides, the protected VM’s memory requires hypervisor to clear the content before returning to host, but VMM may free those memory before clearing, it will result in those memory pages are reclaimed and reused before totally clearing. Using pin/unpin can also avoid the above problems.
The implementation is described as follows.
- Use rb_tree to store pinned memory pages.
- Pin the page when handling page fault.
- Unpin the pages when VM relinquish the pages or is destroyed.
--- drivers/virt/geniezone/gzvm_mmu.c | 74 ++++++++++++++++++++++++++++++- drivers/virt/geniezone/gzvm_vm.c | 21 +++++++++ include/linux/gzvm_drv.h | 12 +++++ 3 files changed, 106 insertions(+), 1 deletion(-)
drivers/virt/geniezone/gzvm_mmu.c +73 -1
@@ -107,8 +107,73 @@ int gzvm_gfn_to_pfn_memslot(struct gzvm_memslot *memslot, u64 gfn,return 0 ; } +static int cmp_ppages (struct rb_node *node,const struct rb_node *parent) +{ +struct gzvm_pinned_page *a =container_of (node, + struct gzvm_pinned_page, + node); +struct gzvm_pinned_page *b =container_of (parent, + struct gzvm_pinned_page, + node); + +if (a->ipa < b->ipa) +return -1 ; +if (a->ipa > b->ipa) +return 1 ; +return 0 ; +} + +static int rb_ppage_cmp (const void *key,const struct rb_node *node) +{ +struct gzvm_pinned_page *p =container_of (node, + struct gzvm_pinned_page, + node); +phys_addr_t ipa = (phys_addr_t )key; + +return (ipa < p->ipa) ?-1 : (ipa > p->ipa); +} + +/* Invoker of this function is responsible for locking */ +static int gzvm_insert_ppage (struct gzvm *vm,struct gzvm_pinned_page *ppage) +{ +if (rb_find_add (&ppage->node, &vm->pinned_pages, cmp_ppages)) +return -EEXIST ; +return 0 ; +} + +static int pin_one_page (struct gzvm *vm,unsigned long hva,u64 gpa) +{ +unsigned int flags =FOLL_HWPOISON |FOLL_LONGTERM |FOLL_WRITE ; +struct gzvm_pinned_page *ppage =NULL ; +struct mm_struct *mm = current->mm; +struct page *page =NULL ; + + ppage =kmalloc (sizeof (*ppage),GFP_KERNEL_ACCOUNT ); +if (!ppage) +return -ENOMEM ; + +mmap_read_lock (mm); +pin_user_pages (hva,1 , flags, &page); +mmap_read_unlock (mm); + +if (!page) { +kfree (ppage); +return -EFAULT ; + } + + ppage->page = page; + ppage->ipa = gpa; + +mutex_lock (&vm->mem_lock); +gzvm_insert_ppage (vm, ppage); +mutex_unlock (&vm->mem_lock); + +return 0 ; +} +static int handle_block_demand_page (struct gzvm *vm,int memslot_id,u64 gfn) { +unsigned long hva;u64 pfn, __gfn;int ret, i;
@@ -131,6 +196,11 @@ static int handle_block_demand_page(struct gzvm *vm, int memslot_id, u64 gfn) goto err_unlock; } vm->demand_page_buffer[i] = pfn; + + hva =gzvm_gfn_to_hva_memslot (&vm->memslot[memslot_id], __gfn); + ret =pin_one_page (vm, hva,PFN_PHYS (__gfn)); +if (ret) + goto err_unlock; } ret = gzvm_arch_map_guest_block(vm->vm_id, memslot_id, start_gfn,
@@ -148,6 +218,7 @@ static int handle_block_demand_page(struct gzvm *vm, int memslot_id, u64 gfn)static int handle_single_demand_page (struct gzvm *vm,int memslot_id,u64 gfn) { +unsigned long hva;int ret;u64 pfn;
@@ -159,7 +230,8 @@ static int handle_single_demand_page(struct gzvm *vm, int memslot_id, u64 gfn)if (unlikely (ret))return -EFAULT ; -return 0 ; + hva =gzvm_gfn_to_hva_memslot (&vm->memslot[memslot_id], gfn); +return pin_one_page (vm, hva,PFN_PHYS (gfn)); }/**
drivers/virt/geniezone/gzvm_vm.c +21 -0
@@ -292,6 +292,22 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl,return ret; } +/* Invoker of this function is responsible for locking */ +static void gzvm_destroy_all_ppage (struct gzvm *gzvm) +{ +struct gzvm_pinned_page *ppage; +struct rb_node *node; + + node =rb_first (&gzvm->pinned_pages); +while (node) { + ppage = rb_entry(node, struct gzvm_pinned_page, node); +unpin_user_pages_dirty_lock (&ppage->page,1 , true); + node =rb_next (node); +rb_erase (&ppage->node, &gzvm->pinned_pages); +kfree (ppage); + } +} +static void gzvm_destroy_vm (struct gzvm *gzvm) {size_t allocated_size;
@@ -315,6 +331,9 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_unlock (&gzvm->lock); +/* No need to lock here becauese it's single-threaded execution */ +gzvm_destroy_all_ppage (gzvm); +kfree (gzvm); }
@@ -390,6 +409,8 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type) gzvm->vm_id = ret; gzvm->mm = current->mm;mutex_init (&gzvm->lock); +mutex_init (&gzvm->mem_lock); + gzvm->pinned_pages =RB_ROOT ; ret =gzvm_vm_irqfd_init (gzvm);if (ret) {
include/linux/gzvm_drv.h +12 -0
@@ -12,6 +12,7 @@#include <linux/mutex.h> #include <linux/gzvm.h> #include <linux/srcu.h> +#include <linux/rbtree.h> /* * For the normal physical address, the highest 12 bits should be zero, so we
@@ -82,6 +83,12 @@ struct gzvm_vcpu {struct gzvm_vcpu_hwstate *hwstate; }; +struct gzvm_pinned_page { +struct rb_node node; +struct page *page; +u64 ipa; +}; +struct gzvm {struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */
@@ -121,6 +128,11 @@ struct gzvm {* at the same time */ struct mutex demand_paging_lock; + +/* Use rb-tree to record pin/unpin page */ +struct rb_root pinned_pages; +/* lock for memory operations */ +struct mutex mem_lock; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
Signature · 1 line
2.18.0
PATCH v8 17/20 virt: geniezone: Add memory relinquish support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Unpin the pages when VM relinquish the pages or is destroyed.
--- drivers/virt/geniezone/gzvm_exception.c | 23 +++++++++++++++ drivers/virt/geniezone/gzvm_mmu.c | 39 +++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 6 ++-- include/linux/gzvm_drv.h | 2 ++ include/uapi/linux/gzvm.h | 5 ++++ 5 files changed, 73 insertions(+), 2 deletions(-)
drivers/virt/geniezone/gzvm_exception.c +23 -0
@@ -37,3 +37,26 @@ bool gzvm_handle_guest_exception(struct gzvm_vcpu *vcpu)else return false; } + +/** +* gzvm_handle_guest_hvc() - Handle guest hvc +* @vcpu: Pointer to struct gzvm_vcpu struct +* Return: +* * true - This hvc has been processed, no need to back to VMM. +* * false - This hvc has not been processed, require userspace. +*/ +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu) +{ +unsigned long ipa; +int ret; + +switch (vcpu->run->hypercall.args[0 ]) { +case GZVM_HVC_MEM_RELINQUISH : + ipa = vcpu->run->hypercall.args[1 ]; + ret =gzvm_handle_relinquish (vcpu, ipa); +return (ret ==0 ) ? true : false; +default : +break ; + } +return false; +}
drivers/virt/geniezone/gzvm_mmu.c +39 -0
@@ -141,6 +141,26 @@ static int gzvm_insert_ppage(struct gzvm *vm, struct gzvm_pinned_page *ppage)return 0 ; } +/* Invoker of this function is responsible for locking */ +static int gzvm_remove_ppage (struct gzvm *vm,phys_addr_t ipa) +{ +struct gzvm_pinned_page *ppage; +struct rb_node *node; + + node =rb_find ((void *)ipa, &vm->pinned_pages, rb_ppage_cmp); + +if (node) +rb_erase (node, &vm->pinned_pages); +else +return 0 ; + + ppage = container_of(node, struct gzvm_pinned_page, node); +unpin_user_pages_dirty_lock (&ppage->page,1 , true); +kfree (ppage); + +return 0 ; +} +static int pin_one_page (struct gzvm *vm,unsigned long hva,u64 gpa) {unsigned int flags =FOLL_HWPOISON |FOLL_LONGTERM |FOLL_WRITE ;
@@ -171,6 +191,25 @@ static int pin_one_page(struct gzvm *vm, unsigned long hva, u64 gpa)return 0 ; } +/** +* gzvm_handle_relinquish() - Handle memory relinquish request from hypervisor +* +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +* @ipa: Start address(gpa) of a reclaimed page +* +* Return: Always return 0 because there are no cases of failure +*/ +int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa) +{ +struct gzvm *vm = vcpu->gzvm; + +mutex_lock (&vm->mem_lock); +gzvm_remove_ppage (vm, ipa); +mutex_unlock (&vm->mem_lock); + +return 0 ; +} +static int handle_block_demand_page (struct gzvm *vm,int memslot_id,u64 gfn) {unsigned long hva;
drivers/virt/geniezone/gzvm_vcpu.c +4 -2
@@ -113,12 +113,14 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void __user *argp)* it's geniezone's responsibility to fill corresponding data * structure */ +case GZVM_EXIT_HYPERCALL : +if (!gzvm_handle_guest_hvc (vcpu)) + need_userspace = true; +break ;case GZVM_EXIT_EXCEPTION :if (!gzvm_handle_guest_exception (vcpu)) need_userspace = true;break ; -case GZVM_EXIT_HYPERCALL : - fallthrough;case GZVM_EXIT_DEBUG : fallthrough;case GZVM_EXIT_FAIL_ENTRY :
include/linux/gzvm_drv.h +2 -0
@@ -175,6 +175,8 @@ int gzvm_arch_inform_exit(u16 vm_id);int gzvm_find_memslot (struct gzvm *vm,u64 gpa);int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu);bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu); +int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa); +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu);int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); int gzvm_arch_inject_irq(struct gzvm *gzvm, unsigned int vcpu_idx,
include/uapi/linux/gzvm.h +5 -0
@@ -193,6 +193,11 @@ enum { GZVM_EXCEPTION_PAGE_FAULT = 0x1, }; +/* hypercall definitions of GZVM_EXIT_HYPERCALL */ +enum { +GZVM_HVC_MEM_RELINQUISH =0xc6000009 , +}; +/** * struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is * shared between userspace, kernel and
Signature · 1 line
2.18.0
PATCH v8 18/20 virt: geniezone: Provide individual VM memory statistics within debugfs
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Created a dedicated per-VM debugfs folder under gzvm, providing user-level programs with easy access to per-VM memory statistics for debugging and profiling purposes. This enables users to effectively analyze and optimize the memory usage of individual virtual machines.
Two types of information can be obtained:
cat /sys/kernel/debug/gzvm/<pid>-<vmid>/protected_hyp_mem shows memory used by the hypervisor and the size of the stage 2 table in bytes.
cat /sys/kernel/debug/gzvm/<pid>-<vmid>/protected_shared_mem gives memory used by the shared resources of the guest and host in bytes.
For example:
console:/ # cat /sys/kernel/debug/gzvm/3417-15/protected_hyp_mem 180328
console:/ # cat /sys/kernel/debug/gzvm/3417-15/protected_shared_mem 262144
console:/ #
More stats will be added in the future.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 + arch/arm64/geniezone/vm.c | 13 +++ drivers/virt/geniezone/gzvm_main.c | 6 ++ drivers/virt/geniezone/gzvm_vm.c | 137 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 15 +++ 5 files changed, 173 insertions(+)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -26,6 +26,7 @@ enum {GZVM_FUNC_SET_DTB_CONFIG =16 ,GZVM_FUNC_MAP_GUEST =17 ,GZVM_FUNC_MAP_GUEST_BLOCK =18 , +GZVM_FUNC_GET_STATISTICS =19 , NR_GZVM_FUNC, };
@@ -52,6 +53,7 @@ enum {#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG)#define MT_HVC_GZVM_MAP_GUEST GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST)#define MT_HVC_GZVM_MAP_GUEST_BLOCK GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST_BLOCK) +#define MT_HVC_GZVM_GET_STATISTICS GZVM_HCALL_ID(GZVM_FUNC_GET_STATISTICS)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +13 -0
@@ -404,3 +404,16 @@ int gzvm_arch_map_guest_block(u16 vm_id, int memslot_id, u64 gfn, u64 nr_pages)return gzvm_hypcall_wrapper (MT_HVC_GZVM_MAP_GUEST_BLOCK , vm_id, memslot_id, gfn, nr_pages,0 ,0 ,0 , &res); } + +int gzvm_arch_get_statistics (struct gzvm *gzvm) +{ +struct arm_smccc_res res; +int ret; + + ret =gzvm_hypcall_wrapper (MT_HVC_GZVM_GET_STATISTICS , gzvm->vm_id, +0 ,0 ,0 ,0 ,0 ,0 , &res); + + gzvm->stat.protected_hyp_mem = ((ret ==0 ) ? res.a1 :0 ); + gzvm->stat.protected_shared_mem = ((ret ==0 ) ? res.a2 :0 ); +return ret; +}
drivers/virt/geniezone/gzvm_main.c +6 -0
@@ -113,6 +113,11 @@ static int gzvm_drv_probe(struct platform_device *pdev) ret =gzvm_drv_irqfd_init ();if (ret)return ret; + + ret =gzvm_drv_debug_init (); +if (ret) +return ret; +return 0 ; }
@@ -121,6 +126,7 @@ static int gzvm_drv_remove(struct platform_device *pdev)gzvm_drv_irqfd_exit ();gzvm_destroy_all_vms ();misc_deregister (&gzvm_dev); +gzvm_drv_debug_exit ();return 0 ; }
drivers/virt/geniezone/gzvm_vm.c +137 -0
175 lines not on this page · raw message
include/linux/gzvm_drv.h +15 -0
@@ -47,6 +47,9 @@#define GZVM_BLOCK_BASED_DEMAND_PAGE_SIZE (2 * 1024 * 1024)/* 2MB */ +#define GZVM_MAX_DEBUGFS_DIR_NAME_SIZE 20 +#define GZVM_MAX_DEBUGFS_VALUE_SIZE 20 +/* struct mem_region_addr_range - Identical to ffa memory constituent */ struct mem_region_addr_range {/* the base IPA of the constituent memory region, aligned to 4 kiB */
@@ -89,6 +92,11 @@ struct gzvm_pinned_page {u64 ipa; }; +struct gzvm_vm_stat { +u64 protected_hyp_mem; +u64 protected_shared_mem; +}; +struct gzvm {struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */
@@ -133,6 +141,9 @@ struct gzvm {struct rb_root pinned_pages;/* lock for memory operations */ struct mutex mem_lock; + +struct gzvm_vm_stat stat; +struct dentry *debug_dir; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
@@ -154,6 +165,7 @@ int gzvm_arch_destroy_vm(u16 vm_id);int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn,u64 nr_pages);int gzvm_arch_map_guest_block (u16 vm_id,int memslot_id,u64 gfn,u64 nr_pages); +int gzvm_arch_get_statistics (struct gzvm *gzvm);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp);
@@ -172,6 +184,9 @@ int gzvm_arch_vcpu_run(struct gzvm_vcpu *vcpu, __u64 *exit_reason);int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid);int gzvm_arch_inform_exit (u16 vm_id); +int gzvm_drv_debug_init (void ); +void gzvm_drv_debug_exit (void ); +int gzvm_find_memslot (struct gzvm *vm,u64 gpa);int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu);bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu);
Signature · 1 line
2.18.0
PATCH v8 19/20 virt: geniezone: Add tracing support for hyp call and vcpu exit_reason
In reply to Yi-De WuAdd tracepoints for hypervisor calls and VCPU exit reasons in GenieZone driver. It aids performance debugging by providing more information about hypervisor operations and VCPU behavior.
Command Usage:
echo geniezone:* >> /sys/kernel/tracing/set_event
echo 1 > /sys/kernel/tracing/tracing_on
echo 0 > /sys/kernel/tracing/tracing_on
cat /sys/kernel/tracing/trace
For example:
crosvm_vcpu0-4838 [004] ..... 76053.536034: mtk_hypcall_enter: id=0xbb001005 crosvm_vcpu0-4838 [004] ..... 76053.540039: mtk_hypcall_leave: id=0xbb001005 invalid=0 crosvm_vcpu0-4838 [004] ..... 76053.540040: mtk_vcpu_exit: vcpu exit_reason=0x92920003
This example tracks a hypervisor function call by an ID (0xbb001005) from initiation to termination, which is supported (invalid=0). A vCPU exit is triggered by an Interrupt Request (IRQ) (exit reason: 0x92920003).
/* VM exit reason */
enum {
GZVM_EXIT_UNKNOWN = 0x92920000,
GZVM_EXIT_MMIO = 0x92920001,
GZVM_EXIT_HYPERCALL = 0x92920002,
GZVM_EXIT_IRQ = 0x92920003,
GZVM_EXIT_EXCEPTION = 0x92920004,
GZVM_EXIT_DEBUG = 0x92920005,
GZVM_EXIT_FAIL_ENTRY = 0x92920006,
GZVM_EXIT_INTERNAL_ERROR = 0x92920007,
GZVM_EXIT_SYSTEM_EVENT = 0x92920008,
GZVM_EXIT_SHUTDOWN = 0x92920009,
GZVM_EXIT_GZ = 0x9292000a,
};--- arch/arm64/geniezone/vm.c | 5 +++ drivers/virt/geniezone/gzvm_vcpu.c | 3 ++ include/trace/events/geniezone.h | 54 ++++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+) create mode 100644 include/trace/events/geniezone.h
arch/arm64/geniezone/vm.c +5 -0
@@ -7,6 +7,8 @@#include <linux/err.h> #include <linux/uaccess.h> +#define CREATE_TRACE_POINTS +#include <trace/events/geniezone.h> #include <linux/gzvm.h> #include <linux/gzvm_drv.h> #include "gzvm_arch_common.h"
@@ -33,7 +35,10 @@ int gzvm_hypcall_wrapper(unsigned long a0, unsigned long a1, unsigned long a6, unsigned long a7, struct arm_smccc_res *res) { +trace_mtk_hypcall_enter (a0 );arm_smccc_hvc (a0, a1, a2, a3, a4, a5, a6, a7, res); +trace_mtk_hypcall_leave (a0, (res->a0 !=ERR_NOT_SUPPORTED ) ?0 :1 ); +return gzvm_err_to_errno (res->a0); }
drivers/virt/geniezone/gzvm_vcpu.c +3 -0
@@ -10,6 +10,8 @@#include <linux/mm.h> #include <linux/platform_device.h> #include <linux/slab.h> + +#include <trace/events/geniezone.h> #include <linux/gzvm_drv.h> /* maximum size needed for holding an integer */
@@ -103,6 +105,7 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void __user *argp)while (!need_userspace && !signal_pending (current)) {gzvm_arch_vcpu_run (vcpu, &exit_reason); +trace_mtk_vcpu_exit (exit_reason);switch (exit_reason) {case GZVM_EXIT_MMIO :
include/trace/events/geniezone.h new file +54 -0
54 lines not on this page · raw message
Signature · 1 line
2.18.0
Steven Rostedt
maintainerRe: [PATCH v8 19/20] virt: geniezone: Add tracing support for hyp call and vcpu exit_reason
Quoted 10 lines · On Thu, 28 Dec 2023 18:51:46 +0800 Yi-De Wu <[email protected]> wrote:
Add tracepoints for hypervisor calls and VCPU exit reasons in GenieZone driver. It aids performance debugging by providing more information about hypervisor operations and VCPU behavior.
Command Usage:
echo geniezone:* >>/sys/kernel/tracing/set_event
echo 1 >/sys/kernel/tracing/tracing_on
echo 0 >/sys/kernel/tracing/tracing_on
cat/sys/kernel/tracing/trace
Quoted 4 lines
For example:
crosvm_vcpu0-4838 [004] ..... 76053.536034:mtk_hypcall_enter: id=0xbb001005 crosvm_vcpu0-4838 [004] ..... 76053.540039:mtk_hypcall_leave: id=0xbb001005 invalid=0 crosvm_vcpu0-4838 [004] ..... 76053.540040:mtk_vcpu_exit: vcpu exit_reason=0x92920003
Cleaning out patchwork, I noticed this patch.
You can make the above more informative by having it output:
crosvm_vcpu0-4838 [004] ..... 76053.540040: mtk_vcpu_exit: vcpu exit_reason=IRQ
Quoted 81 lines
This example tracks a hypervisor function call by an ID (
0xbb001005) from initiation to termination, which is supported (invalid=0). A vCPU exit is triggered by an Interrupt Request (IRQ) (exit reason:0x92920003)./* VM exit reason */
enum { GZVM_EXIT_UNKNOWN = 0x92920000, GZVM_EXIT_MMIO = 0x92920001, GZVM_EXIT_HYPERCALL = 0x92920002, GZVM_EXIT_IRQ = 0x92920003, GZVM_EXIT_EXCEPTION = 0x92920004, GZVM_EXIT_DEBUG = 0x92920005, GZVM_EXIT_FAIL_ENTRY = 0x92920006, GZVM_EXIT_INTERNAL_ERROR = 0x92920007, GZVM_EXIT_SYSTEM_EVENT = 0x92920008, GZVM_EXIT_SHUTDOWN = 0x92920009, GZVM_EXIT_GZ = 0x9292000a, };Signed-off-by Liju-clr Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>--- arch/arm64/geniezone/vm.c | 5 +++ drivers/virt/geniezone/gzvm_vcpu.c | 3 ++ include/trace/events/geniezone.h | 54 ++++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+) create mode 100644 include/trace/events/geniezone.harch/arm64/geniezone/vm.c +5
-0@@ -7,6 +7,8 @@#include <linux/err.h> #include <linux/uaccess.h> +#define CREATE_TRACE_POINTS +#include <trace/events/geniezone.h> #include <linux/gzvm.h> #include <linux/gzvm_drv.h> #include "gzvm_arch_common.h" @@ -33,7 +35,10 @@ int gzvm_hypcall_wrapper(unsigned long a0, unsigned long a1, unsigned long a6, unsigned long a7, struct arm_smccc_res *res) { +trace_mtk_hypcall_enter (a0 );arm_smccc_hvc (a0, a1, a2, a3, a4, a5, a6, a7, res); +trace_mtk_hypcall_leave (a0, (res->a0 !=ERR_NOT_SUPPORTED ) ?0 :1 ); +return gzvm_err_to_errno (res->a0); }drivers/virt/geniezone/gzvm_vcpu.c +3
-0@@ -10,6 +10,8 @@#include <linux/mm.h> #include <linux/platform_device.h> #include <linux/slab.h> + +#include <trace/events/geniezone.h> #include <linux/gzvm_drv.h> /* maximum size needed for holding an integer */ @@ -103,6 +105,7 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void __user *argp)while (!need_userspace && !signal_pending (current)) {gzvm_arch_vcpu_run (vcpu, &exit_reason); +trace_mtk_vcpu_exit (exit_reason);switch (exit_reason) {case GZVM_EXIT_MMIO :include/trace/events/geniezone.h new file +1
-0@@ -0,0 +1,54 @@ +/* SPDX-License-Identifier: GPL-2.0 */
include/trace/events/geniezone.h line 11
Quoted 10 lines
include/trace/events/geniezone.h new file +10
-0+/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM geniezone + +#define _TRACE_GENIEZONE_H + +#include <linux/tracepoint.h>
#define GZVM_EXIT_REASONS \ EM(UNKNOWN) \ EM(MMIO) \ EM(HYPERCALL) \ EM(IRQ) \ EM(EXCEPTION) \ EM(DEBUG) \ EM(FAIL_ENTRY) \ EM(INTERNAL_ERROR) \ EM(SYSTEM_EVENT) \ EM(SHUTDOWN) \ EMe(GZ)
#undef EM
#undef EMe
#define EM(a) TRACE_DEFINE_ENUM(GZVM_EXIT_##a);
#define EMe(a) TRACE_DEFINE_ENUM(GZVM_EXIT_##a);
GZVM_EXIT_REASONS
#undef EM
#undef EMe
#define EM(a) { GZVM_EXIT_##a, #a },
#define EMe(a) { GZVM_EXIT_##a, #a }
Quoted 29 lines
include/trace/events/geniezone.h new file +29
-0+ +TRACE_EVENT (mtk_hypcall_enter, + TP_PROTO(unsigned long id), + +TP_ARGS (id), + + TP_STRUCT__entry(__field(unsigned long, id)), + + TP_fast_assign(__entry->id = id;), + +TP_printk ("id=0x%lx" , __entry->id) +); + +TRACE_EVENT (mtk_hypcall_leave, + TP_PROTO(unsigned long id, unsigned long invalid), + +TP_ARGS (id, invalid), + + TP_STRUCT__entry(__field(unsigned long, id) + __field(unsigned long, invalid) + ), + + TP_fast_assign(__entry->id = id; + __entry->invalid = invalid; + ), + +TP_printk ("id=0x%lx invalid=%lu" , __entry->id, __entry->invalid) +); +
include/trace/events/geniezone.h line 50
Quoted 10 lines
include/trace/events/geniezone.h new file +10
-0+TRACE_EVENT (mtk_vcpu_exit, + TP_PROTO(unsigned long exit_reason), + +TP_ARGS (exit_reason), + + TP_STRUCT__entry(__field(unsigned long, exit_reason)), + + TP_fast_assign(__entry->exit_reason = exit_reason;), + + TP_printk("vcpu exit_reason=0x%lx", __entry->exit_reason)
TP_printk("vcpu exit_reason=0x%lx",
__print_symbolic(__entry->exit_reason, GZVM_EXIT_REASONS))And instead of having the cryptic enum values printed, you will have human readable reasons.
-- Steve
Quoted 4 lines
include/trace/events/geniezone.h new file +4
-0+); + +/* This part must be outside protection */ +#include <trace/define_trace.h>
PATCH v8 20/20 virt: geniezone: Enable PTP for synchronizing time between host and guest VMs
In reply to Yi-De WuFrom: "Kevenny Hsieh" <[email protected]>
Enabled Precision Time Protocol (PTP) for improved host-guest VM time synchronization, optimizing operations needing precise clock sync in virtual environment.
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 3 + arch/arm64/geniezone/hvc.c | 73 +++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_exception.c | 3 +- include/linux/gzvm_drv.h | 1 + include/uapi/linux/gzvm.h | 1 + 6 files changed, 80 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/geniezone/hvc.c
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o vcpu.o vgic.o +gzvm-y += vm.o vcpu.o vgic.o hvc.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h +3 -0
@@ -93,6 +93,8 @@ static inline u16 get_vcpuid_from_tuple(unsigned int tuple)* @__pad: add an explicit '__u32 __pad;' in the middle to make it clear * what the actual layout is. * @lr: The array of LRs(list registers). +* @vtimer_offset: The offset maintained by hypervisor that is host cycle count +* when guest VM startup. * * - Keep the same layout of hypervisor data struct. * - Sync list registers back for acking virtual device interrupt status.
@@ -101,6 +103,7 @@ struct gzvm_vcpu_hwstate {__le32 nr_lrs;__le32 __pad;__le64 lr[GIC_V3_NR_LRS ]; +__le64 vtimer_offset; }; static inline unsigned int
arch/arm64/geniezone/hvc.c new file +73 -0
73 lines not on this page · raw message
drivers/virt/geniezone/gzvm_exception.c +1 -2
@@ -56,7 +56,6 @@ bool gzvm_handle_guest_hvc(struct gzvm_vcpu *vcpu) ret =gzvm_handle_relinquish (vcpu, ipa);return (ret ==0 ) ? true : false;default : -break ; +return gzvm_arch_handle_guest_hvc (vcpu); } -return false; }
include/linux/gzvm_drv.h +1 -0
@@ -192,6 +192,7 @@ int gzvm_handle_page_fault(struct gzvm_vcpu *vcpu);bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu);int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa);bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu); +bool gzvm_arch_handle_guest_hvc (struct gzvm_vcpu *vcpu);int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); int gzvm_arch_inject_irq(struct gzvm *gzvm, unsigned int vcpu_idx,
include/uapi/linux/gzvm.h +1 -0
@@ -195,6 +195,7 @@ enum {/* hypercall definitions of GZVM_EXIT_HYPERCALL */ enum { +GZVM_HVC_PTP =0x86000001 ,GZVM_HVC_MEM_RELINQUISH =0xc6000009 , };
Signature · 1 line
2.18.0