Add imx93-var-som support
Subsystems (3)
v3 cover Add imx93-var-som support
From: Mathieu Othacehe <[email protected]>
Hello,
This v3 adds support for binman and documents how to build and flash a bootloader for the i.MX93 Variscite Symphony evaluation board.
Thanks,
Mathieu
v2: https://lists.denx.de/pipermail/u-boot/2023-December/542001.html
Mathieu Othacehe (3):
spl: binman: Disable u_boot_any symbols for i.MX93 boards
mach-imx: Add i.MX93 binman support.
Add imx93-var-som support
arch/arm/dts/Makefile | 3 +- arch/arm/dts/imx93-u-boot.dtsi | 88 + .../dts/imx93-var-som-symphony-u-boot.dtsi | 253 +++ arch/arm/dts/imx93-var-som-symphony.dts | 305 ++++ arch/arm/dts/imx93-var-som.dtsi | 111 ++ arch/arm/include/asm/arch-imx9/clock.h | 1 + arch/arm/mach-imx/Makefile | 22 +- arch/arm/mach-imx/imx9/Kconfig | 7 + board/variscite/common/eth.c | 59 + board/variscite/common/eth.h | 12 + board/variscite/common/imx9_eeprom.c | 190 +++ board/variscite/common/imx9_eeprom.h | 83 + board/variscite/common/mmc.c | 47 + board/variscite/imx93_var_som/Kconfig | 12 + board/variscite/imx93_var_som/MAINTAINERS | 7 + board/variscite/imx93_var_som/Makefile | 17 + board/variscite/imx93_var_som/container.cfg | 10 + board/variscite/imx93_var_som/imx93_var_som.c | 126 ++ .../variscite/imx93_var_som/imx93_var_som.env | 104 ++ board/variscite/imx93_var_som/imximage.cfg | 10 + .../variscite/imx93_var_som/lpddr4x_timing.c | 1489 +++++++++++++++++ board/variscite/imx93_var_som/spl.c | 144 ++ common/spl/Kconfig | 2 +- common/spl/Kconfig.tpl | 2 +- common/spl/Kconfig.vpl | 2 +- configs/imx93_var_som_defconfig | 156 ++ doc/board/variscite/imx93_var_som.rst | 68 + doc/board/variscite/index.rst | 1 + include/configs/imx93_var_som.h | 48 + 29 files changed, 3374 insertions(+), 5 deletions(-) create mode 100644 arch/arm/dts/imx93-u-boot.dtsi create mode 100644 arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi create mode 100644 arch/arm/dts/imx93-var-som-symphony.dts create mode 100644 arch/arm/dts/imx93-var-som.dtsi create mode 100644 board/variscite/common/eth.c create mode 100644 board/variscite/common/eth.h create mode 100644 board/variscite/common/imx9_eeprom.c create mode 100644 board/variscite/common/imx9_eeprom.h create mode 100644 board/variscite/common/mmc.c create mode 100644 board/variscite/imx93_var_som/Kconfig create mode 100644 board/variscite/imx93_var_som/MAINTAINERS create mode 100644 board/variscite/imx93_var_som/Makefile create mode 100644 board/variscite/imx93_var_som/container.cfg create mode 100644 board/variscite/imx93_var_som/imx93_var_som.c create mode 100644 board/variscite/imx93_var_som/imx93_var_som.env create mode 100644 board/variscite/imx93_var_som/imximage.cfg create mode 100644 board/variscite/imx93_var_som/lpddr4x_timing.c create mode 100644 board/variscite/imx93_var_som/spl.c create mode 100644 configs/imx93_var_som_defconfig create mode 100644 doc/board/variscite/imx93_var_som.rst create mode 100644 include/configs/imx93_var_som.h
Signature · 1 line
2.25.1
Fabio Estevam
reviewerHi Mathieu,
Quoted 7 lines · Mathieu Othacehe
From: Mathieu Othacehe <[email protected]>
Hello,
This v3 adds support for binman and documents how to build and flash a bootloader for the i.MX93 Variscite Symphony evaluation board.
Nice work! Thanks for adding i.MX93 binman support.
From a glance, the whole series looks good. I will take a closer look soon.
Cheers
PATCH v3 1/3 spl: binman: Disable u_boot_any symbols for i.MX93 boards
In reply to Mathieu OthaceheFrom: Mathieu Othacehe <[email protected]>
This is extending commit 6516c9b349b3 ("spl: binman: Disable u_boot_any symbols for i.MX8M boards") to i.MX93 boards.
--- common/spl/Kconfig | 2 +- common/spl/Kconfig.tpl | 2 +- common/spl/Kconfig.vpl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
common/spl/Kconfig +1 -1
@@ -206,7 +206,7 @@ config SPL_BINMAN_SYMBOLS config SPL_BINMAN_UBOOT_SYMBOLS bool "Declare binman symbols for U-Boot phases in SPL" depends on SPL_BINMAN_SYMBOLS - default n if ARCH_IMX8M + default n if ARCH_IMX8M || ARCH_IMX9 default y help This enables use of symbols in SPL which refer to U-Boot phases,
common/spl/Kconfig.tpl +1 -1
@@ -23,7 +23,7 @@ config TPL_BINMAN_SYMBOLS config TPL_BINMAN_UBOOT_SYMBOLS bool "Declare binman symbols for U-Boot phases in TPL" depends on TPL_BINMAN_SYMBOLS - default n if ARCH_IMX8M + default n if ARCH_IMX8M || ARCH_IMX9 default y help This enables use of symbols in TPL which refer to U-Boot phases,
common/spl/Kconfig.vpl +1 -1
@@ -243,7 +243,7 @@ config VPL_BINMAN_SYMBOLS config VPL_BINMAN_UBOOT_SYMBOLS bool "Declare binman symbols for U-Boot phases in VPL" depends on VPL_BINMAN_SYMBOLS - default n if ARCH_IMX8M + default n if ARCH_IMX8M || ARCH_IMX9 default y help This enables use of symbols in VPL which refer to U-Boot phases,
Signature · 1 line
2.25.1
Re: [PATCH v3 1/3] spl: binman: Disable u_boot_any symbols for i.MX93 boards
Quoted 7 lines · Mathieu Othacehe
From: Mathieu Othacehe <[email protected]>
This is extending commit
6516c9b349b3("spl: binman: Disableu_boot_anysymbols for i.MX8M boards") to i.MX93 boards.Signed-off-by Mathieu Othacehe <[email protected]>
PATCH v3 2/3 mach-imx: Add i.MX93 binman support.
In reply to Mathieu OthaceheFrom: Mathieu Othacehe <[email protected]>
Add dedicated Makefile targets for the i.MX93 and a new imx93-u-boot.dtsi device-tree to create binman images.
--- arch/arm/dts/imx93-u-boot.dtsi | 88 ++++++++++++++++++++++++++++++++++ arch/arm/mach-imx/Makefile | 22 ++++++++- 2 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/imx93-u-boot.dtsi
arch/arm/dts/imx93-u-boot.dtsi new file +88 -0
@@ -0,0 +1,88 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2023 Mathieu Othacehe <[email protected]> + */ + +/ { + binman: binman { + multiple-images; + }; +}; + +&binman { + u-boot-spl-ddr { + align = <4>; + align-size = <4>; + filename = "u-boot-spl-ddr.bin"; + pad-byte = <0xff>; + + u-boot-spl { + align-end = <4>; + filename = "u-boot-spl.bin"; + }; + + ddr-1d-imem-fw { + filename = "lpddr4_imem_1d_v202201.bin"; + align-end = <4>; + type = "blob-ext"; + }; + + ddr-1d-dmem-fw { + filename = "lpddr4_dmem_1d_v202201.bin"; + align-end = <4>; + type = "blob-ext"; + }; + + ddr-2d-imem-fw { + filename = "lpddr4_imem_2d_v202201.bin"; + align-end = <4>; + type = "blob-ext"; + }; + + ddr-2d-dmem-fw { + filename = "lpddr4_dmem_2d_v202201.bin"; + align-end = <4>; + type = "blob-ext"; + }; + }; + + spl { + filename = "spl.bin"; + + mkimage { + args = "-n spl/u-boot-spl.cfgout -T imx8image -e 0x2049A000"; + + blob { + filename = "u-boot-spl-ddr.bin"; + }; + }; + }; + + u-boot-container { + filename = "u-boot-container.bin"; + + mkimage { + args = "-n u-boot-container.cfgout -T imx8image -e 0x0"; + + blob { + filename = "u-boot.bin"; + }; + }; + }; + + imx-boot { + filename = "flash.bin"; + pad-byte = <0x00>; + + spl: blob-ext@1 { + filename = "spl.bin"; + offset = <0x0>; + align-size = <0x400>; + align = <0x400>; + }; + + uboot: blob-ext@2 { + filename = "u-boot-container.bin"; + }; + }; +};
arch/arm/mach-imx/Makefile +21 -1
@@ -129,6 +129,9 @@ DEPFILE_EXISTS := $(shell $(CPP) $(cpp_flags) -x c -o u-boot-dtb.cfgout $(srctre else ifeq ($(CONFIG_ARCH_IMX8M), y) IMAGE_TYPE := imx8mimage DEPFILE_EXISTS := 0 +else ifeq ($(CONFIG_ARCH_IMX9), y) +IMAGE_TYPE := imx8image +DEPFILE_EXISTS := 0 else IMAGE_TYPE := imximage DEPFILE_EXISTS := 0
@@ -211,7 +214,24 @@ endif endif ifeq ($(CONFIG_ARCH_IMX9), y) -SPL: + +SPL: spl/u-boot-spl.bin spl/u-boot-spl.cfgout u-boot-container.cfgout FORCE + +MKIMAGEFLAGS_flash.bin = -n spl/u-boot-spl.cfgout -T $(IMAGE_TYPE) -e $(CONFIG_SPL_TEXT_BASE) +flash.bin: MKIMAGEOUTPUT = flash.log + +spl/u-boot-spl.cfgout: $(IMX_CONFIG) FORCE + $(Q)mkdir -p $(dir $@) + $(call if_changed_dep,cpp_cfg) + +spl/u-boot-spl-ddr.bin: spl/u-boot-spl.bin spl/u-boot-spl.cfgout FORCE + +u-boot-container.cfgout: $(IMX_CONTAINER_CFG) FORCE + $(Q)mkdir -p $(dir $@) + $(call if_changed_dep,cpp_cfg) + +flash.bin: spl/u-boot-spl-ddr.bin container.cfgout FORCE + $(call if_changed,mkimage) endif else
Signature · 1 line
2.25.1
Re: [PATCH v3 2/3] mach-imx: Add i.MX93 binman support.
Quoted 7 lines · Mathieu Othacehe
From: Mathieu Othacehe <[email protected]>
Add dedicated
Makefiletargets for the i.MX93 and a newimx93-u-boot.dtsidevice-tree to create binman images.Signed-off-by Mathieu Othacehe <[email protected]>
PATCH v3 3/3 Add imx93-var-som support
In reply to Mathieu OthaceheFrom: Mathieu Othacehe <[email protected]>
Add support for the Variscite VAR-SOM-IMX93 evaluation kit. The SoM consists of an NXP iMX93 dual A55 CPU. The SoM is mounted on a Variscite Symphony SBC.
--- arch/arm/dts/Makefile | 3 +- .../dts/imx93-var-som-symphony-u-boot.dtsi | 253 +++ arch/arm/dts/imx93-var-som-symphony.dts | 305 ++++ arch/arm/dts/imx93-var-som.dtsi | 111 ++ arch/arm/include/asm/arch-imx9/clock.h | 1 + arch/arm/mach-imx/imx9/Kconfig | 7 + board/variscite/common/eth.c | 59 + board/variscite/common/eth.h | 12 + board/variscite/common/imx9_eeprom.c | 190 +++ board/variscite/common/imx9_eeprom.h | 83 + board/variscite/common/mmc.c | 47 + board/variscite/imx93_var_som/Kconfig | 12 + board/variscite/imx93_var_som/MAINTAINERS | 7 + board/variscite/imx93_var_som/Makefile | 17 + board/variscite/imx93_var_som/container.cfg | 10 + board/variscite/imx93_var_som/imx93_var_som.c | 126 ++ .../variscite/imx93_var_som/imx93_var_som.env | 104 ++ board/variscite/imx93_var_som/imximage.cfg | 10 + .../variscite/imx93_var_som/lpddr4x_timing.c | 1489 +++++++++++++++++ board/variscite/imx93_var_som/spl.c | 144 ++ configs/imx93_var_som_defconfig | 156 ++ doc/board/variscite/imx93_var_som.rst | 68 + doc/board/variscite/index.rst | 1 + include/configs/imx93_var_som.h | 48 + 24 files changed, 3262 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi create mode 100644 arch/arm/dts/imx93-var-som-symphony.dts create mode 100644 arch/arm/dts/imx93-var-som.dtsi create mode 100644 board/variscite/common/eth.c create mode 100644 board/variscite/common/eth.h create mode 100644 board/variscite/common/imx9_eeprom.c create mode 100644 board/variscite/common/imx9_eeprom.h create mode 100644 board/variscite/common/mmc.c create mode 100644 board/variscite/imx93_var_som/Kconfig create mode 100644 board/variscite/imx93_var_som/MAINTAINERS create mode 100644 board/variscite/imx93_var_som/Makefile create mode 100644 board/variscite/imx93_var_som/container.cfg create mode 100644 board/variscite/imx93_var_som/imx93_var_som.c create mode 100644 board/variscite/imx93_var_som/imx93_var_som.env create mode 100644 board/variscite/imx93_var_som/imximage.cfg create mode 100644 board/variscite/imx93_var_som/lpddr4x_timing.c create mode 100644 board/variscite/imx93_var_som/spl.c create mode 100644 configs/imx93_var_som_defconfig create mode 100644 doc/board/variscite/imx93_var_som.rst create mode 100644 include/configs/imx93_var_som.h
arch/arm/dts/Makefile +2 -1
@@ -1057,7 +1057,8 @@ dtb-$(CONFIG_ARCH_IMX8M) += \ imx8mq-librem5-r4.dtb dtb-$(CONFIG_ARCH_IMX9) += \ - imx93-11x11-evk.dtb + imx93-11x11-evk.dtb \ + imx93-var-som-symphony.dtb dtb-$(CONFIG_ARCH_IMXRT) += imxrt1050-evk.dtb \ imxrt1020-evk.dtb \
arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi new file +253 -0
253 lines not on this page · raw message
arch/arm/dts/imx93-var-som-symphony.dts new file +305 -0
305 lines not on this page · raw message
arch/arm/dts/imx93-var-som.dtsi new file +111 -0
111 lines not on this page · raw message
arch/arm/include/asm/arch-imx9/clock.h +1 -0
@@ -222,6 +222,7 @@ u32 mxc_get_clock(enum mxc_clock clk);void dram_pll_init (ulong pll_val);void dram_enable_bypass (ulong clk_val);void dram_disable_bypass (void ); +void set_arm_core_max_clk (void );int configure_intpll (enum ccm_clk_src pll,u32 freq);
arch/arm/mach-imx/imx9/Kconfig +7 -0
@@ -31,9 +31,16 @@ config TARGET_IMX93_11X11_EVK bool "imx93_11x11_evk" select IMX93 +config TARGET_IMX93_VAR_SOM + bool "imx93_var_som" + select BINMAN + select IMX93 + select IMX9_LPDDR4X + endchoice source "board/freescale/imx93_evk/Kconfig" +source "board/variscite/imx93_var_som/Kconfig" endif
board/variscite/common/eth.c new file +59 -0
59 lines not on this page · raw message
board/variscite/common/eth.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2023 Variscite Ltd. +* +*/ + +#ifndef _MX9_ETH_H_ +#define _MX9_ETH_H_ + +int var_setup_mac (struct var_eeprom *eeprom); + +#endif /* _MX9_ETH_H_ */
board/variscite/common/imx9_eeprom.c new file +190 -0
190 lines not on this page · raw message
board/variscite/common/imx9_eeprom.h new file +83 -0
83 lines not on this page · raw message
board/variscite/common/mmc.c new file +47 -0
47 lines not on this page · raw message
board/variscite/imx93_var_som/Kconfig new file +12 -0
@@ -0,0 +1,12 @@ +if TARGET_IMX93_VAR_SOM + +config SYS_BOARD + default "imx93_var_som" + +config SYS_VENDOR + default "variscite" + +config SYS_CONFIG_NAME + default "imx93_var_som" + +endif
board/variscite/imx93_var_som/MAINTAINERS new file +7 -0
@@ -0,0 +1,7 @@ +ARM i.MX93 VARISCITE VAR-SOM-MX93 MODULE +M: Mathieu Othacehe <[email protected]> +S: Maintained +F: arch/arm/dts/imx93-var-som* +F: board/variscite/imx93_var_som/ +F: configs/imx93_var_som_defconfig +F: include/configs/imx93_var_som.h
board/variscite/imx93_var_som/Makefile new file +17 -0
@@ -0,0 +1,17 @@ +# +# Copyright 2022 NXP +# Copyright 2023 Variscite Ltd. +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += imx93_var_som.o +obj-$(CONFIG_TARGET_IMX93_VAR_SOM) += ../common/imx9_eeprom.o + +ifdef CONFIG_SPL_BUILD +obj-y += spl.o +obj-$(CONFIG_TARGET_IMX93_VAR_SOM) += lpddr4x_timing.o +else +obj-y += ../common/eth.o +obj-y += ../common/mmc.o +endif
board/variscite/imx93_var_som/container.cfg new file +10 -0
@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2023 Mathieu Othacehe <[email protected]> + */ + +BOOT_FROM SD 0x400 +SOC_TYPE IMX9 +CONTAINER +IMAGE A55 bl31.bin 0x204E0000 +IMAGE A55 u-boot.bin CONFIG_TEXT_BASE
board/variscite/imx93_var_som/imx93_var_som.c new file +126 -0
126 lines not on this page · raw message
board/variscite/imx93_var_som/imx93_var_som.env new file +104 -0
104 lines not on this page · raw message
board/variscite/imx93_var_som/imximage.cfg new file +10 -0
@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2023 Mathieu Othacehe <[email protected]> + */ + +BOOT_FROM SD 0x400 +SOC_TYPE IMX9 +APPEND mx93a0-ahab-container.img +CONTAINER +IMAGE A55 u-boot-spl-ddr.bin 0x2049A000
board/variscite/imx93_var_som/lpddr4x_timing.c new file +1489 -0
1,489 lines not on this page · raw message
board/variscite/imx93_var_som/spl.c new file +144 -0
131 lines not on this page · raw message
configs/imx93_var_som_defconfig new file +156 -0
156 lines not on this page · raw message
doc/board/variscite/imx93_var_som.rst new file +68 -0
68 lines not on this page · raw message
include/configs/imx93_var_som.h new file +48 -0
48 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.25.1
Part of the diff is not shown here. View the raw message.
Fabio Estevam
reviewerHi Mathieu,
Quoted 8 lines · Mathieu Othacehe
From: Mathieu Othacehe <[email protected]>
Add support for the Variscite VAR-SOM-IMX93 evaluation kit. The SoM consists of an NXP iMX93 dual A55 CPU. The SoM is mounted on a Variscite Symphony SBC.
Signed-off-by Mathieu Othacehe <[email protected]>
I applied this patch against U-Boot's next branch.
I had to manually add:
board/variscite/imx93_var_som/spl.c +1 -0
@@ -21,6 +21,7 @@#include <asm/mach-imx/mxc_i2c.h> #include <asm/arch-mx7ulp/gpio.h> #include <asm/mach-imx/syscounter.h> +#include <asm/sections.h> #include <dm/uclass.h> #include <dm/device.h> #include <dm/uclass-internal.h>
so that it can be built.
Also noticed some checkpatch warnings:
ERROR: Do not add common.h to files
#802: FILE: board/variscite/common/eth.c:5:
+#include <common.h>
ERROR: Do not add common.h to files
#886: FILE: board/variscite/common/imx9_eeprom.c:6:
+#include <common.h>
ERROR: Do not add common.h to files
#1172: FILE: board/variscite/common/mmc.c:7:
+#include <common.h>
ERROR: Do not add common.h to files
#1296: FILE: board/variscite/imx93_var_som/imx93_var_som.c:7:
+#include <common.h>
ERROR: Do not add common.h to files
#3050: FILE: board/variscite/imx93_var_som/spl.c:7:
+#include <common.h>
and also got a warning when applying it:
$ git am ~/Downloads/Add-imx93-var-som-support.patch Applying: spl: binman: Disable u_boot_any symbols for i.MX93 boards Applying: mach-imx: Add i.MX93 binman support. Applying: Add imx93-var-som support .git/rebase-apply/patch:3025: new blank line at EOF. + warning: 1 line adds whitespace errors.
arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi line 7
Quoted 10 lines
arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi new file +7
-0@@ -0,0 +1,253 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2022 NXP + * Copyright 2023 Variscite Ltd. + */ + +#include "imx93-u-boot.dtsi"
This file should be included by default. No need to manually include it.
Quoted 11 lines
board/variscite/common/eth.c new file +5
-0@@ -0,0 +1,59 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2023 Variscite Ltd. +*/ +#include <common.h>
board/variscite/common/eth.c line 15
Quoted 10 lines
board/variscite/common/eth.c new file +10
-0+#include <net.h> +#include <miiphy.h> +#include <env.h> +#include "../common/imx9_eeprom.h" + +#define CHAR_BIT 8 + +static u64 mac2int (const u8 hwaddr[]) +{ +s8 i;
Why does i need to be signed?
board/variscite/common/eth.c line 27
Quoted 12 lines
board/variscite/common/eth.c new file +12
-0+u64 ret =0 ; +const u8 *p = hwaddr; + +for (i =5 ; i >=0 ; i--) + ret |= (u64)*p++ << (CHAR_BIT * i); + +return ret; +} + +static void int2mac (const u64 mac,u8 *hwaddr) +{ +s8 i;
Ditto.
Quoted 13 lines
board/variscite/common/eth.c new file +13
-0+int var_carrier_eeprom_read (const char *bus_name,int addr,struct var_carrier_eeprom *ep) +{ +int ret; +struct udevice *bus; +struct udevice *dev; + + ret =uclass_get_device_by_name (UCLASS_I2C , bus_name, &bus); +if (ret) { +debug ("%s: No bus '%s'\n" , __func__, bus_name); +return ret; + } + + ret =dm_i2c_probe (bus, addr,0 , &dev);
board/variscite/common/eth.c line 50
Quoted 10 lines
board/variscite/common/eth.c new file +10
-0+if (ret) { +debug ("%s: Carrier EEPROM I2C probe failed\n" , __func__); +return ret; + } + +/* Read EEPROM to memory */ + ret =dm_i2c_read (dev,0 , (void *)ep,sizeof (*ep)); +if (ret) { +debug ("%s: Carrier EEPROM read failed, ret=%d\n" , __func__, ret); +return ret;
Better print all these error messages.
board/variscite/common/eth.c line 59
Quoted 9 lines
board/variscite/common/eth.c new file +9
-0+return 0 ; +} + +int var_carrier_eeprom_is_valid (struct var_carrier_eeprom *ep) +{ +u32 crc, crc_offset = offsetof(struct var_carrier_eeprom , crc); + +if (htons (ep->magic) !=VAR_CARRIER_EEPROM_MAGIC ) { + debug("Invalid carrier EEPROM magic 0x%x, expected 0x%x\n",
Same here.
Quoted 11 lines
board/variscite/common/eth.c new file +11
-0+// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2022 NXP +* Copyright 2023 Variscite Ltd. +*/ + +#include <common.h> +#include <env.h> +#include <init.h> +#include <miiphy.h> +#include <netdev.h>
board/variscite/common/eth.c
Quoted 10 lines
board/variscite/common/eth.c new file +10
-0+#include <asm/global_data.h> +#include <asm/arch-imx9/ccm_regs.h> +#include <asm/arch/sys_proto.h> +#include <asm/arch-imx9/imx93_pins.h> +#include <asm/arch/clock.h> +#include <power/pmic.h> +#include <dm/device.h> +#include <dm/uclass.h> +#include <usb.h> +#include <dwc3-uboot.h>
These USB-related header files could be removed.
board/variscite/common/eth.c
Quoted 7 lines
board/variscite/common/eth.c new file +7
-0+/* SDRAM ENV */ +snprintf (sdram_size_str,SDRAM_SIZE_STR_LEN ,"%d" , + (int )(gd->ram_size /1024 /1024 )); +env_set ("sdram_size" , sdram_size_str); + +/* Carrier Board ENV */ +var_carrier_eeprom_read (VAR_CARRIER_EEPROM_I2C_NAME ,CARRIER_EEPROM_ADDR , &carrier_eeprom);
No error checking?
Quoted 1 line
+
var_carrier_eeprom_get_revision(&carrier_eeprom, carrier_rev, sizeof(carrier_rev));
No error checking?
board/variscite/imx93_var_som/imx93_var_som.env line 2
Quoted 8 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +2
-0@@ -0,0 +1,104 @@ +initrd_addr=0x83800000 +emmc_dev=0
Not used anywhere. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 3
Quoted 1 line
board/variscite/imx93_var_som/imx93_var_som.env new file +1
-0+sd_dev=1
Not used anywhere. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 4
Quoted 1 line
board/variscite/imx93_var_som/imx93_var_som.env new file +1
-0+scriptaddr=0x83500000
Not used anywhere. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 5
Quoted 1 line
board/variscite/imx93_var_som/imx93_var_som.env new file +1
-0+kernel_addr_r= __stringify(CONFIG_SYS_LOAD_ADDR)
Not used anywhere. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 8
Quoted 3 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +3
-0+image=Image.gz +img_addr=0x82000000 +splashimage=0x90000000
There is no splash screen support. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 9
Quoted 1 line
board/variscite/imx93_var_som/imx93_var_som.env new file +1
-0+console=ttyLP0,115200 earlycon
earlycon is only useful for development. Please remove it.
board/variscite/imx93_var_som/imx93_var_som.env line 13
Quoted 4 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +4
-0+#include <linux/kernel.h> +#include <asm/arch/ddr.h> + +struct dram_cfg_param ddr_ddrc_cfg[] = {
Please make it 'static'.
board/variscite/imx93_var_som/imx93_var_som.env line 15
Quoted 2 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +2
-0+/* ddr phy trained csr */ +struct dram_cfg_param ddr_ddrphy_trained_csr[] = {
Please make it 'static'.
board/variscite/imx93_var_som/imx93_var_som.env line 16
Quoted 1 line
board/variscite/imx93_var_som/imx93_var_som.env new file +1
-0+struct dram_fsp_msg ddr_dram_fsp_msg[] = {
Please make it 'static'.
board/variscite/imx93_var_som/imx93_var_som.env line 20
Quoted 4 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +4
-0+#include <common.h> +#include <command.h> +#include <cpu_func.h> +#include <hang.h>
Is this needed?
board/variscite/imx93_var_som/imx93_var_som.env line 26
Quoted 6 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +6
-0+Get and Build the ARM Trusted firmware +-------------------------------------- + +Note: srctree is U-Boot source directory +Get ATF from: https://github.com/varigit/imx-atf +branch: lf_v2.8_var02
Please use a more generic repo, such as NXP https://github.com/nxp-imx/imx-atf/
branch: lf_v2.8
board/variscite/imx93_var_som/imx93_var_som.env line 28
Quoted 2 lines
board/variscite/imx93_var_som/imx93_var_som.env new file +2
-0+/* Using ULP WDOG for reset */ +#define WDOG_BASE_ADDR WDG3_BASE_ADDR
Not needed to be done in this series, but in the future, it would be nice to convert this wdog driver to DM.
Hello Fabio,
Quoted 3 lines
I applied this patch against U-Boot's next branch.
I had to manually add:
I was testing on 2023.10. I rebased the series on next on my side. I had to do something similar to fb2bdc4efcb in order to fix booting.
Quoted 7 lines
$ git am ~/Downloads/Add-imx93-var-som-support.patch Applying: spl: binman: Disable u_boot_any symbols for i.MX93 boards Applying: mach-imx: Add i.MX93 binman support. Applying: Add imx93-var-som support .git/rebase-apply/patch:3025: new blank line at EOF. + warning: 1 line adds whitespace errors.
Fixed.
Quoted 3 lines
Quoted 1 line
+#include "
imx93-u-boot.dtsi"This file should be included by default. No need to manually include it.
I am not sure why but without this include, I have the following warning:
binman: Device tree 'u-boot.dtb' does not have a 'binman' node
which seem to indicate that this include is needed.
Quoted 2 lines
Not needed to be done in this series, but in the future, it would be nice to convert this wdog driver to DM.
Noted.
I will send a v4 that should take all remarks into account.
Thanks,
Mathieu