Skip to contentSkip to conversation

Add more check points for Review Checklist doc

PATCH Superseded Wei Gao via ltp 2 participants 3 messages Dec 30, 2023 – Mar 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add more check points for Review Checklist doc

---
 doc/Maintainer-Patch-Review-Checklist.asciidoc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
doc/Maintainer-Patch-Review-Checklist.asciidoc +4 -2
index 452de0d49..8bc3468a0 100644
@@ -22,6 +22,7 @@ The following are examples and may not be appropriate for all tests.
   - Use sanitizers e.g. undefined behaviour, address.
   - Compile on non-x86
   - Compile on x86 with -m32
+  - Test patches on GitHub Actions will covers various architectures
 * Use `make check`
 * Run effected tests in a VM
   - Use single vCPU
@@ -30,10 +31,11 @@ The following are examples and may not be appropriate for all tests.
 * Run effected tests on an embedded device
 * Run effected tests on non-x86 machine in general
 * Run reproducers on a kernel where the bug is present
-* Run tests with "-i0"
+* Run tests with "-i0" and "-in"
 * Compare usage of system calls with man page descriptions
-* Compare usage of system calls with kernel code
+* Compare usage of system calls with kernel code or commit message
 * Search the LTP library for existing helper functions
+* Check doc formatting e.g. cd metadata && make && chromium ../docparse/*.html
 
 ## How to find subtle errors
 
Signature · 5 lines
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v2 1/1 Add more check points for Review Checklist doc

---
 doc/Maintainer-Patch-Review-Checklist.asciidoc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
doc/Maintainer-Patch-Review-Checklist.asciidoc +5 -2
index 452de0d49..e5dd624b1 100644
@@ -22,6 +22,7 @@ The following are examples and may not be appropriate for all tests.
   - Use sanitizers e.g. undefined behaviour, address.
   - Compile on non-x86
   - Compile on x86 with -m32
+  - Test patches on GitHub Actions will covers various architectures
 * Use `make check`
 * Run effected tests in a VM
   - Use single vCPU
@@ -30,10 +31,12 @@ The following are examples and may not be appropriate for all tests.
 * Run effected tests on an embedded device
 * Run effected tests on non-x86 machine in general
 * Run reproducers on a kernel where the bug is present
-* Run tests with "-i0"
+* Run tests with "-i0" and "-in"
 * Compare usage of system calls with man page descriptions
-* Compare usage of system calls with kernel code
+* Compare usage of system calls with kernel code or commit message
 * Search the LTP library for existing helper functions
+* Check doc formatting e.g. cd metadata && make && chromium ../docparse/*.html
+* Preview in your fork when change doc such as C-Test-API.asciidoc
 
 ## How to find subtle errors
 
Signature · 5 lines
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi!
I've adjusted the wording here and there and pushed, thanks.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp