Skip to contentSkip to conversation

ACPI: resource: Force irq1 edge low override on Infinity laptops

PATCH Superseded David McFarland 3 participants 8 messages Dec 30, 2023 – Jan 3, 2024 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: resource: Force irq1 edge low override on Infinity laptops

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index 297a88587031..f692604b773c 100644
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		.ident = "Infinity E15-5A165-BM",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		.ident = "Infinity E15-5A305-1M",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.40.1
#1 lore raw

Cc Hans and Mario.

Quoted 19 lines · David McFarland

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +0 -0
index 297a88587031..f692604b773c 100644

drivers/acpi/resource.c static const struct dmi_system_id tongfang_gm_rg[] = { · line 488

Quoted 5 lines
drivers/acpi/resource.c +2 -0
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
                },
        },
+       {
+               .ident = "Infinity E15-5A165-BM",

.ident is not needed any more.

Please add a comment identifying the machine(s) instead.

Quoted 4 lines
drivers/acpi/resource.c +4 -0
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+               },
+       },

drivers/acpi/resource.c static const struct dmi_system_id tongfang_gm_rg[] = {

Quoted 10 lines
drivers/acpi/resource.c +6 -1
+       {
+               .ident = "Infinity E15-5A305-1M",
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+               },
+       },
        { }
 };
 
--

Thanks!

#2 lore raw

PATCH v2 1/1 ACPI: resource: Force irq1 edge low override on Infinity laptops

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index 297a88587031..6b64ea4e9c80 100644
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.40.1
#3 lore raw

Hi David,

Thank you for your patch.

Quoted 9 lines · David McFarland

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.

This patch seems to be based on an older version of the kernel.

Please base this on the latest code from:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/?h=bleeding-edge

There is a single DMI match table there now for all AMD laptops named irq1_edge_low_force_override[]

Which has a bunch of new entries, so your patch will not apply cleanly as is.

Regards,

Hans

Quoted 27 lines
---
 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index 297a88587031..6b64ea4e9c80 100644
@@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
#4 lore raw

PATCH v3 1/1 ACPI: resource: Add Infinity laptops to irq1_level_low_skip_override

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to irq1_level_low_skip_override.

---

- v3: Rebased on bleeding-edge

Sorry, I should have realised based on other commits referencing the new global array name.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index c3536c236be9..575dad7aaaa7 100644
@@ -489,6 +489,18 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "17U70P"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.40.1
#5 lore raw

PATCH v4 1/1 ACPI: resource: Add Infinity laptops to irq1_level_low_force_override

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to irq1_level_low_force_override.

---

- v4: fixed rebase error, adding to _force instead of _skip

Apologies, I messed up the rebase. This one should put them in the correct array.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index c3536c236be9..0e2c397b1399 100644
@@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.40.1
#6 lore raw

PATCH v5 1/1 ACPI: resource: Add Infinity laptops to irq1_edge_low_force_override

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to irq1_edge_low_force_override.

---

- v5: fix commit message

Apologies again, in my haste I made a typo in the commit message.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +12 -0
index c3536c236be9..0e2c397b1399 100644
@@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
 		},
 	},
+	{
+		/* Infinity E15-5A165-BM */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+		},
+	},
+	{
+		/* Infinity E15-5A305-1M */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.40.1
maintainer Applied
#7 lore raw

Re: [PATCH v5] ACPI: resource: Add Infinity laptops to irq1_edge_low_force_override

Quoted 33 lines · David McFarland

A user reported a keyboard problem similar to ones reported with other Zen laptops, on an Infinity E15-5A165-BM.

Add board name matches for this model and one (untested) close relative to irq1_edge_low_force_override.

---

- v5: fix commit message

Apologies again, in my haste I made a typo in the commit message.

 drivers/acpi/resource.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/acpi/resource.c +6 -0
index c3536c236be9..0e2c397b1399 100644
@@ -555,6 +555,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "GM6BG0Q"),
                },
        },
+       {
+               /* Infinity E15-5A165-BM */
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
+               },
+       },

drivers/acpi/resource.c static const struct dmi_system_id irq1_edge_low_force_override[] = {

Quoted 10 lines
drivers/acpi/resource.c +6 -1
+       {
+               /* Infinity E15-5A305-1M */
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
+               },
+       },
        { }
 };
 
--

Applied as 6.8 material, thanks!