serial: 8250_lpss: copy dma_param using devm_kmemdup()
PATCH 1/1 serial: 8250_lpss: copy dma_param using devm_kmemdup()
Use devm_kmemdup() helper to copy dma_param instead of doing it manually.
Signed-off-by Raag Jadav <[email protected]>
--- drivers/tty/serial/8250/8250_lpss.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/tty/serial/8250/8250_lpss.c +2 -5
@@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *portreturn 0 ; } - rx_param =devm_kzalloc (dev,sizeof (*rx_param),GFP_KERNEL ); + rx_param =devm_kmemdup (dev, &lpss->dma_param,sizeof (*rx_param),GFP_KERNEL );if (!rx_param)return -ENOMEM ; - tx_param =devm_kzalloc (dev,sizeof (*tx_param),GFP_KERNEL ); + tx_param =devm_kmemdup (dev, &lpss->dma_param,sizeof (*tx_param),GFP_KERNEL );if (!tx_param)return -ENOMEM ; - *rx_param = lpss->dma_param; - *tx_param = lpss->dma_param; - dma->fn = lpss8250_dma_filter; dma->rx_param = rx_param; dma->tx_param = tx_param;
Signature · 1 line
2.35.3
Quoted 22 lines · Raag Jadav
Use
devm_kmemdup()helper to copydma_paraminstead of doing it manually.Signed-off-by Raag Jadav <[email protected]>--- drivers/tty/serial/8250/8250_lpss.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/tty/serial/8250/8250_lpss.c +1
-2@@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *portreturn 0 ; } - rx_param =devm_kzalloc (dev,sizeof (*rx_param),GFP_KERNEL ); + rx_param =devm_kmemdup (dev, &lpss->dma_param,sizeof (*rx_param),GFP_KERNEL );if (!rx_param)return -ENOMEM ; - tx_param =devm_kzalloc (dev,sizeof (*tx_param),GFP_KERNEL );
drivers/tty/serial/8250/8250_lpss.c static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port · line 300
Quoted 10 lines
drivers/tty/serial/8250/8250_lpss.c +1
-3+ tx_param =devm_kmemdup (dev, &lpss->dma_param,sizeof (*tx_param),GFP_KERNEL );if (!tx_param)return -ENOMEM ; - *rx_param = lpss->dma_param; - *tx_param = lpss->dma_param; - dma->fn = lpss8250_dma_filter; dma->rx_param = rx_param; dma->tx_param = tx_param;
Reviewed-by Ilpo Järvinen <[email protected]>
Signature · 1 line
i.
Quoted 3 lines · Raag Jadav
Use
devm_kmemdup()helper to copydma_paraminstead of doing it manually.Signed-off-by Raag Jadav <[email protected]>
Reviewed-by Mika Westerberg <[email protected]>